Extract workers test helpers into internal/workertest#372
Closed
lilydoar wants to merge 1 commit into
Closed
Conversation
workers/test_env.go, test_workers.go, and test_historyrequire.go were package workers (production) files: the test_ prefix is not special to Go (only _test.go is excluded from builds), so this test-support code compiled into the shipped binary and forced production-only edges from package workers into loadgen/devserver/versions that only the test harness needs. Move them to a dedicated internal/workertest package (env.go, workerpool.go, historyrequire.go). The helpers reference a few production symbols (Builder, Runner, BaseDir, and the previously-unexported logWriter), so export logWriter as LogWriter with a NewLogWriter constructor and qualify the rest. Update the consumers (loadgen and scenario tests) to import internal/workertest. Testing: `go build ./...` and `go vet ./...` pass; the loadgen and scenario test packages compile against the new import path. stack-info: PR: #372, branch: lilydoar/stack/6
lilydoar
force-pushed
the
lilydoar/stack/5
branch
from
2ca480a to
ba97ed4
Compare
lilydoar
force-pushed
the
lilydoar/stack/6
branch
from
f3d8da2 to
74aa52b
Compare
This was referenced May 28, 2026
lilydoar
added a commit
that referenced
this pull request
May 29, 2026
workers/test_env.go, test_workers.go, and test_historyrequire.go were package workers (production) files: the test_ prefix is not special to Go (only _test.go is excluded from builds), so this test-support code compiled into the shipped binary and forced production-only edges from package workers into loadgen/devserver/versions that only the test harness needs. Move them to a dedicated internal/workertest package (env.go, workerpool.go, historyrequire.go). The helpers reference a few production symbols (Builder, Runner, BaseDir, and the previously-unexported logWriter), so export logWriter as LogWriter with a NewLogWriter constructor and qualify the rest. Update the consumers (loadgen and scenario tests) to import internal/workertest. Testing: `go build ./...` and `go vet ./...` pass; the loadgen and scenario test packages compile against the new import path. stack-info: PR: #372, branch: lilydoar/stack/6
Contributor
Author
|
Closing — the module-organization stack was rebased (devserver move dropped, since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Extract workers test helpers into internal/workertest
workers/test_env.go, test_workers.go, and test_historyrequire.go were
package workers (production) files: the test_ prefix is not special to Go
(only _test.go is excluded from builds), so this test-support code compiled
into the shipped binary and forced production-only edges from package workers
into loadgen/devserver/versions that only the test harness needs.
Move them to a dedicated internal/workertest package (env.go, workerpool.go,
historyrequire.go). The helpers reference a few production symbols (Builder,
Runner, BaseDir, and the previously-unexported logWriter), so export logWriter
as LogWriter with a NewLogWriter constructor and qualify the rest. Update the
consumers (loadgen and scenario tests) to import internal/workertest.
Testing:
go build ./...andgo vet ./...pass; the loadgen and scenariotest packages compile against the new import path.