Cache Go dependency downloads in cli.Dockerfile#377
Closed
lilydoar wants to merge 1 commit into
Closed
Conversation
Previously the Dockerfile copied source then go.mod/go.sum and built in one shot, so any source change invalidated the layer and re-downloaded every module. Copy go.mod/go.sum (plus the workers/go/harness/api replace target, required for the module graph to resolve) first and run `go mod download` as its own layer, then copy source and build. Dependency downloads now cache independently of source edits. Verified by building the CLI image with podman. stack-info: PR: #377, branch: lilydoar/stack/11
lilydoar
force-pushed
the
lilydoar/stack/11
branch
from
42bf863 to
9f1faf2
Compare
lilydoar
force-pushed
the
lilydoar/stack/10
branch
from
4edbef4 to
74ea63d
Compare
This was referenced May 28, 2026
lilydoar
added a commit
that referenced
this pull request
May 29, 2026
Previously the Dockerfile copied source then go.mod/go.sum and built in one shot, so any source change invalidated the layer and re-downloaded every module. Copy go.mod/go.sum (plus the workers/go/harness/api replace target, required for the module graph to resolve) first and run `go mod download` as its own layer, then copy source and build. Dependency downloads now cache independently of source edits. Verified by building the CLI image with podman. stack-info: PR: #377, branch: lilydoar/stack/11
lilydoar
added a commit
that referenced
this pull request
May 29, 2026
Previously the Dockerfile copied source then go.mod/go.sum and built in one shot, so any source change invalidated the layer and re-downloaded every module. Copy go.mod/go.sum (plus the workers/go/harness/api replace target, required for the module graph to resolve) first and run `go mod download` as its own layer, then copy source and build. Dependency downloads now cache independently of source edits. Verified by building the CLI image with podman. stack-info: PR: #377, branch: lilydoar/stack/11
Contributor
Author
|
Closing — the module-organization stack was rebased (devserver move dropped, since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Cache Go dependency downloads in cli.Dockerfile
Previously the Dockerfile copied source then go.mod/go.sum and built in one
shot, so any source change invalidated the layer and re-downloaded every
module. Copy go.mod/go.sum (plus the workers/go/harness/api replace target,
required for the module graph to resolve) first and run
go mod downloadasits own layer, then copy source and build. Dependency downloads now cache
independently of source edits. Verified by building the CLI image with podman.