Move workers orchestration package to internal/workerctl#373
Closed
lilydoar wants to merge 1 commit into
Closed
Conversation
The root workers package (build.go, log.go, run.go) is application logic for building and running worker subprocesses, with no consumer outside the root module. Application code that isn't part of a public API belongs under internal/, where the import boundary is compiler-enforced. It also could not stay at workers/, since that directory is the documented polyglot worker-source home (workers/<lang>/...). Move it to internal/workerctl (package workerctl) and update importers. The workers/ directory now contains only the per-language worker source trees. Testing: `go build ./...` and `go vet ./...` pass for both modules. stack-info: PR: #373, branch: lilydoar/stack/7
lilydoar
force-pushed
the
lilydoar/stack/6
branch
from
f3d8da2 to
74aa52b
Compare
lilydoar
force-pushed
the
lilydoar/stack/7
branch
from
f3a4afe to
3b08fcc
Compare
This was referenced May 28, 2026
lilydoar
added a commit
that referenced
this pull request
May 29, 2026
The root workers package (build.go, log.go, run.go) is application logic for building and running worker subprocesses, with no consumer outside the root module. Application code that isn't part of a public API belongs under internal/, where the import boundary is compiler-enforced. It also could not stay at workers/, since that directory is the documented polyglot worker-source home (workers/<lang>/...). Move it to internal/workerctl (package workerctl) and update importers. The workers/ directory now contains only the per-language worker source trees. Testing: `go build ./...` and `go vet ./...` pass for both modules. stack-info: PR: #373, branch: lilydoar/stack/7
Contributor
Author
|
Closing — the module-organization stack was rebased (devserver move dropped, since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Move workers orchestration package to internal/workerctl
The root workers package (build.go, log.go, run.go) is application logic for
building and running worker subprocesses, with no consumer outside the root
module. Application code that isn't part of a public API belongs under
internal/, where the import boundary is compiler-enforced. It also could not
stay at workers/, since that directory is the documented polyglot
worker-source home (workers//...).
Move it to internal/workerctl (package workerctl) and update importers. The
workers/ directory now contains only the per-language worker source trees.
Testing:
go build ./...andgo vet ./...pass for both modules.