Move versions to internal/versions#375
Closed
lilydoar wants to merge 1 commit into
Closed
Conversation
versions (the versions.env reader) has no consumer outside the root module. Application code that isn't part of a public API belongs under internal/, where the import boundary is compiler-enforced. versions.go locates versions.env at runtime by walking up from its own source path (runtime.Caller), so the added directory level requires one more filepath.Dir to still reach the repo root. Verified at runtime that versions.env still resolves after the move. stack-info: PR: #375, branch: lilydoar/stack/9
lilydoar
force-pushed
the
lilydoar/stack/9
branch
from
ec4ba7b to
a21587b
Compare
This was referenced May 28, 2026
lilydoar
added a commit
that referenced
this pull request
May 29, 2026
versions (the versions.env reader) has no consumer outside the root module. Application code that isn't part of a public API belongs under internal/, where the import boundary is compiler-enforced. versions.go locates versions.env at runtime by walking up from its own source path (runtime.Caller), so the added directory level requires one more filepath.Dir to still reach the repo root. Verified at runtime that versions.env still resolves after the move. stack-info: PR: #375, branch: lilydoar/stack/9
lilydoar
added a commit
that referenced
this pull request
May 29, 2026
versions (the versions.env reader) has no consumer outside the root module. Application code that isn't part of a public API belongs under internal/, where the import boundary is compiler-enforced. versions.go locates versions.env at runtime by walking up from its own source path (runtime.Caller), so the added directory level requires one more filepath.Dir to still reach the repo root. Verified at runtime that versions.env still resolves after the move. stack-info: PR: #375, branch: lilydoar/stack/9
Contributor
Author
|
Closing — the module-organization stack was rebased (devserver move dropped, since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Move versions to internal/versions
versions (the versions.env reader) has no consumer outside the root module.
Application code that isn't part of a public API belongs under internal/,
where the import boundary is compiler-enforced.
versions.go locates versions.env at runtime by walking up from its own source
path (runtime.Caller), so the added directory level requires one more
filepath.Dir to still reach the repo root. Verified at runtime that
versions.env still resolves after the move.