Issue 30497 #1
Open
Issue 30497 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngular#37446) Partial resubmit of angular#26243 Fixes incorrect url tree generation for empty path components with children. Adds a test to demonstrate the failure of createUrlTree for those routes. Fixes angular#13011 Fixes angular#35687 PR Close angular#37446
…atch (angular#37494) The function signature selection algorithm is totally naive. It'd unconditionally pick the first signature if there are multiple overloads. This commit improves the algorithm by returning an exact match if one exists. PR Close angular#37494
) Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29 PR Close angular#37437
Use the strongly typed TestBed.inject rather than the weakly typed inject test utility function. Reuse injected dependency variables between sibling test cases. PR Close angular#37459
Prevent duplicate notifications from being emitted when multiple URL change listeners are registered using SpyLocation#onUrlChange. Use `@internal` annotation for the `_urlChangeSubscription` properties instead of the `private` access modifier. Otherwise, we get in trouble because of `SpyLocation implements Location`. PR Close angular#37459
…r#37341) Previously, we would simply prepend any relative URL with the HREF for the current route (pulled from document.location). However, this does not correctly account for the leading slash URLs that would otherwise be parsed correctly in the browser, or the presence of a base HREF in the DOM. Therefore, we use the built-in URL implementation for NodeJS, which implements the WHATWG standard that's used in the browser. We also pull the base HREF from the DOM, falling back on the full HREF as the browser would, to form the correct request URL. Fixes angular#37314 PR Close angular#37341
…ed (angular#37489) We recently moved over the git client from the merge script to the common dev-infra utils. This made specifying a token optional, but it looks like the logic for sanitizing messages doesn't account for that, and we currently add `<TOKEN>` between every message character. e.g. ``` Executing: git <TOKEN>g<TOKEN>i<TOKEN>t<TOKEN> <TOKEN>s<TOKEN>t<TOKEN>a<TOKEN>t<TOKEN>u<TOKEN>s<TOKEN> ``` PR Close angular#37489
The dev-infra rebase PR script currently does not work due to the following issues: 1. The push refspec is incorrect. It refers to the `base` of the PR, and not to the `head` of the PR. 2. The push `--force-with-lease` option does not work in a detached head as no remote-tracking branch is set up. PR Close angular#37489
Looks like we broke the `hasLocalChanges` check in the git client when we moved it over from the merge script. The problem is that we are using `git` in the first argument of `git.run`. That means that we under-the-hood run `git git <..>`. This commit fixes that, but also switches to a better variant for ensuring no local changes because it exits with non-zero when there are local changes. PR Close angular#37489
…nterface files (angular#37370) Previously the comments for these files referenced a path to "packages/core/src/render3/jit/compiler_facade_interface.ts" that does not exist in the current codebase. This PR corrects the path in these comments. PR Close angular#37370
lifecycle hooks api detailed documentation contained links which were pointing to onChanges hook only which is removed, made each hook point towards its deafult page link PR Close angular#36557
…gular#37509) Add a comment to describe what the commit was for the given SHA so that we don't have to look it up. PR Close angular#37509
…r#37372) (angular#37514) In angular#29083 a call to `getCompilerFacade` was added to `ApplicationRef` which pulls in a bit of JIT-specific code. Since the code path that calls the function can't be hit for an AOT-compiled app, these changes add an `ngJitMode` guard which will allow for dead code elimination to drop it completely. Testing it out against a new CLI project showed a difference of ~1.2kb. PR Close angular#37372 PR Close angular#37514
…lease (angular#37378)" (angular#37495) This reverts commit 26849ca. PR Close angular#37495
…ngular#37382) In v7 of Angular we removed `tsickle` from the default `ngc` pipeline. This had the negative potential of breaking ES2015 output and SSR due to a limitation in TypeScript. TypeScript by default preserves type information for decorated constructor parameters when `emitDecoratorMetadata` is enabled. For example, consider this snippet below: ``` @directive() export class MyDirective { constructor(button: MyButton) {} } export class MyButton {} ``` TypeScript would generate metadata for the `MyDirective` class it has a decorator applied. This metadata would be needed in JIT mode, or for libraries that provide `MyDirective` through NPM. The metadata would look as followed: ``` let MyDirective = class MyDir {} MyDirective = __decorate([ Directive(), __metadata("design:paramtypes", [MyButton]), ], MyDirective); let MyButton = class MyButton {} ``` Notice that TypeScript generated calls to `__decorate` and `__metadata`. These calls are needed so that the Angular compiler is able to determine whether `MyDirective` is actually an directive, and what types are needed for dependency injection. The limitation surfaces in this concrete example because `MyButton` is declared after the `__metadata(..)` call, while `__metadata` actually directly references `MyButton`. This is illegal though because `MyButton` has not been declared at this point. This is due to the so-called temporal dead zone in JavaScript. Errors like followed will be reported at runtime when such file/code evaluates: ``` Uncaught ReferenceError: Cannot access 'MyButton' before initialization ``` As noted, this is a TypeScript limitation because ideally TypeScript shouldn't evaluate `__metadata`/reference `MyButton` immediately. Instead, it should defer the reference until `MyButton` is actually declared. This limitation will not be fixed by the TypeScript team though because it's a limitation as per current design and they will only revisit this once the tc39 decorator proposal is finalized (currently stage-2 at time of writing). Given this wontfix on the TypeScript side, and our heavy reliance on this metadata in libraries (and for JIT mode), we intend to fix this from within the Angular compiler by downleveling decorators to static properties that don't need to evaluate directly. For example: ``` MyDirective.ctorParameters = () => [MyButton]; ``` With this snippet above, `MyButton` is not referenced directly. Only lazily when the Angular runtime needs it. This mitigates the temporal dead zone issue caused by a limitation in TypeScript's decorator metadata output. See: microsoft/TypeScript#27519. In the past (as noted; before version 7), the Angular compiler by default used tsickle that already performed this transformation. We moved the transformation to the CLI for JIT and `ng-packager`, but now we realize that we can move this all to a single place in the compiler so that standalone ngc consumers can benefit too, and that we can disable tsickle in our Bazel `ngc-wrapped` pipeline (that currently still relies on tsickle to perform this decorator processing). This transformation also has another positive side-effect of making Angular application/library code more compatible with server-side rendering. In principle, TypeScript would also preserve type information for decorated class members (similar to how it did that for constructor parameters) at runtime. This becomes an issue when your application relies on native DOM globals for decorated class member types. e.g. ``` @input() panelElement: HTMLElement; ``` Your application code would then reference `HTMLElement` directly whenever the source file is loaded in NodeJS for SSR. `HTMLElement` does not exist on the server though, so that will become an invalid reference. One could work around this by providing global mocks for these DOM symbols, but that doesn't match up with other places where dependency injection is used for mocking DOM/browser specific symbols. More context in this issue: angular#30586. The TL;DR here is that the Angular compiler does not care about types for these class members, so it won't ever reference `HTMLElement` at runtime. Fixes angular#30106. Fixes angular#30586. Fixes angular#30141. Resolves FW-2196. Resolves FW-2199. PR Close angular#37382
…nent initialization (angular#36161)" (angular#37524) This reverts commit e9bff5f. Failures were detected in Google tests due to this commit PR Close angular#37524
…37515) This commit removes the autocompletion feature for HTML entities. HTML entites are things like `&`, `<` etc. There are a few reasons for the decision: 1. It is outside the core functionality of Angular LS 2. The implementation relies on regex, which incurs performance cost 3. There isn't much value if users do not already know which entity they want to use 4. The list that we provide is not exhaustive PR Close angular#37515
It is quite common for the TS compiler to have to add synthetic
types to function signatures, where the developer has not
explicitly provided them. This results in `import(...)` expressions
appearing in typings files. For example in `@ngrx/data` there is a
class with a getter that has an implicit type:
```ts
export declare class EntityCollectionServiceBase<...> {
...
get store() {
return this.dispatcher.store;
}
...
}
```
In the d.ts file for this we get:
```ts
get store(): Store<import("@ngrx/data").EntityCache>;
```
Given that this file is within the `@ngrx/data` package already,
this caused ngcc to believe that there was a circular dependency,
causing it to fail to process the package - and in fact crash!
This commit resolves this problem by ignoring `import()` expressions
when scanning typings programs for dependencies. This ability was
only introduced very recently in a 10.0.0 RC release, and so it has
limited benefit given that up till now ngcc has been able to process
libraries effectively without it. Moreover, in the rare case that a
package does have such a dependency, it should get picked up
by the sync ngcc+CLI integration point.
PR Close angular#37503
Web- worker was 2 times in the nav pointing towards the same file, just with different names removed one to remove redundancy PR Close angular#37289
Update the GDE listing with info abbout Mike Huang. Update the GDE listing with info abbout Mike Huang. PR Close angular#36472
This is a proposal commit that adds a separate scope for migration changes. The motiviation is that migrations aren't necessarily always affecting `@angular/core`, but are just stored in the core package for a canonical location when someone runs `ng update`. Additionally, it rather seems confusing in the changelog if migration changes are listed under `core`. PR Close angular#36390
ngcontainer Dockerfile was noted as deprecated ~2 years ago, we no longer rely on it anymore nor do we publish it. PR Close angular#36421
Periodic documentation cleanup of GDEs which are no longer in the Angular program. Removed: - "Filip Bruun Bech-Larsen" - "Vinci Rufus" - "Jeff Cross" PR Close angular#36467
Change documentation to a more grammatically correct format. "bug-free" is preferred over "bug free". PR Close angular#36515
There were some examples for 'DoCheck' in the lifeCycle hooks guide. Added a link to the relevant section of the guide in the 'DoCheck()' api docs. Fixes angular#35596 PR Close angular#36574
Adds @nocollapse to static properties added by ngcc iff annotateForClosureCompiler is true. The Closure Compiler will collapse static properties into the global namespace. Adding this annotation keeps the properties attached to their respective object, which allows them to be referenced via a class's constructor. The annotation is already added by ngtsc and ngc under the same option, this commit extends the functionality to ngcc. Closes angular#36618. PR Close angular#36652
This TypeScript version contains the revert for the classes wrapped in IIFE change that was introduced in version 3.9. PR Close angular#37456
…37456) With this change we update the Angular CLI repo and aio packages to the latest RC version for version 10. PR Close angular#37456
`@babel/preset-env` is needed by for NGCC tests: https://github.com/angular/angular/blob/3569fdf45195c36713e43a91a4feba4fa3c9facf/packages/compiler-cli/ngcc/test/BUILD.bazel#L84 However this is not as a depedency in the angular repo. PR Close angular#37456
Updated comment doc in packages/core/src/interface/type.ts PR Close angular#37930
In angular#37957, parts of the testing guide were broken out into separate guides. As part of that work, the `<live-example>` tags were also copied to the new guides. These `<live-example>` tags did not specify the targeted example project via the `name` attribute, thus they were implicitly targeting the example with the same name as the guide they were in. See the [Docs style guide][1] for more info. However, there is only one example project (`testing/`) and all `<live-example>` tags were supposed to target that. This worked fine on the `testing.md` guide, but it broke on other guides (which tried to target non-existing example projects based on their names). This commit fixes it by explicitly specifying which example is targeted by the `<live-example>` tags. It also removes the `embedded-style` attribute that has no effect. [1]: https://angular.io/guide/docs-style-guide#live-examples Fixes angular#38036 PR Close angular#38038
…oute (angular#38034) In angular.io, it linked to the wrong part of the page. https://angular.io/guide/router#activated-route PR Close angular#38034
Remove an article from the `Data flow in forms` section of the forms overview guide. The use of `the` and `a` together is not syntactically correct. PR Close angular#37933
Fix two typos in the 'Building a template-driven form` that caused the guide to not be displayed correctly. PR Close angular#37933
…gular#36805) When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. See angular#24571 PR Close angular#36805
…onfig (angular#38003) In CLI v10 there was a move to use the new solution-style tsconfig which became available in TS 3.9. The result of this is that the standard tsconfig.json no longer contains important information such as "paths" mappings, which ngcc might need to correctly compute dependencies. ngcc (and ngc and tsc) infer the path to tsconfig.json if not given an explicit tsconfig file-path. But now that means it infers the solution tsconfig rather than one that contains the useful information it used to get. This commit logs a warning in this case to inform the developer that they might not have meant to load this tsconfig and offer alternative options. Fixes angular#36386 PR Close angular#38003
…ngular#38030) The `fs.relative()` method assumed that the file-system is a single tree, which is not the case in Windows, where you can have multiple drives, e.g. `C:`, `D:` etc. This commit changes `fs.relative()` so that it no longer forces the result to be a `PathSegment` and then flows that refactoring through the rest of the compiler-cli (and ngcc). The main difference is that now, in some cases, we needed to check whether the result is "rooted", i.e an `AbsoluteFsPath`, rather than a `PathSegment`, before using it. Fixes angular#36777 PR Close angular#38030
Angular Console has been renamed and links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation. Closes angular#37604 PR Close angular#37608
…8079) Complete and clarify descriptions and example of the guard and resolver functions in Router API documentation. PR Close angular#38079
…gular#38029) Adds Firefox as browser to `dev-infra/browsers` with RBE compatibility. The default Firefox browser is not compatible similar to the default Chromium version exposed by `rules_webtesting`. The Angular Components repository will use this browser target as it enables RBE support. Also it gives us more flexibility about the Firefox version we test against. The version provided by `rules_webtesting` is very old and most likely not frequently updated (based on past experience). PR Close angular#38029
…kage (angular#38026) * fix substitution that was broken by PR angular#36540 to match the new import path PR Close angular#38026
…lar#38026) * Without this BUILD file we were seeing errors about the reference to expand_template.bzl in ng_rollup_bundle.bzl because dev-infra/bazel was not considered a package. PR Close angular#38026
To take advantage of lazy loaded images `img[loading=lazy]`, this commit upgrades lighthouse to version 6.1.0. Closes angular#35965 PR Close angular#37899
…ar#37899) As part of our CI checks, we ensure the a11y score on certain angular.io pages do not fall below some thresholds. This commit increases these thresholds based on our current scores to ensure we do not regress below current values. PR Close angular#37899
…tainer (angular#37773) Fixes the following issues related to how we validate properties during JIT: - The invalid property warning was printing `null` as the node name for `ng-content`. The problem is that when generating a template from `ng-content` we weren't capturing the node name. - We weren't running property validation on `ng-container` at all. This used to be supported on ViewEngine and seems like an oversight. In the process of making these changes, I found and cleaned up a few places where we were passing in `LView` unnecessarily. PR Close angular#37773
…s` --> `publishing...ensures`) (angular#38032) PR Close angular#38032
This commit adds Emma Twersky to the Angular Contributors page along with a bio & a photograph. PR Close angular#38084
Ajit Singh is a newly added collborator after a few months of contributing add him to the contributors.json PR Close angular#37792
* Add petebacondarwin to public-api, size-tracking, and circular-dependencies * Add mhevery, josephperrott, and jelbourn to code-ownership PR Close angular#37994
…8088) Currently the Ivy language service bundle is [10MB]( https://unpkg.com/browse/@angular/language-service@10.0.4/bundles/) because we accidentally included typescript in the bundle. With this change, the bundle size goes down to 1.6MB, which is even smaller than the View Engine bundle (1.8MB). ```bash $ yarn bazel build //packages/language-service/bundles:ivy $ ls -lh dist/bin/packages/language-service/bundles/ivy.umd.js 1.6M Jul 15 15:49 dist/bin/packages/language-service/bundles/ivy.umd.js ``` PR Close angular#38088
Edit descriptions, usage examples, and add links to be complete and consistent with API reference doc style PR Close angular#37980
…#38103) This commit adds a script to build @angular/language-service locally so that it can be consumed by the Angular extension for local development. PR Close angular#38103
…strap
Currently we read lifecycle hooks eagerly during `ɵɵdefineComponent`.
The result is that it is not possible to do any sort of meta-programing
such as mixins or adding lifecycle hooks using custom decorators since
any such code executes after `ɵɵdefineComponent` has extracted the
lifecycle hooks from the prototype. Additionally the behavior is
inconsistent between AOT and JIT mode. In JIT mode overriding lifecycle
hooks is possible because the whole `ɵɵdefineComponent` is placed in
getter which is executed lazily. This is because JIT mode must compile a
template which can be specified as `templateURL` and those we are
waiting for its resolution.
- `+` `ɵɵdefineComponent` becomes smaller as it no longer needs to copy
lifecycle hooks from prototype to `ComponentDef`
- `-` `ɵɵNgOnChangesFeature` feature is now always included with the
codebase as it is no longer tree shakable.
Previously we have read lifecycle hooks from prototype in the
`ɵɵdefineComponent` so that lifecycle hook access would be monomorphic.
This decision was made before we had `T*` data structures. By not
reading the lifecycle hooks we are moving the megamorhic read form
`ɵɵdefineComponent` to instructions. However, the reads happen on
`firstTemplatePass` only and are subsequently cached in the `T*` data
structures. The result is that the overall performance should be same
(or slightly better as the intermediate `ComponentDef` has been
removed.)
- [ ] Remove `ɵɵNgOnChangesFeature` from compiler. (It will no longer
be a feature.)
- [ ] Discuss the future of `Features` as they hinder meta-programing.
Fix angular#30497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information