Skip to content

Conversation

@jeromekelleher
Copy link
Member

@jeromekelleher jeromekelleher commented May 20, 2022

Closes #2269

Waiting on #2240

Stacked on #2331

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #2283 (94a0354) into main (6cde9a6) will decrease coverage by 0.01%.
The diff coverage is 93.37%.

❗ Current head 94a0354 differs from pull request most recent head 9482f5f. Consider uploading reports for the commit 9482f5f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2283      +/-   ##
==========================================
- Coverage   93.28%   93.26%   -0.02%     
==========================================
  Files          28       28              
  Lines       26382    26642     +260     
  Branches     1188     1213      +25     
==========================================
+ Hits        24610    24848     +238     
- Misses       1742     1762      +20     
- Partials       30       32       +2     
Flag Coverage Δ
c-tests 92.25% <86.72%> (-0.06%) ⬇️
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.35% <35.17%> (-0.32%) ⬇️
python-tests 98.87% <99.37%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/core.h 100.00% <ø> (ø)
c/tskit/tables.c 90.24% <84.69%> (-0.09%) ⬇️
python/_tskitmodule.c 90.66% <88.37%> (+<0.01%) ⬆️
python/tskit/drawing.py 99.17% <98.66%> (-0.26%) ⬇️
c/tskit/core.c 97.91% <100.00%> (+0.01%) ⬆️
c/tskit/trees.c 95.08% <100.00%> (+<0.01%) ⬆️
python/tskit/genotypes.py 98.46% <100.00%> (+0.46%) ⬆️
python/tskit/tables.py 98.89% <100.00%> (+<0.01%) ⬆️
python/tskit/trees.py 98.18% <100.00%> (+0.03%) ⬆️
python/tskit/vcf.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4bd75...9482f5f. Read the comment docs.

@jeromekelleher jeromekelleher marked this pull request as ready for review June 10, 2022 12:21
@jeromekelleher jeromekelleher force-pushed the remove-tsutil-decap branch 2 times, most recently from bcabcc2 to 0db515e Compare June 10, 2022 14:34
Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit d3bb5c9 into tskit-dev:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace tsutil.decapitate in tests

2 participants