Skip to content

Conversation

@jeromekelleher
Copy link
Member

Closes #2334

@jeromekelleher jeromekelleher marked this pull request as ready for review June 17, 2022 10:19
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2348 (6aaa04b) into main (a1b1e5d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
- Coverage   93.27%   93.27%   -0.01%     
==========================================
  Files          28       28              
  Lines       26768    26755      -13     
  Branches     1217     1216       -1     
==========================================
- Hits        24969    24956      -13     
  Misses       1766     1766              
  Partials       33       33              
Flag Coverage Δ
c-tests 92.25% <ø> (-0.01%) ⬇️
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.47% <66.66%> (+<0.01%) ⬆️
python-tests 98.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
c/tskit/trees.c 95.03% <ø> (-0.01%) ⬇️
python/_tskitmodule.c 90.67% <100.00%> (-0.01%) ⬇️
python/tskit/trees.py 98.27% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b1e5d...6aaa04b. Read the comment docs.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 928cb2f into tskit-dev:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change default population semantics of decapitate and split_edges

2 participants