Skip to content

refactor(core-transactions): bootstrap transactions in batches#2997

Merged
faustbrian merged 3 commits intodevelopfrom
refactor/core-transactions/bootstrap
Oct 3, 2019
Merged

refactor(core-transactions): bootstrap transactions in batches#2997
faustbrian merged 3 commits intodevelopfrom
refactor/core-transactions/bootstrap

Conversation

@spkjp
Copy link
Copy Markdown
Contributor

@spkjp spkjp commented Oct 1, 2019

Summary

Prevents memory spikes during bootstrap phase by loading transactions of
the same type in batches instead of all at once into memory.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Prevents memory spikes during bootstrap phase by loading transactions of
the same type in batches instead of all at once into memory during
bootstrap.
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 1, 2019

Codecov Report

Merging #2997 into develop will decrease coverage by 0.18%.
The diff coverage is 10.97%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2997      +/-   ##
===========================================
- Coverage    66.05%   65.86%   -0.19%     
===========================================
  Files          420      421       +1     
  Lines        10035    10082      +47     
  Branches       509      510       +1     
===========================================
+ Hits          6629     6641      +12     
- Misses        3364     3399      +35     
  Partials        42       42
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 24.07% <0%> (-0.46%) ⬇️
...c/repositories/transactions-business-repository.ts 87.09% <0%> (-1.43%) ⬇️
...nsactions/src/handlers/bridgechain-registration.ts 70.73% <10%> (-1.77%) ⬇️
...ansactions/src/handlers/bridgechain-resignation.ts 50% <11.11%> (-1.22%) ⬇️
...es/core-transactions/src/handlers/multi-payment.ts 77.14% <12.5%> (-1.65%) ⬇️
...trate-transactions/src/handlers/business-update.ts 26.66% <13.33%> (-3.34%) ⬇️
packages/core-transactions/src/handlers/ipfs.ts 74.07% <14.28%> (-1.93%) ⬇️
...transactions/src/handlers/business-registration.ts 68.75% <16.66%> (-2.22%) ⬇️
...-transactions/src/handlers/business-resignation.ts 56.25% <16.66%> (-1.82%) ⬇️
...transactions/src/handlers/delegate-registration.ts 43.85% <16.66%> (+0.22%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ee4c0...88ae34a. Read the comment docs.

faustbrian
faustbrian previously approved these changes Oct 2, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@4953e48). Click here to learn what that means.
The diff coverage is 10.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2997   +/-   ##
==========================================
  Coverage           ?   65.86%           
==========================================
  Files              ?      421           
  Lines              ?    10082           
  Branches           ?      510           
==========================================
  Hits               ?     6641           
  Misses             ?     3399           
  Partials           ?       42
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 24.07% <0%> (ø)
...c/repositories/transactions-business-repository.ts 87.09% <0%> (ø)
...nsactions/src/handlers/bridgechain-registration.ts 70.73% <10%> (ø)
...ansactions/src/handlers/bridgechain-resignation.ts 50% <11.11%> (ø)
...es/core-transactions/src/handlers/multi-payment.ts 77.14% <12.5%> (ø)
...trate-transactions/src/handlers/business-update.ts 26.66% <13.33%> (ø)
packages/core-transactions/src/handlers/ipfs.ts 74.07% <14.28%> (ø)
...transactions/src/handlers/business-registration.ts 68.75% <16.66%> (ø)
...-transactions/src/handlers/business-resignation.ts 56.25% <16.66%> (ø)
...transactions/src/handlers/delegate-registration.ts 43.85% <16.66%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4953e48...6aee57f. Read the comment docs.

@faustbrian faustbrian merged commit 27132f0 into develop Oct 3, 2019
@ghost ghost deleted the refactor/core-transactions/bootstrap branch October 3, 2019 05:47
vasild added a commit that referenced this pull request Oct 4, 2019
…ts-nonce

* ArkEcosystem/core/develop:
  refactor: remove `vendorFieldHex` (#3014)
  ci: run push events on master and develop, rest on PRs
  perf(crypto): memoize base58 de/encoding (#3015)
  refactor(core-transactions): bootstrap transactions in batches (#2997)
  perf(crypto): replace bignumber.js with native BigInt (#3010)
  refactor: add `round.missed` event (#3011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants