refactor(core-transactions): bootstrap transactions in batches#2997
Merged
faustbrian merged 3 commits intodevelopfrom Oct 3, 2019
Merged
refactor(core-transactions): bootstrap transactions in batches#2997faustbrian merged 3 commits intodevelopfrom
faustbrian merged 3 commits intodevelopfrom
Conversation
Prevents memory spikes during bootstrap phase by loading transactions of the same type in batches instead of all at once into memory during bootstrap.
Codecov Report
@@ Coverage Diff @@
## develop #2997 +/- ##
===========================================
- Coverage 66.05% 65.86% -0.19%
===========================================
Files 420 421 +1
Lines 10035 10082 +47
Branches 509 510 +1
===========================================
+ Hits 6629 6641 +12
- Misses 3364 3399 +35
Partials 42 42
Continue to review full report at Codecov.
|
faustbrian
previously approved these changes
Oct 2, 2019
…sactions/bootstrap
Codecov Report
@@ Coverage Diff @@
## develop #2997 +/- ##
==========================================
Coverage ? 65.86%
==========================================
Files ? 421
Lines ? 10082
Branches ? 510
==========================================
Hits ? 6641
Misses ? 3399
Partials ? 42
Continue to review full report at Codecov.
|
vasild
added a commit
that referenced
this pull request
Oct 4, 2019
…ts-nonce * ArkEcosystem/core/develop: refactor: remove `vendorFieldHex` (#3014) ci: run push events on master and develop, rest on PRs perf(crypto): memoize base58 de/encoding (#3015) refactor(core-transactions): bootstrap transactions in batches (#2997) perf(crypto): replace bignumber.js with native BigInt (#3010) refactor: add `round.missed` event (#3011)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents memory spikes during bootstrap phase by loading transactions of
the same type in batches instead of all at once into memory.
Checklist