perf(crypto): replace bignumber.js with native BigInt#3010
Merged
faustbrian merged 7 commits intodevelopfrom Oct 3, 2019
Merged
perf(crypto): replace bignumber.js with native BigInt#3010faustbrian merged 7 commits intodevelopfrom
faustbrian merged 7 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3010 +/- ##
===========================================
+ Coverage 66.03% 66.05% +0.01%
===========================================
Files 423 423
Lines 10120 10131 +11
Branches 538 539 +1
===========================================
+ Hits 6683 6692 +9
- Misses 3392 3394 +2
Partials 45 45
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Oct 3, 2019
vasild
added a commit
that referenced
this pull request
Oct 4, 2019
…ts-nonce * ArkEcosystem/core/develop: refactor: remove `vendorFieldHex` (#3014) ci: run push events on master and develop, rest on PRs perf(crypto): memoize base58 de/encoding (#3015) refactor(core-transactions): bootstrap transactions in batches (#2997) perf(crypto): replace bignumber.js with native BigInt (#3010) refactor: add `round.missed` event (#3011)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
bignumber.jswith our own thin wrapper around the native BigInt type. Depends on some yet unreleased@arkecosystem/utilsfixes. With native BigInts the memory usage of my node is about 10% less after bootstrap compared to without this PR.Benchmarks before:
After:
Checklist