Skip to content

feat(core-database): emit round.missed for each active delegate that didn't forge#3011

Merged
spkjp merged 1 commit intodevelopfrom
refactor/round-missed
Oct 3, 2019
Merged

feat(core-database): emit round.missed for each active delegate that didn't forge#3011
spkjp merged 1 commit intodevelopfrom
refactor/round-missed

Conversation

@spkjp
Copy link
Copy Markdown
Contributor

@spkjp spkjp commented Oct 3, 2019

Summary

Emit round.missed at the end of a round for each active delegate that didn't forge a block.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Emit `round.missed` whenever an active delegate didn't forge any blocks
during a round.
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 3, 2019

Codecov Report

Merging #3011 into develop will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3011      +/-   ##
===========================================
- Coverage     66.1%   66.03%   -0.07%     
===========================================
  Files          423      423              
  Lines        10110    10120      +10     
  Branches       536      538       +2     
===========================================
  Hits          6683     6683              
- Misses        3382     3392      +10     
  Partials        45       45
Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 26.22% <0%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279585b...06389f0. Read the comment docs.

@spkjp spkjp merged commit 4953e48 into develop Oct 3, 2019
@ghost ghost deleted the refactor/round-missed branch October 3, 2019 02:25
spkjp added a commit that referenced this pull request Oct 3, 2019
Emit `round.missed` whenever an active delegate didn't forge any blocks
during a round.
vasild added a commit that referenced this pull request Oct 4, 2019
…ts-nonce

* ArkEcosystem/core/develop:
  refactor: remove `vendorFieldHex` (#3014)
  ci: run push events on master and develop, rest on PRs
  perf(crypto): memoize base58 de/encoding (#3015)
  refactor(core-transactions): bootstrap transactions in batches (#2997)
  perf(crypto): replace bignumber.js with native BigInt (#3010)
  refactor: add `round.missed` event (#3011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants