Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-database): emit `round.missed` for each active delegate that didn't forge #3011

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@supaiku0
Copy link
Contributor

commented Oct 3, 2019

Summary

Emit round.missed at the end of a round for each active delegate that didn't forge a block.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
Emit `round.missed` whenever an active delegate didn't forge any blocks
during a round.
@codecov

This comment has been minimized.

Copy link

commented Oct 3, 2019

Codecov Report

Merging #3011 into develop will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3011      +/-   ##
===========================================
- Coverage     66.1%   66.03%   -0.07%     
===========================================
  Files          423      423              
  Lines        10110    10120      +10     
  Branches       536      538       +2     
===========================================
  Hits          6683     6683              
- Misses        3382     3392      +10     
  Partials        45       45
Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 26.22% <0%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279585b...06389f0. Read the comment docs.

@supaiku0 supaiku0 merged commit 4953e48 into develop Oct 3, 2019
94 of 100 checks passed
94 of 100 checks passed
unit (10.x)
Details
crypto (10.x)
Details
crypto (10.x)
Details
bridgechain-registration (10.x)
Details
bridgechain-registration (10.x)
Details
unit (10.x)
Details
crypto (12.x)
Details
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (10.x)
Details
bridgechain-resignation (10.x)
Details
integration (10.x)
Details
integration (10.x)
Details
bridgechain-resignation (12.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
integration (12.x)
Details
e2e (10.x)
Details
bridgechain-update (10.x)
Details
bridgechain-update (10.x)
Details
e2e (10.x)
Details
e2e (12.x) e2e (12.x)
Details
bridgechain-update (12.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x)
Details
business-registration (10.x)
Details
business-registration (10.x)
Details
business-registration (12.x)
Details
business-registration (12.x)
Details
business-resignation (10.x)
Details
business-resignation (10.x)
Details
business-resignation (12.x)
Details
business-resignation (12.x)
Details
business-update (10.x)
Details
business-update (10.x)
Details
business-update (12.x)
Details
business-update (12.x)
Details
delegate-registration (10.x)
Details
delegate-registration (10.x)
Details
delegate-registration (12.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (10.x)
Details
delegate-resignation (10.x)
Details
delegate-resignation (12.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (10.x)
Details
htlc-claim (10.x)
Details
htlc-claim (12.x)
Details
htlc-claim (12.x)
Details
htlc-lock (10.x)
Details
htlc-lock (10.x)
Details
htlc-lock (12.x)
Details
htlc-lock (12.x)
Details
htlc-refund (10.x)
Details
htlc-refund (10.x)
Details
htlc-refund (12.x)
Details
htlc-refund (12.x)
Details
ipfs (10.x)
Details
ipfs (10.x)
Details
ipfs (12.x)
Details
ipfs (12.x)
Details
multi-payment (10.x)
Details
multi-payment (10.x)
Details
multi-payment (12.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (10.x)
Details
multi-signature-registration (10.x)
Details
multi-signature-registration (12.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (10.x)
Details
second-signature-registration (10.x)
Details
second-signature-registration (12.x)
Details
second-signature-registration (12.x)
Details
transfer (10.x)
Details
transfer (10.x)
Details
transfer (12.x)
Details
transfer (12.x)
Details
vote (10.x)
Details
vote (10.x)
Details
vote (12.x)
Details
vote (12.x)
Details
codeclimate 1 issue to fix
Details
codecov/patch 0% of diff hit (target 66.1%)
Details
codecov/project 66.03% (-0.07%) compared to 279585b
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the refactor/round-missed branch Oct 3, 2019
supaiku0 added a commit that referenced this pull request Oct 3, 2019
Emit `round.missed` whenever an active delegate didn't forge any blocks
during a round.
vasild added a commit that referenced this pull request Oct 4, 2019
…ts-nonce

* ArkEcosystem/core/develop:
  refactor: remove `vendorFieldHex` (#3014)
  ci: run push events on master and develop, rest on PRs
  perf(crypto): memoize base58 de/encoding (#3015)
  refactor(core-transactions): bootstrap transactions in batches (#2997)
  perf(crypto): replace bignumber.js with native BigInt (#3010)
  refactor: add `round.missed` event (#3011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.