perf(crypto): memoize base58 de/encoding#3015
Merged
faustbrian merged 2 commits intodevelopfrom Oct 3, 2019
Merged
Conversation
ghost
deleted the
vasild
reviewed
Oct 3, 2019
| }; | ||
|
|
||
| export const Base58 = { | ||
| encodeCheck: moize(encodeCheck), |
Contributor
There was a problem hiding this comment.
How much data is this going to store in memory? There is no configuration or anything about that mentioned in https://www.npmjs.com/package/fast-memoize
vasild
added a commit
that referenced
this pull request
Oct 4, 2019
…ts-nonce * ArkEcosystem/core/develop: refactor: remove `vendorFieldHex` (#3014) ci: run push events on master and develop, rest on PRs perf(crypto): memoize base58 de/encoding (#3015) refactor(core-transactions): bootstrap transactions in batches (#2997) perf(crypto): replace bignumber.js with native BigInt (#3010) refactor: add `round.missed` event (#3011)
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Memoize Base58 functions to speed up multipayment processing by up to 50%.
Checklist