Skip to content

Cover existing branch Git update crash recovery#330

Merged
adamziel merged 1 commit into
trunkfrom
codex/existing-update-crash-e2e
May 18, 2026
Merged

Cover existing branch Git update crash recovery#330
adamziel merged 1 commit into
trunkfrom
codex/existing-update-crash-e2e

Conversation

@adamziel
Copy link
Copy Markdown
Contributor

What it does

Fixes Git receive-pack parsing for unmultiplexed PACK data that ends with a short trailing chunk, then adds public E2E coverage for crashing during an existing-branch Git update.

Rationale

The lower-level COW Git test already covered after-existing-branch-update-publish, but the real forkpress commit over HTTP path was not covered. While adding that E2E slice, the public path exposed a parser edge case: the demuxer tried to read a 4-byte prefix from the tail of raw PACK bytes.

Implementation

ProtocolDemultiplexer now streams subsequent unmultiplexed PACK bytes directly once it has seen the PACK marker, instead of treating every later chunk as length-prefixed.

The COW E2E now has FORKPRESS_E2E_ONLY=git-existing-update-crash, which:

  1. Pushes a normal update to feature-cow over HTTP.
  2. Restarts the server with after-existing-branch-update-publish armed.
  3. Verifies the crash leaves the published update and rollback artifact.
  4. Retries the update and verifies stale update artifacts are cleaned.

Testing instructions

php -l vendor/wordpress-php-toolkit/components/Git/Protocol/Parser/class-protocoldemultiplexer.php
php -l tests/cow/git_server.php
umask 0022; make test-cow-git-server
umask 0022; cargo build -p forkpress-cli --target x86_64-unknown-linux-musl
umask 0022; FORKPRESS_E2E_PORT=18419 make test-cow-e2e-git-existing-update-crash

@adamziel adamziel merged commit 9213895 into trunk May 18, 2026
7 checks passed
@adamziel adamziel mentioned this pull request May 18, 2026
adamziel added a commit that referenced this pull request May 18, 2026
## Release `v0.1.35`

Version bump and release metadata update for `v0.1.35`.

**Changelog draft:**
* Extend merge revalidation and WordPress semantic guards
([#313](#313))
* Add Events Calendar-shaped merge smoke coverage
([#318](#318))
* Extend semantic E2E with Site Editor objects
([#317](#317))
* Add thin SSH remote clone command
([#315](#315))
* Update release gate evidence for v0.1.34
([#319](#319))
* Guard plugin children behind logical identity collisions
([#320](#320))
* Hold case-insensitive upload path collisions
([#322](#322))
* Cover scoped crash recovery
([#323](#323))
* Hold malformed attachment metadata shapes
([#324](#324))
* Cover thin remote clone branch metadata
([#326](#326))
* Cover source-added trigger view dependencies
([#321](#321))
* Cover WooCommerce duplicate address semantics
([#325](#325))
* Cover Events Calendar organizer validator semantics
([#327](#327))
* Cover Elementor widget media validator semantics
([#328](#328))
* Reject duplicate attachment upload metadata rows
([#329](#329))
* Cover existing branch Git update crash recovery
([#330](#330))
* Mark WordPress media repairs review-only
([#331](#331))
* Cover backup attachment metadata drift
([#332](#332))
* Limit release verification for COW-only PRs
([#335](#335))
* Batch merge reliability roadmap coverage
([#336](#336))
* Cover WordPress upload MIME drift
([#333](#333))
* Add branch merge history commands
([#334](#334))
* Show restored stale-audit reviews
([#337](#337))
* Cover Yoast duplicate indexable permalinks
([#338](#338))
* Cover Yoast indexable hierarchy drift
([#339](#339))
* Cover revision parent semantic drift
([#340](#340))
* Expose merge history in branch switcher
([#341](#341))
* Cover ACF relationship validator drift
([#342](#342))
* Show merge history on branch admin page
([#343](#343))
* Drill into conflicts from branch admin history
([#344](#344))
* Expose branch tree on admin page
([#345](#345))
* Resolve conflicts from branch admin page
([#346](#346))
* Document conflict review workflow
([#347](#347))

**Full changelog:**
v0.1.34...release/v0.1.35

## Next steps

1. **Review** the changes in this pull request.
2. **Push** any additional edits to this branch (`release/v0.1.35`).
3. **Merge** this pull request to publish `v0.1.35`.

Merging will automatically build ForkPress binaries, create a GitHub
release, and update the Homebrew formula.

Co-authored-by: Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants