Val -> Prod #4384
Merged
Val -> Prod #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update ReportDrawer so admins can't submit for users * Light cleaning Co-authored-by: Nicholas Summers <nick@coforma.io>
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods
* api updates * remove undefined * simplify banner provider api calls * fix banner provider tests
* api updates * remove undefined * simplify dynamodb mocking * simplify banner provider api calls * fix banner provider tests
* remove delete button flash * alternate banner deletion display bug solution (#4173) * for scott * removed overkill banner test Co-authored-by: Brax Excell <braxton@coforma.io>
* EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage
* Add Delete Modal to DynamicFields * Add in spinner * Make it so a user can't fully remove dynamic fields * Check that theres always at least 1 dynamic field * Fix bug where modal wouldn't display if you clicked close and opened again * Add test to confirm delete modal will show multiple times * Simplify setting record for deletion * Garrett Edits * Brax Edit * simplify name mapping * Simplify modal spinner Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Garrett Rabian <garrett@coforma.io> Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com>
#4198) * unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * nick review feedback * Accessibility test fix * hide text if no entities * fix minor type error * garrett feedback changes Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com>
* loading state for hydration * Update Form.tsx * banner dashboard hydration loading state * report pages hydration * wrapped it up * Update ReportPageWrapper.tsx Co-authored-by: Brax Excell <braxton@coforma.io>
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * Implement simple deletion of entities * add EntityCard tests * Add tests for DeleteEntityModal * Add EntityCard test * fix bug with adding after deleting measures * nick review feedback * Brax Edit * Fix failing test * Accessibility test fix * Accessibility test fix * hide text if no entities * fix minor type error * Fix test * Add test to make sure if bad data is present it still fails elegently * Add test to make sure if bad data is present it still fails elegently Co-authored-by: Braxton Excell <braxton.excell@gmail.com> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Brax Excell <braxton@coforma.io>
* added spreadsheet widgets * Update ReportPageIntro.tsx * normal layout
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * Wiring up edit button * Edit is DONE * Hydration of values in modal * Working on failing tests * Unit test is fixed!!!!!!!!!!!! * coverage * Fix issue with types * feedback * Suggested changes Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
* redline section A * PR review changes * added period
* fix nested field validation bug * little naming change
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * nick review feedback * Accessibility test fix * hide text if no entities * wip * wip 2 * fix minor type error * wip * modify submitting status locations * data is submitting * wip for nick * Fix status check on entity cards * Hookup Drawer Details and style it * garrett feedback changes * tweaks * fix failing tests * tweak * tweak * Fix bad typeing in delete entity modal * Add tests for EntityCard * Almost clean up tests * add last needed test * tweak * tweaks * trying to fix these merge conflicts and clean things up * clean up * clean up * style tweak for when there's tons of text * unset selected entity * review feedback * combine button * fix up some tests Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com>
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * nick review feedback * Accessibility test fix * hide text if no entities * wip * wip 2 * fix minor type error * wip * modify submitting status locations * data is submitting * wip for nick * Fix status check on entity cards * Hookup Drawer Details and style it * garrett feedback changes * tweaks * fix failing tests * tweak * tweak * Fix bad typeing in delete entity modal * Add tests for EntityCard * Almost clean up tests * add last needed test * tweak * tweaks * trying to fix these merge conflicts and clean things up * clean up * clean up * style tweak for when there's tons of text * unset selected entity * get drawer hydrating * review feedback * combine button * fix up some tests Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com>
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * nick review feedback * Accessibility test fix * hide text if no entities * wip * wip 2 * fix minor type error * wip * modify submitting status locations * data is submitting * wip for nick * Fix status check on entity cards * Hookup Drawer Details and style it * garrett feedback changes * tweaks * fix failing tests * tweak * tweak * Fix bad typeing in delete entity modal * Add tests for EntityCard * Almost clean up tests * add last needed test * tweak * tweaks * trying to fix these merge conflicts and clean things up * clean up * clean up * style tweak for when there's tons of text * unset selected entity * get drawer hydrating * review feedback * combine button * fix up some tests * simplify hydration data moulding Co-authored-by: Braxton Excell <braxton.excell@gmail.com> Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com>
* add skipnav to sidebar * simplify styling
* Remove react-query * Remove react-query dependency * Remove old comment Co-authored-by: Nicholas Summers <nick@coforma.io>
* Section C Redlines * Fixup Section C Redlines * Fixup Section C Redlines * Fix additional redlines requested * Additional redlines requested * Tighten up styling * Remove example styling for reducing section gap Co-authored-by: Nicholas Summers <nick@coforma.io>
* Reduce mqClasses with Scotts godly ampersand insight * Missed test deletion xd * Update services/ui-src/src/components/fields/CheckboxField.tsx Co-authored-by: Brax Excell <braxton@coforma.io> * Update services/ui-src/src/components/menus/Sidebar.tsx Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Brax Excell <braxton@coforma.io>
* one layer of abstraction * nest within entitycard folder * separate by type * add a11y tests for different card shapes * pr feedback * simplify
Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com>
* one layer of abstraction * nest within entitycard folder * separate by type * parse out entities util * add a11y tests for different card shapes * abstract choice parsing * oops remove
* wip * ha i win * fix failing test * surprise encore * remove commented line
Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Brax Excell <braxton@coforma.io>
ntsummers1
requested review from
karla-vm,
TheDanMiller,
BearHanded,
braxex,
gmrabian,
juliuscaesar,
scwambach and
britt-mo
as code owners
britt-mo
approved these changes
Oct 12, 2022
gmrabian
requested changes
Oct 12, 2022
karla-vm
approved these changes
Oct 12, 2022
gmrabian
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to test
Changed Dependencies
Code author checklist
Reviewer checklist (two different people)