Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Val -> Prod #4384

Merged
merged 34 commits into from
Oct 12, 2022
Merged

Val -> Prod #4384

merged 34 commits into from
Oct 12, 2022

Commits on Sep 30, 2022

  1. MDCT-1992: Update ReportDrawer so admins can't submit for users (#4158)

    * Update ReportDrawer so admins can't submit for users
    
    * Light cleaning
    
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Nick Summers and Nicholas Summers committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    49a78c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. page structure changes (dynamic drawer step 1) (#4172)

    * unnest pages in report json
    
    * refactor spreadsheet
    
    * fix all types and prepare drawer and modal forms'
    
    * final type tweaks
    
    * update copyAdminDisabledStatusToForms utility method
    
    * add more tests for utility methods
    braxex committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    114f003 View commit details
    Browse the repository at this point in the history
  2. MDCT-1993 api updates (#4180)

    * api updates
    
    * remove undefined
    
    * simplify banner provider api calls
    
    * fix banner provider tests
    gmrabian committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    3ecab67 View commit details
    Browse the repository at this point in the history
  3. simplify dynamodb mocking (#4181)

    * api updates
    
    * remove undefined
    
    * simplify dynamodb mocking
    
    * simplify banner provider api calls
    
    * fix banner provider tests
    gmrabian committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c4c5d3d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    533a24e View commit details
    Browse the repository at this point in the history
  5. remove delete button flash (#4168)

    * remove delete button flash
    
    * alternate banner deletion display bug solution (#4173)
    
    * for scott
    
    * removed overkill banner test
    
    Co-authored-by: Brax Excell <braxton@coforma.io>
    scwambach and braxex committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    7bf0711 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. renamed ReportPage types (#4201)

    * EntityDrawerReportPage → DrawerReportPage
    
    * DynamicDrawerReportPage → ModalDrawerReportPage
    braxex committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    5762054 View commit details
    Browse the repository at this point in the history
  2. [MDCT-1959] Clear nested fields after they are hidden from view (#4125)

    * clear nested values
    
    * also for checkbox
    
    * add null check for displayvalue
    
    * rEcUrSiOn
    
    * update tests to include nested options
    
    * switch
    juliuscaesar committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    4917888 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. MDCT-1995: Add Delete Modal to DynamicFields (#4188)

    * Add Delete Modal to DynamicFields
    
    * Add in spinner
    
    * Make it so a user can't fully remove dynamic fields
    
    * Check that theres always at least 1 dynamic field
    
    * Fix bug where modal wouldn't display if you clicked close and opened again
    
    * Add test to confirm delete modal will show multiple times
    
    * Simplify setting record for deletion
    
    * Garrett Edits
    
    * Brax Edit
    
    * simplify name mapping
    
    * Simplify modal spinner
    
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Co-authored-by: Garrett Rabian <garrett@coforma.io>
    Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com>
    4 people committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    09bc493 View commit details
    Browse the repository at this point in the history
  2. fix type error (#4238)

    braxex committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    6b02ebd View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. ModalDrawerReportPage step 1 (initial state, creation, & initial card) (

    #4198)
    
    * unnest pages in report json
    
    * refactor spreadsheet
    
    * fix all types and prepare drawer and modal forms'
    
    * final type tweaks
    
    * update copyAdminDisabledStatusToForms utility method
    
    * add more tests for utility methods
    
    * build add/edit modal; style initial page
    
    * solve overwrite issue
    
    * build out card with no functionality
    
    * DynamicDrawerReportPage tests
    
    * EntityDrawerReportPage → DrawerReportPage
    
    * DynamicDrawerReportPage → ModalDrawerReportPage
    
    * switch from record to entity
    
    * change dynamicType to entityType
    
    * fix failing test
    
    * add AddEditEntityModal tests
    
    * add EntityCard tests
    
    * nick review feedback
    
    * Accessibility test fix
    
    * hide text if no entities
    
    * fix minor type error
    
    * garrett feedback changes
    
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Co-authored-by: Nick Summers <ntsummers1@gmail.com>
    3 people committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    4ebcf8b View commit details
    Browse the repository at this point in the history
  2. Mdct 2000 (#4236)

    * loading state for hydration
    
    * Update Form.tsx
    
    * banner dashboard hydration loading state
    
    * report pages hydration
    
    * wrapped it up
    
    * Update ReportPageWrapper.tsx
    
    Co-authored-by: Brax Excell <braxton@coforma.io>
    scwambach and braxex committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    61c6876 View commit details
    Browse the repository at this point in the history
  3. MDCT-1979: Delete Measure Details (#4222)

    * unnest pages in report json
    
    * refactor spreadsheet
    
    * fix all types and prepare drawer and modal forms'
    
    * final type tweaks
    
    * update copyAdminDisabledStatusToForms utility method
    
    * add more tests for utility methods
    
    * build add/edit modal; style initial page
    
    * solve overwrite issue
    
    * build out card with no functionality
    
    * DynamicDrawerReportPage tests
    
    * EntityDrawerReportPage → DrawerReportPage
    
    * DynamicDrawerReportPage → ModalDrawerReportPage
    
    * switch from record to entity
    
    * change dynamicType to entityType
    
    * fix failing test
    
    * add AddEditEntityModal tests
    
    * Implement simple deletion of entities
    
    * add EntityCard tests
    
    * Add tests for DeleteEntityModal
    
    * Add EntityCard test
    
    * fix bug with adding after deleting measures
    
    * nick review feedback
    
    * Brax Edit
    
    * Fix failing test
    
    * Accessibility test fix
    
    * Accessibility test fix
    
    * hide text if no entities
    
    * fix minor type error
    
    * Fix test
    
    * Add test to make sure if bad data is present it still fails elegently
    
    * Add test to make sure if bad data is present it still fails elegently
    
    Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Co-authored-by: Brax Excell <braxton@coforma.io>
    4 people committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    9d43e0b View commit details
    Browse the repository at this point in the history
  4. Update mcpar.json (#4258)

    scwambach committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    90adda6 View commit details
    Browse the repository at this point in the history
  5. added spreadsheet widgets (#4248)

    * added spreadsheet widgets
    
    * Update ReportPageIntro.tsx
    
    * normal layout
    scwambach committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    c5f7440 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. MDCT-1980: Edit Measure Details (#4221)

    * unnest pages in report json
    
    * refactor spreadsheet
    
    * fix all types and prepare drawer and modal forms'
    
    * final type tweaks
    
    * update copyAdminDisabledStatusToForms utility method
    
    * add more tests for utility methods
    
    * build add/edit modal; style initial page
    
    * solve overwrite issue
    
    * build out card with no functionality
    
    * DynamicDrawerReportPage tests
    
    * EntityDrawerReportPage → DrawerReportPage
    
    * DynamicDrawerReportPage → ModalDrawerReportPage
    
    * switch from record to entity
    
    * change dynamicType to entityType
    
    * fix failing test
    
    * add AddEditEntityModal tests
    
    * add EntityCard tests
    
    * Wiring up edit button
    
    * Edit is DONE
    
    * Hydration of values in modal
    
    * Working on failing tests
    
    * Unit test is fixed!!!!!!!!!!!!
    
    * coverage
    
    * Fix issue with types
    
    * feedback
    
    * Suggested changes
    
    Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
    karla-vm and braxex committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    e175126 View commit details
    Browse the repository at this point in the history
  2. redline section A (#4264)

    * redline section A
    
    * PR review changes
    
    * added period
    britt-mo committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    0bbb72c View commit details
    Browse the repository at this point in the history
  3. fix nested field validation bug (#4268)

    * fix nested field validation bug
    
    * little naming change
    braxex committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    f5ddeaa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    34a414c View commit details
    Browse the repository at this point in the history
  5. Enter access measure details (#4247)

    * unnest pages in report json
    
    * refactor spreadsheet
    
    * fix all types and prepare drawer and modal forms'
    
    * final type tweaks
    
    * update copyAdminDisabledStatusToForms utility method
    
    * add more tests for utility methods
    
    * build add/edit modal; style initial page
    
    * solve overwrite issue
    
    * build out card with no functionality
    
    * DynamicDrawerReportPage tests
    
    * EntityDrawerReportPage → DrawerReportPage
    
    * DynamicDrawerReportPage → ModalDrawerReportPage
    
    * switch from record to entity
    
    * change dynamicType to entityType
    
    * fix failing test
    
    * add AddEditEntityModal tests
    
    * add EntityCard tests
    
    * nick review feedback
    
    * Accessibility test fix
    
    * hide text if no entities
    
    * wip
    
    * wip 2
    
    * fix minor type error
    
    * wip
    
    * modify submitting status locations
    
    * data is submitting
    
    * wip for nick
    
    * Fix status check on entity cards
    
    * Hookup Drawer Details and style it
    
    * garrett feedback changes
    
    * tweaks
    
    * fix failing tests
    
    * tweak
    
    * tweak
    
    * Fix bad typeing in delete entity modal
    
    * Add tests for EntityCard
    
    * Almost clean up tests
    
    * add last needed test
    
    * tweak
    
    * tweaks
    
    * trying to fix these merge conflicts and clean things up
    
    * clean up
    
    * clean up
    
    * style tweak for when there's tons of text
    
    * unset selected entity
    
    * review feedback
    
    * combine button
    
    * fix up some tests
    
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Co-authored-by: Nick Summers <ntsummers1@gmail.com>
    3 people committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    0aaa440 View commit details
    Browse the repository at this point in the history
  6. edit access measure details (last part of ModalDrawerReportPage) (#4287)

    * unnest pages in report json
    
    * refactor spreadsheet
    
    * fix all types and prepare drawer and modal forms'
    
    * final type tweaks
    
    * update copyAdminDisabledStatusToForms utility method
    
    * add more tests for utility methods
    
    * build add/edit modal; style initial page
    
    * solve overwrite issue
    
    * build out card with no functionality
    
    * DynamicDrawerReportPage tests
    
    * EntityDrawerReportPage → DrawerReportPage
    
    * DynamicDrawerReportPage → ModalDrawerReportPage
    
    * switch from record to entity
    
    * change dynamicType to entityType
    
    * fix failing test
    
    * add AddEditEntityModal tests
    
    * add EntityCard tests
    
    * nick review feedback
    
    * Accessibility test fix
    
    * hide text if no entities
    
    * wip
    
    * wip 2
    
    * fix minor type error
    
    * wip
    
    * modify submitting status locations
    
    * data is submitting
    
    * wip for nick
    
    * Fix status check on entity cards
    
    * Hookup Drawer Details and style it
    
    * garrett feedback changes
    
    * tweaks
    
    * fix failing tests
    
    * tweak
    
    * tweak
    
    * Fix bad typeing in delete entity modal
    
    * Add tests for EntityCard
    
    * Almost clean up tests
    
    * add last needed test
    
    * tweak
    
    * tweaks
    
    * trying to fix these merge conflicts and clean things up
    
    * clean up
    
    * clean up
    
    * style tweak for when there's tons of text
    
    * unset selected entity
    
    * get drawer hydrating
    
    * review feedback
    
    * combine button
    
    * fix up some tests
    
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Co-authored-by: Nick Summers <ntsummers1@gmail.com>
    3 people committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    1a147a1 View commit details
    Browse the repository at this point in the history
  7. Simplify hydration (#4301)

    * unnest pages in report json
    
    * refactor spreadsheet
    
    * fix all types and prepare drawer and modal forms'
    
    * final type tweaks
    
    * update copyAdminDisabledStatusToForms utility method
    
    * add more tests for utility methods
    
    * build add/edit modal; style initial page
    
    * solve overwrite issue
    
    * build out card with no functionality
    
    * DynamicDrawerReportPage tests
    
    * EntityDrawerReportPage → DrawerReportPage
    
    * DynamicDrawerReportPage → ModalDrawerReportPage
    
    * switch from record to entity
    
    * change dynamicType to entityType
    
    * fix failing test
    
    * add AddEditEntityModal tests
    
    * add EntityCard tests
    
    * nick review feedback
    
    * Accessibility test fix
    
    * hide text if no entities
    
    * wip
    
    * wip 2
    
    * fix minor type error
    
    * wip
    
    * modify submitting status locations
    
    * data is submitting
    
    * wip for nick
    
    * Fix status check on entity cards
    
    * Hookup Drawer Details and style it
    
    * garrett feedback changes
    
    * tweaks
    
    * fix failing tests
    
    * tweak
    
    * tweak
    
    * Fix bad typeing in delete entity modal
    
    * Add tests for EntityCard
    
    * Almost clean up tests
    
    * add last needed test
    
    * tweak
    
    * tweaks
    
    * trying to fix these merge conflicts and clean things up
    
    * clean up
    
    * clean up
    
    * style tweak for when there's tons of text
    
    * unset selected entity
    
    * get drawer hydrating
    
    * review feedback
    
    * combine button
    
    * fix up some tests
    
    * simplify hydration data moulding
    
    Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
    Co-authored-by: Brax Excell <braxton@coforma.io>
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Co-authored-by: Nick Summers <ntsummers1@gmail.com>
    5 people committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    3add8da View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. MDCT-2009 add skipnav to sidebar (#4315)

    * add skipnav to sidebar
    
    * simplify styling
    gmrabian committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    62e129a View commit details
    Browse the repository at this point in the history
  2. MDCT-2004: Remove React-Query Dependency (#4314)

    * Remove react-query
    
    * Remove react-query dependency
    
    * Remove old comment
    
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Nick Summers and Nicholas Summers committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    863b04a View commit details
    Browse the repository at this point in the history
  3. MDCT-2016: Section C Redlines (#4253)

    * Section C Redlines
    
    * Fixup Section C Redlines
    
    * Fixup Section C Redlines
    
    * Fix additional redlines requested
    
    * Additional redlines requested
    
    * Tighten up styling
    
    * Remove example styling for reducing section gap
    
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Nick Summers and Nicholas Summers committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    0480598 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. MDCT-2027: Scotts Great Ampersand (#4346)

    * Reduce mqClasses with Scotts godly ampersand insight
    
    * Missed test deletion xd
    
    * Update services/ui-src/src/components/fields/CheckboxField.tsx
    
    Co-authored-by: Brax Excell <braxton@coforma.io>
    
    * Update services/ui-src/src/components/menus/Sidebar.tsx
    
    Co-authored-by: Brax Excell <braxton@coforma.io>
    
    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Co-authored-by: Brax Excell <braxton@coforma.io>
    3 people committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    62f1a6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f730be View commit details
    Browse the repository at this point in the history
  3. Customize entity card per type (#4336)

    * one layer of abstraction
    
    * nest within entitycard folder
    
    * separate by type
    
    * add a11y tests for different card shapes
    
    * pr feedback
    
    * simplify
    gmrabian committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    5b7ed80 View commit details
    Browse the repository at this point in the history
  4. Update README.md (#4340)

    Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com>
    britt-mo and gmrabian committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    66f5816 View commit details
    Browse the repository at this point in the history
  5. parse out entities util (#4337)

    * one layer of abstraction
    
    * nest within entitycard folder
    
    * separate by type
    
    * parse out entities util
    
    * add a11y tests for different card shapes
    
    * abstract choice parsing
    
    * oops remove
    gmrabian committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    88a6819 View commit details
    Browse the repository at this point in the history
  6. skipnav: a tragedy in 3 acts (#4351)

    * wip
    
    * ha i win
    
    * fix failing test
    
    * surprise encore
    
    * remove commented line
    braxex committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b4a6fc1 View commit details
    Browse the repository at this point in the history
  7. Fix amazingly huge drawer (#4372)

    Co-authored-by: Nicholas Summers <nick@coforma.io>
    Co-authored-by: Brax Excell <braxton@coforma.io>
    3 people committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    71793ec View commit details
    Browse the repository at this point in the history
  8. unwrap (#4376)

    Co-authored-by: Brax Excell <braxton@coforma.io>
    Co-authored-by: Nick Summers <ntsummers1@gmail.com>
    3 people committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    18e42a0 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #4383 from CMSgov/main

    Nick Summers committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    06e3c58 View commit details
    Browse the repository at this point in the history