-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Val -> Prod #4384
Val -> Prod #4384
Commits on Sep 30, 2022
-
MDCT-1992: Update ReportDrawer so admins can't submit for users (#4158)
* Update ReportDrawer so admins can't submit for users * Light cleaning Co-authored-by: Nicholas Summers <nick@coforma.io>
Nick Summers and Nicholas Summers committedSep 30, 2022 Configuration menu - View commit details
-
Copy full SHA for 49a78c0 - Browse repository at this point
Copy the full SHA 49a78c0View commit details
Commits on Oct 3, 2022
-
page structure changes (dynamic drawer step 1) (#4172)
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods
Configuration menu - View commit details
-
Copy full SHA for 114f003 - Browse repository at this point
Copy the full SHA 114f003View commit details -
* api updates * remove undefined * simplify banner provider api calls * fix banner provider tests
Configuration menu - View commit details
-
Copy full SHA for 3ecab67 - Browse repository at this point
Copy the full SHA 3ecab67View commit details -
simplify dynamodb mocking (#4181)
* api updates * remove undefined * simplify dynamodb mocking * simplify banner provider api calls * fix banner provider tests
Configuration menu - View commit details
-
Copy full SHA for c4c5d3d - Browse repository at this point
Copy the full SHA c4c5d3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 533a24e - Browse repository at this point
Copy the full SHA 533a24eView commit details -
remove delete button flash (#4168)
* remove delete button flash * alternate banner deletion display bug solution (#4173) * for scott * removed overkill banner test Co-authored-by: Brax Excell <braxton@coforma.io>
Configuration menu - View commit details
-
Copy full SHA for 7bf0711 - Browse repository at this point
Copy the full SHA 7bf0711View commit details
Commits on Oct 4, 2022
-
renamed ReportPage types (#4201)
* EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage
Configuration menu - View commit details
-
Copy full SHA for 5762054 - Browse repository at this point
Copy the full SHA 5762054View commit details -
[MDCT-1959] Clear nested fields after they are hidden from view (#4125)
* clear nested values * also for checkbox * add null check for displayvalue * rEcUrSiOn * update tests to include nested options * switch
Configuration menu - View commit details
-
Copy full SHA for 4917888 - Browse repository at this point
Copy the full SHA 4917888View commit details
Commits on Oct 5, 2022
-
MDCT-1995: Add Delete Modal to DynamicFields (#4188)
* Add Delete Modal to DynamicFields * Add in spinner * Make it so a user can't fully remove dynamic fields * Check that theres always at least 1 dynamic field * Fix bug where modal wouldn't display if you clicked close and opened again * Add test to confirm delete modal will show multiple times * Simplify setting record for deletion * Garrett Edits * Brax Edit * simplify name mapping * Simplify modal spinner Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Garrett Rabian <garrett@coforma.io> Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 09bc493 - Browse repository at this point
Copy the full SHA 09bc493View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b02ebd - Browse repository at this point
Copy the full SHA 6b02ebdView commit details
Commits on Oct 6, 2022
-
ModalDrawerReportPage step 1 (initial state, creation, & initial card) (
#4198) * unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * nick review feedback * Accessibility test fix * hide text if no entities * fix minor type error * garrett feedback changes Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ebcf8b - Browse repository at this point
Copy the full SHA 4ebcf8bView commit details -
* loading state for hydration * Update Form.tsx * banner dashboard hydration loading state * report pages hydration * wrapped it up * Update ReportPageWrapper.tsx Co-authored-by: Brax Excell <braxton@coforma.io>
Configuration menu - View commit details
-
Copy full SHA for 61c6876 - Browse repository at this point
Copy the full SHA 61c6876View commit details -
MDCT-1979: Delete Measure Details (#4222)
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * Implement simple deletion of entities * add EntityCard tests * Add tests for DeleteEntityModal * Add EntityCard test * fix bug with adding after deleting measures * nick review feedback * Brax Edit * Fix failing test * Accessibility test fix * Accessibility test fix * hide text if no entities * fix minor type error * Fix test * Add test to make sure if bad data is present it still fails elegently * Add test to make sure if bad data is present it still fails elegently Co-authored-by: Braxton Excell <braxton.excell@gmail.com> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Brax Excell <braxton@coforma.io>
Configuration menu - View commit details
-
Copy full SHA for 9d43e0b - Browse repository at this point
Copy the full SHA 9d43e0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90adda6 - Browse repository at this point
Copy the full SHA 90adda6View commit details -
added spreadsheet widgets (#4248)
* added spreadsheet widgets * Update ReportPageIntro.tsx * normal layout
Configuration menu - View commit details
-
Copy full SHA for c5f7440 - Browse repository at this point
Copy the full SHA c5f7440View commit details
Commits on Oct 7, 2022
-
MDCT-1980: Edit Measure Details (#4221)
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * Wiring up edit button * Edit is DONE * Hydration of values in modal * Working on failing tests * Unit test is fixed!!!!!!!!!!!! * coverage * Fix issue with types * feedback * Suggested changes Co-authored-by: Braxton Excell <braxton.excell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e175126 - Browse repository at this point
Copy the full SHA e175126View commit details -
* redline section A * PR review changes * added period
Configuration menu - View commit details
-
Copy full SHA for 0bbb72c - Browse repository at this point
Copy the full SHA 0bbb72cView commit details -
fix nested field validation bug (#4268)
* fix nested field validation bug * little naming change
Configuration menu - View commit details
-
Copy full SHA for f5ddeaa - Browse repository at this point
Copy the full SHA f5ddeaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34a414c - Browse repository at this point
Copy the full SHA 34a414cView commit details -
Enter access measure details (#4247)
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * nick review feedback * Accessibility test fix * hide text if no entities * wip * wip 2 * fix minor type error * wip * modify submitting status locations * data is submitting * wip for nick * Fix status check on entity cards * Hookup Drawer Details and style it * garrett feedback changes * tweaks * fix failing tests * tweak * tweak * Fix bad typeing in delete entity modal * Add tests for EntityCard * Almost clean up tests * add last needed test * tweak * tweaks * trying to fix these merge conflicts and clean things up * clean up * clean up * style tweak for when there's tons of text * unset selected entity * review feedback * combine button * fix up some tests Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0aaa440 - Browse repository at this point
Copy the full SHA 0aaa440View commit details -
edit access measure details (last part of ModalDrawerReportPage) (#4287)
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * nick review feedback * Accessibility test fix * hide text if no entities * wip * wip 2 * fix minor type error * wip * modify submitting status locations * data is submitting * wip for nick * Fix status check on entity cards * Hookup Drawer Details and style it * garrett feedback changes * tweaks * fix failing tests * tweak * tweak * Fix bad typeing in delete entity modal * Add tests for EntityCard * Almost clean up tests * add last needed test * tweak * tweaks * trying to fix these merge conflicts and clean things up * clean up * clean up * style tweak for when there's tons of text * unset selected entity * get drawer hydrating * review feedback * combine button * fix up some tests Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a147a1 - Browse repository at this point
Copy the full SHA 1a147a1View commit details -
* unnest pages in report json * refactor spreadsheet * fix all types and prepare drawer and modal forms' * final type tweaks * update copyAdminDisabledStatusToForms utility method * add more tests for utility methods * build add/edit modal; style initial page * solve overwrite issue * build out card with no functionality * DynamicDrawerReportPage tests * EntityDrawerReportPage → DrawerReportPage * DynamicDrawerReportPage → ModalDrawerReportPage * switch from record to entity * change dynamicType to entityType * fix failing test * add AddEditEntityModal tests * add EntityCard tests * nick review feedback * Accessibility test fix * hide text if no entities * wip * wip 2 * fix minor type error * wip * modify submitting status locations * data is submitting * wip for nick * Fix status check on entity cards * Hookup Drawer Details and style it * garrett feedback changes * tweaks * fix failing tests * tweak * tweak * Fix bad typeing in delete entity modal * Add tests for EntityCard * Almost clean up tests * add last needed test * tweak * tweaks * trying to fix these merge conflicts and clean things up * clean up * clean up * style tweak for when there's tons of text * unset selected entity * get drawer hydrating * review feedback * combine button * fix up some tests * simplify hydration data moulding Co-authored-by: Braxton Excell <braxton.excell@gmail.com> Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3add8da - Browse repository at this point
Copy the full SHA 3add8daView commit details
Commits on Oct 11, 2022
-
MDCT-2009 add skipnav to sidebar (#4315)
* add skipnav to sidebar * simplify styling
Configuration menu - View commit details
-
Copy full SHA for 62e129a - Browse repository at this point
Copy the full SHA 62e129aView commit details -
MDCT-2004: Remove React-Query Dependency (#4314)
* Remove react-query * Remove react-query dependency * Remove old comment Co-authored-by: Nicholas Summers <nick@coforma.io>
Nick Summers and Nicholas Summers committedOct 11, 2022 Configuration menu - View commit details
-
Copy full SHA for 863b04a - Browse repository at this point
Copy the full SHA 863b04aView commit details -
MDCT-2016: Section C Redlines (#4253)
* Section C Redlines * Fixup Section C Redlines * Fixup Section C Redlines * Fix additional redlines requested * Additional redlines requested * Tighten up styling * Remove example styling for reducing section gap Co-authored-by: Nicholas Summers <nick@coforma.io>
Nick Summers and Nicholas Summers committedOct 11, 2022 Configuration menu - View commit details
-
Copy full SHA for 0480598 - Browse repository at this point
Copy the full SHA 0480598View commit details
Commits on Oct 12, 2022
-
MDCT-2027: Scotts Great Ampersand (#4346)
* Reduce mqClasses with Scotts godly ampersand insight * Missed test deletion xd * Update services/ui-src/src/components/fields/CheckboxField.tsx Co-authored-by: Brax Excell <braxton@coforma.io> * Update services/ui-src/src/components/menus/Sidebar.tsx Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Brax Excell <braxton@coforma.io>
Configuration menu - View commit details
-
Copy full SHA for 62f1a6f - Browse repository at this point
Copy the full SHA 62f1a6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f730be - Browse repository at this point
Copy the full SHA 6f730beView commit details -
Customize entity card per type (#4336)
* one layer of abstraction * nest within entitycard folder * separate by type * add a11y tests for different card shapes * pr feedback * simplify
Configuration menu - View commit details
-
Copy full SHA for 5b7ed80 - Browse repository at this point
Copy the full SHA 5b7ed80View commit details -
Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 66f5816 - Browse repository at this point
Copy the full SHA 66f5816View commit details -
parse out entities util (#4337)
* one layer of abstraction * nest within entitycard folder * separate by type * parse out entities util * add a11y tests for different card shapes * abstract choice parsing * oops remove
Configuration menu - View commit details
-
Copy full SHA for 88a6819 - Browse repository at this point
Copy the full SHA 88a6819View commit details -
skipnav: a tragedy in 3 acts (#4351)
* wip * ha i win * fix failing test * surprise encore * remove commented line
Configuration menu - View commit details
-
Copy full SHA for b4a6fc1 - Browse repository at this point
Copy the full SHA b4a6fc1View commit details -
Fix amazingly huge drawer (#4372)
Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Brax Excell <braxton@coforma.io>
Configuration menu - View commit details
-
Copy full SHA for 71793ec - Browse repository at this point
Copy the full SHA 71793ecView commit details -
Co-authored-by: Brax Excell <braxton@coforma.io> Co-authored-by: Nick Summers <ntsummers1@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 18e42a0 - Browse repository at this point
Copy the full SHA 18e42a0View commit details -
Merge pull request #4383 from CMSgov/main
Nick Summers committedOct 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 06e3c58 - Browse repository at this point
Copy the full SHA 06e3c58View commit details