October 6, 2021

Time/Place

This meeting is held virtually via Zoom, with an open channel for chatter on Slack. Anyone is welcome to join. Here is the info:

• Time: 1:00pm Eastern Time US (UTC-5)
• Zoom link: https://zoom.us/j/97345581392
• Join us on the Slack Islandora 8 Channel https://islandora.slack.com/archives/CM5PPAV28
  • Chair rota
    • Mark
    • Melissa
    • Eli
    • Rosie
    • Seth 🪑
    • Danny

Attendees

• Seth Shaw, Kirsta Stapelfeldt (Notes), Drew Heles, Jared Whiklo, Jordan Dukart, Kristina Spurgin, Melissa Anez, Mark Jordan, Nat Kanthan, Rosie Le Faive, Adam Vessey, Alex O'Neill, Brandon Weigel, Kyle Huynh, Jordan Dukart

Agenda

1. Update on Branches/Versioning changes (https://github.com/Islandora/documentation/issues/1907)
   1. New branches cut for all github.com/Islandora code (not including islandora_ci, documentation)
   2. How to update playbook and ISLE
      1. Are all of these still in use, or do some need to be deprecated?
         • https://github.com/Islandora-Devops/islandora_starter_theme
         • https://github.com/Islandora-Devops/islandora_install_profile_demo
         • https://github.com/Islandora-Devops/islandora_base_theme
         • https://github.com/Islandora-Devops/islandora-project
         • https://github.com/Islandora-Devops/islandora_profile
   3. How to version things in Islandora-Devops
2. Issue Roundup
   1. Do we need composer.lock files in our code repos? https://github.com/Islandora/documentation/issues/1908 & https://github.com/Islandora/Crayfish/pull/129
   2. Rogue issue on islandora-sandbox: https://github.com/Islandora-Devops/islandora-sandbox/issues/3
   3. FITS Media Type RDF Mappings: https://github.com/Islandora/documentation/issues/1906 (https://github.com/Islandora/islandora_defaults/pull/55)
   4. Github config: Require checks on chullo? https://github.com/Islandora/documentation/issues/1909
3. PR Roundup
   1. Add taxonomy manager as required module for OOTB experience: https://github.com/Islandora/islandora_defaults/pull/56
4. Historical Issue Cleanup
5. Islandora Awesome List

(Last 10 Minutes): Roundtable

Minutes

1. Update on Branches/Versioning changes (https://github.com/Islandora/documentation/issues/1907) Rosie, Seth, and Bethany made a strong start to operationalize the plan for Semantic versioning, but there are a few ongoing questions. You can review the spreadsheet to see the status on this work

2. Are all of these still in use, or do some need to be deprecated?

• https://github.com/Islandora-Devops/islandora_starter_theme

Possibly used in some deployments, unclear if it was a replacement for Carapace. Review who has committed to it. Danny and Don. Discussion here of how we ask questions about what we should be doing.

• https://github.com/Islandora-Devops/islandora_install_profile_demo

Also Danny and Don work.

• https://github.com/Islandora-Devops/islandora_base_theme

Also Danny and Don. Alex made a commit in May, but doesn't recall. Discuss about how to handle this when it is incomplete. State of the work is unclear.

• https://github.com/Islandora-Devops/islandora-project

Seems to be Alex and Danny - try to have a general composer that would accept an installation profile, but relies on unsupported technologies. We should move this to deprecated for now, and then a unified composer project could be started anew later on.

• https://github.com/Islandora-Devops/islandora_profile

This is also an installation profile, but it is not being used. Should be moved to deprecated for now (same as above).

Movement towards looking at Islandora as something that can be installed in any Drupal site without this building up of dependencies. Supporting this use case is important.

1. How to version things in Islandora-Devops/Playbook/ISLE

We don't need to bump things to 2.0 because they are not Drupal modules. Seth assumes that we want to use the same semantic versioning approach. Alex points to the fact that some release tags already exist. Rosie points out that semantic versioning's goals may not map accurately to the goals of Islandora-Devops. For microservices, semver makes sense. How do we translate the concept of an API to this context. What is the best practice for how we go about making changes, and when that happens?

Should we tag with the same version as the 'core Islandora modules' - Islandora Playbook gets a major version when core gets updated, and that's what those pin on. Chatter in the chat: Geerlingguy roles seem to bump a major version when e.g. it adds support to another major version of the thing it is an installer for. This seems to be similar to the goals we are trying to achieve.

Jordan offers the following white paper on the subject: https://conferences.computer.org/icsme/pdfs/SCAM2020-CdP3rS7mSlqVWzF3cXW7H/924800a227/924800a227.pdf

Decision: We need pull requests to bump versions in DevOps - we are not doing branch changes, but we are doing PRs to point things to the correct new branch of the code.

Kristina: People seem to disagree how to handle semver when changes are test, documentation (build from code), or refactoring only. Not sure if that's really relevant here, but it's a tangle I've ventured into trying to understand best practices on (still not clear to me)

Add to Agenda Next Week - continue discussion about how to version Devops/ISLE/Playbook. For now, we are not doing branch management until this is sorted.

1. Issue Roundup
   1. Do we need composer.lock files in our code repos? https://github.com/Islandora/documentation/issues/1908 & https://github.com/Islandora/Crayfish/pull/129

There are ways of automatically bumping the composer.lock files, notes Adam. Crayfish is required by Crayfish, or Crayfish-commons. Seth agrees that we keep composer.lock with Crayfish specifically. Crayfish Commons needs to live alongside a Drupal installation, so would prefer not to have to rely on composer.lock on Crayfish commons. Crayfish is a collection of things. The installation process installs multiple things (Homarus, etc.) and they are all separate. If you go into the individual vendor directories, they all install Crayfish, but we need to install different versions since some are on Symphony, and some are on Silex.

Rosie asks if the pull request as authored is the 'right' way of doing this. Rosie asks: Can I modify the composer.lock file in order to modify it to point to semantic versioning. Need to find correct composer flags. DGI has had this problem, and is willing to work through this on Slack. Should we look at the APIs for microservices and identify testing gaps? Trade off - It's fine until a minor version release version breaks things. It's potentially a larger problem depending on where other lock files exist. What should we do with this proposal?

Seth: Because tests pass, he would do it. Could somebody second it or smoke test it? (Pull these changes and make sure the derivatives get made). Jordan suggests we accept automatic bumps and push off this issue - he will work with Rosie over slack.

1. Rogue issue on islandora-sandbox: https://github.com/Islandora-Devops/islandora-sandbox/issues/3

Local sandbox has an issue on it. Nobody who uses the sandbox is on the call. May want to open this issue on the official issues list so it gets more eyes on it.

We need readme descriptions that will put deployment methods into context. Mark Jordan or Rosie will write back on the issue to clarify what it is supposed to be for.

1. FITS Media Type RDF Mappings: https://github.com/Islandora/documentation/issues/1906 (https://github.com/Islandora/islandora_defaults/pull/55)

There are no FITS Media Type RDF Mappings which slows down queue processing and doesn't put RDF in Fedora for FITS. There is a PR to fix it, but there is an issue (Seth put a comment). This PR presumes that we require RobLib Islandora FITS module, which we currently do not require for Islandora Defaults. Waiting to hear a reply from Danny. Should be added to agenda next week.

1. Github config: Require checks on chullo? https://github.com/Islandora/documentation/issues/1909

A lot of these branches have requirements for what allows things to be pushed and whether we can push a PR on a branch. Chullo requires status checks in the past, but doesn't say what checks we need to do. It's turned on, but ineffective, as we're not listing things that need to be checked. Were these intentionally removed, or just not added? Rosie will ping Danny on ticket. We suspect it was just missed, but it might also be known to be broken.

1. PR Roundup
   1. Add taxonomy manager as required module for OOTB experience: https://github.com/Islandora/islandora_defaults/pull/56

Not controversial, but somebody should test and merge. Any volunteers? Mark Jordan will test.

1. Historical Issue Cleanup

#30 - good research in the ticket. Should we leave with help wanted tag? Discussion on the ticket. #37 - Need a use case. It does not get the alias in the JSON-LD.

1. Islandora Awesome List - deferred to next week as there is limited time.

(Last 10 Minutes): Roundtable