Skip to content

[pull] master from getsentry:master#2003

Merged
pull[bot] merged 16 commits into
KingDEV95:masterfrom
getsentry:master
May 27, 2026
Merged

[pull] master from getsentry:master#2003
pull[bot] merged 16 commits into
KingDEV95:masterfrom
getsentry:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented May 27, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

JoshuaKGoldberg and others added 16 commits May 27, 2026 06:32
Continuous profile chunks with a single sample give weight 0 to that
sample (it diffs against itself). That causes `appendSample` to discard
it and show "This flamegraph has no data." This adds a 10ms default
instead to match matching the 100Hz sampling rate so the stack is still
visible.

This also fixes `getMaxConfigSpace` to use each profile's end position
(`startedAt` + `duration`) instead of just `duration`. Without this, a
profile that starts late in the observability window renders its frames
mostly off-screen, appearing blank even after the weight fix.

Put together, this fixes rendering for the two main views reported in
PRO-43.

Closes PRO-43.
…g project id (#116279)

- Fix this, queries returned empty results
Replace synchronous DOM queries with async `findBy*` queries to properly
wait for React state updates after user interactions.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Nick <nsdeschenes@users.noreply.github.com>
The goal of this PR is to lie down the foundational work of
removing/hiding internal attributes from non-staff/non-super-user
requests.

To determine if an attribute should be hidden or not, we pull that
information from the Sentry conventions package from the `visibility`
field from attribute metadata.

These changes are limited to the eap search resolver, as such this PR
does not doing any enforcement of these attributes, that will come in
follow up PRs. As well, this PR adds in some tests.

---------

Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Adds a first version of the low-value span configuration issue detail UI
so these issues use a focused Problem and Troubleshooting layout.

<img width="1728" height="993" alt="Screenshot 2026-05-27 at 08 35 02"
src="https://github.com/user-attachments/assets/d9172e91-7dea-4579-9696-55cdfea65c49"
/>


Closes TET-2198

---------

Co-authored-by: OpenAI Codex <noreply@openai.com>
…116288)

Adds taskbroker raw mode tasks for query subscription consumers (events,
transactions, metrics, generic_metrics, eap).

ref STREAM-1021
Redo of #116226 which I reverted
because it caused test failures on master that weren't caught by
selective testing.

------

This model frequently blocks relocations for import/export differences,
and I'd like that to not happen anymore.

The Email model is populated by signals on create/delete operations to
UserEmail it does not synchronize state on updates, and there are
several older user accounts that are missing records in sentry_email
that are present in sentry_useremail which cause relocations to fail.

By excluding this model from exports, these records won't participate in
the validation checks and can't cause diffs. When the relocation is
processed records will still be stored in sentry_email because of the
aformentioned signals.
As of #113394 we don't allow `project:distribution` to be a scope for
user tokens.

Currently, there are several members in the sentry org with tokens that
have the `project:distribution` scope. This is causing all relocations
to fail because the 'baseline-config' validation is detecting changes.

By normalizing the ApiToken scopes during export we can avoid
differences after importing & re-exporting the baseline configuration.

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Add a `tags` field to `SnapshotImage` and render tags as muted badges in
snapshot card headers. Each tag appears as a `key=value` pill below the
image name, giving reviewers quick visibility into the variant
dimensions (language, direction, theme) of each snapshot.

**Card header layout rework**

The header switches from a single row with a subtitle file name to a
two-row layout: the top row holds the display name, action icons, and
status text; the bottom row holds the tag badges. The file name moves
from inline text to a small icon button that copies the name on click.

Depends on #115659

<img width="1706" height="552" alt="CleanShot 2026-05-26 at 18 06 40@2x"
src="https://github.com/user-attachments/assets/5d6ce626-92e6-4b24-a627-fb003d47a241"
/>

<img width="1628" height="456" alt="CleanShot 2026-05-26 at 18 05 54@2x"
src="https://github.com/user-attachments/assets/d485516c-c023-485e-8ca6-9c73ef064629"
/>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 <noreply@example.com>
The replay scrubber hover timestamp was tall enough to trigger page
overflow in the details layout.

before

<img width="350" height="86" alt="image"
src="https://github.com/user-attachments/assets/23b3ef15-b2df-4bbb-90c9-bb52e8020a32"
/>

after

<img width="275" height="76" alt="image"
src="https://github.com/user-attachments/assets/8e245a06-0a5c-4b83-bad3-83897752f0fc"
/>
…116299)

## Summary
- `test_typed_attributes_with_colons` stored a boolean and queried it as
a `,number]`, which only worked because the eap-items consumer
double-wrote booleans into the float columns
- Snuba is removing that double-write in getsentry/snuba#7689, breaking
the assertion in Snuba CI
- Query the same attribute with its real `,boolean]` type so the
colon-in-key check is exercised against the column the value actually
lives in

## Test plan
- [x] CI on this branch

Refs getsentry/snuba#7689
@pull pull Bot locked and limited conversation to collaborators May 27, 2026
@pull pull Bot added the ⤵️ pull label May 27, 2026
@pull pull Bot merged commit 63656dd into KingDEV95:master May 27, 2026
@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⤵️ pull Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.