Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Sep 2, 2019

See Commits and Changes for more details.


Created by pull[bot]. Want to support this open source service? Please star it : )

@pull pull bot added the ⤵️ pull label Sep 2, 2019
@ghost
Copy link

ghost commented Nov 5, 2020

DeepCode's analysis on #9c00f8 found:

  • ℹ️ 1 minor issue. 👇
  • ✔️ 4 issues were fixed.

Top issues

Description Example fixes
Unexpected 'this'. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

usha-mandya and others added 28 commits September 12, 2022 14:50
* extension SDK : cannot chain commands in exec()

Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>

* Apply suggestions from code review

Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>

Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
* Update 04_sharing_app.md

regarding issue #15614
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
* added vale config embryo

* added some more example rules

* update rules

* add more formatting rules

* expanded vocab

* added more rules

* added dvp vocabulary terms

* rm link text from sentence case rule
Signed-off-by: Usha Mandya <usha.mandya@docker.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
jerae-duffin and others added 28 commits October 20, 2022 13:57
* updated getting started guide

* toc update

* rearranging

* fix broken link

* fix broken links

* naming tweaks

* links fix

* add icon links
Add comments to `wait-for-postgres.sh`
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.8 to 1.13.9.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.13.8...v1.13.9)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ENGDOCS-1020

* fix broken links

* fix build

* add important note
Signed-off-by: GitHub <noreply@github.com>
…i-reference-v2.12.1

Update Compose reference API to v2.12.1
* Add CVE-2022-42889 and some cleanup

* Update index.md

* Apply suggestions from code review

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com>
* Docs: update sample application initiation in venv

Until now, readers would install 'Flask' on their main system
python environment, freeze their entire packages, and grep only
the 'Flask' package! So they would be missing all the other
dependencies in their requirements file.

With this commit, a better practice is followed. First, create a
clean virtual environment, then install 'Flask' and freeze
everything into the requirements file.

Also, I recommend using 'python3 -m pip freeze' instead of 'pip3
freeze' while in the virtual environment. This is because
sometimes hidden quirks of 'pip' will ignore the actiavted
environment and freeze the entire python packages in the
system (e.g. in ArchLinux).

* Docs: update python sample testing application

In the previous commit, I forgot to update the 'Test the
application' section so that the users activate the virtual
environment first.

This commit fixes that.

Co-authored-by: Stefan Scherer <stefan.scherer@docker.com>
* Document Moby vs BuildKit differences

* Apply suggestions from code review

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…i-reference-v2.12.2

Update Compose reference API to v2.12.2
* Add documentation for Docker+Wasm

* Fix issues discovered by linter

* Adjust text at the beginning of the doc and link to the blog post
* wasm-patch

* fix warning note
* contribute-patch

* guidance on UI content and brackets
* Update the Wasm docs to add a quick explainer for Wasm

* Update links for Wasm preview downloads to use new vanity URLs
Fix links and add IDs for Wasm download links
@crazy-max crazy-max deleted the branch Mattlk13:master October 25, 2022 09:08
@crazy-max crazy-max deleted the master branch October 25, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.