fix(process): #1312 unset process.env.X is undefined (nullish), so ?? applies#1314
Merged
Merged
Conversation
… applies Reading an unset env var via the process.env.X / process.env[key] fast paths called js_getenv (returns a null *StringHeader when unset) and then unconditionally tagged the result with STRING_TAG. A null pointer OR'd with STRING_TAG is a malformed value: typeof reads "string", JSON.stringify emits null, it is falsy under || but NOT nullish under ??, so the idiomatic process.env.X ?? default silently kept the bogus value instead of the fallback. Add js_getenv_value(name) -> f64 which returns NaN-boxed undefined for an unset var (matching Node, where process.env.UNSET is undefined) and the string otherwise. A var set to the empty string still returns "" (falsy but not nullish), so ?? won't clobber a legitimately empty value. Both the static (EnvGet) and dynamic (EnvGetDynamic) codegen paths now call it. Output is byte-for-byte identical to node --experimental-strip-types across unset / set / empty-string / dynamic-access cases (test_issue_1312_env_nullish.ts).
proggeramlug
added a commit
that referenced
this pull request
May 22, 2026
…sweep (#1414) Rolls up 26 PRs that merged to main post-v0.5.1023 without version bumps: - node:crypto gap-fixes (#1386 #1393 #1394 #1402 #1405): randomInt, timingSafeEqual, getHashes/getCiphers, sha224/sha384, base64 digest, Buffer hash input, no-arg digest() → Buffer, pbkdf2Sync digest arg, scryptSync. - node:perf_hooks (#1321 + #1328 #1342 coverage): performance + User Timing + PerformanceObserver native impl, granular node-suite + edge-case coverage. - #1090 GC checkpoint runtime work (#1324). - #1311 geisterhand on iOS (#1316 #1383 #1384 #1385). - #1312 process.env.X (unset) is nullish undefined (#1314). - #1319 thread-safety hardening for cross-thread runtime statics. - #1322 exact-head GC evidence packet. - #1323 wasm timers dispatch through mem_call bridge (#1329). - #1317 node:timers/promises shadow-segfault fix (#1326). - #1330 node:process suite (#1331). - #1292 bcrypt.hash() returns String (#1307). - #1293 fastify .json()/.body external-fastify dispatch (#1308). - #1296 app pattern performance gaps. - #1297 diagnostics_channel parity. - #1301 iOS App Groups capability (#1313). - #1318 #1325 os/methods/modern-methods static dispatch. - #1315 expanded Node parity test coverage. - #1382 ui-ios stdlib pump for async fetch. - #1392 ui-wasm reactive state + setText (#1404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1312. Reading an unset env var via
process.env.X(orprocess.env[key]) returned a value that was falsy but not nullish, so the idiomaticprocess.env.X ?? defaultsilently kept the bogus value instead of applying the fallback.Root cause
The
process.env.X/process.env[key]fast paths (EnvGet/EnvGetDynamicin codegen) calledjs_getenv, which returns a null*StringHeaderwhen the var is unset, then unconditionally tagged the result withSTRING_TAG. A null pointer OR'd withSTRING_TAGis a malformed value:typeof"string""undefined")JSON.stringifynullundefined)?? default|| defaultFix
Add
js_getenv_value(name) -> f64inperry-runtime/src/process.rsthat returns NaN-boxedundefinedfor an unset var — matching Node, whereprocess.env.UNSETisundefined— and the string otherwise. A var set to the empty string still returns""(falsy but not nullish), so??won't clobber a legitimately empty value. Both the static (EnvGet) and dynamic (EnvGetDynamic) codegen paths now call it.js_getenvis left intact.Validation
test-files/test_issue_1312_env_nullish.tscovers unset / set / empty-string / dynamic-access cases. Perry output is byte-for-byte identical tonode --experimental-strip-types.test_process_env.tsparity still matches.cargo test -p perry-runtime -p perry-codegen: 456 passed, 0 failed.cargo fmt --all -- --check: clean.Per repo convention this PR omits the version bump / CHANGELOG entry — the maintainer folds those in at merge.