fix(ui-wasm): #1392 wire reactive state + setText on web/wasm target#1404
Merged
Conversation
On the web/wasm target, perry/ui's reactive `state` and imperative `setText` were silent no-ops: `count.text()` never updated, `count.value` read `undefined`, and `setText(id, val)` dispatched to nothing. The `state_desugar` HIR pass lowers `state<T>` to a synthetic, string-keyed registry API (`__state_init`/`__state_get`/`__state_set`, plus 2-arg `Text(content, id)`, `__foreach_register`, `__navstack_register_route`). The native LLVM backend special-cases these in lower_call/native/mod.rs and backs them with perry-runtime's ui_text_registry, but neither the wasm backend (perry-codegen-wasm) nor the JS backend (perry-codegen-js) implemented them — the synthetic methods resolved to `perry_ui_unknown` and `perry_ui_text_create` dropped its 2nd `id` arg. Fix mirrors the native model (synth id reused as both the state key and the Text widget's setText id, so a write fans out to every bound widget): - emit: map `__state_*` / `__foreach_register` / `__navstack_register_route` to keyed bridge fns in both ui_method_map.rs (wasm) and calls.rs (js). - runtime (wasm_runtime.js + web_runtime.js): add a keyed-state registry, `perry_ui_set_text`, keyed get/set/init, foreach + navstack dispatch, and make `perry_ui_text_create(text, id)` register the 2-arg form so `setText` and `__state_set` find and re-render it. Verified end-to-end by booting the compiled counter wasm in Node with a DOM mock: button click fires, bound Text re-renders 0->1->2, and `count.value` reads correctly.
proggeramlug
added a commit
that referenced
this pull request
May 22, 2026
…sweep (#1414) Rolls up 26 PRs that merged to main post-v0.5.1023 without version bumps: - node:crypto gap-fixes (#1386 #1393 #1394 #1402 #1405): randomInt, timingSafeEqual, getHashes/getCiphers, sha224/sha384, base64 digest, Buffer hash input, no-arg digest() → Buffer, pbkdf2Sync digest arg, scryptSync. - node:perf_hooks (#1321 + #1328 #1342 coverage): performance + User Timing + PerformanceObserver native impl, granular node-suite + edge-case coverage. - #1090 GC checkpoint runtime work (#1324). - #1311 geisterhand on iOS (#1316 #1383 #1384 #1385). - #1312 process.env.X (unset) is nullish undefined (#1314). - #1319 thread-safety hardening for cross-thread runtime statics. - #1322 exact-head GC evidence packet. - #1323 wasm timers dispatch through mem_call bridge (#1329). - #1317 node:timers/promises shadow-segfault fix (#1326). - #1330 node:process suite (#1331). - #1292 bcrypt.hash() returns String (#1307). - #1293 fastify .json()/.body external-fastify dispatch (#1308). - #1296 app pattern performance gaps. - #1297 diagnostics_channel parity. - #1301 iOS App Groups capability (#1313). - #1318 #1325 os/methods/modern-methods static dispatch. - #1315 expanded Node parity test coverage. - #1382 ui-ios stdlib pump for async fetch. - #1392 ui-wasm reactive state + setText (#1404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1392.
Problem
On the web/wasm target (what the playground hub compiles to), perry/ui's reactive
stateand imperativesetTextwere silent no-ops:count.text()showed the initial value and never changed afterset.count.valuereadundefined.setText(id, value)dispatched to nothing;Text(content, id)'s 2ndidarg was dropped.Root cause
The
state_desugarHIR pass (crates/perry-transform/src/state_desugar.rs) lowersstate<T>to a synthetic, string-keyed registry API:__state_init/__state_get/__state_set, the 2-argText(content, id)form, plus__foreach_registerand__navstack_register_route. The native LLVM backend special-cases these (lower_call/native/mod.rs) and backs them withperry-runtime/src/ui_text_registry.rs. But neither the wasm backend (perry-codegen-wasm) nor the JS backend (perry-codegen-js) implemented them:__state_*resolved toperry_ui_unknown/__perry.perry_ui___state_*(nonexistent).perry_ui_text_createignored its 2ndidarg.perry_ui_set_text.Fix
Mirrors the native model — the synth id is reused as both the state key and the Text widget's
setTextid, so a write fans out to every bound widget.Emit — map the synthetic methods to keyed bridge functions:
crates/perry-codegen-wasm/src/emit/ui_method_map.rscrates/perry-codegen-js/src/emit/calls.rsRuntime (
wasm_runtime.js+web_runtime.js):perry_ui_state_init/perry_ui_state_get_keyed/perry_ui_state_set_keyed)perry_ui_set_text(id, value)+ an id→widget text registryperry_ui_text_create(text, id)registers the 2-arg formperry_ui_foreach_register/perry_ui_navstack_register_routekeyed dispatch__perryUiDispatch(wasm) /window.__perry(js)Verification
--target wasm; bridge names now resolve (perry_ui_state_init/_get_keyed/_set_keyed, 2-argperry_ui_text_create) — no moreperry_ui_unknown.0 → 1 → 2, andcount.valuereads correctly (console.logprintsval 1,val 2, notval undefined).wasm_runtime.jsandweb_runtime.jspass for keyed get/set, reactive Text, 2-arg Text, and imperativesetText.cargo fmt --all -- --checkclean;perry-codegen-wasm/perry-codegen-js/perry-dispatch/perry-transformtests pass.Note: version bump + CHANGELOG entry intentionally omitted (folded in at merge per repo workflow).