feat(crypto): implement crypto.scryptSync (#1361)#1405
Merged
Conversation
scryptSync was rejected by the strict-API gate (#463) — the existing js_crypto_scrypt returned a hex string and was never wired to the crypto namespace. Add js_crypto_scrypt_bytes, which returns a Buffer (matching Node) and reads inputs via bytes_from_ptr so string and Buffer password/salt both work. Optional cost parameters are read from the options object in the runtime: N/cost, r/blockSize, p/parallelization, defaulting to Node's N=16384, r=8, p=1. HIR already types scryptSync as Uint8Array, so scryptSync(...).toString('hex') and indexing take the buffer path. Wired through codegen (expr/calls.rs), the FFI decls, and the API manifest (+ regenerated docs). Verified byte-for-byte against `node --experimental-strip-types`: default 32/64-byte keys, .length, byte indexing, custom { N, r, p } options, and Buffer inputs. Closes #1361
4 tasks
proggeramlug
added a commit
that referenced
this pull request
May 22, 2026
…sweep (#1414) Rolls up 26 PRs that merged to main post-v0.5.1023 without version bumps: - node:crypto gap-fixes (#1386 #1393 #1394 #1402 #1405): randomInt, timingSafeEqual, getHashes/getCiphers, sha224/sha384, base64 digest, Buffer hash input, no-arg digest() → Buffer, pbkdf2Sync digest arg, scryptSync. - node:perf_hooks (#1321 + #1328 #1342 coverage): performance + User Timing + PerformanceObserver native impl, granular node-suite + edge-case coverage. - #1090 GC checkpoint runtime work (#1324). - #1311 geisterhand on iOS (#1316 #1383 #1384 #1385). - #1312 process.env.X (unset) is nullish undefined (#1314). - #1319 thread-safety hardening for cross-thread runtime statics. - #1322 exact-head GC evidence packet. - #1323 wasm timers dispatch through mem_call bridge (#1329). - #1317 node:timers/promises shadow-segfault fix (#1326). - #1330 node:process suite (#1331). - #1292 bcrypt.hash() returns String (#1307). - #1293 fastify .json()/.body external-fastify dispatch (#1308). - #1296 app pattern performance gaps. - #1297 diagnostics_channel parity. - #1301 iOS App Groups capability (#1313). - #1318 #1325 os/methods/modern-methods static dispatch. - #1315 expanded Node parity test coverage. - #1382 ui-ios stdlib pump for async fetch. - #1392 ui-wasm reactive state + setText (#1404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto.scryptSyncwas rejected by the strict-API gate (#463): the existingjs_crypto_scryptreturned a hex string and was never wired to thecryptonamespace.Implementation
js_crypto_scrypt_bytesreturns a Buffer (matching Node) and reads inputs viabytes_from_ptr, so string and Buffer password/salt both work.N/cost,r/blockSize,p/parallelization, defaulting to Node's N=16384, r=8, p=1.scryptSyncasUint8Array, soscryptSync(...).toString('hex')and[i]indexing take the buffer path.expr/calls.rs), the FFI decls, and the API manifest (+ regenerated docs).Validation
Byte-for-byte vs
node --experimental-strip-types:.lengthand byte indexing (buf[0]){ N: 1024, r: 8, p: 1 }optionsBufferpassword/salt inputsNote
This implements the synchronous form. The callback-style async
crypto.scrypt(pw, salt, keylen, cb)is not included — Perry has no native→JS callback path for KDFs today (the existing "async"pbkdf2is likewise sync-returning), so it's a separate follow-up.Closes #1361