fix(crypto): sha224/sha384, base64 digest, and Buffer hash input#1393
Merged
Conversation
Three fixes in the createHash/createHmac digest path: - sha224 / sha384 (#1357): add both to the runtime HashState enum, js_crypto_create_hash, and dispatch_hash. createHash('sha224'|'sha384') previously returned undefined, crashing on the chained .update(). - digest('base64'|'base64url') (#1352): the inline sha256/md5/hmac fast path only emits hex (or a raw-byte Buffer for the no-arg form), so it silently returned hex for any other encoding. Narrow the fast path to hex / no-arg only; every other encoding falls through to the runtime handle dispatch, whose dispatch_hash already honors base64/base64url. - update(Buffer) / createHmac(_, Buffer) (#1354): the fast path unboxed inputs as *StringHeader and hashed the UTF-8 string bytes, which reads the wrong bytes for a Buffer/Uint8Array (different header layout). Route Buffer-typed inputs (inline Buffer.from(...)/randomBytes(...) and Buffer/Uint8Array-typed locals) to the handle dispatch, whose bytes_from_ptr reads either layout. The hex + string-input fast path (SCRAM / #214 / #1076) is unchanged. Verified byte-for-byte against `node --experimental-strip-types` for base64/base64url (hash + hmac), Buffer input (local + inline), sha224/384, plus regression on hex/no-arg-Buffer/standalone/dynamic-alg forms. Closes #1352 Closes #1354 Closes #1357
4 tasks
proggeramlug
added a commit
that referenced
this pull request
May 22, 2026
…sweep (#1414) Rolls up 26 PRs that merged to main post-v0.5.1023 without version bumps: - node:crypto gap-fixes (#1386 #1393 #1394 #1402 #1405): randomInt, timingSafeEqual, getHashes/getCiphers, sha224/sha384, base64 digest, Buffer hash input, no-arg digest() → Buffer, pbkdf2Sync digest arg, scryptSync. - node:perf_hooks (#1321 + #1328 #1342 coverage): performance + User Timing + PerformanceObserver native impl, granular node-suite + edge-case coverage. - #1090 GC checkpoint runtime work (#1324). - #1311 geisterhand on iOS (#1316 #1383 #1384 #1385). - #1312 process.env.X (unset) is nullish undefined (#1314). - #1319 thread-safety hardening for cross-thread runtime statics. - #1322 exact-head GC evidence packet. - #1323 wasm timers dispatch through mem_call bridge (#1329). - #1317 node:timers/promises shadow-segfault fix (#1326). - #1330 node:process suite (#1331). - #1292 bcrypt.hash() returns String (#1307). - #1293 fastify .json()/.body external-fastify dispatch (#1308). - #1296 app pattern performance gaps. - #1297 diagnostics_channel parity. - #1301 iOS App Groups capability (#1313). - #1318 #1325 os/methods/modern-methods static dispatch. - #1315 expanded Node parity test coverage. - #1382 ui-ios stdlib pump for async fetch. - #1392 ui-wasm reactive state + setText (#1404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes in the
createHash/createHmacdigest path. The hex + string-input inline fast path (SCRAM / #214 / #1076) is left unchanged; the fixes either add runtime algorithms or route the previously-mishandled cases to the runtime handle dispatch (dispatch_hash), which was already correct for them.Fixes
HashStateenum,js_crypto_create_hash, anddispatch_hash.createHash('sha224'|'sha384')previously returnedundefined, so the chained.update()threwCannot read properties of undefined.digest('base64'|'base64url')(node:crypto — hash.digest('base64'|'base64url') ignores the encoding #1352) — the inlinesha256/md5/hmac-sha256fast path only emits hex (or a raw-byte Buffer for the no-arg form), so it silently returned hex for any other encoding. The fast path is now narrowed to hex / no-arg only; every other encoding falls through todispatch_hash, which honors base64/base64url.update(Buffer)/createHmac(_, Buffer)(node:crypto — createHash().update(Buffer) hashes the wrong representation #1354) — the fast path unboxed inputs as*StringHeaderand hashed the UTF-8 string bytes, reading the wrong bytes for a Buffer/Uint8Array (different header layout). Buffer-typed inputs — inlineBuffer.from(...)/crypto.randomBytes(...)andBuffer/Uint8Array-typed locals/fields — now route to the handle dispatch, whosebytes_from_ptrreads either layout.Validation
Byte-for-byte parity against
node --experimental-strip-types:digest('base64')/digest('base64url')for hash + hmacupdate(Buffer)(local var) andcreateHmac(_, Buffer.from(...))(inline)sha224/sha384hex + base64sha256/md5/hmachex, no-arg Buffer digest length, standaloneconst h = createHash(...)form, dynamic (const alg) hash/hmac, incremental.update().update().Not included
digest()(no-arg) Buffer.toString('hex')/ numeric indexing (#1353) is a separate type-inference issue — the no-argdigest()result isn't statically typed as a Buffer, so.toString('hex')andbuf[0]mis-dispatch. It affects the runtime handle path too and is unchanged by this PR; it'll be addressed separately.Closes #1352
Closes #1354
Closes #1357