fix(crypto): type no-arg digest() result as Buffer, not string (#1353)#1394
Merged
Conversation
createHash(alg).update(d).digest() with no encoding arg returns a Buffer,
but the codegen typed every digest chain as String. So `const buf =
hash.digest(); buf.toString('hex')` treated the buffer as a Latin-1 string
and `buf[0]` returned a character instead of the byte value.
Refine the no-encoding digest chain to Uint8Array in all three places that
classify it — refine_type_from_init (bound local), static_type_of (inline
`digest().toString(...)` / `digest()[i]`), and is_string_expr (so the
buffer toString-with-encoding path isn't skipped). The encoded form
(digest('hex'|'base64'|...)) stays String-typed, preserving the
`===` / `.length` / `.slice` / `.includes` hex-string fast paths.
Verified vs `node --experimental-strip-types`: bound + inline
digest().toString('hex'|'base64') and digest()[i] now match, including the
sha512 fallback path; encoded-chain string ops unchanged.
Closes #1353
4 tasks
proggeramlug
added a commit
that referenced
this pull request
May 22, 2026
…sweep (#1414) Rolls up 26 PRs that merged to main post-v0.5.1023 without version bumps: - node:crypto gap-fixes (#1386 #1393 #1394 #1402 #1405): randomInt, timingSafeEqual, getHashes/getCiphers, sha224/sha384, base64 digest, Buffer hash input, no-arg digest() → Buffer, pbkdf2Sync digest arg, scryptSync. - node:perf_hooks (#1321 + #1328 #1342 coverage): performance + User Timing + PerformanceObserver native impl, granular node-suite + edge-case coverage. - #1090 GC checkpoint runtime work (#1324). - #1311 geisterhand on iOS (#1316 #1383 #1384 #1385). - #1312 process.env.X (unset) is nullish undefined (#1314). - #1319 thread-safety hardening for cross-thread runtime statics. - #1322 exact-head GC evidence packet. - #1323 wasm timers dispatch through mem_call bridge (#1329). - #1317 node:timers/promises shadow-segfault fix (#1326). - #1330 node:process suite (#1331). - #1292 bcrypt.hash() returns String (#1307). - #1293 fastify .json()/.body external-fastify dispatch (#1308). - #1296 app pattern performance gaps. - #1297 diagnostics_channel parity. - #1301 iOS App Groups capability (#1313). - #1318 #1325 os/methods/modern-methods static dispatch. - #1315 expanded Node parity test coverage. - #1382 ui-ios stdlib pump for async fetch. - #1392 ui-wasm reactive state + setText (#1404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createHash(alg).update(d).digest()with no encoding arg returns a Buffer, but the codegen typed every digest chain asString. So:const buf = hash.digest(); buf.toString('hex')mis-read the buffer bytes as a Latin-1 string (returned garbage instead of hex).buf[0]returned a character instead of the numeric byte value.Fix
Type-inference only (
type_analysis.rs). The no-encoding digest chain is refined toUint8Arrayin the three places that classify it:refine_type_from_init— the bound-local form (const buf = hash.digest()), the issue's repro.static_type_of— the inline form (hash.digest().toString('hex')/hash.digest()[i]).is_string_expr— so thetoString(encoding)buffer path isn't skipped (it requires!is_string_expr(receiver)).The encoded form (
digest('hex'|'base64'|…)) staysString-typed, preserving the===/.length/.slice/.includeshex-string fast paths.Validation
Byte-for-byte vs
node --experimental-strip-types:digest().toString('hex')anddigest().toString('base64')→ correctdigest()[0]→ numeric byte valuea === b,.length,.slice,.includes, hmac===, andtypeof digest('base64') === 'string'.Closes #1353