test(parity): expand node:perf_hooks coverage + input validation#1328
Merged
Conversation
Follow-up to #1321 (the perf_hooks implementation). Adds 13 granular node-suite cases plus the runtime behavior they require: - mark/measure instanceof PerformanceEntry / PerformanceMark / PerformanceMeasure - getEntries() unfiltered; getEntriesByName / getEntriesByType no-match - measure({ start, duration, detail }) detail handling - observer: observe 'measure', takeRecords(), and multiple entryTypes in one delivery - eventLoopUtilization() first-call shape - input validation matching Node: performance.mark() / clearMarks() throw a TypeError on a Symbol name; mark() throws on a non-numeric startTime - getEntries* and observer lists now return entries ordered by startTime (Node returns the timeline sorted, stable on ties) 31/33 pass. Two deferrals, recorded in test-parity/known_failures.json: observer/entry-types (typeof obs.observe — native-class member reads lower as calls, #1320) and global/performance-identity (globalThis.performance identity, #1327).
proggeramlug
added a commit
that referenced
this pull request
May 22, 2026
…odeTiming, toJSON, resource-timing, single-type observe) (#1342) Follow-up to #1321/#1328. Adds 11 granular cases covering the rest of the node:perf_hooks surface. New passing: observer observe({type}) single-type, eventLoopUtilization(b,a) two-arg diff, getEntriesByName(name,type). 8 new cases pin gaps, each tracked by its own granular issue + known_failures: - timerify (#1335), monitorEventLoopDelay/createHistogram (#1336), nodeTiming (#1337), toJSON (#1338), clearResourceTimings/ setResourceTimingBufferSize (#1339), mark detail structured-clone (#1340), PerformanceObserver.supportedEntryTypes.includes (#1341).
This was referenced May 22, 2026
proggeramlug
added a commit
that referenced
this pull request
May 22, 2026
…sweep (#1414) Rolls up 26 PRs that merged to main post-v0.5.1023 without version bumps: - node:crypto gap-fixes (#1386 #1393 #1394 #1402 #1405): randomInt, timingSafeEqual, getHashes/getCiphers, sha224/sha384, base64 digest, Buffer hash input, no-arg digest() → Buffer, pbkdf2Sync digest arg, scryptSync. - node:perf_hooks (#1321 + #1328 #1342 coverage): performance + User Timing + PerformanceObserver native impl, granular node-suite + edge-case coverage. - #1090 GC checkpoint runtime work (#1324). - #1311 geisterhand on iOS (#1316 #1383 #1384 #1385). - #1312 process.env.X (unset) is nullish undefined (#1314). - #1319 thread-safety hardening for cross-thread runtime statics. - #1322 exact-head GC evidence packet. - #1323 wasm timers dispatch through mem_call bridge (#1329). - #1317 node:timers/promises shadow-segfault fix (#1326). - #1330 node:process suite (#1331). - #1292 bcrypt.hash() returns String (#1307). - #1293 fastify .json()/.body external-fastify dispatch (#1308). - #1296 app pattern performance gaps. - #1297 diagnostics_channel parity. - #1301 iOS App Groups capability (#1313). - #1318 #1325 os/methods/modern-methods static dispatch. - #1315 expanded Node parity test coverage. - #1382 ui-ios stdlib pump for async fetch. - #1392 ui-wasm reactive state + setText (#1404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1321 (the
node:perf_hooksimplementation, now merged). Deepens the granular suite and adds the runtime behavior the new cases require.Added tests (13)
PerformanceEntry/PerformanceMark; a measure is aPerformanceEntry/PerformanceMeasuregetEntries()unfiltered;getEntriesByName/getEntriesByTypeempty on no match{ start, duration, detail }detail handling'measure',takeRecords(), multipleentryTypesdelivered togetheridle/activenumbers,utilizationin[0,1])mark(Symbol())/clearMarks(Symbol())/mark('a',{startTime:'x'})throwglobalThis.performance === import(currently a documented gap)Runtime changes (
crates/perry-runtime/src/perf_hooks.rs)mark()/clearMarks()throw aTypeErroron a Symbol name;mark()throws on a non-numericstartTime.getEntries*and observer lists now return entries sorted bystartTime(stable on ties) — Node returns the timeline sorted, whichentries/get-entries-allexercises.Result
./run_parity_tests.sh --suite node-suite --module perf_hooks→ 31/33 pass. Two deferrals, recorded inknown_failures.json:observer/entry-types—typeof obs.observe(native-class member reads lower as calls) → node:perf_hooks — typeof PerformanceObserver instance methods reports wrong type (native-class member read lowers as a call) #1320global/performance-identity—globalThis.performanceobject identity → node:perf_hooks — globalThis.performance is not identical to the node:perf_hooks named import #1327No version bump / CHANGELOG (maintainer folds in at merge, per the contributor convention).