Conversation
* chore: update shape doc * chore: update shape doc * chore: add shapes * build: harden rerun-if-changed path handling (#439) * build: harden rerun-if-changed path handling * build: add rerun-if-changed fallback * build: inline format arg * fix: vk map parallelism * fix: vk map parallelism * fix: vk map parallelism * chore: change mpsc channel to crossbeam * chore: update vk map * chore: stepo count * feat: update step count * chore: add payload constructor * fix: reviews and comments --------- Co-authored-by: Olexandr88 <radole1203@gmail.com>
…ers (#463) * fix(curves): correct nb_scalar_bits calculation in WeierstrassParameters * remove duplicate nb_scalar_bits from WeierstrassParameters
* initial picus backend for Ziren * adding comment describing PicusInfo for AddSub * adding readme * adding macro to derive PicusInfo * removing outdated comment * determining inputs/outputs through interactions * misc picus support changes * rebased * adding symbolic and concrete pending tasks * fixing unused import and formatting issues * clippy fixes * removing picus out files * format fix * format fix * clippy fixes * fixing clippy warning * adding back selector post-conditions and checking one hot constraints on selectors * fixing fmt and clippy warnings * refactor picus backend * adding readme * fixing clippy warnings * updating dependency in Cargo lock * removing is_real from a selector in Sll * refactoring the extractor and fixing errors with how flags in receive_instruction are treated * additional cleanup * fixing formatting * applying additional fixes * fixing cargo fmt issue * deleting character from comment * op_a should be immutable for teq * syncing with stephens updates * removing redundant constraint added during debugging
* fix: ins offset = 32 * fix: format * fix: recover cargo toml * fix: udpate MiscInstrs in mips costs * fix: udpate MiscInstrs in mips costs
* fixing a == b check in teq and cleaning up builder * fixing trace * simplifying teq fix * updating comment * fixing clippy error * removing extra picus files * removing extra files * adding an extra bool check on is_real and tying it to selectors for clo_clz to be safe. It shouldn't be needed but Picus analyzes the circuit assuming the is_real selector can be 1 or 0.
* fix(sdk): clarify proof bytes() encoding for compressed vs snark proofs (#466) * Revert "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (#470) This reverts commit 7af605d. * chore: fix expected string (#471) * Reapply "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (#470) This reverts commit 537c656. * test: fix expected string * refactor: extract common attribute parsing logic in derive macros --------- Co-authored-by: GarmashAlex <garmasholeksii@gmail.com> Co-authored-by: Stephen Duan <81497928+eigmax@users.noreply.github.com> Co-authored-by: Jingping Yin <yinjingping2022@gmail.com>
* fixing a == b check in teq and cleaning up builder * fixing trace * simplifying teq fix * updating comment * fixing clippy error * removing extra picus files * removing extra files * adding an extra bool check on is_real and tying it to selectors for clo_clz to be safe. It shouldn't be needed but Picus analyzes the circuit assuming the is_real selector can be 1 or 0. * make sure hi_record_is_real can only enabled when is_real is enabled.
eigmax
commented
Mar 17, 2026
* optimize: Lt and ShiftRight chip * optimize: Lt and ShiftRight chip
* optimize: Lt and ShiftRight chip * optimize: Lt and ShiftRight chip * adding mipstests from regression test suite --------- Co-authored-by: eigmax <sd@eigen.market>
* fix(sdk): clarify proof bytes() encoding for compressed vs snark proofs (#466) * Revert "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (#470) This reverts commit 7af605d. * chore: fix expected string (#471) * Reapply "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (#470) This reverts commit 537c656. * test: fix expected string * fix(prover): remove leftover debug code (#473) * feat: build groth16 vk without verifying stark vk * fix: add part vk in the circuit * style: cargo fmt * fix: replace addition with hashing * feat: add script * feat: add 'common' feature * style: refactor * chore: update vks * style: refactor * feat: get part start vk by version * style: refactor * fix: ci * style: rename feature, var and func * feat: get partial stark vk locally * feat: arkwork verifier * style: refactor --------- Co-authored-by: GarmashAlex <garmasholeksii@gmail.com> Co-authored-by: Stephen Duan <81497928+eigmax@users.noreply.github.com> Co-authored-by: emmmm <155267286+eeemmmmmm@users.noreply.github.com>
eigmax
force-pushed
the
pre-release-v1.2.5
branch
from
70c21fd to
0371728
Compare
felicityin
force-pushed
the
pre-release-v1.2.5
branch
from
82127ca to
5b83ec0
Compare
felicityin
force-pushed
the
pre-release-v1.2.5
branch
from
d44f916 to
696004e
Compare
* fix: re-gen shapes * chore: add test in divrem * fix: save in keeper * fix: save in keeper * chore: commit shapes files
* fix: re-gen shapes * chore: add test in divrem * fix: save in keeper * fix: save in keeper * chore: commit shapes files * chore: update shapes
…n dividing by INT_MIN (#483) * fix trace generator bug for division that handles dividing by INT_MIN * refactoring mipstests to support both executor and prover tests
# Conflicts: # crates/prover/vk_map.bin # crates/verifier/bn254-vk/groth16_vk.bin # crates/verifier/bn254-vk/history/v1.2.5_part_stark_vk.bin # crates/verifier/bn254-vk/part_stark_vk.bin # crates/verifier/bn254-vk/plonk_vk.bin
…16 public input verification (#490) * Bundle historical part_stark_vks for guest lookup * Support ZKM_IMM_WRAP_VK in verify_groth16_bn254_public_inputs
blake-pro
approved these changes
Apr 9, 2026
* feat: LtChip trace FFI * fix: set cols init value zero * feat: BitwiseChip trace FFI * feat: CloClzChip trace FFI * feat: BranchChip trace FFI * feat: JumpChip trace FFI * feat: MemoryInstructionChip * fix: set the initial value to 0 * feat: MiscInstrsChip trace FFI * feat: MovCond trace FFI * feat: ShiftLeftChip trace FFI * feat: ShiftRightChip trace FFI * feat: DivRemChip trace FFI * feat: MulChip trace FFI * feat: SyscallInstrsChip trace FFI * chore: SyscallInstrsChip adapted to v1.2.5 * chore: debug * chore: SyscallChip adapted to v1.2.5 * chore: make func inline and remove dead code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.