Re-enable light overlap debug mode #118

sebastienlagarde · 2020-04-14T15:58:39Z

Fix for https://fogbugz.unity3d.com/f/cases/1237782/

* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210) * Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204) * Update documentation to mention more explicitely the lack of support of vertex animation * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202) * Make subsection in decal debug menu * changelog * Support cookie on light backing for Disc Area Light #6138 * Hdrp /lookdev/fix crash on adding volume as viewed game object #6129 * fixed changelog * Add smoothness remark (#6226) * Removed legacy VR code from HDRP #5923 * Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895 * Improve light clipping and culling #2 #4711 * Hdrp/fix/decal material ui errors #6225 * Fix z-fighting in sceneview when scene lighting is off (#6213) * Do not override the depth state of transparent materials in RenderDebugView * Changelog * Changelog - add case number Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md * Mention default post processing in default volumes. (#6233) * Fix cubemap inspector so that thumbnail for cubemap work #6231 * - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fix some typos in the debug menu (#6249) * Backport renaming * changelog * Added debug exposure to light hierarchy debug. (#6216) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254) * Clearer naming of tile and cluster categories for environment lights #6227 * Fix texture curve destroy (#6277) # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md * Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270) * fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266) * Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235 * Add XR setting to control camera jitter for temporal effects #6259 * fix unreachable code in TextureXR.useTexArray (#6260) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Deprecate Utilities namespace #6219 * Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265 * Update CHANGELOG.md * [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289) * Fix null texture usage happening on CoreRP upgrade * Partially fix garbage collected stylesheet issue. (Need more work on UIElement side, see case 1228706 ) * Update CHANGELOG.md * Clean log * [Backport 8.x.x] Hdrp/fix default volume switch (#6336) * Fixed an issue where default volume would not update when switching profile. * Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied * Changelog * [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339) * Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7 * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335) * Fixed an issue where Volume inspector might not refresh correctly in some cases. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix material baked emission #5392 * Fixed volume components lifespan in the clipboard #5869 * Hdrp/fix/particle light shadows #6111 * Bugfix: uncached reflection probe cameras were reseting the debug mode #6245 * Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272 * Hdrp/probe scale 1219246 (#6288) * Fix when scale down < 0 all direction of box Influence Volume * Update Change log * Update CHANGELOG.md * Split set rendering feature set and API validity check #6301 * Fix Render Texture with XR #6306 * Fix sRGB mismatch with XR SDK #6311 * Fix XR single-pass with Mock HMD plugin #6313 * Fix XR culling with multiple cameras #6314 * Add custom pass opaque rendering error message #6330 * Update Light-Component.md (#6332) * Update CHANGELOG.md * Update TextureCurve.cs * fix merge issue * Update CHANGELOG.md * - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410) * First pass of light loop optimizations (still single threaded) (#6367) (#6424) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Catch and handle NRefactory parser exceptions (#6392) Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> * Avoid negative input to sqrt() (#6397) - The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value. - This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21. - This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`. - On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact. * Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * Added known issues page (#6447) * Platform/playstation #6380 * Shadow cascade tooltip fix (when using the metric mode) #6448 * Focus on Decal uses the extends of the projectors #6449 * [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455) * - Fixed how the area light influence volume is computed to match rasterization. * Fix an issue with axis order Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed usage of light size data that are not available at runtime. (#6490) * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Add option to disable XR rendering on the camera settings #6372 * Move scene view camera settings to camera settings window #6390 * Corrected typo and changed links to .md (#6414) * Corrected typo and changed links to .md * Update Master-Node-Fabric.md * Hdrp /fix reset of HDAdditionalLightData #6453 * Fix null error when leaving debug menu #6467 * Hdrp /fix drag area width at left of light intensity #6471 * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473 * Fix custom pass depth copy #6484 * Hdrp /lookdev ui fixes #6491 * Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496 * fix unused leftover (#6497) * Fix custom pass test reference images (#6512) * [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#27) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * path validation when creating new volume profile (#36) * Clamp probes compression factor to 0 #19 * [Backport 8.x.x] Fix various leaks in HDRP (#119) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs * Update changelog * [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#115) * Follow references when unloading unneeded assets * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix MSAA resolve when there is no motion vectors * Fix issues causing planar probes to be broken with multiple cameras in the scene * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. * Hdrp/fix/custom pass msaa rendering info * Added disocclusion and ghosting to the glossary (#75) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position * Fix null reference when processing light probe * Fix black screen in XR when HDRP package is present but not used * [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor * fix Stacklit.hlsl after merge * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Vfx/docs/bulk review continued (#78) * Reviewed Contexts and terminology. * Began reviewing Events * Added sticky notes doc and reviewed Events * Update Contexts.md * Formatted documentation. * Update Contexts.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Thomas <Chman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com> Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com> Co-authored-by: Tim Cannell <timcannell@unity3d.com> Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210) * Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204) * Update documentation to mention more explicitely the lack of support of vertex animation * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202) * Make subsection in decal debug menu * changelog * Support cookie on light backing for Disc Area Light #6138 * Hdrp /lookdev/fix crash on adding volume as viewed game object #6129 * fixed changelog * Add smoothness remark (#6226) * Removed legacy VR code from HDRP #5923 * Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895 * Improve light clipping and culling #2 #4711 * Hdrp/fix/decal material ui errors #6225 * Fix z-fighting in sceneview when scene lighting is off (#6213) * Do not override the depth state of transparent materials in RenderDebugView * Changelog * Changelog - add case number Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md * Mention default post processing in default volumes. (#6233) * Fix cubemap inspector so that thumbnail for cubemap work #6231 * - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fix some typos in the debug menu (#6249) * Backport renaming * changelog * Added debug exposure to light hierarchy debug. (#6216) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254) * Clearer naming of tile and cluster categories for environment lights #6227 * Fix texture curve destroy (#6277) # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md * Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270) * fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266) * Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235 * Add XR setting to control camera jitter for temporal effects #6259 * fix unreachable code in TextureXR.useTexArray (#6260) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Deprecate Utilities namespace #6219 * Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265 * Update CHANGELOG.md * [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289) * Fix null texture usage happening on CoreRP upgrade * Partially fix garbage collected stylesheet issue. (Need more work on UIElement side, see case 1228706 ) * Update CHANGELOG.md * Clean log * [Backport 8.x.x] Hdrp/fix default volume switch (#6336) * Fixed an issue where default volume would not update when switching profile. * Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied * Changelog * [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339) * Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7 * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335) * Fixed an issue where Volume inspector might not refresh correctly in some cases. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix material baked emission #5392 * Fixed volume components lifespan in the clipboard #5869 * Hdrp/fix/particle light shadows #6111 * Bugfix: uncached reflection probe cameras were reseting the debug mode #6245 * Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272 * Hdrp/probe scale 1219246 (#6288) * Fix when scale down < 0 all direction of box Influence Volume * Update Change log * Update CHANGELOG.md * Split set rendering feature set and API validity check #6301 * Fix Render Texture with XR #6306 * Fix sRGB mismatch with XR SDK #6311 * Fix XR single-pass with Mock HMD plugin #6313 * Fix XR culling with multiple cameras #6314 * Add custom pass opaque rendering error message #6330 * Update Light-Component.md (#6332) * Update CHANGELOG.md * Update TextureCurve.cs * fix merge issue * Update CHANGELOG.md * - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410) * First pass of light loop optimizations (still single threaded) (#6367) (#6424) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Catch and handle NRefactory parser exceptions (#6392) Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> * Avoid negative input to sqrt() (#6397) - The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value. - This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21. - This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`. - On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact. * Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * Added known issues page (#6447) * Platform/playstation #6380 * Shadow cascade tooltip fix (when using the metric mode) #6448 * Focus on Decal uses the extends of the projectors #6449 * [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455) * - Fixed how the area light influence volume is computed to match rasterization. * Fix an issue with axis order Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed usage of light size data that are not available at runtime. (#6490) * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Add option to disable XR rendering on the camera settings #6372 * Move scene view camera settings to camera settings window #6390 * Corrected typo and changed links to .md (#6414) * Corrected typo and changed links to .md * Update Master-Node-Fabric.md * Hdrp /fix reset of HDAdditionalLightData #6453 * Fix null error when leaving debug menu #6467 * Hdrp /fix drag area width at left of light intensity #6471 * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473 * Fix custom pass depth copy #6484 * Hdrp /lookdev ui fixes #6491 * Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496 * fix unused leftover (#6497) * Fix custom pass test reference images (#6512) * [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#27) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * path validation when creating new volume profile (#36) * Clamp probes compression factor to 0 #19 * [Backport 8.x.x] Fix various leaks in HDRP (#119) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs * Update changelog * [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#115) * Follow references when unloading unneeded assets * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix MSAA resolve when there is no motion vectors * Fix issues causing planar probes to be broken with multiple cameras in the scene * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. * Hdrp/fix/custom pass msaa rendering info * Added disocclusion and ghosting to the glossary (#75) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position * Fix null reference when processing light probe * Fix black screen in XR when HDRP package is present but not used * [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor * fix Stacklit.hlsl after merge * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Vfx/docs/bulk review continued (#78) * Reviewed Contexts and terminology. * Began reviewing Events * Added sticky notes doc and reviewed Events * Update Contexts.md * Formatted documentation. * Update Contexts.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Fix for white flash happening when changing lighting condition (like teleport) * Fix issue with metal shader and raytracing * Fix default volume profile collapse * Update AxF-Shader.md (#152) * Bind missing buffer #159 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Thomas <Chman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com> Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com> Co-authored-by: Tim Cannell <timcannell@unity3d.com> Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210) * Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204) * Update documentation to mention more explicitely the lack of support of vertex animation * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202) * Make subsection in decal debug menu * changelog * Support cookie on light backing for Disc Area Light #6138 * Hdrp /lookdev/fix crash on adding volume as viewed game object #6129 * fixed changelog * Add smoothness remark (#6226) * Removed legacy VR code from HDRP #5923 * Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895 * Improve light clipping and culling #2 #4711 * Hdrp/fix/decal material ui errors #6225 * Fix z-fighting in sceneview when scene lighting is off (#6213) * Do not override the depth state of transparent materials in RenderDebugView * Changelog * Changelog - add case number Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md * Mention default post processing in default volumes. (#6233) * Fix cubemap inspector so that thumbnail for cubemap work #6231 * - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fix some typos in the debug menu (#6249) * Backport renaming * changelog * Added debug exposure to light hierarchy debug. (#6216) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254) * Clearer naming of tile and cluster categories for environment lights #6227 * Fix texture curve destroy (#6277) # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md * Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270) * fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266) * Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235 * Add XR setting to control camera jitter for temporal effects #6259 * fix unreachable code in TextureXR.useTexArray (#6260) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Deprecate Utilities namespace #6219 * Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265 * Update CHANGELOG.md * [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289) * Fix null texture usage happening on CoreRP upgrade * Partially fix garbage collected stylesheet issue. (Need more work on UIElement side, see case 1228706 ) * Update CHANGELOG.md * Clean log * [Backport 8.x.x] Hdrp/fix default volume switch (#6336) * Fixed an issue where default volume would not update when switching profile. * Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied * Changelog * [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339) * Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7 * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335) * Fixed an issue where Volume inspector might not refresh correctly in some cases. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix material baked emission #5392 * Fixed volume components lifespan in the clipboard #5869 * Hdrp/fix/particle light shadows #6111 * Bugfix: uncached reflection probe cameras were reseting the debug mode #6245 * Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272 * Hdrp/probe scale 1219246 (#6288) * Fix when scale down < 0 all direction of box Influence Volume * Update Change log * Update CHANGELOG.md * Split set rendering feature set and API validity check #6301 * Fix Render Texture with XR #6306 * Fix sRGB mismatch with XR SDK #6311 * Fix XR single-pass with Mock HMD plugin #6313 * Fix XR culling with multiple cameras #6314 * Add custom pass opaque rendering error message #6330 * Update Light-Component.md (#6332) * Update CHANGELOG.md * Update TextureCurve.cs * fix merge issue * Update CHANGELOG.md * - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410) * First pass of light loop optimizations (still single threaded) (#6367) (#6424) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Catch and handle NRefactory parser exceptions (#6392) Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> * Avoid negative input to sqrt() (#6397) - The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value. - This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21. - This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`. - On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact. * Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * Added known issues page (#6447) * Platform/playstation #6380 * Shadow cascade tooltip fix (when using the metric mode) #6448 * Focus on Decal uses the extends of the projectors #6449 * [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455) * - Fixed how the area light influence volume is computed to match rasterization. * Fix an issue with axis order Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed usage of light size data that are not available at runtime. (#6490) * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Add option to disable XR rendering on the camera settings #6372 * Move scene view camera settings to camera settings window #6390 * Corrected typo and changed links to .md (#6414) * Corrected typo and changed links to .md * Update Master-Node-Fabric.md * Hdrp /fix reset of HDAdditionalLightData #6453 * Fix null error when leaving debug menu #6467 * Hdrp /fix drag area width at left of light intensity #6471 * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473 * Fix custom pass depth copy #6484 * Hdrp /lookdev ui fixes #6491 * Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496 * fix unused leftover (#6497) * Fix custom pass test reference images (#6512) * [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#27) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * path validation when creating new volume profile (#36) * Clamp probes compression factor to 0 #19 * [Backport 8.x.x] Fix various leaks in HDRP (#119) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs * Update changelog * [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#115) * Follow references when unloading unneeded assets * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix MSAA resolve when there is no motion vectors * Fix issues causing planar probes to be broken with multiple cameras in the scene * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. * Hdrp/fix/custom pass msaa rendering info * Added disocclusion and ghosting to the glossary (#75) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position * Fix null reference when processing light probe * Fix black screen in XR when HDRP package is present but not used * [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor * fix Stacklit.hlsl after merge * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Vfx/docs/bulk review continued (#78) * Reviewed Contexts and terminology. * Began reviewing Events * Added sticky notes doc and reviewed Events * Update Contexts.md * Formatted documentation. * Update Contexts.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Fix for white flash happening when changing lighting condition (like teleport) * Fix issue with metal shader and raytracing * Fix default volume profile collapse * Update AxF-Shader.md (#152) * Bind missing buffer #159 * Enable Light Baking Cookies by default + Warning #79 * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Thomas <Chman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com> Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com> Co-authored-by: Tim Cannell <timcannell@unity3d.com> Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210) * Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204) * Update documentation to mention more explicitely the lack of support of vertex animation * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202) * Make subsection in decal debug menu * changelog * Support cookie on light backing for Disc Area Light #6138 * Hdrp /lookdev/fix crash on adding volume as viewed game object #6129 * fixed changelog * Add smoothness remark (#6226) * Removed legacy VR code from HDRP #5923 * Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895 * Improve light clipping and culling #2 #4711 * Hdrp/fix/decal material ui errors #6225 * Fix z-fighting in sceneview when scene lighting is off (#6213) * Do not override the depth state of transparent materials in RenderDebugView * Changelog * Changelog - add case number Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md * Mention default post processing in default volumes. (#6233) * Fix cubemap inspector so that thumbnail for cubemap work #6231 * - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fix some typos in the debug menu (#6249) * Backport renaming * changelog * Added debug exposure to light hierarchy debug. (#6216) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254) * Clearer naming of tile and cluster categories for environment lights #6227 * Fix texture curve destroy (#6277) # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md * Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270) * fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266) * Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235 * Add XR setting to control camera jitter for temporal effects #6259 * fix unreachable code in TextureXR.useTexArray (#6260) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Deprecate Utilities namespace #6219 * Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265 * Update CHANGELOG.md * [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289) * Fix null texture usage happening on CoreRP upgrade * Partially fix garbage collected stylesheet issue. (Need more work on UIElement side, see case 1228706 ) * Update CHANGELOG.md * Clean log * [Backport 8.x.x] Hdrp/fix default volume switch (#6336) * Fixed an issue where default volume would not update when switching profile. * Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied * Changelog * [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339) * Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7 * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335) * Fixed an issue where Volume inspector might not refresh correctly in some cases. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix material baked emission #5392 * Fixed volume components lifespan in the clipboard #5869 * Hdrp/fix/particle light shadows #6111 * Bugfix: uncached reflection probe cameras were reseting the debug mode #6245 * Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272 * Hdrp/probe scale 1219246 (#6288) * Fix when scale down < 0 all direction of box Influence Volume * Update Change log * Update CHANGELOG.md * Split set rendering feature set and API validity check #6301 * Fix Render Texture with XR #6306 * Fix sRGB mismatch with XR SDK #6311 * Fix XR single-pass with Mock HMD plugin #6313 * Fix XR culling with multiple cameras #6314 * Add custom pass opaque rendering error message #6330 * Update Light-Component.md (#6332) * Update CHANGELOG.md * Update TextureCurve.cs * fix merge issue * Update CHANGELOG.md * - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410) * First pass of light loop optimizations (still single threaded) (#6367) (#6424) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Catch and handle NRefactory parser exceptions (#6392) Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> * Avoid negative input to sqrt() (#6397) - The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value. - This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21. - This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`. - On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact. * Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * Added known issues page (#6447) * Platform/playstation #6380 * Shadow cascade tooltip fix (when using the metric mode) #6448 * Focus on Decal uses the extends of the projectors #6449 * [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455) * - Fixed how the area light influence volume is computed to match rasterization. * Fix an issue with axis order Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed usage of light size data that are not available at runtime. (#6490) * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Add option to disable XR rendering on the camera settings #6372 * Move scene view camera settings to camera settings window #6390 * Corrected typo and changed links to .md (#6414) * Corrected typo and changed links to .md * Update Master-Node-Fabric.md * Hdrp /fix reset of HDAdditionalLightData #6453 * Fix null error when leaving debug menu #6467 * Hdrp /fix drag area width at left of light intensity #6471 * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473 * Fix custom pass depth copy #6484 * Hdrp /lookdev ui fixes #6491 * Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496 * fix unused leftover (#6497) * Fix custom pass test reference images (#6512) * [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#27) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * path validation when creating new volume profile (#36) * Clamp probes compression factor to 0 #19 * [Backport 8.x.x] Fix various leaks in HDRP (#119) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs * Update changelog * [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#115) * Follow references when unloading unneeded assets * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix MSAA resolve when there is no motion vectors * Fix issues causing planar probes to be broken with multiple cameras in the scene * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. * Hdrp/fix/custom pass msaa rendering info * Added disocclusion and ghosting to the glossary (#75) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position * Fix null reference when processing light probe * Fix black screen in XR when HDRP package is present but not used * [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor * fix Stacklit.hlsl after merge * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Vfx/docs/bulk review continued (#78) * Reviewed Contexts and terminology. * Began reviewing Events * Added sticky notes doc and reviewed Events * Update Contexts.md * Formatted documentation. * Update Contexts.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Fix for white flash happening when changing lighting condition (like teleport) * Fix issue with metal shader and raytracing * Fix default volume profile collapse * Update AxF-Shader.md (#152) * Bind missing buffer #159 * Enable Light Baking Cookies by default + Warning #79 * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * [Backport 8.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#180) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Add range attenuation to box-shaped spotlights [Skip CI] #101 * Contact shadow min distance + fix scalarization code #150 * Hdrp/combine material samples with shader samples [Skip CI] #117 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Thomas <Chman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com> Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com> Co-authored-by: Tim Cannell <timcannell@unity3d.com> Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 * [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * fix typo * fix typo 2 * Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284) * [7.x.x Backport] Fix pre/post pass sg properties #82 (#85) * Fix depth pre/post passes not correctly enabled when switching shaders on the material # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs # com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs * Hide prepass and postpass in the material UI # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#306) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Updated raytracing async compute warning. (#304) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog * [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307) * Fixed an error about procedural sky being logged by mistake. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog * [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317) * render until ambient probe is ready * remove comment * changelog * [Backport 7.x.x] Fixed some gcalloc in the debug window (#464) * Fixed some GCAlloc in the debug window # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs * Update changelog * [Backport 7.x.x] Hdrp/small ui update (#466) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs # com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs * update changelog * [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482) * PBR Sky renderer now shares its internal precomputation table between different instances. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs * Doc update * Update changelog * [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs * Update changelog * [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Update changelog * Changed UI name, tooltip, and doc for maximum decals on screen (#232) Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/ * Update Custom-Post-Process.md (#233) * Update HDRP-Features.md (#235) * Hdrp/reflection probe scale perf #252 * HD: Switch to 1920x1080 default standalone resolution (#279) Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res (moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo) * Makes sure quaternion is normalized and valid before converting to ma… #331 * Fix cookie srgb #297 * Updated forward and deferred rendering definitions (#350) * Update Forward-And-Deferred-Rendering.md * Update Forward-And-Deferred-Rendering.md * Update Light-Component.md (#357) * Hd/add layer modification on generated emissive mesh for area light #364 * Update Look-Dev-Environment-Library.md (#365) * Update Volumetric-Lighting.md (#402) Fixes https://fogbugz.unity3d.com/f/cases/1238592 * Hd/fix nullref while removing decal component #416 * Fix issue with Uber Post process shader when alpha is enabled #422 * Fix the bug (#430) * Fix issue causing not all baked reflection probes to be deleted #441 * Updated Decal Projector doc (#477) Updated Limitations section and added a disclaimer about decal shader stripping. * Look Dev docs refactor 2 #484 * [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA #315 * Fix issue with the resolve of motion vectors (#421) * fix issue with ShowPrePassAndPostPass * fix compilation issue in rendergraph Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Aras Pranckevičius <aras@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 * [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * fix typo * fix typo 2 * Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284) * [7.x.x Backport] Fix pre/post pass sg properties #82 (#85) * Fix depth pre/post passes not correctly enabled when switching shaders on the material # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs # com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs * Hide prepass and postpass in the material UI # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#306) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Updated raytracing async compute warning. (#304) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog * [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307) * Fixed an error about procedural sky being logged by mistake. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog * [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317) * render until ambient probe is ready * remove comment * changelog * [Backport 7.x.x] Fixed some gcalloc in the debug window (#464) * Fixed some GCAlloc in the debug window # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs * Update changelog * [Backport 7.x.x] Hdrp/small ui update (#466) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs # com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs * update changelog * [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482) * PBR Sky renderer now shares its internal precomputation table between different instances. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs * Doc update * Update changelog * [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs * Update changelog * [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Update changelog * Changed UI name, tooltip, and doc for maximum decals on screen (#232) Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/ * Update Custom-Post-Process.md (#233) * Update HDRP-Features.md (#235) * Hdrp/reflection probe scale perf #252 * HD: Switch to 1920x1080 default standalone resolution (#279) Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res (moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo) * Makes sure quaternion is normalized and valid before converting to ma… #331 * Fix cookie srgb #297 * Updated forward and deferred rendering definitions (#350) * Update Forward-And-Deferred-Rendering.md * Update Forward-And-Deferred-Rendering.md * Update Light-Component.md (#357) * Hd/add layer modification on generated emissive mesh for area light #364 * Update Look-Dev-Environment-Library.md (#365) * Update Volumetric-Lighting.md (#402) Fixes https://fogbugz.unity3d.com/f/cases/1238592 * Hd/fix nullref while removing decal component #416 * Fix issue with Uber Post process shader when alpha is enabled #422 * Fix the bug (#430) * Fix issue causing not all baked reflection probes to be deleted #441 * Updated Decal Projector doc (#477) Updated Limitations section and added a disclaimer about decal shader stripping. * Look Dev docs refactor 2 #484 * [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA #315 * Fix issue with the resolve of motion vectors (#421) * fix issue with ShowPrePassAndPostPass * fix compilation issue in rendergraph * Fixed null reference exception in LookDev when setting the SRP to None #447 * Check reflection probe null pointer before use. (case 1244047) #456 * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Fix few multi-editing issues with Emission UI #473 * Re-enable cubemap thumbnail gen only for d3d11 #487 * Hd/fix undo environmentlibrary lookdev #490 * Added system requirements and frame settings api docs (#510) * Added system requirements and frame settings api doc * Update System-Requirements.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Aras Pranckevičius <aras@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 * [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * fix typo * fix typo 2 * Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284) * [7.x.x Backport] Fix pre/post pass sg properties #82 (#85) * Fix depth pre/post passes not correctly enabled when switching shaders on the material # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs # com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs * Hide prepass and postpass in the material UI # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#306) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Updated raytracing async compute warning. (#304) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog * [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307) * Fixed an error about procedural sky being logged by mistake. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog * [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317) * render until ambient probe is ready * remove comment * changelog * [Backport 7.x.x] Fixed some gcalloc in the debug window (#464) * Fixed some GCAlloc in the debug window # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs * Update changelog * [Backport 7.x.x] Hdrp/small ui update (#466) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs # com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs * update changelog * [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482) * PBR Sky renderer now shares its internal precomputation table between different instances. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs * Doc update * Update changelog * [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs * Update changelog * [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Update changelog * Changed UI name, tooltip, and doc for maximum decals on screen (#232) Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/ * Update Custom-Post-Process.md (#233) * Update HDRP-Features.md (#235) * Hdrp/reflection probe scale perf #252 * HD: Switch to 1920x1080 default standalone resolution (#279) Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res (moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo) * Makes sure quaternion is normalized and valid before converting to ma… #331 * Fix cookie srgb #297 * Updated forward and deferred rendering definitions (#350) * Update Forward-And-Deferred-Rendering.md * Update Forward-And-Deferred-Rendering.md * Update Light-Component.md (#357) * Hd/add layer modification on generated emissive mesh for area light #364 * Update Look-Dev-Environment-Library.md (#365) * Update Volumetric-Lighting.md (#402) Fixes https://fogbugz.unity3d.com/f/cases/1238592 * Hd/fix nullref while removing decal component #416 * Fix issue with Uber Post process shader when alpha is enabled #422 * Fix the bug (#430) * Fix issue causing not all baked reflection probes to be deleted #441 * Updated Decal Projector doc (#477) Updated Limitations section and added a disclaimer about decal shader stripping. * Look Dev docs refactor 2 #484 * [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA #315 * Fix issue with the resolve of motion vectors (#421) * fix issue with ShowPrePassAndPostPass * fix compilation issue in rendergraph * Fixed null reference exception in LookDev when setting the SRP to None #447 * Check reflection probe null pointer before use. (case 1244047) #456 * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Fix few multi-editing issues with Emission UI #473 * Re-enable cubemap thumbnail gen only for d3d11 #487 * Hd/fix undo environmentlibrary lookdev #490 * Added system requirements and frame settings api docs (#510) * Added system requirements and frame settings api doc * Update System-Requirements.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * hide exposure compensation for fixed exposure (#535) * hide exposure compensation for fixed exposure * Update PostProcessSystem.cs * [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522 * Use path relative to package for depth of field #523 * Fix taaFrameIndex and restore TAA tests for XR #534 * Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538) * fix DXR manifest * update reference screenshots Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Aras Pranckevičius <aras@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 * [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * fix typo * fix typo 2 * Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284) * [7.x.x Backport] Fix pre/post pass sg properties #82 (#85) * Fix depth pre/post passes not correctly enabled when switching shaders on the material # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs # com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs * Hide prepass and postpass in the material UI # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#306) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Updated raytracing async compute warning. (#304) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog * [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307) * Fixed an error about procedural sky being logged by mistake. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog * [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317) * render until ambient probe is ready * remove comment * changelog * [Backport 7.x.x] Fixed some gcalloc in the debug window (#464) * Fixed some GCAlloc in the debug window # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs * Update changelog * [Backport 7.x.x] Hdrp/small ui update (#466) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs # com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs * update changelog * [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482) * PBR Sky renderer now shares its internal precomputation table between different instances. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs * Doc update * Update changelog * [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs * Update changelog * [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Update changelog * Changed UI name, tooltip, and doc for maximum decals on screen (#232) Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/ * Update Custom-Post-Process.md (#233) * Update HDRP-Features.md (#235) * Hdrp/reflection probe scale perf #252 * HD: Switch to 1920x1080 default standalone resolution (#279) Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res (moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo) * Makes sure quaternion is normalized and valid before converting to ma… #331 * Fix cookie srgb #297 * Updated forward and deferred rendering definitions (#350) * Update Forward-And-Deferred-Rendering.md * Update Forward-And-Deferred-Rendering.md * Update Light-Component.md (#357) * Hd/add layer modification on generated emissive mesh for area light #364 * Update Look-Dev-Environment-Library.md (#365) * Update Volumetric-Lighting.md (#402) Fixes https://fogbugz.unity3d.com/f/cases/1238592 * Hd/fix nullref while removing decal component #416 * Fix issue with Uber Post process shader when alpha is enabled #422 * Fix the bug (#430) * Fix issue causing not all baked reflection probes to be deleted #441 * Updated Decal Projector doc (#477) Updated Limitations section and added a disclaimer about decal shader stripping. * Look Dev docs refactor 2 #484 * [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA #315 * Fix issue with the resolve of motion vectors (#421) * fix issue with ShowPrePassAndPostPass * fix compilation issue in rendergraph * Fixed null reference exception in LookDev when setting the SRP to None #447 * Check reflection probe null pointer before use. (case 1244047) #456 * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Fix few multi-editing issues with Emission UI #473 * Re-enable cubemap thumbnail gen only for d3d11 #487 * Hd/fix undo environmentlibrary lookdev #490 * Added system requirements and frame settings api docs (#510) * Added system requirements and frame settings api doc * Update System-Requirements.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * hide exposure compensation for fixed exposure (#535) * hide exposure compensation for fixed exposure * Update PostProcessSystem.cs * [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522 * Use path relative to package for depth of field #523 * Fix taaFrameIndex and restore TAA tests for XR #534 * Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538) * fix DXR manifest * update reference screenshots * Clone in the Asset folder when the original volume profile is in a re… #508 * Add support for batchmode (#542) * Update Reflection-Probes-Intro.md (#548) Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Aras Pranckevičius <aras@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 * [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * fix typo * fix typo 2 * Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284) * [7.x.x Backport] Fix pre/post pass sg properties #82 (#85) * Fix depth pre/post passes not correctly enabled when switching shaders on the material # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs # com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs * Hide prepass and postpass in the material UI # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#306) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Updated raytracing async compute warning. (#304) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog * [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307) * Fixed an error about procedural sky being logged by mistake. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog * [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317) * render until ambient probe is ready * remove comment * changelog * [Backport 7.x.x] Fixed some gcalloc in the debug window (#464) * Fixed some GCAlloc in the debug window # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs * Update changelog * [Backport 7.x.x] Hdrp/small ui update (#466) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs # com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs * update changelog * [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482) * PBR Sky renderer now shares its internal precomputation table between different instances. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs * Doc update * Update changelog * [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs * Update changelog * [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Update changelog * Changed UI name, tooltip, and doc for maximum decals on screen (#232) Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/ * Update Custom-Post-Process.md (#233) * Update HDRP-Features.md (#235) * Hdrp/reflection probe scale perf #252 * HD: Switch to 1920x1080 default standalone resolution (#279) Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res (moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo) * Makes sure quaternion is normalized and valid before converting to ma… #331 * Fix cookie srgb #297 * Updated forward and deferred rendering definitions (#350) * Update Forward-And-Deferred-Rendering.md * Update Forward-And-Deferred-Rendering.md * Update Light-Component.md (#357) * Hd/add layer modification on generated emissive mesh for area light #364 * Update Look-Dev-Environment-Library.md (#365) * Update Volumetric-Lighting.md (#402) Fixes https://fogbugz.unity3d.com/f/cases/1238592 * Hd/fix nullref while removing decal component #416 * Fix issue with Uber Post process shader when alpha is enabled #422 * Fix the bug (#430) * Fix issue causing not all baked reflection probes to be deleted #441 * Updated Decal Projector doc (#477) Updated Limitations section and added a disclaimer about decal shader stripping. * Look Dev docs refactor 2 #484 * [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA #315 * Fix issue with the resolve of motion vectors (#421) * fix issue with ShowPrePassAndPostPass * fix compilation issue in rendergraph * Fixed null reference exception in LookDev when setting the SRP to None #447 * Check reflection probe null pointer before use. (case 1244047) #456 * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Fix few multi-editing issues with Emission UI #473 * Re-enable cubemap thumbnail gen only for d3d11 #487 * Hd/fix undo environmentlibrary lookdev #490 * Added system requirements and frame settings api docs (#510) * Added system requirements and frame settings api doc * Update System-Requirements.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * hide exposure compensation for fixed exposure (#535) * hide exposure compensation for fixed exposure * Update PostProcessSystem.cs * [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522 * Use path relative to package for depth of field #523 * Fix taaFrameIndex and restore TAA tests for XR #534 * Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538) * fix DXR manifest * update reference screenshots * Clone in the Asset folder when the original volume profile is in a re… #508 * Add support for batchmode (#542) * Update Reflection-Probes-Intro.md (#548) * Added note on decal emission on transparent surfaces (#567) * Update Decal-Projector.md * Update Decal-Projector.md * Update Decal-Projector.md * Added terrain lit doc (#573) * Add terrain lit doc * Update HDRP-Features.md * Update HDRP-Features.md * Hd/fix wizard defaultvolumeprofile creation #565 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Aras Pranckevičius <aras@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>

* Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * First pass of light loop optimizations (still single threaded) (#6367) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog * Shadow cascade tooltip fix (when using the metric mode) (#6448) * fix tooltip and public API about shadow cascades * minor modifications in the text * Add default tooltips * Add assert in case we support more cascades in the future * Minor text edit * Changlog * Updated tooltip text * update TAA screenshots * Disable POM test and update ref images (#6445) * Focus on Decal uses the extends of the projectors (#6449) * Added Alpha To Mask for HDRP and ShaderGraph (#6297) * Added AlphaToMask render state * AlphaToMask * AlphaToMask test * Updated changelog * Updated LayeredLit and AxF test * Added reference images * Fix depth and motion vector passes for Unlit * AlphaToMask doc. Unified doc and fixed links for Alpha Clipping * Updated reference screenshots * Update CHANGELOG.md * Fix motion vector settings for test scenes * Block AlphaToMask state in deferred or not MSAA. Updated test screenshots * Fix MRT blend state Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Move scene view camera settings to camera settings window (#6390) * Move the HDRP scene view settings to the Editor camera settings widget * Changelog + tooltips * update upgrade guide * fix spelling Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed how the area light influence volume is computed to match rasterization. (#6454) * - Fixed how the area light influence volume is computed to match rasterization. * Fix issue in the axis order * Update DebugDisplay.cs (#6467) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Adding 5 automated test scenes (#6483) * Sharing more code for light data building (RT) and building a more optimal atlas (#6370) * - Sharing GetLightData code between rasterization and ray tracing to avoid duplication and lack of features - Inject all lights at the same time (rasterization and ray tracing) into the cookie atlas to avoid waste of space. - Added a test scene to make sure it works properly * correcting debug mistake * Forgot to add the screenshot and to enable the test in the editor build settings * - Fixed usage of light size data that are not available at runtime. (#6489) * Hdrp /lookdev ui fixes (#6491) * Fix no environment text wraping * Add missing toolbar tooltips * Fix camera button-dropdown layout * Fix uss loss at domain reload * Update CHANGELOG.md * Fix custom pass depth copy (#6484) * Fixed the depth buffer copy made before custom pass after opaque and normal injection point * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6479) * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on (#6473) * Use different hash to prevent the perennial dirtying of baked probes. * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp /fix drag area width at left of light intensity (#6471) * Fix drag area width at left of light's intensity * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp /fix reset of HDAdditionalLightData (#6453) * fix type resolving issue when reseting HDAdditionalLightdata * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Add option to disable XR rendering on the camera settings (#6372) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix unused leftover (#6497) * Split HDRP Test scene 1900 in two scene (#6498) * Fix custom pass test reference images (#6512) * Updated ref image for PT fog test (5005). (#6513) * Review corrections for previous PR (#6494) * Fixed an usage of a a compute buffer not bound (1229964) (#6476) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520) Fixing an issue with sub-surface scattering and updating screenshots * fix typo (#6500) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. * Update changelog. * Additional fix for regular inspector * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. * Update changelog * Removed wrongly serialized fields in StaticLightingSky (#6441) * Removed unnecessarily serialized members in StaticLightingSky component. * Update changelog * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504) * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix a compilation issue to to a backport that did not go well. (#9) * Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31) * Clamp probes compression factor to 0 (#19) * Clamp to positive * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * path validation when creating new volume profile (#36) * Validate whole path when creating new profile * Changelog Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com> * Alpha to coverage frame setting (#33) * Added FrameSettingsField.AlphaToMask * Changelog + Documentation * Changed field index * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41) * AxF: Add support for specular AA from geometric curvature. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights. * AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe. * AxF: Use get scalar roughness function to factor out code. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * Add changelog entries. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement constant buffers for HDRP global variables. (#52) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Fixed color/depth pyramid debug * Cleanup * Small fix * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Add Performance framework package and HDRP performance tests (#45) * Added performance test project * Added new test scene system and memory p[rofiling * Added shader analysis package * Create symlink folder in library directory * Update editor window * Update shader analysis selection * Added CLI utility to execute shader analysis reports * Added example for the cli * Removed problematic HDRP graphic test packages * Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903) * Update memory profiling test sample count * Update shader graph support * Updated project settings * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Use background job API and improved progress reporting * Empty commit for Performance reports * Updated ui * Empty commit for Performance reports * Empty commit for Performance reports * Added filter on shader pass and variants * Added option to only generate shader variants * Empty commit for Performance reports * Increase garlic heap size * Begin to add build profiling * Added more build info * Working version of the shader compilation time reporting * wip * Removed useless cli * Added util functions to name test and sample groups * Renamed all markers and finished the build profiling * Update test framework package * Updated shader analysis tests * Updated API * Updated API and log command for compiler * Updated api * Use unknown metric instead of time one as workaround * Enable the CPU profiling API * Fix when deleting an analyzed shader * Load reference on enable * Added shader analysis package * Fixed PS4 test name * Fixed memory unit * Added more test scenes * Force performance tests to run on PS4 base * Fixed sample units and use the same SampleGroup for multiple frames in counter test * Begin to create the graphic perf test * Finished the first version of performance graphic test package * Fixed build tests * Increase static analysis timeout * More timeout * Removed Lit shader static analysis * Fix counters tests * Added performance settings window in project settings * Re-add Forward build test scene * Fixed shader analysis filter * PR fixes * Begin to write the doc * Finished V1 of the performance package doc * Added grafana image and doc description * Updated doc * Maybe fix yamayo tests * Update documentation for static analysis * Added note on core asmdef * Removed debug * Fixed total memory * Added tesselation counters test * Tessellation shadow test * Added per scene settings * Added naming convention doc * Fixed build issue on yamato * Compilation fix to revert * Begin to write the new doc page * Completed performance doc * Fixed build test * Added Lit in static analysis * Removed deferred static analysis Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Hdrp/fix/custom pass msaa rendering info (#42) * Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass AOV API (#50) * Very basic AOV support for custom pass * Updated AOV API for custom passes * Changelog * Update AOV API * API improvements * API documentation * API doc, factorize all push texture calls in RenderCustomPass * added default values and constructor for CustomPassAOVBuffers * fix merge conflicts * Fix GC alloc during rendering: use a for loop instead of findIndex+lambda Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile…

* Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * First pass of light loop optimizations (still single threaded) (#6367) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog * Shadow cascade tooltip fix (when using the metric mode) (#6448) * fix tooltip and public API about shadow cascades * minor modifications in the text * Add default tooltips * Add assert in case we support more cascades in the future * Minor text edit * Changlog * Updated tooltip text * update TAA screenshots * Disable POM test and update ref images (#6445) * Focus on Decal uses the extends of the projectors (#6449) * Added Alpha To Mask for HDRP and ShaderGraph (#6297) * Added AlphaToMask render state * AlphaToMask * AlphaToMask test * Updated changelog * Updated LayeredLit and AxF test * Added reference images * Fix depth and motion vector passes for Unlit * AlphaToMask doc. Unified doc and fixed links for Alpha Clipping * Updated reference screenshots * Update CHANGELOG.md * Fix motion vector settings for test scenes * Block AlphaToMask state in deferred or not MSAA. Updated test screenshots * Fix MRT blend state Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Move scene view camera settings to camera settings window (#6390) * Move the HDRP scene view settings to the Editor camera settings widget * Changelog + tooltips * update upgrade guide * fix spelling Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed how the area light influence volume is computed to match rasterization. (#6454) * - Fixed how the area light influence volume is computed to match rasterization. * Fix issue in the axis order * Update DebugDisplay.cs (#6467) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Adding 5 automated test scenes (#6483) * Sharing more code for light data building (RT) and building a more optimal atlas (#6370) * - Sharing GetLightData code between rasterization and ray tracing to avoid duplication and lack of features - Inject all lights at the same time (rasterization and ray tracing) into the cookie atlas to avoid waste of space. - Added a test scene to make sure it works properly * correcting debug mistake * Forgot to add the screenshot and to enable the test in the editor build settings * - Fixed usage of light size data that are not available at runtime. (#6489) * Hdrp /lookdev ui fixes (#6491) * Fix no environment text wraping * Add missing toolbar tooltips * Fix camera button-dropdown layout * Fix uss loss at domain reload * Update CHANGELOG.md * Fix custom pass depth copy (#6484) * Fixed the depth buffer copy made before custom pass after opaque and normal injection point * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6479) * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on (#6473) * Use different hash to prevent the perennial dirtying of baked probes. * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp /fix drag area width at left of light intensity (#6471) * Fix drag area width at left of light's intensity * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp /fix reset of HDAdditionalLightData (#6453) * fix type resolving issue when reseting HDAdditionalLightdata * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Add option to disable XR rendering on the camera settings (#6372) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix unused leftover (#6497) * Split HDRP Test scene 1900 in two scene (#6498) * Fix custom pass test reference images (#6512) * Updated ref image for PT fog test (5005). (#6513) * Review corrections for previous PR (#6494) * Fixed an usage of a a compute buffer not bound (1229964) (#6476) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520) Fixing an issue with sub-surface scattering and updating screenshots * fix typo (#6500) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. * Update changelog. * Additional fix for regular inspector * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. * Update changelog * Removed wrongly serialized fields in StaticLightingSky (#6441) * Removed unnecessarily serialized members in StaticLightingSky component. * Update changelog * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504) * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix a compilation issue to to a backport that did not go well. (#9) * Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31) * Clamp probes compression factor to 0 (#19) * Clamp to positive * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * path validation when creating new volume profile (#36) * Validate whole path when creating new profile * Changelog Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com> * Alpha to coverage frame setting (#33) * Added FrameSettingsField.AlphaToMask * Changelog + Documentation * Changed field index * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41) * AxF: Add support for specular AA from geometric curvature. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights. * AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe. * AxF: Use get scalar roughness function to factor out code. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * Add changelog entries. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement constant buffers for HDRP global variables. (#52) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Fixed color/depth pyramid debug * Cleanup * Small fix * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Add Performance framework package and HDRP performance tests (#45) * Added performance test project * Added new test scene system and memory p[rofiling * Added shader analysis package * Create symlink folder in library directory * Update editor window * Update shader analysis selection * Added CLI utility to execute shader analysis reports * Added example for the cli * Removed problematic HDRP graphic test packages * Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903) * Update memory profiling test sample count * Update shader graph support * Updated project settings * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Use background job API and improved progress reporting * Empty commit for Performance reports * Updated ui * Empty commit for Performance reports * Empty commit for Performance reports * Added filter on shader pass and variants * Added option to only generate shader variants * Empty commit for Performance reports * Increase garlic heap size * Begin to add build profiling * Added more build info * Working version of the shader compilation time reporting * wip * Removed useless cli * Added util functions to name test and sample groups * Renamed all markers and finished the build profiling * Update test framework package * Updated shader analysis tests * Updated API * Updated API and log command for compiler * Updated api * Use unknown metric instead of time one as workaround * Enable the CPU profiling API * Fix when deleting an analyzed shader * Load reference on enable * Added shader analysis package * Fixed PS4 test name * Fixed memory unit * Added more test scenes * Force performance tests to run on PS4 base * Fixed sample units and use the same SampleGroup for multiple frames in counter test * Begin to create the graphic perf test * Finished the first version of performance graphic test package * Fixed build tests * Increase static analysis timeout * More timeout * Removed Lit shader static analysis * Fix counters tests * Added performance settings window in project settings * Re-add Forward build test scene * Fixed shader analysis filter * PR fixes * Begin to write the doc * Finished V1 of the performance package doc * Added grafana image and doc description * Updated doc * Maybe fix yamayo tests * Update documentation for static analysis * Added note on core asmdef * Removed debug * Fixed total memory * Added tesselation counters test * Tessellation shadow test * Added per scene settings * Added naming convention doc * Fixed build issue on yamato * Compilation fix to revert * Begin to write the new doc page * Completed performance doc * Fixed build test * Added Lit in static analysis * Removed deferred static analysis Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Hdrp/fix/custom pass msaa rendering info (#42) * Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass AOV API (#50) * Very basic AOV support for custom pass * Updated AOV API for custom passes * Changelog * Update AOV API * API improvements * API documentation * API doc, factorize all push texture calls in RenderCustomPass * added default values and constructor for CustomPassAOVBuffers * fix merge conflicts * Fix GC alloc during rendering: use a for loop instead of findIndex+lambda Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers …

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 * [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * fix typo * fix typo 2 * Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284) * [7.x.x Backport] Fix pre/post pass sg properties #82 (#85) * Fix depth pre/post passes not correctly enabled when switching shaders on the material # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs # com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs * Hide prepass and postpass in the material UI # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#306) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Updated raytracing async compute warning. (#304) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog * [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307) * Fixed an error about procedural sky being logged by mistake. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog * [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317) * render until ambient probe is ready * remove comment * changelog * [Backport 7.x.x] Fixed some gcalloc in the debug window (#464) * Fixed some GCAlloc in the debug window # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs * Update changelog * [Backport 7.x.x] Hdrp/small ui update (#466) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs # com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs * update changelog * [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482) * PBR Sky renderer now shares its internal precomputation table between different instances. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs * Doc update * Update changelog * [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs * Update changelog * [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Update changelog * Changed UI name, tooltip, and doc for maximum decals on screen (#232) Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/ * Update Custom-Post-Process.md (#233) * Update HDRP-Features.md (#235) * Hdrp/reflection probe scale perf #252 * HD: Switch to 1920x1080 default standalone resolution (#279) Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res (moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo) * Makes sure quaternion is normalized and valid before converting to ma… #331 * Fix cookie srgb #297 * Updated forward and deferred rendering definitions (#350) * Update Forward-And-Deferred-Rendering.md * Update Forward-And-Deferred-Rendering.md * Update Light-Component.md (#357) * Hd/add layer modification on generated emissive mesh for area light #364 * Update Look-Dev-Environment-Library.md (#365) * Update Volumetric-Lighting.md (#402) Fixes https://fogbugz.unity3d.com/f/cases/1238592 * Hd/fix nullref while removing decal component #416 * Fix issue with Uber Post process shader when alpha is enabled #422 * Fix the bug (#430) * Fix issue causing not all baked reflection probes to be deleted #441 * Updated Decal Projector doc (#477) Updated Limitations section and added a disclaimer about decal shader stripping. * Look Dev docs refactor 2 #484 * [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA #315 * Fix issue with the resolve of motion vectors (#421) * fix issue with ShowPrePassAndPostPass * fix compilation issue in rendergraph * Fixed null reference exception in LookDev when setting the SRP to None #447 * Check reflection probe null pointer before use. (case 1244047) #456 * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Fix few multi-editing issues with Emission UI #473 * Re-enable cubemap thumbnail gen only for d3d11 #487 * Hd/fix undo environmentlibrary lookdev #490 * Added system requirements and frame settings api docs (#510) * Added system requirements and frame settings api doc * Update System-Requirements.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * hide exposure compensation for fixed exposure (#535) * hide exposure compensation for fixed exposure * Update PostProcessSystem.cs * [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522 * Use path relative to package for depth of field #523 * Fix taaFrameIndex and restore TAA tests for XR #534 * Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538) * fix DXR manifest * update reference screenshots * Clone in the Asset folder when the original volume profile is in a re… #508 * Add support for batchmode (#542) * Update Reflection-Probes-Intro.md (#548) * Added note on decal emission on transparent surfaces (#567) * Update Decal-Projector.md * Update Decal-Projector.md * Update Decal-Projector.md * Added terrain lit doc (#573) * Add terrain lit doc * Update HDRP-Features.md * Update HDRP-Features.md * Hd/fix wizard defaultvolumeprofile creation #565 * Fixed light layers not correctly disabled when the lightlayers is set to Nothing #584 * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * Added Lit master node doc (#613) Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Aras Pranckevičius <aras@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>

* Added Alpha To Mask for HDRP and ShaderGraph (#6297) * Added AlphaToMask render state * AlphaToMask * AlphaToMask test * Updated changelog * Updated LayeredLit and AxF test * Added reference images * Fix depth and motion vector passes for Unlit * AlphaToMask doc. Unified doc and fixed links for Alpha Clipping * Updated reference screenshots * Update CHANGELOG.md * Fix motion vector settings for test scenes * Block AlphaToMask state in deferred or not MSAA. Updated test screenshots * Fix MRT blend state Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Move scene view camera settings to camera settings window (#6390) * Move the HDRP scene view settings to the Editor camera settings widget * Changelog + tooltips * update upgrade guide * fix spelling Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed how the area light influence volume is computed to match rasterization. (#6454) * - Fixed how the area light influence volume is computed to match rasterization. * Fix issue in the axis order * Update DebugDisplay.cs (#6467) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Adding 5 automated test scenes (#6483) * Sharing more code for light data building (RT) and building a more optimal atlas (#6370) * - Sharing GetLightData code between rasterization and ray tracing to avoid duplication and lack of features - Inject all lights at the same time (rasterization and ray tracing) into the cookie atlas to avoid waste of space. - Added a test scene to make sure it works properly * correcting debug mistake * Forgot to add the screenshot and to enable the test in the editor build settings * - Fixed usage of light size data that are not available at runtime. (#6489) * Hdrp /lookdev ui fixes (#6491) * Fix no environment text wraping * Add missing toolbar tooltips * Fix camera button-dropdown layout * Fix uss loss at domain reload * Update CHANGELOG.md * Fix custom pass depth copy (#6484) * Fixed the depth buffer copy made before custom pass after opaque and normal injection point * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6479) * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on (#6473) * Use different hash to prevent the perennial dirtying of baked probes. * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp /fix drag area width at left of light intensity (#6471) * Fix drag area width at left of light's intensity * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp /fix reset of HDAdditionalLightData (#6453) * fix type resolving issue when reseting HDAdditionalLightdata * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Add option to disable XR rendering on the camera settings (#6372) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix unused leftover (#6497) * Split HDRP Test scene 1900 in two scene (#6498) * Fix custom pass test reference images (#6512) * Updated ref image for PT fog test (5005). (#6513) * Review corrections for previous PR (#6494) * Fixed an usage of a a compute buffer not bound (1229964) (#6476) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520) Fixing an issue with sub-surface scattering and updating screenshots * fix typo (#6500) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. * Update changelog. * Additional fix for regular inspector * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. * Update changelog * Removed wrongly serialized fields in StaticLightingSky (#6441) * Removed unnecessarily serialized members in StaticLightingSky component. * Update changelog * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504) * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix a compilation issue to to a backport that did not go well. (#9) * Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31) * Clamp probes compression factor to 0 (#19) * Clamp to positive * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * path validation when creating new volume profile (#36) * Validate whole path when creating new profile * Changelog Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com> * Alpha to coverage frame setting (#33) * Added FrameSettingsField.AlphaToMask * Changelog + Documentation * Changed field index * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41) * AxF: Add support for specular AA from geometric curvature. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights. * AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe. * AxF: Use get scalar roughness function to factor out code. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * Add changelog entries. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement constant buffers for HDRP global variables. (#52) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Fixed color/depth pyramid debug * Cleanup * Small fix * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Add Performance framework package and HDRP performance tests (#45) * Added performance test project * Added new test scene system and memory p[rofiling * Added shader analysis package * Create symlink folder in library directory * Update editor window * Update shader analysis selection * Added CLI utility to execute shader analysis reports * Added example for the cli * Removed problematic HDRP graphic test packages * Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903) * Update memory profiling test sample count * Update shader graph support * Updated project settings * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Use background job API and improved progress reporting * Empty commit for Performance reports * Updated ui * Empty commit for Performance reports * Empty commit for Performance reports * Added filter on shader pass and variants * Added option to only generate shader variants * Empty commit for Performance reports * Increase garlic heap size * Begin to add build profiling * Added more build info * Working version of the shader compilation time reporting * wip * Removed useless cli * Added util functions to name test and sample groups * Renamed all markers and finished the build profiling * Update test framework package * Updated shader analysis tests * Updated API * Updated API and log command for compiler * Updated api * Use unknown metric instead of time one as workaround * Enable the CPU profiling API * Fix when deleting an analyzed shader * Load reference on enable * Added shader analysis package * Fixed PS4 test name * Fixed memory unit * Added more test scenes * Force performance tests to run on PS4 base * Fixed sample units and use the same SampleGroup for multiple frames in counter test * Begin to create the graphic perf test * Finished the first version of performance graphic test package * Fixed build tests * Increase static analysis timeout * More timeout * Removed Lit shader static analysis * Fix counters tests * Added performance settings window in project settings * Re-add Forward build test scene * Fixed shader analysis filter * PR fixes * Begin to write the doc * Finished V1 of the performance package doc * Added grafana image and doc description * Updated doc * Maybe fix yamayo tests * Update documentation for static analysis * Added note on core asmdef * Removed debug * Fixed total memory * Added tesselation counters test * Tessellation shadow test * Added per scene settings * Added naming convention doc * Fixed build issue on yamato * Compilation fix to revert * Begin to write the new doc page * Completed performance doc * Fixed build test * Added Lit in static analysis * Removed deferred static analysis Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Hdrp/fix/custom pass msaa rendering info (#42) * Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass AOV API (#50) * Very basic AOV support for custom pass * Updated AOV API for custom passes * Changelog * Update AOV API * API improvements * API documentation * API doc, factorize all push texture calls in RenderCustomPass * added default values and constructor for CustomPassAOVBuffers * fix merge conflicts * Fix GC alloc during rendering: use a for loop instead of findIndex+lambda Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup …

* Hdrp /fix reset of HDAdditionalLightData (#6453) * fix type resolving issue when reseting HDAdditionalLightdata * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Add option to disable XR rendering on the camera settings (#6372) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix unused leftover (#6497) * Split HDRP Test scene 1900 in two scene (#6498) * Fix custom pass test reference images (#6512) * Updated ref image for PT fog test (5005). (#6513) * Review corrections for previous PR (#6494) * Fixed an usage of a a compute buffer not bound (1229964) (#6476) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520) Fixing an issue with sub-surface scattering and updating screenshots * fix typo (#6500) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. * Update changelog. * Additional fix for regular inspector * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. * Update changelog * Removed wrongly serialized fields in StaticLightingSky (#6441) * Removed unnecessarily serialized members in StaticLightingSky component. * Update changelog * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504) * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix a compilation issue to to a backport that did not go well. (#9) * Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31) * Clamp probes compression factor to 0 (#19) * Clamp to positive * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * path validation when creating new volume profile (#36) * Validate whole path when creating new profile * Changelog Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com> * Alpha to coverage frame setting (#33) * Added FrameSettingsField.AlphaToMask * Changelog + Documentation * Changed field index * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41) * AxF: Add support for specular AA from geometric curvature. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights. * AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe. * AxF: Use get scalar roughness function to factor out code. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * Add changelog entries. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement constant buffers for HDRP global variables. (#52) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Fixed color/depth pyramid debug * Cleanup * Small fix * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Add Performance framework package and HDRP performance tests (#45) * Added performance test project * Added new test scene system and memory p[rofiling * Added shader analysis package * Create symlink folder in library directory * Update editor window * Update shader analysis selection * Added CLI utility to execute shader analysis reports * Added example for the cli * Removed problematic HDRP graphic test packages * Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903) * Update memory profiling test sample count * Update shader graph support * Updated project settings * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Use background job API and improved progress reporting * Empty commit for Performance reports * Updated ui * Empty commit for Performance reports * Empty commit for Performance reports * Added filter on shader pass and variants * Added option to only generate shader variants * Empty commit for Performance reports * Increase garlic heap size * Begin to add build profiling * Added more build info * Working version of the shader compilation time reporting * wip * Removed useless cli * Added util functions to name test and sample groups * Renamed all markers and finished the build profiling * Update test framework package * Updated shader analysis tests * Updated API * Updated API and log command for compiler * Updated api * Use unknown metric instead of time one as workaround * Enable the CPU profiling API * Fix when deleting an analyzed shader * Load reference on enable * Added shader analysis package * Fixed PS4 test name * Fixed memory unit * Added more test scenes * Force performance tests to run on PS4 base * Fixed sample units and use the same SampleGroup for multiple frames in counter test * Begin to create the graphic perf test * Finished the first version of performance graphic test package * Fixed build tests * Increase static analysis timeout * More timeout * Removed Lit shader static analysis * Fix counters tests * Added performance settings window in project settings * Re-add Forward build test scene * Fixed shader analysis filter * PR fixes * Begin to write the doc * Finished V1 of the performance package doc * Added grafana image and doc description * Updated doc * Maybe fix yamayo tests * Update documentation for static analysis * Added note on core asmdef * Removed debug * Fixed total memory * Added tesselation counters test * Tessellation shadow test * Added per scene settings * Added naming convention doc * Fixed build issue on yamato * Compilation fix to revert * Begin to write the new doc page * Completed performance doc * Fixed build test * Added Lit in static analysis * Removed deferred static analysis Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Hdrp/fix/custom pass msaa rendering info (#42) * Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass AOV API (#50) * Very basic AOV support for custom pass * Updated AOV API for custom passes * Changelog * Update AOV API * API improvements * API documentation * API doc, factorize all push texture calls in RenderCustomPass * added default values and constructor for CustomPassAOVBuffers * fix merge conflicts * Fix GC alloc during rendering: use a for loop instead of findIndex+lambda Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the…

* Hdrp /fix reset of HDAdditionalLightData (#6453) * fix type resolving issue when reseting HDAdditionalLightdata * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Add option to disable XR rendering on the camera settings (#6372) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix unused leftover (#6497) * Split HDRP Test scene 1900 in two scene (#6498) * Fix custom pass test reference images (#6512) * Updated ref image for PT fog test (5005). (#6513) * Review corrections for previous PR (#6494) * Fixed an usage of a a compute buffer not bound (1229964) (#6476) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520) Fixing an issue with sub-surface scattering and updating screenshots * fix typo (#6500) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. * Update changelog. * Additional fix for regular inspector * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. * Update changelog * Removed wrongly serialized fields in StaticLightingSky (#6441) * Removed unnecessarily serialized members in StaticLightingSky component. * Update changelog * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504) * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix a compilation issue to to a backport that did not go well. (#9) * Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31) * Clamp probes compression factor to 0 (#19) * Clamp to positive * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * path validation when creating new volume profile (#36) * Validate whole path when creating new profile * Changelog Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com> * Alpha to coverage frame setting (#33) * Added FrameSettingsField.AlphaToMask * Changelog + Documentation * Changed field index * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41) * AxF: Add support for specular AA from geometric curvature. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights. * AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe. * AxF: Use get scalar roughness function to factor out code. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * Add changelog entries. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement constant buffers for HDRP global variables. (#52) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Fixed color/depth pyramid debug * Cleanup * Small fix * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Add Performance framework package and HDRP performance tests (#45) * Added performance test project * Added new test scene system and memory p[rofiling * Added shader analysis package * Create symlink folder in library directory * Update editor window * Update shader analysis selection * Added CLI utility to execute shader analysis reports * Added example for the cli * Removed problematic HDRP graphic test packages * Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903) * Update memory profiling test sample count * Update shader graph support * Updated project settings * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Use background job API and improved progress reporting * Empty commit for Performance reports * Updated ui * Empty commit for Performance reports * Empty commit for Performance reports * Added filter on shader pass and variants * Added option to only generate shader variants * Empty commit for Performance reports * Increase garlic heap size * Begin to add build profiling * Added more build info * Working version of the shader compilation time reporting * wip * Removed useless cli * Added util functions to name test and sample groups * Renamed all markers and finished the build profiling * Update test framework package * Updated shader analysis tests * Updated API * Updated API and log command for compiler * Updated api * Use unknown metric instead of time one as workaround * Enable the CPU profiling API * Fix when deleting an analyzed shader * Load reference on enable * Added shader analysis package * Fixed PS4 test name * Fixed memory unit * Added more test scenes * Force performance tests to run on PS4 base * Fixed sample units and use the same SampleGroup for multiple frames in counter test * Begin to create the graphic perf test * Finished the first version of performance graphic test package * Fixed build tests * Increase static analysis timeout * More timeout * Removed Lit shader static analysis * Fix counters tests * Added performance settings window in project settings * Re-add Forward build test scene * Fixed shader analysis filter * PR fixes * Begin to write the doc * Finished V1 of the performance package doc * Added grafana image and doc description * Updated doc * Maybe fix yamayo tests * Update documentation for static analysis * Added note on core asmdef * Removed debug * Fixed total memory * Added tesselation counters test * Tessellation shadow test * Added per scene settings * Added naming convention doc * Fixed build issue on yamato * Compilation fix to revert * Begin to write the new doc page * Completed performance doc * Fixed build test * Added Lit in static analysis * Removed deferred static analysis Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Hdrp/fix/custom pass msaa rendering info (#42) * Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass AOV API (#50) * Very basic AOV support for custom pass * Updated AOV API for custom passes * Changelog * Update AOV API * API improvements * API documentation * API doc, factorize all push texture calls in RenderCustomPass * added default values and constructor for CustomPassAOVBuffers * fix merge conflicts * Fix GC alloc during rendering: use a for loop instead of findIndex+lambda Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly…

* Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41) * AxF: Add support for specular AA from geometric curvature. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights. * AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe. * AxF: Use get scalar roughness function to factor out code. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * Add changelog entries. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement constant buffers for HDRP global variables. (#52) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Fixed color/depth pyramid debug * Cleanup * Small fix * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Add Performance framework package and HDRP performance tests (#45) * Added performance test project * Added new test scene system and memory p[rofiling * Added shader analysis package * Create symlink folder in library directory * Update editor window * Update shader analysis selection * Added CLI utility to execute shader analysis reports * Added example for the cli * Removed problematic HDRP graphic test packages * Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903) * Update memory profiling test sample count * Update shader graph support * Updated project settings * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Use background job API and improved progress reporting * Empty commit for Performance reports * Updated ui * Empty commit for Performance reports * Empty commit for Performance reports * Added filter on shader pass and variants * Added option to only generate shader variants * Empty commit for Performance reports * Increase garlic heap size * Begin to add build profiling * Added more build info * Working version of the shader compilation time reporting * wip * Removed useless cli * Added util functions to name test and sample groups * Renamed all markers and finished the build profiling * Update test framework package * Updated shader analysis tests * Updated API * Updated API and log command for compiler * Updated api * Use unknown metric instead of time one as workaround * Enable the CPU profiling API * Fix when deleting an analyzed shader * Load reference on enable * Added shader analysis package * Fixed PS4 test name * Fixed memory unit * Added more test scenes * Force performance tests to run on PS4 base * Fixed sample units and use the same SampleGroup for multiple frames in counter test * Begin to create the graphic perf test * Finished the first version of performance graphic test package * Fixed build tests * Increase static analysis timeout * More timeout * Removed Lit shader static analysis * Fix counters tests * Added performance settings window in project settings * Re-add Forward build test scene * Fixed shader analysis filter * PR fixes * Begin to write the doc * Finished V1 of the performance package doc * Added grafana image and doc description * Updated doc * Maybe fix yamayo tests * Update documentation for static analysis * Added note on core asmdef * Removed debug * Fixed total memory * Added tesselation counters test * Tessellation shadow test * Added per scene settings * Added naming convention doc * Fixed build issue on yamato * Compilation fix to revert * Begin to write the new doc page * Completed performance doc * Fixed build test * Added Lit in static analysis * Removed deferred static analysis Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Hdrp/fix/custom pass msaa rendering info (#42) * Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass AOV API (#50) * Very basic AOV support for custom pass * Updated AOV API for custom passes * Changelog * Update AOV API * API improvements * API documentation * API doc, factorize all push texture calls in RenderCustomPass * added default values and constructor for CustomPassAOVBuffers * fix merge conflicts * Fix GC alloc during rendering: use a for loop instead of findIndex+lambda Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screen…

* Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screenshot for 502 recursive rendering disabled test scene * upgrade shader material * Fix transparent movec scene view (#698) * Disable transparent movec when object motion vectors are disabled * changelog * Port (#599) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass API part 2 (#227) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Added the API to override camera rendering * Updated changelog * Updated changelog * Fixed compilation issue * Added custom pass API test scene * Begin to add custom pass override test * Factorized protection function * Update custom pass test scene * Fixed custom pass API doc * Begin to add camera override tests * Fixed camera override in scene view * Finished RenderFrom API fucntions * Fixed XR disable class * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations * Finished to fix the RenderFrom* functions * Moved obsolete execute function into the new one * Update reference images * Added all the API doc * Updated changelog * revert mats * Updated custom clear pass to use the new API * Fixed depth buffer random read/write error * Disable custom pass blur test part * Revert camera pixel rect changes * Rename multi-pass to single pass * Disable custom pass test on vulkan and XR Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix line that got lost in merge (#729) * Porting console fixes to staging (#699) * Path tracer: added support for transparency on the Unlit shader. (#717) * Added support for transparency in Unlit. * Updated Changelog. * Update capture for 5007_PathTracing Unlit Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor related fixes (#730) * Fixes for the compositor test * Enable the compoositor test in build settings * Avoid gc alloc, hide internal components from vomume menu * Vulkan and DX12 screens, adjust compositor UI refresh * Fixed a vulkan and metal warning in the SSGI compute shader. (#715) * - Fixed a vulkan and metal warning in the SSGI compute shader. * - Fixed an exception due to the color pyramid not allocated when SSGI is enabled. - Fixed an issue with the first depth history mip was incorrectly copied. * Fix path traced DoF focusing issue (#732) * Remove mip padding from PlanarReflectionProbeCache.cs * Disable 9702 test nor working + 9041 XR (instable) * Hdrp/pt pass no bsdf data (#710) * Removed direct use of BSDFData in path tracing pass. * Updated changelog. * Fixed float3 typo... * fix metal 9800 reference screnshots * update meta file and testcasefilter * Pre warm RT Handle system so that reallocations are reduced. (#713) * Pre warm rt handle system and initialize to screen width/height * changelog * not all was pushed Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fixes for Graphics tests with Render Graph (#725) * WIP for enabling valid graphics tests with Render Graph. Fixed a lot of gcalloc. * Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled. * First batch of disabled tests. * Fixed decal rendering * Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral) * Revert "First batch of disabled tests." This reverts commit 505924b6967041787c0698b4ede1d158686f990e. * Temp "texture not bound" error fix until bloom is implemented. * Fixed an error when using a stale invalid renderer list handle. Reduced error message spam when encountering an execution error. * Add some debug info to compiled passes and removed wrong refCount++ on passes. * Added possibility to disallow pass pruning Fixed a number of pass pruning issues. * Small fixes * temporarily removed pruning of passes without product * Fixed HDRP asset for test 5009 * Implement alpha copy for post processes * Small render graph error fix for motion vector pass. * Disabled for render graph tests that are currently broken. * Updated yamato with new render graph configurations * Fixed lens distortion * Reenabled 4021 * Revert "Reenabled 4021" This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64. * Revert "Updated yamato with new render graph configurations" This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9. * Revert "Disabled for render graph tests that are currently broken." This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026. * Reverted HDRP test framework files (will go to another PR) * Revert "Fixed HDRP asset for test 5009" This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fix and improvements for ray traced effects (#597) * Adding a minimal lit used for RTGI in peformance mode Dispatch binned rays in 1D instead of 2D Fix an issue with the half resolution Mode for RTGI Only read the geometric attributes that are required using the share pass info and shader graph defines Fix an issue with the color intensity of emissive for performance rtgi * Correct bug with shadow history rejection * reduce the exponential accumulation value a bit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Procedural metering mask that follows target (#723) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * start of procedural mask * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * Some basic version of procedural working * need to switch branch * Exposure target and threshold. * fix merge mess * Fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Added presets quality settings for RTAO and RTGI. (#724) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue in HDRaytracingIndirectDiffuse * fix shader warning in exposure * Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648) * - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). * Simplifying the culling override. * Update 708_ShadowExtendedCulling.png Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Removed reference image for player (unused) in HDRP Test * Update preview naming (#753) * Cloud layer volume override (#461) * Added uv distorsion for …

* re-enable light on tesselation test * enable batcher in HDRP test (Unity-Technologies#2680) * Fix memory leak issue * Improve tracking of RT memory * Update log variant to log level in HDRP asset * Make HDRP shader features local (Unity-Technologies#2663) * Switch to 'shader_feature_local' * Make some keywords non-local due to the size limit of 64 * Undo changes to TerrainLit as apparently the setup code does some weird s*** * remove transparent from shader_feature_local * Can't change Terrain to shader local keyword for "reasons" * Update CHANGELOG.md * Update HDUnlitSubShader.cs * Update CHANGELOG.md * Update HDUnlitSettingsView.cs * Rename LIGHTLOOP_SINGLE_PASS to LIGHTLOOP_DISABLE_TILE_AND_CLUSTER (Unity-Technologies#2688) * Rename LIGHTLOOP_SINGLE_PASS => LIGHTLOOP_DISABLE_TILE_AND_CLUSTER and clean all usage of LIGHTLOOP_TILE_PASS Rename LIGHTLOOP_SINGLE_PASS to LIGHTLOOP_DISABLE_TILE_AND_CLUSTER Change multicompile LIGHTLOOP_SINGLE_PASS LIGHTLOOP_TILE_PASS to multicompile _ LIGHTLOOP_DISABLE_TILE_AND_CLUSTER New behavior, we don't need to define LIGHTLOOP_TILE_PASS anymore to be "tile/cluster". We are tile/cluster by default and need to define LIGHTLOOP_DISABLE_TILE_AND_CLUSTER to have brute force mode. Disabling tile/cluster is only useful for debugging. Previously the code was commented to allow to debug in LightLoopSettings, This PR re-enable the UI to control it but only allow it for deferred, not forward. This allow to clean the various comment (and it doesn't work with shader graph anyway). We keep debug mode only in the case of deferred. So in the future we need to debug with brute force mode the lighting, we need to be in deferred and will not able to debug forward material. which should be fine. * Make Enable Tile And Cluster a deferred only option * Move declaration of pragma vertex and pixel shader (Unity-Technologies#2689) * Rename LIGHTLOOP_SINGLE_PASS => LIGHTLOOP_DISABLE_TILE_AND_CLUSTER and clean all usage of LIGHTLOOP_TILE_PASS Rename LIGHTLOOP_SINGLE_PASS to LIGHTLOOP_DISABLE_TILE_AND_CLUSTER Change multicompile LIGHTLOOP_SINGLE_PASS LIGHTLOOP_TILE_PASS to multicompile _ LIGHTLOOP_DISABLE_TILE_AND_CLUSTER New behavior, we don't need to define LIGHTLOOP_TILE_PASS anymore to be "tile/cluster". We are tile/cluster by default and need to define LIGHTLOOP_DISABLE_TILE_AND_CLUSTER to have brute force mode. Disabling tile/cluster is only useful for debugging. Previously the code was commented to allow to debug in LightLoopSettings, This PR re-enable the UI to control it but only allow it for deferred, not forward. This allow to clean the various comment (and it doesn't work with shader graph anyway). We keep debug mode only in the case of deferred. So in the future we need to debug with brute force mode the lighting, we need to be in deferred and will not able to debug forward material. which should be fine. * Make Enable Tile And Cluster a deferred only option * Move pragma vertex and pixel shader to prepare for raytrace shader * Hdrp master move pragmar vertex (Unity-Technologies#2690) Move SurfaceGradient defines location * Update CHANGELOG.md * call C++ version of CorrelatedColorTemperatureToRGB * Initial implementation of Raytracing for HDRP-master (Unity-Technologies#2691) * Light Cluster Build and Debug Raytraced Reflections Raytraced Ambient Occlusion Raytraced Area Shadows Screen Space jittered 2Dx8 Noise textures Support for Shader Graph Master Node HDLit HD raytracing Environement & Custom Inspector Ao Nvidia denoiser Bilateral Filter for denoising Per-Camera Raytracing Filters Raytracing Manager that handles reconstruction and update Lit and Unlit Shader support Mipmap LODs for raytracing * Minor fix to the HDlitRaytracingPass Shader Graph Master Node * Re-enabling the full lightloop * Supporting more Lit Features properly: - Specular Color - Iridescence - Anisotropy - Clearcoat * Fixing the transmission * Delete Lit.shader.orig * Fix compilation issue after merge * Update HDRaytracingLightCluster.cs * Update AmbientOcclusion.cs * Move raytracing shader variables files * Add preexposure to raytracing pass * Rename completeColor to finalColor * remove INTERSECTION_SHADING define, useless * Remove HAS_LIGHTLOOP include path from ShaderPass * some cleanup in raytrace lit shader graph * Add generation of raytrace visibility pass in master node * rename defaultLayerMask to editorRaytracingFilterLayerMask * Move _RaytracedAreaShadow + add more #if ENABLE_RAYTRACING * rename ShaderVariablesRaytracing to ShaderVariablesRaytracingLightLoop * rename AreaBillateralShadow => AreaBilateralShadow * Create AreaBillateralShadow.compute.meta * remove Area billateral files * change code to use PerceptualRoughnessToRoughness * revert undesired change * Update HDLightUI.cs * Added Support for multi viewport (Unity-Technologies#2700) * Multi viewport support WIP * Fixed motion vector debug * Formatting * Formatting again * Fixed flipY for debug view with cameras with a render texture * Made a function for draw full screen with viewport. * Added graphics test * Fix fog on decals + saturate alpha * Update HDRPPreprocessShaders.cs * Update HDRPPreprocessShaders.cs * Small Fixes to Editor (to enumerate inherited types and filter out abstract ones), + better handling of lists * fix shader variant stripping * Update Pre-exposure for lighting buffer * Fix legacy render path shader compilation issues (already backported) * Hdrp fix depth and color nodes (Unity-Technologies#2714) * Make work SceneColor and SceneDepth nodes in HDRP * Update CHANGELOG.md * Various corrections asked during the initial review of the Raytracing PR (Unity-Technologies#2713) * Various corrections asked during the initial review of the Raytracing code * Removing a duplicate resource bind * Supporting properly double sided and its modes and supporting the cutoff properly * Handle undefined space and let user specify them (LocalToWorld & WorldToLocal node concerned) (Unity-Technologies#76) * Fixed pre-exposure being applied to realtime probes (Unity-Technologies#2717) * Added exposure control to frame settings and disabled it on reflection probes Note: frame settings support on probes seem to be half-broken. * Fixed test ref images * Rename PreExposure -> ExposureControl * Added todo * Add Scene color and depth node tests (Unity-Technologies#2716) * Fix SSR in forward (Unity-Technologies#2718) * Fix SSR in forward * update changelog * Update HDRenderPipeline.cs * - Fixed custom editor of Unlit, HD Unlit and PBR shader graph master node * Fix micro shadowing in forward * Fix time reset (Unity-Technologies#2720) * Update CHANGELOG.md * Don't expose emission for unlit shader * Various fixes and de-commenting the lit and unlit raytracing shader code (Unity-Technologies#2721) * Raytraced Area Shadow Merge Corrections * intersection function for MIS * Added m_LightDataGPUArray and m_LightCullResult to ReleaseResources in HDRaytracingLightCluster * Correcting the alpha test for the hdlit raytracing shader graph * Only Computing raytraced SSAO when required Adding a toggle flag for raytraced shadows * Uncommenting the raytracing subshaders * Corrections to the raytracing shadow disabling * Update HDCameraUI.Skin.cs * Improve Variant Provider interface (Unity-Technologies#73) * Add overridable ComputeVariant function for variant provider * Update changelog * Improve AttributeFromCurve Variant provider & Remove Curl Cellular from listing * Remove ".XYZ" for library naming * Prevent to build a player if no hdrp asset found (Unity-Technologies#2729) * Vector4 Field & Animated Parameter (Unity-Technologies#56) * Clean approach : - Use MultiPropertyField instad of Vector4Field - Use Begin/End property instead of IsAnimated * Fix inspector while resizing * Update changelog + rebuild vfx * Hdrp fix open gl error message (Unity-Technologies#2733) * Fix OpenGL build error not displayed in the editor * Removed useless comments * Camera-relative support for stereo (Unity-Technologies#2719) * WIP - attempt to fix camera-relative directional shadows with stereo * Add ApplyCameraRelativeStereoOffset() to avoid dup code * Fix shadowmaps with camera-relative * shader code cleanup and fixes * refactor C# code for stereo camera-relative * add entry to changelog * move calls to StereoCameraRelativeEyeToCenter to higher level to avoid applying offset twice * HD/Post-processing fixes (Unity-Technologies#2732) * Cleaned up & simplified previous PR on pre-exposure control * Added guard bands to bloom to deal with RTHandle resizing Hack, but better than leaking stuff from the top & left of the screen * Motion blur for PP v3 (Unity-Technologies#2727) * Manual rebase of wip-motion-blur (modified files) * Resubmit editor * Resubmit component * Resubmit shaders * Fixup resource asset * Set intensity to 0 by default * Revert the no motion set to 2.0 * Use Wave Intrinsics tile generation (2x improvement on PS4, 1.5x on Scorpio) * Remove int division * Better threshold for vel prep * Revert (For now) the thresh check on vel prep stage * Refactor parallel reduction code * Getting rid of merged prep and tile * Slight optimization to the wave intrinsic version of the tile generation * [Testing - probably going to revert] Try scalar load for tile max velocity * Revert "[Testing - probably going to revert] Try scalar load for tile max velocity" This reverts commit 844778ac4935d1a5bd3842636b6b468d1c21892f. * [Testing - probably going to revert] Try scalar load for tile max velocity This reverts commit 3dafec82c914d555536ce13c4e1c5ca60fc715dd. * Revert "[Testing - probably going to revert] Try scalar load for tile max velocity" This reverts commit 0416e62182acdb143d380bbf50f793aba2322fb9. * Some messing around with debug vis and weights (nothing useful really, most will be reverted) * Optimize sample count Minimum of 2 samples, but we clamp the number of sample so that we'll never have samples that span less than half a pixel. * Fix few warnings * Reset history flag * Clamp tile coordinates when computing neighbourhood max * Change early out clause in vel prepping * Change blur group size from 8x8 to 16x16. *Much* better (reduce cost by 1/3 in some cases) on Scorpio, slightly better or same on PS4 * PACKING is now not an option anymore, but always the case * Optimize sample count is not an option but always on now * Remove f from float numbers * Move compute velocity and scale rotation by intensity as well * Add clamp of camera rotation and move a bit of things from common to prep * Use texture macros * Make explicit group size variable * Handle "Force no motion" * Better jitter for tiles and update tooltip This reverts commit 95889accd337e93175fa2f2f93c0e318dfbf6db6. * Fixup RTHandle issues when switching to different sized RT * Update UI, update sample count debug mode and a bit of cleanup * Fix tab issue * Convert tabs to spaces * Comment debug symbols pragma * Better name for sample count debug view * Comment on the double direction sampling * Comment on why we set velocity to 2 for "force no motion" * Update MotionBlur.cs * Update MotionBlur.cs * Fix Metal API not allowed by HDRP (Unity-Technologies#2736) * Add enable field to motion blur editor (Unity-Technologies#2737) * turn off post process for stereo (Unity-Technologies#2735) * HDRP emission node, unit intensity and pre-exposure control (Unity-Technologies#2722) * Add Emission Node and pre-exposure control for emission * Removed emission pre-expose percent for terrain * Added emission fields for layered lit and layered lit tesselation * Update CHANGELOG.md * Added Emission Node doc, and unlit emissive UI * Use exp2 instead of PositivePow * Renamed pre-exposure weight to Exposure Weight * Removed EmissionColorHDR and moved GetExposureMultiplier to * Add emissive intensity fields for lit tesselation shader * Better parity for sequential operator (Unity-Technologies#78) * Better parity for sequential operator, Unify Sequential3D with count as first entries too => TODO, add orientable Circle Type & Box Mode * Add #pragma editor_sync_compilation to various editor and first time shader * Update HDRenderPipelineResources.asset * Change cascade shadow map error message (Unity-Technologies#2743) * Fix for case of Template for LINUX compatibility * Optimized uberfx & final pass (Unity-Technologies#2749) Xbox One X (4K): - Uber without bloom and/or dirt: 540µs -> 368µs (32%) - Finalpass: 587µs -> 410µs (30%) * Add tests for motion blur (disabled by default) (Unity-Technologies#2748) * Fix planar reflection issue after merge of multiviewport (Unity-Technologies#2752) * update reference screenshots (Unity-Technologies#2753) * Fix planar reflection issue after merge of multiviewport * Update reference screenshots * fixed issue with PBR master node not using correct geometric normal * Fix issue with mircoshadow and specular occlusion when LightLayers is enabled (Unity-Technologies#2757) * fix microshadowing with specular occlusoin and lightlayers * Update SimpleLit.hlsl * Added color grading curves (YRGB + secondaries) (Unity-Technologies#2759) * HDRP shader graph HD render queues (Unity-Technologies#2750) * Added HDMaterialTags to generate shader tags in shader graphs * Added an error message for objects that have refraction and BeforeRefraction render pass Plus added a renderpass combobox for unlit shader graph node * Remove useless comment * Fix shader graph render pass update when switching opaque/transparent * Fix transparent render queue generation * Fixed HDRP shader compilation * Fixed scaleY in ConnectTarget (was broken when size != 1.0) (Unity-Technologies#79) * Fixed scaleY in ConnectTarget (was broken when size != 1.0) * Added changes to changelog * Fixing the Lit warnings due to Improved moment shadows (Unity-Technologies#2762) * Material validator hdrp (Unity-Technologies#2738) * Material validator using Debug Display for HDRP * Update changlog Update changelog to include material validation * Update based on PR feedback * Update code with PR feedback - Rename validation method * Update CHANGELOG.md * Update CHANGELOG.md * Fix compilation issue + rename mode to diffuseColor / SpecularColor * Update string in UI * More renaming * Fix typo * Disable Motion blur via intensity instead of checkbox (Unity-Technologies#2765) * Disable mb via intensity * Ooopsie * Update for 32 threads in wavefronts on Switch. (Unity-Technologies#2724) * Update for 32 threads in wavefronts on Switch. * removed SORTLIST() and unecessary GroupMemoryBarrierWithGroupSync() to get parity with PS4/XB1. * Moved thread group size to 32 threads on Switch (minor speed up from 0.66ms to 0.55ms). * Encapsulated optimal thread group size into a #define. PS4, XB1 and Switch can take advantage of the optimal group size. * Removed obsolete comment (the file is not autogenerated anymore). * Removed debug mode as it causes compiler error on Switch. * Updated comments. * Moved THREAD_GROUP_OPTIMAL_SIZE into platform headers and renamed to PLATFORM_THREAD_GROUP_OPTIMAL_SIZE. * Missing updated file from previous commit. * Added comments. * Use GraphicsFormat instead of RenderTextureFormat (Unity-Technologies#2761) * Move to GraphicsFormat * Fix bug with decals * Use graphics format instead of format in the pool recycler (Unity-Technologies#2767) * Fix RenderQueue update when changing surface type on unlit HD master node (Unity-Technologies#2768) * Fixed serialization of SurfaceThickness setting in Collider Depth * Fix legacy shader build * Update depth and color node tests for HDRP (Unity-Technologies#2771) * Vfx/fix/ui fixes (Unity-Technologies#81) * Fix exception when a port having edge is removed. * Refactor ContextUI RefreshContext * Fix for block edges not disappearing. * fix for RefreshContext refactor * fix slider to change value directly on click. * Fix index when adding new block. * fix toobar item alignement. * No longer restore global selection when window is focused( because we receive a focus event even when only one of the docked panel in our window is focused ). * New iteration on gizmo : make it compatible with new property storage ( property stored only if overridden ) . Fix local/world on component gizmo once again. * Gizmos : automatically add new property if the gizmo is modified and the value of the gizmo was not overridden yet. * Unprepare the visual effect editor gizmos when the state of an overridden property has changed. * Blackboard now shows level two and more of subproperties (for example ArcCircle.circle.center / .radius) if expanded * Fix location of new context when dropping a flow edge over the graph [FB:1117090] * [FB:1117127]Opening the Target Component window by clicking on component "edit" updates the state of the toggle "Target GameObject" * Remove second "Visual Effects" menu[1117105] * Put Visual Effect graph into preference category. * Fix for stickynote sliding when dragging a group it is in. * Fix case where view can't be found in anchor AttachToPanelEvent * make sure input and output slot are at the same height * hide divider on contexts when there is no settings. * Fix block selection border margins. * Hide settings dvider if the node has no settings. * Switch to new notification API for scene view in slotcontainereditor. * Rotate scale gizmo. * Added Depth sampling modes to the scene depth node (Unity-Technologies#2740) * Added Depth sampling modes to the scene depth node * Fix eye depth mode description * Fixed typos * Update CHANGELOG.md * Fix warning an issue with scenecolor node in hdrp (Unity-Technologies#2774) * Fix warning an issue with scenecolor node in hdrp * Delete InitTestScene636834054956858632.unity.meta delete wrong submited files * Delete InitTestScene636834054956858632.unity delete wrong submited files * revert undesired change * fix for merge * Hdrp/fix shadergraph hdrenderqueue migration (Unity-Technologies#2776) * Fix renderingPass creation along data from prior its existance * Fix renderingPass creation along data from prior its existance (Unlit) * Fix After PostProcessTransparent generated queue text to be base on Transparent * [HDRP] Upgrade FrameSettings (Unity-Technologies#2766) * Introduce BitArray utility class * Introduce FrameSettingsAttribute to help inspector and DebugMenu display * Add unit test on BitArray * Refactor FrameSettings and merge LightLoopSettings * Add data migration * Rename and update OverridableFrameSettingsArea UI utility * Introduce FrameSettingsHistory for DebugMenu debugging agregatted values * Fix FrameSettings usage * Fix tooltips of Camera * Fix former unit tests referencing FrameSettings * Update UI * Update DebuggerDisplays * Fix alignment issue in PlanarReflectionProbe and ReflectionProbe inspectors * Easing add of new FrameSettings in UI part based on FrameSettingField attribute * Fix Default non bool FrameSettings * Fix FrameSettings ordering * Fix auto numbering of FrameSettingsFieldAttribute * Fix FrameSettingsHistory and do history field UI * Add DebugMenu generation on the same principe than inspector * Add history in DebugMenu * Clean history activation * Speed up FrameSettingsHistory enabled * Cleaning * QuickFix issue due to PreviewCamera becoming of type Game for no reason. * Add auto fixing broken serialized resources for HDRP. * Update reflection method call for Preview of camera to reflect updated trunk * Add support for multiselection * Missing migration of recently added ExposureControl * Update reflection method call for Preview of PlanarReflectionProbe to reflect updated trunk * Update changelog * Fix issue when adding-removing Scene View tab * Fix typos * Update FrameSettings.Migration.cs * Prenvent very old probes to crash at migration when they have no LightLoopSettings * Prevent SceneCameras to feed several times debug menu when HDRenderPipeline is reconstructed For instance, this occures when we launch graphics tests * Update MiniProfiler and debug menu which was broken * Revert "Update MiniProfiler and debug menu which was broken" This reverts commit 434b5a14f52075cf259f6f4958525a57ff27a390. * Update FrameSettings.cs * Update 2301_Shadow_Mask.unity * Primary Visibility and Area Shadow (plus some additional raytracing features) (Unity-Technologies#2770) * Adding a Raytracing render queue for both transparent and opaque objects Opaque Objects that are in the raytracing queue are rendered in the prepass and not in the deferred/forward passes Adding the primary visibility mode in the raytracing environement Correcting a label in the rt_env_inspector Adding a Debug Mode for raytracing area shadow Adding an equivalent of the ssr lit brdf evaluation Adding a forward raytracing pass for the lit and the unlit Supporting Ior for the lit.shader Implementing a HDRaytracingRenderer that handles primary visibility code Adding resources for the raytracing primary ray Not Pushing a light to the Light cluster if null (has been deleted) Enabling Automatic raytracing scene invalidation on hierarchy change in the editor Using the global command buffer parameter instead of the raytracing one when required for closest hit Adding a texture for the analytic value (required for shadow filtering) Adding default anyhit shaders to ambient occlusion and area shadow raytracing shaders Adding the remainingDepth to the rayintersection structure Adding an input reflection and transmission value for the Raytracing Lightloop and adding them to the evaluation Adding the light dimension to the spherical rectangle Correcting the bias usage for Raytraced AO and Reflection * Refactoring and stabillization changes for the raytracing code * Review corrections * Order in args check for raytracingrenderer * Delete 9601_MotionBlur.meta * Update reference screenshots * Avoid issue with modulo (save actually some computation recycling result of unsigned division anyway) (Unity-Technologies#83) * remove unsupported FormerlySerializedAs in ShaderGraph serialisation (Unity-Technologies#2779) * Hdrp/fix framesettings formerly nullable tests (Unity-Technologies#2781) * Remove test: FrameSettings cannot be null anymore. * Change test: FrameSettings cannot be null anymore. But wrong rendertexture type. * Update 8205 test * Add editor test to cover fixed delta time (using an debug spawner state) (Unity-Technologies#84) * Update graphic test (scene + screenshots) * Update HDCubemapInspector.cs * Vfx/fix/add prefab editor test 1117103 (Unity-Technologies#80) * Add new test with expected failure (commented in l.171 & 172) : Covers simple prefab override from fogbugz 1117103 * Add other test to cover future possible issue due to refactor of serialization cycle in VisualEffect component * Minor : change exposed name * Hdrp master reflection fix (Unity-Technologies#2785) Fix of debug mode with reflection probe * Hdrp/fix framesettings msaa and exposurecontrol (Unity-Technologies#2786) * Add negativeDependency in FrameSettings * Make MSAA's frame settings more user friendly * Fixed sky exposure (Unity-Technologies#2778) Fixed sky exposure * Update CHANGELOG.md * Hdrp/new ambient mode (Unity-Technologies#2630) * - Added AmbientMode enum - Renamed Baking Sky to Static Lighting Sky * Implemented static and dynamic sky ambient probe * Optimized version of AmbientProbeConvolution * Removed manual serialization from static lighting sky * Increased the number of sample to 256 (optimized with LDS on PS4/XBone) * Fixed ambient probe flickering when a preview is displayed * Changelog + Comment fixes * Updated Test data according to static lighting changes * - Fixed deprecated calls - Fixed static lighting when no baking sky is present - Fixed deserialization of former BakingSky component. * Fixes/comments from PR feedback * Removed f from float values in ambient convolution shader. * Refactor to make realtime GI work with ambient static/dynamic modes * Fixed issue with missing skybox material when running tests. * Updated screenshots * Temporarily disabled realtime GI part of test 2102 * Update Screenshots after merge * Update scenes and screenshots * Rebuild vfx * Fix shader compilation issue (Unity-Technologies#2793) * Fix shader compilation issue * remove old def on PS4 * Hdrp/fix framesettings probe overrides and tests (Unity-Technologies#2794) * Make DebuggerDisplay easier to read between FrameSettings and FrameSettingsOverideMask * Fix FrameSettings override for ReflectionProbes * Fix FrameSettings Equals * Fix RandomUtilities.RandomFloat and add RandomEnumValue * Add unit tests for framesettings aggregation * Ammend CameraSettingsUtilitiesTests.ApplySettings test with FrameSettings check * Fix missing ShaderLitMode in FrameSettingsMigration * Added migration test for FrameSettings * update vfx test screenshot for master * Update skyManager with UnityEditor.Lightmapping api changed * Hdrp fix double sided (Unity-Technologies#2798) * Fix the flip for the Lit shader * Move flip normal handling to the resolve point * Remove bitangent flips * Fix the double sided 'None' mode * Unify code of Lit and SG * update init values * comment //#pragma enable_d3d11_debug_symbols * Update reference screenshots * FrameSettings SSR & Raytracing Fixes (Unity-Technologies#2801) * Corrections due to merge issues * SSR FrameSetting condition correction * Update 2103 test * Ambient occlusion raytracing hit distance (Unity-Technologies#2802) Correcting type in the raytracing enable flag * Add inverse lerp node (Unity-Technologies#85) * Corretions for the render queue field in shader graph hdrp shaders (Unity-Technologies#2787) * Corretions for the render queue field in shader graph hdrp shaders * Only display working rendering pass for now for surfacetype * Some cleaning * Fixed issues with realtime probe resolution (Unity-Technologies#2806) * - Fixed an issue where probe target texture wasn't resized properly when changing HDRP asset. - Fixed rendering viewport for probe rendering * Updated obsolete screenshot (exposure issue) * Update changelog * Rebuild vfx * Update bad reference image * Update VFX Test project settings * Revert "Update VFX Test project settings" This reverts commit 9d4e2ec231870b80b35b6afa4be42da0ac4449df. * Revert unwanted changes * Vfx/feature/expose light probe usage (Unity-Technologies#77) * First implementation * Encapsulate all VFX renderer related inspector stuff in RendererEditor class * Add proxy override and probe anchor settings * Update changelog * Fix typo * fix for override check width. * fixed slider field focus * disable blackboard add button is no visualeffect asset is displayed. * Multiple fixes needed when more than one VisualEffect is selected (FB #1110747) (Unity-Technologies#90) * Multiple fixes needed when more than one VisualEffect is selected (FB #1110747) * reseed button give each selected component a different value. * Refactored VFManagerEditor to cache properties. Guess hen reset has been selected to reset shaders and path to sane value. * Fix missing inspector for VisualEffectActivationClip * Use system title first line ( if any ) in Aset inspector output list. * fix exception when restoring a removed context class. * Update VFX * Better Handling of Null or Missing Parameter Binders (Editor + Runtime) (Unity-Technologies#82) * Better Handling of Null or Missing Parameter Binders (Editor + Runtime) * Better Handling of Null or Missing Parameter Binders (Editor + Runtime) * Fix typo: Remove slot from correct model when removing a block * Fix 1110419 + optimize a bit * Fix blend factor not appearing with inherit attribute + bland value is now a [0,1] slider * Add test to cover more VFX awakening (Unity-Technologies#91) Only new editor test, dedicated for 2019.2, no backport, no changelog : * Add some regression test to check visual effect expected serialization behavior * Add check for reset override * Force open Game View while running some tests * Add a failing test of a corner case in prefab * Covers actually failing manipulation of prefab * Vfx/feature/addressing mode sequential (Unity-Technologies#93) * Add addressing mode in Sequential block & Operator * Fix Spaceable (Unity-Technologies#86) * First wip of cleaner way to compute spaceable slot list (cached has been init too soon, leading to impossibility of updating slot) * Fix missing copy space while sanitizing slot * Fix Undo/Redo & Add a regression test * Update Change Log * Minor reverting dirty unwanted changes * - Cover linked slot situation - Fix domain reload case * Rename SpaceSlotConcerned in SlotWithSpaceTransformation * Use specific PropageChildrenReverse * Fix for floatfield overridden when focus. * window OnEnable postpone the loadresource. * Add Invert Transform GPU (Unity-Technologies#94) * Add specific expression for saturate, ceil, frac, round * Add expression for InverseTRSMatrix * Fix hlsl warning * Add operator for inverse & transpose * - Fix VFXExpressionTransformMatrix - Move SDF to Texture folder - Start implementing a new graphicTest * Remove deprecated * Simplify VFXInverseTRSMatrix (GPU) * Fix Operator TransposeMatrix & InvertTRSMatrix * remove deprecated file * Use projection * Add 23_InvertTRSMatrix graphic test * Doesn't use random in gpu event (not really deterministic) & Add reference image * Update 06_Lineoutput (expected change with new expression for frac) * Add comment * Update ChangeLog * *Update reference images * Use Matrix4x4.Inverse3DAffine with 2019.2 or newer * *WIP* Draft for reduction to the saturate operator * Add reduction & test to detect automatically saturate operator * Rename CanBeReducedZeroOneToSature in CanBeReducedToSaturate * Add missing cases for saturate * fix expanded parameter in blockboard appearing when their category is collapsed. * Vfx/fix/fixed random (Unity-Technologies#99) * Fix fixed random * Update changelog * Fix consistency * fix for text alignment within blocks * fix for indeterminate checkbox. * Add new editor test for drag&drop (Unity-Technologies#97) * Create branch & Add new editor test to verify VFXRenderer state while drag & drop (actual fix is in C++) * Make this new test more fair waiting for culling * Simpler test to Verify state (and actually, there are some issue with bound) * Fix missing graph reimport when exception has been thrown (Unity-Technologies#103) * Cosmetic changes to inspector (to ressemble more like HDRP inspectors) (Unity-Technologies#95) * Cosmetic changes to inspector (to ressemble more like HDRP inspectors) * Small fix to get the correct icon when overring a float property override check ( previously the drag to modify value icon was appearing). * Fix category not folding when clicking on the title. * More Fixes for PR * Improve depth buffers blocks + auto reference of buffers for main camera (Unity-Technologies#104) * Add buffer to expressions and CameraType * Fix issues with spaceable when chaning types * Fixes to match C++ * Another attempt to fix InitSpaceable issue * Use camera provided depth buffer in collisions * Temp hook in HDRenderPipeline to copy buffers * Update depth module test * Fix compil * Made Color, Normal and Depth buffers accessible to VFX graphs. * Fix HDRP compilation * Fix ProjectOnDepth block * Fix scene color fetch * Factorize camera blocks + add a settings for camera mode * backout changes in VFXPropertyAttribute * Update and reactivate gfx test * Dont use colorBuffer if not needed * Rename Project on Depth to Position (Depth) for consistancy * Update changelog * Fix editor test * Recompile VFX * Update settings * Deactivate a test because logging in test does not work on Katana * Fixes for VFX Parameter Binder Editor (had to derive from Editor due to recent changes) (Unity-Technologies#105) * Update changelog * Simplify graphicTest to avoid instability (Unity-Technologies#106) * Add TotalTime in PreWarm (Unity-Technologies#96) * Add prewarm total time in inspector * Minor change * New propal for prewarm settings * Fix editor test disabling logging error temporary * LWRP Unlit (without graphicTest) (Unity-Technologies#3174) * Fake project to test legacy (actually an automatic copy of VisualEffectGraph) * Fix build legacy * Add template for LWRP * Remove deprecated Meta * Add missing meta * Remove project folder & use a 7z as backup * Fix missing processCamera (allow particles sorting) & renable decal * Integrate fog function in LWRP * Update changelog * Integrate Vertex Shadow Bias * Fix duplicated line * Revert added function in LWRP * Fix ApplyShadowBias Legacy * Fix missing VFXApplyExposure for LWRP * Recompile all vfx * Fix execption while removing a sub-slot on a dynamic operator (Unity-Technologies#107) * The category name field takes correctly the focus when it is double clicked. * fix for blackboard tooltip width forcing whole blackboard width. * Nitpicking for the edition of systems and context titles. edited title appear exactly on top of the static text, with the correct styling. * Add editor test for rounding & use test case by name for Min/Max * Additional Parameter Binders (Unity-Technologies#87) * Additional Parameter Binders * Fixes + GraphicTest * Fixed audio instability using wav & forcing play state * Remove deprecated meta * Updated Changelog * Rename UnityEngine.VFX.Utils in UnityEngine.Experimental.VFX.Utility * Revert 23_ParameterBinders.unity * Add Reset Call in GraphicTest * Fix changing namespace *wip* this is incorrect serialization behavior, should not happen * Fix AudioClip reference * disable override to detect correctly failure with parameter binders * Make parameter binder stable again * Save it runtime mode * Save vfx after close * Fix graphicTest build * Fix antialiased lines * Fix screen space size block * Rebuild VFX * fix fit to text not working * fix rate field hidden. * Distortion Output + Graphic Test + Changelog (Unity-Technologies#109) * VFX Event Tester (SceneView Window) * Distortion Output + Graphic Test + Changelog * Changes for PR * Removed comment * Removed VF Generator + Block Template generator (Unity-Technologies#110) * Fix Infinite Loop Spawner (case 1135299) (Unity-Technologies#112) * Move CanLink to VFXFlowAnchorController * Add test to avoid loop in graph * Restore duplicate link test (but adding condition for slotIndex) * Add EditorTest for VFXController * Delete problematic files LightingData.asset * Update changelog * Minor : Update comment * Fix SetAttribute initial value (Unity-Technologies#113) * Fix Set Attribute default value & Add test to check this regression (using alpha) * Set default lifeTime value to 1.0 instead of 0.0 * Fix Min_Max_Expression_Folding_TestCase (random failure) * Add comment to explain purpose of a regression test * Remove useless code in VFXOperator * Fix Default Scale Attribute content * Fix case 1126471 : first added value in propertySheet should be mark as overridden (Unity-Technologies#114) * Revert "Fix case 1126471 : first added value in propertySheet should be mark as overridden (Unity-Technologies#114)" (Unity-Technologies#116) This reverts commit 873ab6c5dbafc6d6cf32702163b9def540c12c1c. * Fix case 1126471 : Inspector (Unity-Technologies#117) * Fix case 1126471 : first added value in propertySheet should be mark as overridden * Update ChangeLog.md * Fix hitbox when a category is displayed (Unity-Technologies#115) Pretty minor and obvious, doesn't require review (and no backport needed) * Fix base.OnEnable not called in VectorFieldImporterEditor * Disable Min_Max_Expression_Folding : can't explain the instability for now * Fix exception in inspector due to debug info (case 1141638) * Added Gradient Mapping texture color mode for Unlit outputs (Unity-Technologies#118) * Added Gradient Mapping for Unlit outputs * Fixes for PR * Fixed names * Fix distortion output with planar primitive refactor * Fix GUITests expceptions * Clean previous rev * Forgot missing meta * Motion vector based flipbook interpolation * Fix UV in planar primitives for flipbook interpolation + remove unused file * Fix issue with invalid contexts not being removed from flowk links * Fix merge * Recompile VFX * [1146829] Fix for linking spawner to spawner while first spawner is linked to initialize + test * Fix space of spacable slot not copy pasted + test * Set Attribute Spaceable (Unity-Technologies#119) * Fix for PositionBase block using default Direction attribute instead of newly created Direction * [1152500] Fix for category disappearing in inspector when it is renamed in the blackboard. * [1152496] transfer first texture when converting output if no texture of the same name if found. * Fix conversion of output between planar types. * Fix position circle z (Unity-Technologies#128) * Add exposure weight to HDRP lit outputs * Forgot to update changelog * Force UpdateSubAssets at the end of SantizeGraph

* Move declaration of pragma vertex and pixel shader (Unity-Technologies#2689) * Rename LIGHTLOOP_SINGLE_PASS => LIGHTLOOP_DISABLE_TILE_AND_CLUSTER and clean all usage of LIGHTLOOP_TILE_PASS Rename LIGHTLOOP_SINGLE_PASS to LIGHTLOOP_DISABLE_TILE_AND_CLUSTER Change multicompile LIGHTLOOP_SINGLE_PASS LIGHTLOOP_TILE_PASS to multicompile _ LIGHTLOOP_DISABLE_TILE_AND_CLUSTER New behavior, we don't need to define LIGHTLOOP_TILE_PASS anymore to be "tile/cluster". We are tile/cluster by default and need to define LIGHTLOOP_DISABLE_TILE_AND_CLUSTER to have brute force mode. Disabling tile/cluster is only useful for debugging. Previously the code was commented to allow to debug in LightLoopSettings, This PR re-enable the UI to control it but only allow it for deferred, not forward. This allow to clean the various comment (and it doesn't work with shader graph anyway). We keep debug mode only in the case of deferred. So in the future we need to debug with brute force mode the lighting, we need to be in deferred and will not able to debug forward material. which should be fine. * Make Enable Tile And Cluster a deferred only option * Move pragma vertex and pixel shader to prepare for raytrace shader * Hdrp master move pragmar vertex (Unity-Technologies#2690) Move SurfaceGradient defines location * Update CHANGELOG.md * call C++ version of CorrelatedColorTemperatureToRGB * Initial implementation of Raytracing for HDRP-master (Unity-Technologies#2691) * Light Cluster Build and Debug Raytraced Reflections Raytraced Ambient Occlusion Raytraced Area Shadows Screen Space jittered 2Dx8 Noise textures Support for Shader Graph Master Node HDLit HD raytracing Environement & Custom Inspector Ao Nvidia denoiser Bilateral Filter for denoising Per-Camera Raytracing Filters Raytracing Manager that handles reconstruction and update Lit and Unlit Shader support Mipmap LODs for raytracing * Minor fix to the HDlitRaytracingPass Shader Graph Master Node * Re-enabling the full lightloop * Supporting more Lit Features properly: - Specular Color - Iridescence - Anisotropy - Clearcoat * Fixing the transmission * Delete Lit.shader.orig * Fix compilation issue after merge * Update HDRaytracingLightCluster.cs * Update AmbientOcclusion.cs * Move raytracing shader variables files * Add preexposure to raytracing pass * Rename completeColor to finalColor * remove INTERSECTION_SHADING define, useless * Remove HAS_LIGHTLOOP include path from ShaderPass * some cleanup in raytrace lit shader graph * Add generation of raytrace visibility pass in master node * rename defaultLayerMask to editorRaytracingFilterLayerMask * Move _RaytracedAreaShadow + add more #if ENABLE_RAYTRACING * rename ShaderVariablesRaytracing to ShaderVariablesRaytracingLightLoop * rename AreaBillateralShadow => AreaBilateralShadow * Create AreaBillateralShadow.compute.meta * remove Area billateral files * change code to use PerceptualRoughnessToRoughness * revert undesired change * Update HDLightUI.cs * Added Support for multi viewport (Unity-Technologies#2700) * Multi viewport support WIP * Fixed motion vector debug * Formatting * Formatting again * Fixed flipY for debug view with cameras with a render texture * Made a function for draw full screen with viewport. * Added graphics test * Fix fog on decals + saturate alpha * Update HDRPPreprocessShaders.cs * Update HDRPPreprocessShaders.cs * Small Fixes to Editor (to enumerate inherited types and filter out abstract ones), + better handling of lists * fix shader variant stripping * Update Pre-exposure for lighting buffer * Fix legacy render path shader compilation issues (already backported) * Hdrp fix depth and color nodes (Unity-Technologies#2714) * Make work SceneColor and SceneDepth nodes in HDRP * Update CHANGELOG.md * Various corrections asked during the initial review of the Raytracing PR (Unity-Technologies#2713) * Various corrections asked during the initial review of the Raytracing code * Removing a duplicate resource bind * Supporting properly double sided and its modes and supporting the cutoff properly * Handle undefined space and let user specify them (LocalToWorld & WorldToLocal node concerned) (Unity-Technologies#76) * Fixed pre-exposure being applied to realtime probes (Unity-Technologies#2717) * Added exposure control to frame settings and disabled it on reflection probes Note: frame settings support on probes seem to be half-broken. * Fixed test ref images * Rename PreExposure -> ExposureControl * Added todo * Add Scene color and depth node tests (Unity-Technologies#2716) * Fix SSR in forward (Unity-Technologies#2718) * Fix SSR in forward * update changelog * Update HDRenderPipeline.cs * - Fixed custom editor of Unlit, HD Unlit and PBR shader graph master node * Fix micro shadowing in forward * Fix time reset (Unity-Technologies#2720) * Update CHANGELOG.md * Don't expose emission for unlit shader * Various fixes and de-commenting the lit and unlit raytracing shader code (Unity-Technologies#2721) * Raytraced Area Shadow Merge Corrections * intersection function for MIS * Added m_LightDataGPUArray and m_LightCullResult to ReleaseResources in HDRaytracingLightCluster * Correcting the alpha test for the hdlit raytracing shader graph * Only Computing raytraced SSAO when required Adding a toggle flag for raytraced shadows * Uncommenting the raytracing subshaders * Corrections to the raytracing shadow disabling * Update HDCameraUI.Skin.cs * Improve Variant Provider interface (Unity-Technologies#73) * Add overridable ComputeVariant function for variant provider * Update changelog * Improve AttributeFromCurve Variant provider & Remove Curl Cellular from listing * Remove ".XYZ" for library naming * Prevent to build a player if no hdrp asset found (Unity-Technologies#2729) * Vector4 Field & Animated Parameter (Unity-Technologies#56) * Clean approach : - Use MultiPropertyField instad of Vector4Field - Use Begin/End property instead of IsAnimated * Fix inspector while resizing * Update changelog + rebuild vfx * Hdrp fix open gl error message (Unity-Technologies#2733) * Fix OpenGL build error not displayed in the editor * Removed useless comments * Camera-relative support for stereo (Unity-Technologies#2719) * WIP - attempt to fix camera-relative directional shadows with stereo * Add ApplyCameraRelativeStereoOffset() to avoid dup code * Fix shadowmaps with camera-relative * shader code cleanup and fixes * refactor C# code for stereo camera-relative * add entry to changelog * move calls to StereoCameraRelativeEyeToCenter to higher level to avoid applying offset twice * HD/Post-processing fixes (Unity-Technologies#2732) * Cleaned up & simplified previous PR on pre-exposure control * Added guard bands to bloom to deal with RTHandle resizing Hack, but better than leaking stuff from the top & left of the screen * Motion blur for PP v3 (Unity-Technologies#2727) * Manual rebase of wip-motion-blur (modified files) * Resubmit editor * Resubmit component * Resubmit shaders * Fixup resource asset * Set intensity to 0 by default * Revert the no motion set to 2.0 * Use Wave Intrinsics tile generation (2x improvement on PS4, 1.5x on Scorpio) * Remove int division * Better threshold for vel prep * Revert (For now) the thresh check on vel prep stage * Refactor parallel reduction code * Getting rid of merged prep and tile * Slight optimization to the wave intrinsic version of the tile generation * [Testing - probably going to revert] Try scalar load for tile max velocity * Revert "[Testing - probably going to revert] Try scalar load for tile max velocity" This reverts commit 844778ac4935d1a5bd3842636b6b468d1c21892f. * [Testing - probably going to revert] Try scalar load for tile max velocity This reverts commit 3dafec82c914d555536ce13c4e1c5ca60fc715dd. * Revert "[Testing - probably going to revert] Try scalar load for tile max velocity" This reverts commit 0416e62182acdb143d380bbf50f793aba2322fb9. * Some messing around with debug vis and weights (nothing useful really, most will be reverted) * Optimize sample count Minimum of 2 samples, but we clamp the number of sample so that we'll never have samples that span less than half a pixel. * Fix few warnings * Reset history flag * Clamp tile coordinates when computing neighbourhood max * Change early out clause in vel prepping * Change blur group size from 8x8 to 16x16. *Much* better (reduce cost by 1/3 in some cases) on Scorpio, slightly better or same on PS4 * PACKING is now not an option anymore, but always the case * Optimize sample count is not an option but always on now * Remove f from float numbers * Move compute velocity and scale rotation by intensity as well * Add clamp of camera rotation and move a bit of things from common to prep * Use texture macros * Make explicit group size variable * Handle "Force no motion" * Better jitter for tiles and update tooltip This reverts commit 95889accd337e93175fa2f2f93c0e318dfbf6db6. * Fixup RTHandle issues when switching to different sized RT * Update UI, update sample count debug mode and a bit of cleanup * Fix tab issue * Convert tabs to spaces * Comment debug symbols pragma * Better name for sample count debug view * Comment on the double direction sampling * Comment on why we set velocity to 2 for "force no motion" * Update MotionBlur.cs * Update MotionBlur.cs * Fix Metal API not allowed by HDRP (Unity-Technologies#2736) * Add enable field to motion blur editor (Unity-Technologies#2737) * turn off post process for stereo (Unity-Technologies#2735) * HDRP emission node, unit intensity and pre-exposure control (Unity-Technologies#2722) * Add Emission Node and pre-exposure control for emission * Removed emission pre-expose percent for terrain * Added emission fields for layered lit and layered lit tesselation * Update CHANGELOG.md * Added Emission Node doc, and unlit emissive UI * Use exp2 instead of PositivePow * Renamed pre-exposure weight to Exposure Weight * Removed EmissionColorHDR and moved GetExposureMultiplier to * Add emissive intensity fields for lit tesselation shader * Better parity for sequential operator (Unity-Technologies#78) * Better parity for sequential operator, Unify Sequential3D with count as first entries too => TODO, add orientable Circle Type & Box Mode * Add #pragma editor_sync_compilation to various editor and first time shader * Update HDRenderPipelineResources.asset * Change cascade shadow map error message (Unity-Technologies#2743) * Fix for case of Template for LINUX compatibility * Optimized uberfx & final pass (Unity-Technologies#2749) Xbox One X (4K): - Uber without bloom and/or dirt: 540µs -> 368µs (32%) - Finalpass: 587µs -> 410µs (30%) * Add tests for motion blur (disabled by default) (Unity-Technologies#2748) * Fix planar reflection issue after merge of multiviewport (Unity-Technologies#2752) * update reference screenshots (Unity-Technologies#2753) * Fix planar reflection issue after merge of multiviewport * Update reference screenshots * fixed issue with PBR master node not using correct geometric normal * Fix issue with mircoshadow and specular occlusion when LightLayers is enabled (Unity-Technologies#2757) * fix microshadowing with specular occlusoin and lightlayers * Update SimpleLit.hlsl * Added color grading curves (YRGB + secondaries) (Unity-Technologies#2759) * HDRP shader graph HD render queues (Unity-Technologies#2750) * Added HDMaterialTags to generate shader tags in shader graphs * Added an error message for objects that have refraction and BeforeRefraction render pass Plus added a renderpass combobox for unlit shader graph node * Remove useless comment * Fix shader graph render pass update when switching opaque/transparent * Fix transparent render queue generation * Fixed HDRP shader compilation * Fixed scaleY in ConnectTarget (was broken when size != 1.0) (Unity-Technologies#79) * Fixed scaleY in ConnectTarget (was broken when size != 1.0) * Added changes to changelog * Fixing the Lit warnings due to Improved moment shadows (Unity-Technologies#2762) * Material validator hdrp (Unity-Technologies#2738) * Material validator using Debug Display for HDRP * Update changlog Update changelog to include material validation * Update based on PR feedback * Update code with PR feedback - Rename validation method * Update CHANGELOG.md * Update CHANGELOG.md * Fix compilation issue + rename mode to diffuseColor / SpecularColor * Update string in UI * More renaming * Fix typo * Disable Motion blur via intensity instead of checkbox (Unity-Technologies#2765) * Disable mb via intensity * Ooopsie * Update for 32 threads in wavefronts on Switch. (Unity-Technologies#2724) * Update for 32 threads in wavefronts on Switch. * removed SORTLIST() and unecessary GroupMemoryBarrierWithGroupSync() to get parity with PS4/XB1. * Moved thread group size to 32 threads on Switch (minor speed up from 0.66ms to 0.55ms). * Encapsulated optimal thread group size into a #define. PS4, XB1 and Switch can take advantage of the optimal group size. * Removed obsolete comment (the file is not autogenerated anymore). * Removed debug mode as it causes compiler error on Switch. * Updated comments. * Moved THREAD_GROUP_OPTIMAL_SIZE into platform headers and renamed to PLATFORM_THREAD_GROUP_OPTIMAL_SIZE. * Missing updated file from previous commit. * Added comments. * Use GraphicsFormat instead of RenderTextureFormat (Unity-Technologies#2761) * Move to GraphicsFormat * Fix bug with decals * Use graphics format instead of format in the pool recycler (Unity-Technologies#2767) * Fix RenderQueue update when changing surface type on unlit HD master node (Unity-Technologies#2768) * Fixed serialization of SurfaceThickness setting in Collider Depth * Fix legacy shader build * Update depth and color node tests for HDRP (Unity-Technologies#2771) * Vfx/fix/ui fixes (Unity-Technologies#81) * Fix exception when a port having edge is removed. * Refactor ContextUI RefreshContext * Fix for block edges not disappearing. * fix for RefreshContext refactor * fix slider to change value directly on click. * Fix index when adding new block. * fix toobar item alignement. * No longer restore global selection when window is focused( because we receive a focus event even when only one of the docked panel in our window is focused ). * New iteration on gizmo : make it compatible with new property storage ( property stored only if overridden ) . Fix local/world on component gizmo once again. * Gizmos : automatically add new property if the gizmo is modified and the value of the gizmo was not overridden yet. * Unprepare the visual effect editor gizmos when the state of an overridden property has changed. * Blackboard now shows level two and more of subproperties (for example ArcCircle.circle.center / .radius) if expanded * Fix location of new context when dropping a flow edge over the graph [FB:1117090] * [FB:1117127]Opening the Target Component window by clicking on component "edit" updates the state of the toggle "Target GameObject" * Remove second "Visual Effects" menu[1117105] * Put Visual Effect graph into preference category. * Fix for stickynote sliding when dragging a group it is in. * Fix case where view can't be found in anchor AttachToPanelEvent * make sure input and output slot are at the same height * hide divider on contexts when there is no settings. * Fix block selection border margins. * Hide settings dvider if the node has no settings. * Switch to new notification API for scene view in slotcontainereditor. * Rotate scale gizmo. * Added Depth sampling modes to the scene depth node (Unity-Technologies#2740) * Added Depth sampling modes to the scene depth node * Fix eye depth mode description * Fixed typos * Update CHANGELOG.md * Fix warning an issue with scenecolor node in hdrp (Unity-Technologies#2774) * Fix warning an issue with scenecolor node in hdrp * Delete InitTestScene636834054956858632.unity.meta delete wrong submited files * Delete InitTestScene636834054956858632.unity delete wrong submited files * revert undesired change * fix for merge * Hdrp/fix shadergraph hdrenderqueue migration (Unity-Technologies#2776) * Fix renderingPass creation along data from prior its existance * Fix renderingPass creation along data from prior its existance (Unlit) * Fix After PostProcessTransparent generated queue text to be base on Transparent * [HDRP] Upgrade FrameSettings (Unity-Technologies#2766) * Introduce BitArray utility class * Introduce FrameSettingsAttribute to help inspector and DebugMenu display * Add unit test on BitArray * Refactor FrameSettings and merge LightLoopSettings * Add data migration * Rename and update OverridableFrameSettingsArea UI utility * Introduce FrameSettingsHistory for DebugMenu debugging agregatted values * Fix FrameSettings usage * Fix tooltips of Camera * Fix former unit tests referencing FrameSettings * Update UI * Update DebuggerDisplays * Fix alignment issue in PlanarReflectionProbe and ReflectionProbe inspectors * Easing add of new FrameSettings in UI part based on FrameSettingField attribute * Fix Default non bool FrameSettings * Fix FrameSettings ordering * Fix auto numbering of FrameSettingsFieldAttribute * Fix FrameSettingsHistory and do history field UI * Add DebugMenu generation on the same principe than inspector * Add history in DebugMenu * Clean history activation * Speed up FrameSettingsHistory enabled * Cleaning * QuickFix issue due to PreviewCamera becoming of type Game for no reason. * Add auto fixing broken serialized resources for HDRP. * Update reflection method call for Preview of camera to reflect updated trunk * Add support for multiselection * Missing migration of recently added ExposureControl * Update reflection method call for Preview of PlanarReflectionProbe to reflect updated trunk * Update changelog * Fix issue when adding-removing Scene View tab * Fix typos * Update FrameSettings.Migration.cs * Prenvent very old probes to crash at migration when they have no LightLoopSettings * Prevent SceneCameras to feed several times debug menu when HDRenderPipeline is reconstructed For instance, this occures when we launch graphics tests * Update MiniProfiler and debug menu which was broken * Revert "Update MiniProfiler and debug menu which was broken" This reverts commit 434b5a14f52075cf259f6f4958525a57ff27a390. * Update FrameSettings.cs * Update 2301_Shadow_Mask.unity * Primary Visibility and Area Shadow (plus some additional raytracing features) (Unity-Technologies#2770) * Adding a Raytracing render queue for both transparent and opaque objects Opaque Objects that are in the raytracing queue are rendered in the prepass and not in the deferred/forward passes Adding the primary visibility mode in the raytracing environement Correcting a label in the rt_env_inspector Adding a Debug Mode for raytracing area shadow Adding an equivalent of the ssr lit brdf evaluation Adding a forward raytracing pass for the lit and the unlit Supporting Ior for the lit.shader Implementing a HDRaytracingRenderer that handles primary visibility code Adding resources for the raytracing primary ray Not Pushing a light to the Light cluster if null (has been deleted) Enabling Automatic raytracing scene invalidation on hierarchy change in the editor Using the global command buffer parameter instead of the raytracing one when required for closest hit Adding a texture for the analytic value (required for shadow filtering) Adding default anyhit shaders to ambient occlusion and area shadow raytracing shaders Adding the remainingDepth to the rayintersection structure Adding an input reflection and transmission value for the Raytracing Lightloop and adding them to the evaluation Adding the light dimension to the spherical rectangle Correcting the bias usage for Raytraced AO and Reflection * Refactoring and stabillization changes for the raytracing code * Review corrections * Order in args check for raytracingrenderer * Delete 9601_MotionBlur.meta * Update reference screenshots * Avoid issue with modulo (save actually some computation recycling result of unsigned division anyway) (Unity-Technologies#83) * remove unsupported FormerlySerializedAs in ShaderGraph serialisation (Unity-Technologies#2779) * Hdrp/fix framesettings formerly nullable tests (Unity-Technologies#2781) * Remove test: FrameSettings cannot be null anymore. * Change test: FrameSettings cannot be null anymore. But wrong rendertexture type. * Update 8205 test * Add editor test to cover fixed delta time (using an debug spawner state) (Unity-Technologies#84) * Update graphic test (scene + screenshots) * Update HDCubemapInspector.cs * Vfx/fix/add prefab editor test 1117103 (Unity-Technologies#80) * Add new test with expected failure (commented in l.171 & 172) : Covers simple prefab override from fogbugz 1117103 * Add other test to cover future possible issue due to refactor of serialization cycle in VisualEffect component * Minor : change exposed name * Hdrp master reflection fix (Unity-Technologies#2785) Fix of debug mode with reflection probe * Hdrp/fix framesettings msaa and exposurecontrol (Unity-Technologies#2786) * Add negativeDependency in FrameSettings * Make MSAA's frame settings more user friendly * Fixed sky exposure (Unity-Technologies#2778) Fixed sky exposure * Update CHANGELOG.md * Hdrp/new ambient mode (Unity-Technologies#2630) * - Added AmbientMode enum - Renamed Baking Sky to Static Lighting Sky * Implemented static and dynamic sky ambient probe * Optimized version of AmbientProbeConvolution * Removed manual serialization from static lighting sky * Increased the number of sample to 256 (optimized with LDS on PS4/XBone) * Fixed ambient probe flickering when a preview is displayed * Changelog + Comment fixes * Updated Test data according to static lighting changes * - Fixed deprecated calls - Fixed static lighting when no baking sky is present - Fixed deserialization of former BakingSky component. * Fixes/comments from PR feedback * Removed f from float values in ambient convolution shader. * Refactor to make realtime GI work with ambient static/dynamic modes * Fixed issue with missing skybox material when running tests. * Updated screenshots * Temporarily disabled realtime GI part of test 2102 * Update Screenshots after merge * Update scenes and screenshots * Rebuild vfx * Fix shader compilation issue (Unity-Technologies#2793) * Fix shader compilation issue * remove old def on PS4 * Hdrp/fix framesettings probe overrides and tests (Unity-Technologies#2794) * Make DebuggerDisplay easier to read between FrameSettings and FrameSettingsOverideMask * Fix FrameSettings override for ReflectionProbes * Fix FrameSettings Equals * Fix RandomUtilities.RandomFloat and add RandomEnumValue * Add unit tests for framesettings aggregation * Ammend CameraSettingsUtilitiesTests.ApplySettings test with FrameSettings check * Fix missing ShaderLitMode in FrameSettingsMigration * Added migration test for FrameSettings * update vfx test screenshot for master * Update skyManager with UnityEditor.Lightmapping api changed * Hdrp fix double sided (Unity-Technologies#2798) * Fix the flip for the Lit shader * Move flip normal handling to the resolve point * Remove bitangent flips * Fix the double sided 'None' mode * Unify code of Lit and SG * update init values * comment //#pragma enable_d3d11_debug_symbols * Update reference screenshots * FrameSettings SSR & Raytracing Fixes (Unity-Technologies#2801) * Corrections due to merge issues * SSR FrameSetting condition correction * Update 2103 test * Ambient occlusion raytracing hit distance (Unity-Technologies#2802) Correcting type in the raytracing enable flag * Add inverse lerp node (Unity-Technologies#85) * Corretions for the render queue field in shader graph hdrp shaders (Unity-Technologies#2787) * Corretions for the render queue field in shader graph hdrp shaders * Only display working rendering pass for now for surfacetype * Some cleaning * Fixed issues with realtime probe resolution (Unity-Technologies#2806) * - Fixed an issue where probe target texture wasn't resized properly when changing HDRP asset. - Fixed rendering viewport for probe rendering * Updated obsolete screenshot (exposure issue) * Update changelog * Rebuild vfx * Update bad reference image * Update VFX Test project settings * Revert "Update VFX Test project settings" This reverts commit 9d4e2ec231870b80b35b6afa4be42da0ac4449df. * Revert unwanted changes * Vfx/feature/expose light probe usage (Unity-Technologies#77) * First implementation * Encapsulate all VFX renderer related inspector stuff in RendererEditor class * Add proxy override and probe anchor settings * Update changelog * Fix typo * fix for override check width. * fixed slider field focus * disable blackboard add button is no visualeffect asset is displayed. * Multiple fixes needed when more than one VisualEffect is selected (FB #1110747) (Unity-Technologies#90) * Multiple fixes needed when more than one VisualEffect is selected (FB #1110747) * reseed button give each selected component a different value. * Refactored VFManagerEditor to cache properties. Guess hen reset has been selected to reset shaders and path to sane value. * Fix missing inspector for VisualEffectActivationClip * Use system title first line ( if any ) in Aset inspector output list. * fix exception when restoring a removed context class. * Update VFX * Better Handling of Null or Missing Parameter Binders (Editor + Runtime) (Unity-Technologies#82) * Better Handling of Null or Missing Parameter Binders (Editor + Runtime) * Better Handling of Null or Missing Parameter Binders (Editor + Runtime) * Fix typo: Remove slot from correct model when removing a block * Fix 1110419 + optimize a bit * Fix blend factor not appearing with inherit attribute + bland value is now a [0,1] slider * Add test to cover more VFX awakening (Unity-Technologies#91) Only new editor test, dedicated for 2019.2, no backport, no changelog : * Add some regression test to check visual effect expected serialization behavior * Add check for reset override * Force open Game View while running some tests * Add a failing test of a corner case in prefab * Covers actually failing manipulation of prefab * Vfx/feature/addressing mode sequential (Unity-Technologies#93) * Add addressing mode in Sequential block & Operator * Fix Spaceable (Unity-Technologies#86) * First wip of cleaner way to compute spaceable slot list (cached has been init too soon, leading to impossibility of updating slot) * Fix missing copy space while sanitizing slot * Fix Undo/Redo & Add a regression test * Update Change Log * Minor reverting dirty unwanted changes * - Cover linked slot situation - Fix domain reload case * Rename SpaceSlotConcerned in SlotWithSpaceTransformation * Use specific PropageChildrenReverse * Fix for floatfield overridden when focus. * window OnEnable postpone the loadresource. * Add Invert Transform GPU (Unity-Technologies#94) * Add specific expression for saturate, ceil, frac, round * Add expression for InverseTRSMatrix * Fix hlsl warning * Add operator for inverse & transpose * - Fix VFXExpressionTransformMatrix - Move SDF to Texture folder - Start implementing a new graphicTest * Remove deprecated * Simplify VFXInverseTRSMatrix (GPU) * Fix Operator TransposeMatrix & InvertTRSMatrix * remove deprecated file * Use projection * Add 23_InvertTRSMatrix graphic test * Doesn't use random in gpu event (not really deterministic) & Add reference image * Update 06_Lineoutput (expected change with new expression for frac) * Add comment * Update ChangeLog * *Update reference images * Use Matrix4x4.Inverse3DAffine with 2019.2 or newer * *WIP* Draft for reduction to the saturate operator * Add reduction & test to detect automatically saturate operator * Rename CanBeReducedZeroOneToSature in CanBeReducedToSaturate * Add missing cases for saturate * fix expanded parameter in blockboard appearing when their category is collapsed. * Vfx/fix/fixed random (Unity-Technologies#99) * Fix fixed random * Update changelog * Fix consistency * fix for text alignment within blocks * fix for indeterminate checkbox. * Add new editor test for drag&drop (Unity-Technologies#97) * Create branch & Add new editor test to verify VFXRenderer state while drag & drop (actual fix is in C++) * Make this new test more fair waiting for culling * Simpler test to Verify state (and actually, there are some issue with bound) * Fix missing graph reimport when exception has been thrown (Unity-Technologies#103) * Cosmetic changes to inspector (to ressemble more like HDRP inspectors) (Unity-Technologies#95) * Cosmetic changes to inspector (to ressemble more like HDRP inspectors) * Small fix to get the correct icon when overring a float property override check ( previously the drag to modify value icon was appearing). * Fix category not folding when clicking on the title. * More Fixes for PR * Improve depth buffers blocks + auto reference of buffers for main camera (Unity-Technologies#104) * Add buffer to expressions and CameraType * Fix issues with spaceable when chaning types * Fixes to match C++ * Another attempt to fix InitSpaceable issue * Use camera provided depth buffer in collisions * Temp hook in HDRenderPipeline to copy buffers * Update depth module test * Fix compil * Made Color, Normal and Depth buffers accessible to VFX graphs. * Fix HDRP compilation * Fix ProjectOnDepth block * Fix scene color fetch * Factorize camera blocks + add a settings for camera mode * backout changes in VFXPropertyAttribute * Update and reactivate gfx test * Dont use colorBuffer if not needed * Rename Project on Depth to Position (Depth) for consistancy * Update changelog * Fix editor test * Recompile VFX * Update settings * Deactivate a test because logging in test does not work on Katana * Fixes for VFX Parameter Binder Editor (had to derive from Editor due to recent changes) (Unity-Technologies#105) * Update changelog * Simplify graphicTest to avoid instability (Unity-Technologies#106) * Add TotalTime in PreWarm (Unity-Technologies#96) * Add prewarm total time in inspector * Minor change * New propal for prewarm settings * Fix editor test disabling logging error temporary * LWRP Unlit (without graphicTest) (Unity-Technologies#3174) * Fake project to test legacy (actually an automatic copy of VisualEffectGraph) * Fix build legacy * Add template for LWRP * Remove deprecated Meta * Add missing meta * Remove project folder & use a 7z as backup * Fix missing processCamera (allow particles sorting) & renable decal * Integrate fog function in LWRP * Update changelog * Integrate Vertex Shadow Bias * Fix duplicated line * Revert added function in LWRP * Fix ApplyShadowBias Legacy * Fix missing VFXApplyExposure for LWRP * Recompile all vfx * Fix execption while removing a sub-slot on a dynamic operator (Unity-Technologies#107) * The category name field takes correctly the focus when it is double clicked. * fix for blackboard tooltip width forcing whole blackboard width. * Nitpicking for the edition of systems and context titles. edited title appear exactly on top of the static text, with the correct styling. * Add editor test for rounding & use test case by name for Min/Max * Additional Parameter Binders (Unity-Technologies#87) * Additional Parameter Binders * Fixes + GraphicTest * Fixed audio instability using wav & forcing play state * Remove deprecated meta * Updated Changelog * Rename UnityEngine.VFX.Utils in UnityEngine.Experimental.VFX.Utility * Revert 23_ParameterBinders.unity * Add Reset Call in GraphicTest * Fix changing namespace *wip* this is incorrect serialization behavior, should not happen * Fix AudioClip reference * disable override to detect correctly failure with parameter binders * Make parameter binder stable again * Save it runtime mode * Save vfx after close * Fix graphicTest build * Fix antialiased lines * Fix screen space size block * Rebuild VFX * fix fit to text not working * fix rate field hidden. * Distortion Output + Graphic Test + Changelog (Unity-Technologies#109) * VFX Event Tester (SceneView Window) * Distortion Output + Graphic Test + Changelog * Changes for PR * Removed comment * Removed VF Generator + Block Template generator (Unity-Technologies#110) * Fix Infinite Loop Spawner (case 1135299) (Unity-Technologies#112) * Move CanLink to VFXFlowAnchorController * Add test to avoid loop in graph * Restore duplicate link test (but adding condition for slotIndex) * Add EditorTest for VFXController * Delete problematic files LightingData.asset * Update changelog * Minor : Update comment * Fix SetAttribute initial value (Unity-Technologies#113) * Fix Set Attribute default value & Add test to check this regression (using alpha) * Set default lifeTime value to 1.0 instead of 0.0 * Fix Min_Max_Expression_Folding_TestCase (random failure) * Add comment to explain purpose of a regression test * Remove useless code in VFXOperator * Fix Default Scale Attribute content * Fix case 1126471 : first added value in propertySheet should be mark as overridden (Unity-Technologies#114) * Revert "Fix case 1126471 : first added value in propertySheet should be mark as overridden (Unity-Technologies#114)" (Unity-Technologies#116) This reverts commit 873ab6c5dbafc6d6cf32702163b9def540c12c1c. * Fix case 1126471 : Inspector (Unity-Technologies#117) * Fix case 1126471 : first added value in propertySheet should be mark as overridden * Update ChangeLog.md * Fix hitbox when a category is displayed (Unity-Technologies#115) Pretty minor and obvious, doesn't require review (and no backport needed) * Fix base.OnEnable not called in VectorFieldImporterEditor * Disable Min_Max_Expression_Folding : can't explain the instability for now * Fix exception in inspector due to debug info (case 1141638) * Added Gradient Mapping texture color mode for Unlit outputs (Unity-Technologies#118) * Added Gradient Mapping for Unlit outputs * Fixes for PR * Fixed names * Fix distortion output with planar primitive refactor * Fix GUITests expceptions * Clean previous rev * Forgot missing meta * Motion vector based flipbook interpolation * Fix UV in planar primitives for flipbook interpolation + remove unused file * Fix issue with invalid contexts not being removed from flowk links * Fix merge * Recompile VFX * [1146829] Fix for linking spawner to spawner while first spawner is linked to initialize + test * Fix space of spacable slot not copy pasted + test * Set Attribute Spaceable (Unity-Technologies#119) * Fix for PositionBase block using default Direction attribute instead of newly created Direction * [1152500] Fix for category disappearing in inspector when it is renamed in the blackboard. * [1152496] transfer first texture when converting output if no texture of the same name if found. * Fix conversion of output between planar types. * Fix position circle z (Unity-Technologies#128) * Add exposure weight to HDRP lit outputs * Forgot to update changelog * Force UpdateSubAssets at the end of SantizeGraph * Control Awake Event (Unity-Technologies#123) * Make exposed parameter name delayed. * Change OnDisable to OnDestroy on VFXViewWindow because OnDisable can be called too late, when the graph and the rest have already been disabled. OnDestroy is called as soon as the window is closed * Fix vfx parameters & inspector multiselection (Unity-Technologies#132) * Fix subgraphs issues (compilation, tests and changelog) * Fix software lines * Fix merge * Rebuild VFX * Add missing meta file

* call C++ version of CorrelatedColorTemperatureToRGB * Initial implementation of Raytracing for HDRP-master (Unity-Technologies#2691) * Light Cluster Build and Debug Raytraced Reflections Raytraced Ambient Occlusion Raytraced Area Shadows Screen Space jittered 2Dx8 Noise textures Support for Shader Graph Master Node HDLit HD raytracing Environement & Custom Inspector Ao Nvidia denoiser Bilateral Filter for denoising Per-Camera Raytracing Filters Raytracing Manager that handles reconstruction and update Lit and Unlit Shader support Mipmap LODs for raytracing * Minor fix to the HDlitRaytracingPass Shader Graph Master Node * Re-enabling the full lightloop * Supporting more Lit Features properly: - Specular Color - Iridescence - Anisotropy - Clearcoat * Fixing the transmission * Delete Lit.shader.orig * Fix compilation issue after merge * Update HDRaytracingLightCluster.cs * Update AmbientOcclusion.cs * Move raytracing shader variables files * Add preexposure to raytracing pass * Rename completeColor to finalColor * remove INTERSECTION_SHADING define, useless * Remove HAS_LIGHTLOOP include path from ShaderPass * some cleanup in raytrace lit shader graph * Add generation of raytrace visibility pass in master node * rename defaultLayerMask to editorRaytracingFilterLayerMask * Move _RaytracedAreaShadow + add more #if ENABLE_RAYTRACING * rename ShaderVariablesRaytracing to ShaderVariablesRaytracingLightLoop * rename AreaBillateralShadow => AreaBilateralShadow * Create AreaBillateralShadow.compute.meta * remove Area billateral files * change code to use PerceptualRoughnessToRoughness * revert undesired change * Update HDLightUI.cs * Added Support for multi viewport (Unity-Technologies#2700) * Multi viewport support WIP * Fixed motion vector debug * Formatting * Formatting again * Fixed flipY for debug view with cameras with a render texture * Made a function for draw full screen with viewport. * Added graphics test * Fix fog on decals + saturate alpha * Update HDRPPreprocessShaders.cs * Update HDRPPreprocessShaders.cs * Small Fixes to Editor (to enumerate inherited types and filter out abstract ones), + better handling of lists * fix shader variant stripping * Update Pre-exposure for lighting buffer * Fix legacy render path shader compilation issues (already backported) * Hdrp fix depth and color nodes (Unity-Technologies#2714) * Make work SceneColor and SceneDepth nodes in HDRP * Update CHANGELOG.md * Various corrections asked during the initial review of the Raytracing PR (Unity-Technologies#2713) * Various corrections asked during the initial review of the Raytracing code * Removing a duplicate resource bind * Supporting properly double sided and its modes and supporting the cutoff properly * Handle undefined space and let user specify them (LocalToWorld & WorldToLocal node concerned) (Unity-Technologies#76) * Fixed pre-exposure being applied to realtime probes (Unity-Technologies#2717) * Added exposure control to frame settings and disabled it on reflection probes Note: frame settings support on probes seem to be half-broken. * Fixed test ref images * Rename PreExposure -> ExposureControl * Added todo * Add Scene color and depth node tests (Unity-Technologies#2716) * Fix SSR in forward (Unity-Technologies#2718) * Fix SSR in forward * update changelog * Update HDRenderPipeline.cs * - Fixed custom editor of Unlit, HD Unlit and PBR shader graph master node * Fix micro shadowing in forward * Fix time reset (Unity-Technologies#2720) * Update CHANGELOG.md * Don't expose emission for unlit shader * Various fixes and de-commenting the lit and unlit raytracing shader code (Unity-Technologies#2721) * Raytraced Area Shadow Merge Corrections * intersection function for MIS * Added m_LightDataGPUArray and m_LightCullResult to ReleaseResources in HDRaytracingLightCluster * Correcting the alpha test for the hdlit raytracing shader graph * Only Computing raytraced SSAO when required Adding a toggle flag for raytraced shadows * Uncommenting the raytracing subshaders * Corrections to the raytracing shadow disabling * Update HDCameraUI.Skin.cs * Improve Variant Provider interface (Unity-Technologies#73) * Add overridable ComputeVariant function for variant provider * Update changelog * Improve AttributeFromCurve Variant provider & Remove Curl Cellular from listing * Remove ".XYZ" for library naming * Prevent to build a player if no hdrp asset found (Unity-Technologies#2729) * Vector4 Field & Animated Parameter (Unity-Technologies#56) * Clean approach : - Use MultiPropertyField instad of Vector4Field - Use Begin/End property instead of IsAnimated * Fix inspector while resizing * Update changelog + rebuild vfx * Hdrp fix open gl error message (Unity-Technologies#2733) * Fix OpenGL build error not displayed in the editor * Removed useless comments * Camera-relative support for stereo (Unity-Technologies#2719) * WIP - attempt to fix camera-relative directional shadows with stereo * Add ApplyCameraRelativeStereoOffset() to avoid dup code * Fix shadowmaps with camera-relative * shader code cleanup and fixes * refactor C# code for stereo camera-relative * add entry to changelog * move calls to StereoCameraRelativeEyeToCenter to higher level to avoid applying offset twice * HD/Post-processing fixes (Unity-Technologies#2732) * Cleaned up & simplified previous PR on pre-exposure control * Added guard bands to bloom to deal with RTHandle resizing Hack, but better than leaking stuff from the top & left of the screen * Motion blur for PP v3 (Unity-Technologies#2727) * Manual rebase of wip-motion-blur (modified files) * Resubmit editor * Resubmit component * Resubmit shaders * Fixup resource asset * Set intensity to 0 by default * Revert the no motion set to 2.0 * Use Wave Intrinsics tile generation (2x improvement on PS4, 1.5x on Scorpio) * Remove int division * Better threshold for vel prep * Revert (For now) the thresh check on vel prep stage * Refactor parallel reduction code * Getting rid of merged prep and tile * Slight optimization to the wave intrinsic version of the tile generation * [Testing - probably going to revert] Try scalar load for tile max velocity * Revert "[Testing - probably going to revert] Try scalar load for tile max velocity" This reverts commit 844778ac4935d1a5bd3842636b6b468d1c21892f. * [Testing - probably going to revert] Try scalar load for tile max velocity This reverts commit 3dafec82c914d555536ce13c4e1c5ca60fc715dd. * Revert "[Testing - probably going to revert] Try scalar load for tile max velocity" This reverts commit 0416e62182acdb143d380bbf50f793aba2322fb9. * Some messing around with debug vis and weights (nothing useful really, most will be reverted) * Optimize sample count Minimum of 2 samples, but we clamp the number of sample so that we'll never have samples that span less than half a pixel. * Fix few warnings * Reset history flag * Clamp tile coordinates when computing neighbourhood max * Change early out clause in vel prepping * Change blur group size from 8x8 to 16x16. *Much* better (reduce cost by 1/3 in some cases) on Scorpio, slightly better or same on PS4 * PACKING is now not an option anymore, but always the case * Optimize sample count is not an option but always on now * Remove f from float numbers * Move compute velocity and scale rotation by intensity as well * Add clamp of camera rotation and move a bit of things from common to prep * Use texture macros * Make explicit group size variable * Handle "Force no motion" * Better jitter for tiles and update tooltip This reverts commit 95889accd337e93175fa2f2f93c0e318dfbf6db6. * Fixup RTHandle issues when switching to different sized RT * Update UI, update sample count debug mode and a bit of cleanup * Fix tab issue * Convert tabs to spaces * Comment debug symbols pragma * Better name for sample count debug view * Comment on the double direction sampling * Comment on why we set velocity to 2 for "force no motion" * Update MotionBlur.cs * Update MotionBlur.cs * Fix Metal API not allowed by HDRP (Unity-Technologies#2736) * Add enable field to motion blur editor (Unity-Technologies#2737) * turn off post process for stereo (Unity-Technologies#2735) * HDRP emission node, unit intensity and pre-exposure control (Unity-Technologies#2722) * Add Emission Node and pre-exposure control for emission * Removed emission pre-expose percent for terrain * Added emission fields for layered lit and layered lit tesselation * Update CHANGELOG.md * Added Emission Node doc, and unlit emissive UI * Use exp2 instead of PositivePow * Renamed pre-exposure weight to Exposure Weight * Removed EmissionColorHDR and moved GetExposureMultiplier to * Add emissive intensity fields for lit tesselation shader * Better parity for sequential operator (Unity-Technologies#78) * Better parity for sequential operator, Unify Sequential3D with count as first entries too => TODO, add orientable Circle Type & Box Mode * Add #pragma editor_sync_compilation to various editor and first time shader * Update HDRenderPipelineResources.asset * Change cascade shadow map error message (Unity-Technologies#2743) * Fix for case of Template for LINUX compatibility * Optimized uberfx & final pass (Unity-Technologies#2749) Xbox One X (4K): - Uber without bloom and/or dirt: 540µs -> 368µs (32%) - Finalpass: 587µs -> 410µs (30%) * Add tests for motion blur (disabled by default) (Unity-Technologies#2748) * Fix planar reflection issue after merge of multiviewport (Unity-Technologies#2752) * update reference screenshots (Unity-Technologies#2753) * Fix planar reflection issue after merge of multiviewport * Update reference screenshots * fixed issue with PBR master node not using correct geometric normal * Fix issue with mircoshadow and specular occlusion when LightLayers is enabled (Unity-Technologies#2757) * fix microshadowing with specular occlusoin and lightlayers * Update SimpleLit.hlsl * Added color grading curves (YRGB + secondaries) (Unity-Technologies#2759) * HDRP shader graph HD render queues (Unity-Technologies#2750) * Added HDMaterialTags to generate shader tags in shader graphs * Added an error message for objects that have refraction and BeforeRefraction render pass Plus added a renderpass combobox for unlit shader graph node * Remove useless comment * Fix shader graph render pass update when switching opaque/transparent * Fix transparent render queue generation * Fixed HDRP shader compilation * Fixed scaleY in ConnectTarget (was broken when size != 1.0) (Unity-Technologies#79) * Fixed scaleY in ConnectTarget (was broken when size != 1.0) * Added changes to changelog * Fixing the Lit warnings due to Improved moment shadows (Unity-Technologies#2762) * Material validator hdrp (Unity-Technologies#2738) * Material validator using Debug Display for HDRP * Update changlog Update changelog to include material validation * Update based on PR feedback * Update code with PR feedback - Rename validation method * Update CHANGELOG.md * Update CHANGELOG.md * Fix compilation issue + rename mode to diffuseColor / SpecularColor * Update string in UI * More renaming * Fix typo * Disable Motion blur via intensity instead of checkbox (Unity-Technologies#2765) * Disable mb via intensity * Ooopsie * Update for 32 threads in wavefronts on Switch. (Unity-Technologies#2724) * Update for 32 threads in wavefronts on Switch. * removed SORTLIST() and unecessary GroupMemoryBarrierWithGroupSync() to get parity with PS4/XB1. * Moved thread group size to 32 threads on Switch (minor speed up from 0.66ms to 0.55ms). * Encapsulated optimal thread group size into a #define. PS4, XB1 and Switch can take advantage of the optimal group size. * Removed obsolete comment (the file is not autogenerated anymore). * Removed debug mode as it causes compiler error on Switch. * Updated comments. * Moved THREAD_GROUP_OPTIMAL_SIZE into platform headers and renamed to PLATFORM_THREAD_GROUP_OPTIMAL_SIZE. * Missing updated file from previous commit. * Added comments. * Use GraphicsFormat instead of RenderTextureFormat (Unity-Technologies#2761) * Move to GraphicsFormat * Fix bug with decals * Use graphics format instead of format in the pool recycler (Unity-Technologies#2767) * Fix RenderQueue update when changing surface type on unlit HD master node (Unity-Technologies#2768) * Fixed serialization of SurfaceThickness setting in Collider Depth * Fix legacy shader build * Update depth and color node tests for HDRP (Unity-Technologies#2771) * Vfx/fix/ui fixes (Unity-Technologies#81) * Fix exception when a port having edge is removed. * Refactor ContextUI RefreshContext * Fix for block edges not disappearing. * fix for RefreshContext refactor * fix slider to change value directly on click. * Fix index when adding new block. * fix toobar item alignement. * No longer restore global selection when window is focused( because we receive a focus event even when only one of the docked panel in our window is focused ). * New iteration on gizmo : make it compatible with new property storage ( property stored only if overridden ) . Fix local/world on component gizmo once again. * Gizmos : automatically add new property if the gizmo is modified and the value of the gizmo was not overridden yet. * Unprepare the visual effect editor gizmos when the state of an overridden property has changed. * Blackboard now shows level two and more of subproperties (for example ArcCircle.circle.center / .radius) if expanded * Fix location of new context when dropping a flow edge over the graph [FB:1117090] * [FB:1117127]Opening the Target Component window by clicking on component "edit" updates the state of the toggle "Target GameObject" * Remove second "Visual Effects" menu[1117105] * Put Visual Effect graph into preference category. * Fix for stickynote sliding when dragging a group it is in. * Fix case where view can't be found in anchor AttachToPanelEvent * make sure input and output slot are at the same height * hide divider on contexts when there is no settings. * Fix block selection border margins. * Hide settings dvider if the node has no settings. * Switch to new notification API for scene view in slotcontainereditor. * Rotate scale gizmo. * Added Depth sampling modes to the scene depth node (Unity-Technologies#2740) * Added Depth sampling modes to the scene depth node * Fix eye depth mode description * Fixed typos * Update CHANGELOG.md * Fix warning an issue with scenecolor node in hdrp (Unity-Technologies#2774) * Fix warning an issue with scenecolor node in hdrp * Delete InitTestScene636834054956858632.unity.meta delete wrong submited files * Delete InitTestScene636834054956858632.unity delete wrong submited files * revert undesired change * fix for merge * Hdrp/fix shadergraph hdrenderqueue migration (Unity-Technologies#2776) * Fix renderingPass creation along data from prior its existance * Fix renderingPass creation along data from prior its existance (Unlit) * Fix After PostProcessTransparent generated queue text to be base on Transparent * [HDRP] Upgrade FrameSettings (Unity-Technologies#2766) * Introduce BitArray utility class * Introduce FrameSettingsAttribute to help inspector and DebugMenu display * Add unit test on BitArray * Refactor FrameSettings and merge LightLoopSettings * Add data migration * Rename and update OverridableFrameSettingsArea UI utility * Introduce FrameSettingsHistory for DebugMenu debugging agregatted values * Fix FrameSettings usage * Fix tooltips of Camera * Fix former unit tests referencing FrameSettings * Update UI * Update DebuggerDisplays * Fix alignment issue in PlanarReflectionProbe and ReflectionProbe inspectors * Easing add of new FrameSettings in UI part based on FrameSettingField attribute * Fix Default non bool FrameSettings * Fix FrameSettings ordering * Fix auto numbering of FrameSettingsFieldAttribute * Fix FrameSettingsHistory and do history field UI * Add DebugMenu generation on the same principe than inspector * Add history in DebugMenu * Clean history activation * Speed up FrameSettingsHistory enabled * Cleaning * QuickFix issue due to PreviewCamera becoming of type Game for no reason. * Add auto fixing broken serialized resources for HDRP. * Update reflection method call for Preview of camera to reflect updated trunk * Add support for multiselection * Missing migration of recently added ExposureControl * Update reflection method call for Preview of PlanarReflectionProbe to reflect updated trunk * Update changelog * Fix issue when adding-removing Scene View tab * Fix typos * Update FrameSettings.Migration.cs * Prenvent very old probes to crash at migration when they have no LightLoopSettings * Prevent SceneCameras to feed several times debug menu when HDRenderPipeline is reconstructed For instance, this occures when we launch graphics tests * Update MiniProfiler and debug menu which was broken * Revert "Update MiniProfiler and debug menu which was broken" This reverts commit 434b5a14f52075cf259f6f4958525a57ff27a390. * Update FrameSettings.cs * Update 2301_Shadow_Mask.unity * Primary Visibility and Area Shadow (plus some additional raytracing features) (Unity-Technologies#2770) * Adding a Raytracing render queue for both transparent and opaque objects Opaque Objects that are in the raytracing queue are rendered in the prepass and not in the deferred/forward passes Adding the primary visibility mode in the raytracing environement Correcting a label in the rt_env_inspector Adding a Debug Mode for raytracing area shadow Adding an equivalent of the ssr lit brdf evaluation Adding a forward raytracing pass for the lit and the unlit Supporting Ior for the lit.shader Implementing a HDRaytracingRenderer that handles primary visibility code Adding resources for the raytracing primary ray Not Pushing a light to the Light cluster if null (has been deleted) Enabling Automatic raytracing scene invalidation on hierarchy change in the editor Using the global command buffer parameter instead of the raytracing one when required for closest hit Adding a texture for the analytic value (required for shadow filtering) Adding default anyhit shaders to ambient occlusion and area shadow raytracing shaders Adding the remainingDepth to the rayintersection structure Adding an input reflection and transmission value for the Raytracing Lightloop and adding them to the evaluation Adding the light dimension to the spherical rectangle Correcting the bias usage for Raytraced AO and Reflection * Refactoring and stabillization changes for the raytracing code * Review corrections * Order in args check for raytracingrenderer * Delete 9601_MotionBlur.meta * Update reference screenshots * Avoid issue with modulo (save actually some computation recycling result of unsigned division anyway) (Unity-Technologies#83) * remove unsupported FormerlySerializedAs in ShaderGraph serialisation (Unity-Technologies#2779) * Hdrp/fix framesettings formerly nullable tests (Unity-Technologies#2781) * Remove test: FrameSettings cannot be null anymore. * Change test: FrameSettings cannot be null anymore. But wrong rendertexture type. * Update 8205 test * Add editor test to cover fixed delta time (using an debug spawner state) (Unity-Technologies#84) * Update graphic test (scene + screenshots) * Update HDCubemapInspector.cs * Vfx/fix/add prefab editor test 1117103 (Unity-Technologies#80) * Add new test with expected failure (commented in l.171 & 172) : Covers simple prefab override from fogbugz 1117103 * Add other test to cover future possible issue due to refactor of serialization cycle in VisualEffect component * Minor : change exposed name * Hdrp master reflection fix (Unity-Technologies#2785) Fix of debug mode with reflection probe * Hdrp/fix framesettings msaa and exposurecontrol (Unity-Technologies#2786) * Add negativeDependency in FrameSettings * Make MSAA's frame settings more user friendly * Fixed sky exposure (Unity-Technologies#2778) Fixed sky exposure * Update CHANGELOG.md * Hdrp/new ambient mode (Unity-Technologies#2630) * - Added AmbientMode enum - Renamed Baking Sky to Static Lighting Sky * Implemented static and dynamic sky ambient probe * Optimized version of AmbientProbeConvolution * Removed manual serialization from static lighting sky * Increased the number of sample to 256 (optimized with LDS on PS4/XBone) * Fixed ambient probe flickering when a preview is displayed * Changelog + Comment fixes * Updated Test data according to static lighting changes * - Fixed deprecated calls - Fixed static lighting when no baking sky is present - Fixed deserialization of former BakingSky component. * Fixes/comments from PR feedback * Removed f from float values in ambient convolution shader. * Refactor to make realtime GI work with ambient static/dynamic modes * Fixed issue with missing skybox material when running tests. * Updated screenshots * Temporarily disabled realtime GI part of test 2102 * Update Screenshots after merge * Update scenes and screenshots * Rebuild vfx * Fix shader compilation issue (Unity-Technologies#2793) * Fix shader compilation issue * remove old def on PS4 * Hdrp/fix framesettings probe overrides and tests (Unity-Technologies#2794) * Make DebuggerDisplay easier to read between FrameSettings and FrameSettingsOverideMask * Fix FrameSettings override for ReflectionProbes * Fix FrameSettings Equals * Fix RandomUtilities.RandomFloat and add RandomEnumValue * Add unit tests for framesettings aggregation * Ammend CameraSettingsUtilitiesTests.ApplySettings test with FrameSettings check * Fix missing ShaderLitMode in FrameSettingsMigration * Added migration test for FrameSettings * update vfx test screenshot for master * Update skyManager with UnityEditor.Lightmapping api changed * Hdrp fix double sided (Unity-Technologies#2798) * Fix the flip for the Lit shader * Move flip normal handling to the resolve point * Remove bitangent flips * Fix the double sided 'None' mode * Unify code of Lit and SG * update init values * comment //#pragma enable_d3d11_debug_symbols * Update reference screenshots * FrameSettings SSR & Raytracing Fixes (Unity-Technologies#2801) * Corrections due to merge issues * SSR FrameSetting condition correction * Update 2103 test * Ambient occlusion raytracing hit distance (Unity-Technologies#2802) Correcting type in the raytracing enable flag * Add inverse lerp node (Unity-Technologies#85) * Corretions for the render queue field in shader graph hdrp shaders (Unity-Technologies#2787) * Corretions for the render queue field in shader graph hdrp shaders * Only display working rendering pass for now for surfacetype * Some cleaning * Fixed issues with realtime probe resolution (Unity-Technologies#2806) * - Fixed an issue where probe target texture wasn't resized properly when changing HDRP asset. - Fixed rendering viewport for probe rendering * Updated obsolete screenshot (exposure issue) * Update changelog * Rebuild vfx * Update bad reference image * Update VFX Test project settings * Revert "Update VFX Test project settings" This reverts commit 9d4e2ec231870b80b35b6afa4be42da0ac4449df. * Revert unwanted changes * Vfx/feature/expose light probe usage (Unity-Technologies#77) * First implementation * Encapsulate all VFX renderer related inspector stuff in RendererEditor class * Add proxy override and probe anchor settings * Update changelog * Fix typo * fix for override check width. * fixed slider field focus * disable blackboard add button is no visualeffect asset is displayed. * Multiple fixes needed when more than one VisualEffect is selected (FB #1110747) (Unity-Technologies#90) * Multiple fixes needed when more than one VisualEffect is selected (FB #1110747) * reseed button give each selected component a different value. * Refactored VFManagerEditor to cache properties. Guess hen reset has been selected to reset shaders and path to sane value. * Fix missing inspector for VisualEffectActivationClip * Use system title first line ( if any ) in Aset inspector output list. * fix exception when restoring a removed context class. * Update VFX * Better Handling of Null or Missing Parameter Binders (Editor + Runtime) (Unity-Technologies#82) * Better Handling of Null or Missing Parameter Binders (Editor + Runtime) * Better Handling of Null or Missing Parameter Binders (Editor + Runtime) * Fix typo: Remove slot from correct model when removing a block * Fix 1110419 + optimize a bit * Fix blend factor not appearing with inherit attribute + bland value is now a [0,1] slider * Add test to cover more VFX awakening (Unity-Technologies#91) Only new editor test, dedicated for 2019.2, no backport, no changelog : * Add some regression test to check visual effect expected serialization behavior * Add check for reset override * Force open Game View while running some tests * Add a failing test of a corner case in prefab * Covers actually failing manipulation of prefab * Vfx/feature/addressing mode sequential (Unity-Technologies#93) * Add addressing mode in Sequential block & Operator * Fix Spaceable (Unity-Technologies#86) * First wip of cleaner way to compute spaceable slot list (cached has been init too soon, leading to impossibility of updating slot) * Fix missing copy space while sanitizing slot * Fix Undo/Redo & Add a regression test * Update Change Log * Minor reverting dirty unwanted changes * - Cover linked slot situation - Fix domain reload case * Rename SpaceSlotConcerned in SlotWithSpaceTransformation * Use specific PropageChildrenReverse * Fix for floatfield overridden when focus. * window OnEnable postpone the loadresource. * Add Invert Transform GPU (Unity-Technologies#94) * Add specific expression for saturate, ceil, frac, round * Add expression for InverseTRSMatrix * Fix hlsl warning * Add operator for inverse & transpose * - Fix VFXExpressionTransformMatrix - Move SDF to Texture folder - Start implementing a new graphicTest * Remove deprecated * Simplify VFXInverseTRSMatrix (GPU) * Fix Operator TransposeMatrix & InvertTRSMatrix * remove deprecated file * Use projection * Add 23_InvertTRSMatrix graphic test * Doesn't use random in gpu event (not really deterministic) & Add reference image * Update 06_Lineoutput (expected change with new expression for frac) * Add comment * Update ChangeLog * *Update reference images * Use Matrix4x4.Inverse3DAffine with 2019.2 or newer * *WIP* Draft for reduction to the saturate operator * Add reduction & test to detect automatically saturate operator * Rename CanBeReducedZeroOneToSature in CanBeReducedToSaturate * Add missing cases for saturate * fix expanded parameter in blockboard appearing when their category is collapsed. * Vfx/fix/fixed random (Unity-Technologies#99) * Fix fixed random * Update changelog * Fix consistency * fix for text alignment within blocks * fix for indeterminate checkbox. * Add new editor test for drag&drop (Unity-Technologies#97) * Create branch & Add new editor test to verify VFXRenderer state while drag & drop (actual fix is in C++) * Make this new test more fair waiting for culling * Simpler test to Verify state (and actually, there are some issue with bound) * Fix missing graph reimport when exception has been thrown (Unity-Technologies#103) * Cosmetic changes to inspector (to ressemble more like HDRP inspectors) (Unity-Technologies#95) * Cosmetic changes to inspector (to ressemble more like HDRP inspectors) * Small fix to get the correct icon when overring a float property override check ( previously the drag to modify value icon was appearing). * Fix category not folding when clicking on the title. * More Fixes for PR * Improve depth buffers blocks + auto reference of buffers for main camera (Unity-Technologies#104) * Add buffer to expressions and CameraType * Fix issues with spaceable when chaning types * Fixes to match C++ * Another attempt to fix InitSpaceable issue * Use camera provided depth buffer in collisions * Temp hook in HDRenderPipeline to copy buffers * Update depth module test * Fix compil * Made Color, Normal and Depth buffers accessible to VFX graphs. * Fix HDRP compilation * Fix ProjectOnDepth block * Fix scene color fetch * Factorize camera blocks + add a settings for camera mode * backout changes in VFXPropertyAttribute * Update and reactivate gfx test * Dont use colorBuffer if not needed * Rename Project on Depth to Position (Depth) for consistancy * Update changelog * Fix editor test * Recompile VFX * Update settings * Deactivate a test because logging in test does not work on Katana * Fixes for VFX Parameter Binder Editor (had to derive from Editor due to recent changes) (Unity-Technologies#105) * Update changelog * Simplify graphicTest to avoid instability (Unity-Technologies#106) * Add TotalTime in PreWarm (Unity-Technologies#96) * Add prewarm total time in inspector * Minor change * New propal for prewarm settings * Fix editor test disabling logging error temporary * LWRP Unlit (without graphicTest) (Unity-Technologies#3174) * Fake project to test legacy (actually an automatic copy of VisualEffectGraph) * Fix build legacy * Add template for LWRP * Remove deprecated Meta * Add missing meta * Remove project folder & use a 7z as backup * Fix missing processCamera (allow particles sorting) & renable decal * Integrate fog function in LWRP * Update changelog * Integrate Vertex Shadow Bias * Fix duplicated line * Revert added function in LWRP * Fix ApplyShadowBias Legacy * Fix missing VFXApplyExposure for LWRP * Recompile all vfx * Fix execption while removing a sub-slot on a dynamic operator (Unity-Technologies#107) * The category name field takes correctly the focus when it is double clicked. * fix for blackboard tooltip width forcing whole blackboard width. * Nitpicking for the edition of systems and context titles. edited title appear exactly on top of the static text, with the correct styling. * Add editor test for rounding & use test case by name for Min/Max * Additional Parameter Binders (Unity-Technologies#87) * Additional Parameter Binders * Fixes + GraphicTest * Fixed audio instability using wav & forcing play state * Remove deprecated meta * Updated Changelog * Rename UnityEngine.VFX.Utils in UnityEngine.Experimental.VFX.Utility * Revert 23_ParameterBinders.unity * Add Reset Call in GraphicTest * Fix changing namespace *wip* this is incorrect serialization behavior, should not happen * Fix AudioClip reference * disable override to detect correctly failure with parameter binders * Make parameter binder stable again * Save it runtime mode * Save vfx after close * Fix graphicTest build * Fix antialiased lines * Fix screen space size block * Rebuild VFX * fix fit to text not working * fix rate field hidden. * Distortion Output + Graphic Test + Changelog (Unity-Technologies#109) * VFX Event Tester (SceneView Window) * Distortion Output + Graphic Test + Changelog * Changes for PR * Removed comment * Removed VF Generator + Block Template generator (Unity-Technologies#110) * Fix Infinite Loop Spawner (case 1135299) (Unity-Technologies#112) * Move CanLink to VFXFlowAnchorController * Add test to avoid loop in graph * Restore duplicate link test (but adding condition for slotIndex) * Add EditorTest for VFXController * Delete problematic files LightingData.asset * Update changelog * Minor : Update comment * Fix SetAttribute initial value (Unity-Technologies#113) * Fix Set Attribute default value & Add test to check this regression (using alpha) * Set default lifeTime value to 1.0 instead of 0.0 * Fix Min_Max_Expression_Folding_TestCase (random failure) * Add comment to explain purpose of a regression test * Remove useless code in VFXOperator * Fix Default Scale Attribute content * Fix case 1126471 : first added value in propertySheet should be mark as overridden (Unity-Technologies#114) * Revert "Fix case 1126471 : first added value in propertySheet should be mark as overridden (Unity-Technologies#114)" (Unity-Technologies#116) This reverts commit 873ab6c5dbafc6d6cf32702163b9def540c12c1c. * Fix case 1126471 : Inspector (Unity-Technologies#117) * Fix case 1126471 : first added value in propertySheet should be mark as overridden * Update ChangeLog.md * Fix hitbox when a category is displayed (Unity-Technologies#115) Pretty minor and obvious, doesn't require review (and no backport needed) * Fix base.OnEnable not called in VectorFieldImporterEditor * Disable Min_Max_Expression_Folding : can't explain the instability for now * Fix exception in inspector due to debug info (case 1141638) * Added Gradient Mapping texture color mode for Unlit outputs (Unity-Technologies#118) * Added Gradient Mapping for Unlit outputs * Fixes for PR * Fixed names * Fix distortion output with planar primitive refactor * Fix GUITests expceptions * Clean previous rev * Forgot missing meta * Motion vector based flipbook interpolation * Fix UV in planar primitives for flipbook interpolation + remove unused file * Fix issue with invalid contexts not being removed from flowk links * Fix merge * Recompile VFX * [1146829] Fix for linking spawner to spawner while first spawner is linked to initialize + test * Fix space of spacable slot not copy pasted + test * Set Attribute Spaceable (Unity-Technologies#119) * Fix for PositionBase block using default Direction attribute instead of newly created Direction * [1152500] Fix for category disappearing in inspector when it is renamed in the blackboard. * [1152496] transfer first texture when converting output if no texture of the same name if found. * Fix conversion of output between planar types. * Fix position circle z (Unity-Technologies#128) * Add exposure weight to HDRP lit outputs * Forgot to update changelog * Force UpdateSubAssets at the end of SantizeGraph * Control Awake Event (Unity-Technologies#123) * Make exposed parameter name delayed. * Change OnDisable to OnDestroy on VFXViewWindow because OnDisable can be called too late, when the graph and the rest have already been disabled. OnDestroy is called as soon as the window is closed * Fix vfx parameters & inspector multiselection (Unity-Technologies#132) * Fix subgraphs issues (compilation, tests and changelog) * Fix software lines * Fix merge * Rebuild VFX * output refactor * Rebuild VFX * Missing meta

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 * [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * fix typo * fix typo 2 * Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284) * [7.x.x Backport] Fix pre/post pass sg properties #82 (#85) * Fix depth pre/post passes not correctly enabled when switching shaders on the material # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs # com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs * Hide prepass and postpass in the material UI # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#306) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Updated raytracing async compute warning. (#304) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog * [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307) * Fixed an error about procedural sky being logged by mistake. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog * [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317) * render until ambient probe is ready * remove comment * changelog * [Backport 7.x.x] Fixed some gcalloc in the debug window (#464) * Fixed some GCAlloc in the debug window # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs * Update changelog * [Backport 7.x.x] Hdrp/small ui update (#466) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs # com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs * update changelog * [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482) * PBR Sky renderer now shares its internal precomputation table between different instances. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs * Doc update * Update changelog * [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs * Update changelog * [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Update changelog * Changed UI name, tooltip, and doc for maximum decals on screen (#232) Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/ * Update Custom-Post-Process.md (#233) * Update HDRP-Features.md (#235) * Hdrp/reflection probe scale perf #252 * HD: Switch to 1920x1080 default standalone resolution (#279) Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res (moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo) * Makes sure quaternion is normalized and valid before converting to ma… #331 * Fix cookie srgb #297 * Updated forward and deferred rendering definitions (#350) * Update Forward-And-Deferred-Rendering.md * Update Forward-And-Deferred-Rendering.md * Update Light-Component.md (#357) * Hd/add layer modification on generated emissive mesh for area light #364 * Update Look-Dev-Environment-Library.md (#365) * Update Volumetric-Lighting.md (#402) Fixes https://fogbugz.unity3d.com/f/cases/1238592 * Hd/fix nullref while removing decal component #416 * Fix issue with Uber Post process shader when alpha is enabled #422 * Fix the bug (#430) * Fix issue causing not all baked reflection probes to be deleted #441 * Updated Decal Projector doc (#477) Updated Limitations section and added a disclaimer about decal shader stripping. * Look Dev docs refactor 2 #484 * [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA #315 * Fix issue with the resolve of motion vectors (#421) * fix issue with ShowPrePassAndPostPass * fix compilation issue in rendergraph * Fixed null reference exception in LookDev when setting the SRP to None #447 * Check reflection probe null pointer before use. (case 1244047) #456 * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Fix few multi-editing issues with Emission UI #473 * Re-enable cubemap thumbnail gen only for d3d11 #487 * Hd/fix undo environmentlibrary lookdev #490 * Added system requirements and frame settings api docs (#510) * Added system requirements and frame settings api doc * Update System-Requirements.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * hide exposure compensation for fixed exposure (#535) * hide exposure compensation for fixed exposure * Update PostProcessSystem.cs * [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522 * Use path relative to package for depth of field #523 * Fix taaFrameIndex and restore TAA tests for XR #534 * Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538) * fix DXR manifest * update reference screenshots * [Backport 7.x.x] Fixed an issue where manipulating the color wheels in a volume component would reset the cursor every time. (#988) * Fixed an issue where manipulating the color wheels in a volume component would reset the cursor every time. * Update changelog * [Backport 7.x.x] Fixed an issue where static sky lighting would not be updated for a new scene until it's reloaded at least once. (#990) * Fixed an issue where static sky lighting would not be updated for a new scene until it's reloaded at least once. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/SkyManager.cs * Update changelog * [Backport 7.x.x] Add defines guards around shadows hlsl files (#1091) * Add guards to shadow includes # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowAlgorithms.hlsl * changelog * [Backport 7.x.x] Fix issue with light layers > 7 in the deferred path (#1093) * Mask layers to consider only the supported 8 bits * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix decal being duplicated in prefab isolation mode. (#1103) * Fixed decals being duplicated in prefab isolation mode. * Fix decals in the player. * Update changelog * Revert "[Backport 7.x.x] Fix decal being duplicated in prefab isolation mode. (#1103)" This reverts commit 5e5ecd9. * Update CHANGELOG.md * Hdrp/docs/volumetric lighting format fix (#628) * Updated volumetric lighting and subsurface scattering docs * Update Override-Diffusion-Profile.md * Adds mention of fidelityfx-cas as requested by AMD (#629) * Update Light-Component.md (#682) * Fix transparent movec scene view #698 * Update HDRP-Camera.md (#706) * Update Reflection-Probe (#790) * Update Reflection-Probe.md * Update Reflection-Probe.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix reflection probe framesettings override #796 * Workaround for GetKernelThreadGroupSizes returning wrong data #760 * Sanitize transparent motion vectors setting #761 * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823 * Force post process parent setting to be before child settings #799 * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Fix warning in HDAdditionalLightData OnValidate #885 * Revert "Fix warning in HDAdditionalLightData OnValidate #885" This reverts commit 1798e28. * Fix warning in HDAdditionalLightData OnValidate #885 * Fix warning in HDAdditionalLightData OnValidate #885 - fix merge issue * Editing volumes via script doc (#884) * Added Volumes API doc * Update Volumes-API.md * Changed terminology back to Volume Override * Added terminology disclaimer * Fix message for metal and ao (#859) * Update HDR information. Also updated format and links. (#853) * Fix issue with the blue line of prefab modifications for Volume mode #860 * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865 * Rename h to hlsl * Change extensions of CAS includes from h to hlsl #961 * Fix SSAO with double sided material and normal mode to none #1043 * fix typo in the Render Pipeline Wizard #1037 * Fix emissive mesh layer mask behaviour #1062 * Fix for area light baked data not updating when changing the gizmo #1075 * Fixed an error when switch area light shape to disk while an emissive… #1112 * Have the PBR Sky not render black when below horizon #1116 * Fix area light gizmo not updating engine side light v2 #1156 * Fix XR single-pass macros in tessellation shaders #1160 * Update Override-Micro-Shadows.md (#1236) * Added disclaimer to volumes (#1247) * Fix XR Display providers not getting zNear and zFar updated on them. #1269 * Moved requirements in toc to make it consistent with URP/VFX #1352 * Docs quality fixes #1445 * Added enable Volume snippet #1477 * Update Volume-Override-Enable-Override.md * Porting console fixes to staging (#699) * Fix some NaNs issues on consoles - fix * [7.x.x Backport] Fix exposure white flash when enabling SSR (#845) * inform postprocess * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fix depth pyramid issues with dynamic resolution (#849) * Port * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed Look Dev with Light Theme (#1101) * Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1104) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Fixed issue when using Custom * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1321) * Fixed an issue where look dev lighting would go black when a new scene is loaded. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Aras Pranckevičius <aras@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> Co-authored-by: robinb-u3d <robinb-u3d@users.noreply.github.com>

…n the asset inside the editor. (#118) * Added OnOpenAssetAttributeMode.Validate * added UNITY_2021_1 * remove the shaders has they are not edited in the editor. * Fix macro

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77) * *Prepare a proper way to test different shadow cases * prepare a shadow graph unlit (modifying alpha) * Add reference data for shadow test * Minimal data for reproduce issue 1259511 * Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define * *Update ShadowMaterial * *Update ShaderGraphShadow.vfx * *Move shader to common testing asset * Add equivalent test for URP * Add graphicTest for URP * *Update reference images * Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting * Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence * Fix incorrect block listing * *Update changelog.md * Fix pass selection for lit effect * Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution * Voluntary add disabled branch on shadow unlit to cover alphaTreshold case * *Minor comment * Fix return alpha clipping (missing actual alpha test enabled) * *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging) * VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.' # Conflicts: # com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template * Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset * *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f) * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288 It was a bad merge Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96) * Fix missing type copy in reduce Tested locally on a PS4 * Add expection to detect unsupported value type * Fix 1154328 - infinite recompile with rand (#93) * Change the way rand expression equality is handled * Refactor a bit * Add editor test * World to Viewport Point & Viewport to World Point operators + Test (#98) * World to Viewport Point & Viewport to World Point operators + Test First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator. Includes a test scene for these 2 operators. * Update CHANGELOG.md Update Changelog * Added documentation md files. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Make null ( not deserializable ) objects part of undo state (#86) * Fix compile loop in vfxoperator (#61) * Update to visual studio package 2.0.2 (#74) * Fix SDF Operators and blocks from PR #88 (#94) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Remove the use of inverse transpose for the "normals" * Restore the Inverse Transpose and modify Collision code * Restore Conform and Collide previous behavior + direction points to the surface * add documentation * Consistent distance and normal handling + ref images * Cleaning + World space stick distance and radius + references * Max scale through expression evaluated on GPU (if needed) * Max3 on CPU * Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91) * Simpler update to use now available ByteAddressBuffer * Temp Workaround a GPU hang We should isolate properly this code. * Proper fix of OOB FetchBuffer * *Update changelog.md * Update assets * Update URP tests assets * More update to assets * Remove old gfx tests images ref * Fix changelog * Fix Construct Matrix on GPU (#102) * Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU * *Update changelog.md * Output Event Helpers (#58) * Base Commit * Moved Files down one folder * Updated Package Configuration, CHANGELOG and documentation * Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour * Small fixes and checks * Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check * Small Fixes * Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly * Other custom Editors + Helpbox * Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in Prefab Spawn * Removed Rerouting Helpers as CopyValuesFrom is broken at the moment. * Fixed ASMDEFs / class accessibility * Updated Documentation * Fixed Class Accessibility for ExposedPropertyDrawer * Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer) Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Add support for Gradient sampling with and without gradient mode #100 * Fix changelog * Fix case 1279294 : Invalid Random per component behavior in spawn context (#107) * Revert "Output Event Helpers" (#110) * Revert "Output Event Helpers (#58)" This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78. * Revert "Fix changelog" This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137. * Fix changelog (missing revert) * Fix changelog : Unexpected carriage return * Point cache: Binary format corrupted due to an extra byte offset (#108) * Point cache header, wait for new line character only (/n) and skip carriage return(/r) An extra trailing new line character was causing an invalid offset in binary point cache files. * Update Changelog * Remove unnecessary files * Fix InvalidCastException when using byte properties in point cache files (#109) * Change casting to byte We were trying to cast an object containing a byte to an int. Also, a better normalization would be dividing by 255. * Update CHANGELOG.md * update asset and scripts * Remove unwanted files * Output Event Helpers (revival) (#111) * Base Commit * Moved Files down one folder * Updated Package Configuration, CHANGELOG and documentation * Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour * Small fixes and checks * Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check * Small Fixes * Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly * Other custom Editors + Helpbox * Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in Prefab Spawn * Removed Rerouting Helpers as CopyValuesFrom is broken at the moment. * Fixed ASMDEFs / class accessibility * Updated Documentation * Fixed Class Accessibility for ExposedPropertyDrawer * Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer) * Revert "Revert "Output Event Helpers" (#110)" This reverts commit e72745d0ce4df6205dffa8aca7332a8afea96880. * Revert "Revert "Output Event Helpers" (#110)" This reverts commit e72745d0ce4df6205dffa8aca7332a8afea96880. * First pass of coding rule validation * Rename VFXOutputEventHandler in VFXOutputEventAbstractHandler Following coding rule from https://ono.unity3d.com/unity-extra/unity-meta/files/@/ReferenceSource/CSharp/Assets/CSharpReference.cs * *Missing rename * Remove useless member * Rework VFXOutputEventPrefabSpawn : - Avoid any inconsistency with transform - Use prefab link when available - Use a lazy approach and lock editable values to editor * Fix issue with "Open Prefab" which was resetting the "Hide Flag" * *Minor cleanup * *Minor Change * Missing DisposeInstance when we are disabling "Execute In Editor" * Fix missing full stop at the end of all tooltips * *Apply auto formatting * Fix spamming null reference error reported by @vlad https://unity.slack.com/archives/GA2Q6JU1X/p1601055259085900?thread_ts=1601044036.085800&cid=GA2Q6JU1X * Safely fallback on Instanciate when InstantiatePrefab returns silently null Instance of prefab within the scene are actually copies because an override could have been applied. * Fix model spawn using NotAPrefab instead of Regular * Expliciter code in VFXOutputEventPrefabSpawn Doesn't change the internal behavior * Minor fix : audio != null isn't equivalent than audio?. * Fix assignement : prevent setting audioSource or rigidBody from a prefab asset * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/111#discussion_r73827 Use explicit DrawOutputEventProperties to avoid multiple serializedObject.Update per Inspector * Minor : remove unexpected carriage return Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> Co-authored-by: Thomas Iché <thomasi@unity3d.com> * Fix spawner set attribute/ custom category (#115) * Fix spawner set attribute/ custom category * Update CHANGELOG.md * Update CHANGELOG.md * Setting ZClip in shadow caster templates (#99) * Setting ZClip in shadow caster templates Shadows from directional lights where culled by the near plane in some cascades Added ZClip [_ZClip] to every PassShadowCaster.template file. * Update CHANGELOG.md Update changelog * Modify graphic test for vfx shadows to test ZClip Added an extra particle mesh output that could potentially be clipped by the near plane in some cascades * Trigger output can start an edge drag [Case 1271691] (#114) * Trigger output can start an edge drag [Case 1271691](https://fogbugz.unity3d.com/f/cases/1271691/) * Update CHANGELOG.md * Fix and reenable test (#117) * Error display in vfx editor (#33) * First commit for link impossible explanation. * Some cleanup, delay before info appear. info appear always in the view. * added error management when linking a GPU operator to a CPU slot. * added uninitilized attribute message with context granularity. * Alert when a context a context slot, a block or a block slot use an attribute that is not initialized, except for a known list of attributes with good default values (TBC). * adding age to the list of attributes with good initial value * fix errorr message bases on vlad feedback. * fix for rebase * use RequireInitialization Flag on attributes instead of list of attribute name with good value. * really remove attribute with good default values. * Fix for rebase * fixes based on PR review * cleanup based on PR comments * Move resources for this PR to Editor Default Resources * fixes for merge * Work on error handling for invalidate * Compile and Invalidate Error works. * add ignore error * Make sure non ignored error are visible at start * make sure error indices are unique. * clear unwanted diffs * Fixes for merge * fixes for uss warnings. * Remove incrorrect code from VFXGraph.cs * Fixes based on PR review. * Removed VFXErrors * Started working on drag ignore for refresherrors * Drag on filed label on refresherrors once. * Slider drag do not trigger a refresh error * Remove debug log. * Removed useless line * Update CHANGELOG.md * Fix editorTest which cover copy/past without a graph attached to the controller * Add missing meta * delete Editor/Resource empty directories and metas * Removed VFXBlockDataAnchor from this branch as a bad merge readded it. Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> * *Add missing reference image & fix changelog bad merde * Fix bad merge : unexpected change in "ConstantBuffer.cs" * Fix non uniform scale test (once again) * Update assets * Update URP assets * Increase error threshold on test 26 (due to sky) * Fix reference images for shadow test * Fix cascaded type popup width (#124) * Fix cascaded type popup width * Update CHANGELOG.md * Be resilient to possible null subgraph references. (#120) * Be resilient to possible null subgraph references. * Update CHANGELOG.md * Update CHANGELOG.md * Fix 101_Exposure on PS4 (#126) * Fix wrong code generation from PSSL * *Update changelog.md * Remove inout BuiltInData which is a bit counter intuitive Bonus : Remove VFXClipFragmentColor which was done twice. * Forbid creation of context in VisualEffectSubgraphBlock through edge … (#119) * Forbid creation of context in VisualEffectSubgraphBlock through edge dropping * Update CHANGELOG.md * Make sure m_DependentDirty is flagged when the strutu change because kExpressionGraphChanged is not send for subgraphs. Cleanup (#121) * Fix overlap in properties (#128) * Fix overlap in properties * Update CHANGELOG.md * Fix bad merge from c72287dfdb8c9b041db6c6d49582241810c73a9b Wrongly formed meta files * Fix Sample installation in URP (#122) * Fix RecreateCopy since subouput are conserved Regression introduced at 273b6e32cac0e7ad19b7c8dbbed08593e39fe4f8 * *Update changelog.md * Four bug fixes for event tester (#123) * Fixe some bugs on event tester window * Update CHANGELOG.md * adding another bugfix * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Fix for displaying error from the creation of a node. (#131) * Fix for displaying error from the creation of a node. * *Add warning for CollisionDepthBuffer Update & Fix Changelog.md * Update message from @vlad suggestion Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757 Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> * Blackboard improvements ( clear unused properties, add output ) (#45) * Added clear unused properties menu * added add button to outputcategories. * unused properties are greyed in the blackboard. * Fix from PR review * Update CHANGELOG.md * Fix * Menu for blackboard separated from menu for Pills no more triple dot menu. * Fix unwanted changelog changes * reset modified icon meta * Delete Parameter in Blackboard deletes all selected parameters. * Fixed weird blackboard field selection behaviour on Windows * Reset the indentLevel at the end of VisualEffectEditor, also better c… (#127) * Reset the indentLevel at the end of VisualEffectEditor, also better criteria for doubling the width when the inspector is not wide enough. * Conserve original enabled state in VisualEffectEditor * Update CHANGELOG.md * Un edit nodes that are collapsed (#133) * Un edit nodes that are collapsed * Update CHANGELOG.md * Update CHANGELOG.md * Fixes https://fogbugz.unity3d.com/f/cases/1268956/ (#125) * Block - Position on SDF (#105) * Initial commit * Update PositionOnSDF.cs * Test scene + new SDF assets * Two step approach for projection, texture margin in expression, new test scene * Performance improvement * Revert "Performance improvement" This reverts commit 42ce897756bcdb3bb279abbd529fa9fe33e49884. * Modify test scene * minor changes * Fixing the output direction * Add graphic tests * Update references * Update CHANGELOG.md * Fast derivatives, outliers killing option, cleaning * Convert line endings * Added docoumentation and supporting media. * Update PositionOnSDF.cs * Filename did not match the class name ... Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix several URP issue (for 10.2) (#116) * *Prepare Scene for new sample reflection test * *Update Scene * Fix Reflection Probe missing edition URP only because SupportedRenderingFeatures.active.reflectionProbes is tested * Filter out rendererPriority if SupportedRenderingFeatures.active.rendererPriority returns false * Fix missing layer option : correctly fallback to the default layer if srpAsset.renderingLayerMaskNames returns null * Prepare test addition for RenderDepth * Fix missing depthpass in URP * *Add test data * *Add Test Data for SubPixelAA * Fix SubPixelAA * Fix missing warning using Proxy Volume with URP * Add two sections in inspector to separate probe setting than additionnal Also add a comment about m_SortingOrder * *Update 014 before moving this to common * Add 014_ScreenSpaceSize to HDRP * *Add graphicTest for URP * *Add Reference images for player * *Add missing meta file * *Add Editor Image reference * *Update changelog.md * Add editor test : Check_VFXRenderer_DefaultRenderingLayerNames * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/116#discussion_r78363 * "Create new VisualEffect Graph" creates a graph from the default template [Case 1279999](https://fogbugz.unity3d.com/f/cases/1279999/) (#113) * fixed spelling (#142) * Positition on SDF - Graphics Tests Fix (#138) * Complete .vfx files and update references * Updated documentation. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Update assets * Fix changelog * More changelog fixes * Add missing warning for other block operator using depth (#140) Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#discussion_r79026 * *Adding missing meta file in TestProject * Missing doc & Deprecate VFXViewModicationProcessor (#143) * Fix missing doc & Deprecate VFXViewModicationProcessor Unexpected public API * *Revert unexpected change * Fix several issue from @lewisjordan - fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79397 - fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79398 * Fix Several issue in Property Binder (#106) * Fix case 1274790 : Use DestroyImmediate when editor isn't playing * Fix case 1247230 : Avoid null exposed property Property entry is modified by UX always not null, however, it requires a default value * Fix case 1274788 : Missing null check in Hierarchy to Attribute Map * Fix case 1248711 : Property window view wasn't working Missing Update, it also fixes Undo/Redo * *Update changelog * Fix compilation when ENABLE_LEGACY_INPUT_MANAGER isn't enabled Should be fix for 10.2 * Fix case 1279471 : Avoid OnMouseDown/Up/... declaration Game scripts or other custom code contains OnMouse_ event handlers. Presence of such handlers might impact performance on handheld devices." when building for Android/IOS * Fix positionDepthOperator ref images * Add one pixel to height in non wide mode so that margin is equal to wide mode. (#145) * Update CHANGELOG.md * Fix API validation * Harmonize Composition in Position / Velocity Blocks (#44) * Base refactor + Attempt to get position from AABox (not working for thickness ATM) * Fixed cone syntax issues + correct computation of AABox direction * Added Variant providers + Composition in Sequential * Updated Variants for Shape Sequential Blocks * Harmonized Namings + added composition to Position Depth * Updated Changelog * Fixes for PR * Fixed Blend Composition in Sequential * Added Direction to PositionSequential * Fixes in Position Circle / Set Blend factor in shapes to 1.0 by default * Used Absolute Box size as expression * Propal for https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files/e029bb9ec37555e70af21a97399774667030c031#r61533 Use case by case approach for direction of AABox * *Temp add test data for graphicTest * Fix ApplyAddressingMode : clamp & mirror was overflowing, mirror has also a wrong pattern * Edit graphicTest * Move 014 to common package * Add 014_PositionBlock in editor test listing * Precompute line_direction in PositionLine Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files#r67908 * *Add reference images * Fix editor test (wrong reference data) * Fix issue introduced at 9c54056a68e9ef90354e969e9baba18aa552f8f4 : Looping correctly the circle See also : https://unity.slack.com/archives/G1BTWN88Z/p1598508170069200?thread_ts=1598429838.039200&cid=G1BTWN88Z * Probably uploaded the wrong image reference for standalone * *Update reference images (I think I mess up twice, I should double check the change in motionVector) * Fix build (VFXExpressionCondition now supports uint) * *Temp* Delete motion vector reference image, should regenerate them from yamato. * Readd reference image using yamato result at b9a04b7424323e0c3801e34c13213c4050f020f1 * *Update changelog Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#discussion_r70582 * Fix PositionTorus when used in vertex shader * Fix multiple definition of UNITY_PI * Fix changelog bad automatic merge * Fix incorrect volume Base radius while computing volume factor on sphere & circle : use fix approach from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/89 using name instead of index See : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#issuecomment-28990 & https://docs.google.com/document/d/1RAVkfmMQA9D_hKkJyt6PKOgRs8JHkjlYRhcfBtIU1Ag/edit?disco=AAAAJ7Z4S18 Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix 1285603 View and Object mode of Shadergraph position node don't return proper values (#141) * Update VFXShaderGraphParticleOutput.cs * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix collapse exception and added automated test (#149) * Misc fixes for vfx shadergraph integrations (#130) * Diffusion profile has PropertyType.Float but isn't castable in Vector1ShaderProperty : safeprof code * Unity serialization produced a beast with object.ReferenceEquals(null) != 0 and instanceID == 0 foolProof code for this * Update CHANGELOG.md * Small fix for collapse test * Some extra security around error feedback (#153) * Prevent exceptions from making notification stay. Prevent exception in errors to potential break the ui * Prevent list from being badly deserialized. * Fix Event connected directly to Output Event (#152) * Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment * Misc fixes in strips (#136) * Vfx/feature/strips improvements (#265) * Add spanwIndexInStrip attribute * Fix particleCountInStrip in Init * Add OrientStrip block * Remove some useless code * Add From Target Position mode in Orient Strip * Update changelog * Fix SpawnOverDistance * Fix reference images * Fix changelog * Merge Orient and OrientStrip blocks * Remove FaceCameraPlane from strips * Sanitize quad strip orientation * Update VFX * Update changelog * Add error feedback * Use IsPerspectiveProjection * Fix GetStripTangent for lines * Add subpixel AA to head and trails template system * Add strip variant for intialize in menu * Fix for errors not appearing after convert output * Update graph version * Fix ribbon VFX * Fix spawnIndexInStrip (tooltip + init) * Fix issue with inspector not triggering OnSettingChanged * Check that a converted output could keep the same flow links. Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Revert adaeba7f20802aa19fe089463e1abfaf2a0488e6 * update vfx * Update URP assets * Update URP ref * Vfx/fix/additional subgraphs 2 (#155) * Updated Changelog * Updated Blocks with Fixes and Missing Workflows * update VFX additions Co-authored-by: Thomas Iché <peeweek@gmail.com> * Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139) * Reindex the TEXCOORD[n] * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix serveral minor issues (#103) Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458987790 Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988272 Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988870 * Update rebuild all script to take subgraph into account * Update VFX assets * Fix URP vfx assets * *WIP graphicTest * Renable exact fixed time option Actual fix in progress, I'm adding a graphicTest to cover problematic behavior. * *Update test effect * Share same graph for both mode TODO : Updat graphicTest frame to allow special case * *Add settings to scale fixed time step * *Update fixed time scene * Fix Event connected directly to Output Event (revival) (#154) * Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment * Fix regression with subgraph * Add Subgraph_Event_Link_To_Spawn editor test * Cover test with prewarm behavior * Fix changelog Add entry in the right place from 0009e5373ddd6927977fc8054e2ab16c14b5e81b * Restore disabled 26_NonUnifomScale due to a wrong merge (need backport to 10.x.x) * *Update 015 settings & Move force paused in testing repro * Move 015_FixedTime to common testing package * Add 015_FixedTime test to HDRP as well * [HDRP] Fix debug view material (albedo/normal/...) (#163) * Fix debug view material TODO : Add GraphicTest * Fix tab/space mix * Add HDRP debug scene * *Add reference image for HDRD_Debug(Property) * *Update changelog.md * Use explicitly layer zero for independant system That's actually the way the runtime assumed * *Add reference image (yamato & local result strictly identical) * Force ui update when shader might be reimported in StaticMeshOutput (#158) * Don't create VFXGraph during import callbacks (#148) * do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation * Add the necessary openasset callback for the system to know if we open the asset inside the editor. (#118) * Added OnOpenAssetAttributeMode.Validate * added UNITY_2021_1 * remove the shaders has they are not edited in the editor. * Fix macro * Select node on create (#166) * Select node on create * Fix for right click in block and add doesn't deselect clicked block * fix for subgraph not being selected on drag and drop * Select converted node/block after convert subgraph * Fix for selection undo separate in some cases. Fixed flow anchor drag context selection. * Fix for undo of add subgraph operator * “Refactor” * "Refactor" bis (some file has been missed) * Dont flag dirty in vfxgraph is the model modified is a copy (#165) * Workflow improvement : Change VisualEffect inspector "Edit" button to "New" when no asset is set. (#173) * Base Commit * Documentation * Updated Changelog * Fixed Typo Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Added excludeFromTAA setting to VFX outputs (#170) * Added excludeFromTAA setting to VFX outputs Added excludeFromTAA setting to VFX outputs. Currently it is only supported in HDRP suboutputs. Required adding ${VFXStencilForward} variable to forward pass templates * Update VFXHDRPSubOutput.cs suport exclude from TAA in transparent only * Added documentation to exclude from TAA property * Graphic test Added graphic test: 32_ExcludeFromTAA * Update graphic test background for better contrast * Update CHANGELOG.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * Missing Reference image for test 32_ExcludeFromTAA * Add test to cover case exposed by 1258022 (#54) * Fix Custom Spawn serialization (#132) * Allow Set Spawn Count & Set Spawn Time TODO : List Spawn count in available variant * Fix reference lost in m_SerializableType No idea of implication of this :-/ * Squashed commit of the following: (retrieve fix from @tristan) commit c24981d7dad15100eb40a92a6a9370e9ba800acd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 17:27:57 2020 +0200 Update message from @vlad suggestion Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757 commit a87ba182b30da7683e31a29048c9f2f3a0312927 Merge: 13b501e15863 296ffd333bcf Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:25:02 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/error-at-creation # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 13b501e158634dfc98b96058723d248cd5d1f34d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:24:27 2020 +0200 *Add warning for CollisionDepthBuffer Update & Fix Changelog.md commit 4bfb1e7c9874d8a9403ca5267d1e10735e52a87b Author: Tristan Genevet <tristan@unity3d.com> Date: Thu Oct 8 18:10:42 2020 +0200 Fix for displaying error from the creation of a node. * Add error feedback on failing custom spawner reference * Revert "Allow Set Spawn Count & Set Spawn Time" This reverts commit 0a6c75cc54072b831dcc56bffc3bbe04734d3324. # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs * Remove unexpected change * *Revert change in changelog * *WIP* add ResolveCustomCallbackInstance Some refactor mark as "TODOPAUL" * Clean implementation : customBehavior & comment * *Add test to cover sanitize before modify references * Change namespace for builtin custom spawner & sanitize * Extend test to verify connexion * *Update changelog.md * Add specific error if customBehavior returns null * Fix corner case when ScriptableObject reference has been lost * Work but not idea with copy/past + potential leak * Better implementation : use directly "MonoScript" * Fix spawnerTest * Rename "Can't found" => "Can't find" * Fix case 1294180 : Error feedback throwing an error while changing capacity (#174) Issue introduced with https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136 And more precisely https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136/commits/27c041da92ec89407ae775fe4c4f24681f156cb8 * [Test] Add test to cover "Thread Group Size" error (#104) * Add test * Add test to cover behavior from case 1271839 * Fix Preset (with exclusion) (#177) * Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog * Fix 1276602 incorrect uchar pcache import (#129) * Base Commit * Updated Documentation with explicit limitations. * Fixed incorrect Merge * Add regression Test * Removed Test as It can't handle Exceptions thrown in Custom Importers * Fixed value divider Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Update gradient test (#151) * Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Sample Point Cache Operator (#92) * Initial commit * Overflow handling options for the user * Addressing mode for overflow to the choice of the user * Foldable to Constant value * Update 09_PointCache.vfx * Added reference images * Remove float-to-integer conversion * Put the choice of the output type in the Inspector only * Simplify output type handling * Sample Point cache != Attribute map => two operators * Update Branch (error .yamato/docs/editor_pinning.png) * Update SamplePointCache.cs * Update 09_PointCache.vfx * Output type set in a cogwheel * Update 09_PointCache.vfx * Revert "Update Branch (error .yamato/docs/editor_pinning.png)" This reverts commit 02f6b6c993c2382bb10669edd16f7d06876a0cbc. * Restore vfx asset * Revert back to using generics for type handling * Update SampleAttributeMap.cs * Reformating + changelog * Update 09_PointCache.vfx * Update SamplePointCache.cs * Refactor of AttributeFromMap using VFXExpressionSampleAttributeMap * Merge branch 'vfx/staging' into vfx/feature/sample-point-cache * Revert "Merge branch 'vfx/staging' into vfx/feature/sample-point-cache" This reverts commit b4a03e182a3e106c2fabc262777615f9c3b94a7e. * Fix point cache vfx + update HDRP vfx * Update URP assets * Fix changelog * Fix Case 1223747 - NaN caused by normal bending (#181) * Update Pass.template * Update CHANGELOG.md * 1293608 - Fix LPPV not working in deferred (#180) * Enable LPPV in HDRP test project * Fix LPPV for gbuffer pass * Add graphics test * Update changelog * Fix 1290493 - Spaceship specific warnings (#176) * Avoid implicit trucation in template + safe normalize setting * Update CHANGELOG.md * Added variants * Delete conditioning on GPU evaluation + conservative safe normalize Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix incorrect compilation condition for linux build (#184) * Fix formatting * Update 26_NonUniformScale kind of sky : gradient instead of procedural * Fix regression from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/176 Issue introduced at 44f497b438b46a54072721d335910bfab3e392ef : Incorrect VFXExpressionCondition See also : https://unity.slack.com/archives/G1BTWN88Z/p1607963794139900?thread_ts=1607955907.136600&cid=G1BTWN88Z * Disable Gradient Sky in 26_NonUniformScale & 33_LightProbe * *Update VFX (newly introduced safeNormalize, default 0) * Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA * Revert "Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA" This reverts commit ddee2e356dc7e529cad2904836fef8a688e546a8. * 32_ExcludeFromTAA : Disable XR * 33_LightProbe : Slighlty increase treshold from 0.0005 to 0.0006 * *Update Image Reference for D312 (mainly missing file) * *Disable 32_ExcludeFromTAA Instability detected. * *Add missing D3D12 image references * Fix GPUEvent & SubGraph (#178) * Fix SelectionHasCompleteSystems Detect correctly if there are dependencies due to GPUEvent (or stripAttribute) * Add allDependenciesIncludingNotCompilable in VFXData This helper is usefull for UI + use it in SelectionHasCompleteSystems * Add note without change the beahvior * Remove debug ToArray() * [Subgraph] Prevent Pasting Context invalid subgraph (#191) * Prevent pasting context within operator/block subgraph * Fix case https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/191#discussion_r102007 Fix Approximate english log warning * Update VFXPaste log message Missing "the" * Fix Mouse Event Binder in player (#175) * Fix missing call to CreateVFXEventAttribute OnValidate is only called in editor, in runtime, we should init cache data with OnEnable * *Update changelog.md * Add editor test to cover Safe Normalize behavior (#189) * Vfx/docs/bugfixes (#188) * Resolved 1272101 * Resolved 1264943 * Removed uncertainty around 'should' * Resolved 1298031 * Added snippets file * Resolved 1292127 * Fixed typos * Resolved 1295296 Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Texture2D Array Layout for Flipbooks (#97) * Initial commit, working for planar primitives only * Increased support to Cube, Decals, Meshes, Lit Planar Primitives, Lit Meshes * Correct handling of depth pass * Added Reference images for test * Added graphic test / restore defaut HD Material This reverts commit 1d8c36af255f41e515cbe3c87ea691125cd43077. * Update Test References * Added Tooltips, simplify input type selection * Fix handling of Lit Mesh output * Automatic Flipbook size for Array Layout * Delete the flipBookSize slot when Texture2DArray is set * More explicative Tooltip + end of flipbook blend fixed * Update CHANGELOG.md * Distortion Quad and Mesh output support * Update VFXAbstractParticleHDRPLitOutput.cs * Retrieve changelog from staging * Added entry * Motion Vector generation improvements (#194) * Added VFX_FEATURE_MOTION_VECTORS_VERTS mode to store motion vector info per vertex Optimized default motion vectors mode to store 4x3 matrix instead of 4x4. Added mode to store each previous vertex position for quads, triangles, lines and points. Refactor of motion vector defines. * Motion vectors support in lines and points * Resize buffer according to the element size * fix points and lines when not using the optimization * Fix motion vectors for lines * Changes suggested in review - Removed misplaced comment in VFXLineStripOutput - Access VFXLineOutput useTargetOffset through GetSettingValue in VFXOutputUpdate - Moved previous frame position calculation to the end of OutputUpdate compute - Added 4 bytes per particle for last frame index in elementToVFXBufferMotionVector buffer - Added noperspective when using VFX_FEATURE_MOTION_VECTORS_VERTS, through VFX_FEATURE_MOTION_VECTORS_INTERPOLATION define. - Fixed order of verts in lineSW particles. * Missing define rename in ParticleMeshes/PassForward.template * Improved condition for discarding due to not enough indirect buffers * Missing renaming of WRITE_MOTION_VECTOR_IN_FORWARD for particle lit meshes * Spawn State documentation (#195) * Added Spawn State doc * Fixed formatting Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Added what's new page and moved blocks out one level in the table of contents (#199) * Added what's new documentation for version 10 * Updated image and minor rewording * Added link from what's new to node library * Updated changelog link Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * HDRP - Fix Debug View Material (#182) * Fix fallback (?) depth state in debug view material Not sure about this : should double check with HDRP team * *Update changelog * *Updare reference image It corresponds to the result in 7.x.x & 8.x.x * *Apply reformat * *Apply reformat (bis) * Fix CameraFade for shadows (#179) * Fix CameraFade for shadows +CameraFade was taking the distance to the light when rendering the shadow map. +Added setting to optionally affect shadow, with warning for multiple cameras +Implemented functions to get camera position and direction * Update CHANGELOG.md * Update CameraFade.cs -Change fade default value to false. -Fix behaviour when affect shadows is false * Update documentation Added Affect shadows setting * Update documentation Modified AffectShadows setting description following @lewisjordan suggestions * Move camera functions to VFXCommonOutput * Remove ${VFXFragmentCommonFunctions} ${VFXFragmentCommonFunctions} was used only for the VFXCommonOutput.hlsl include, which is now generated by VFXCodeGenerator as part of ${VFXPerPassInclude} * Correct Sign operator node output for float when input is 0.0f (#190) * Changed specialization for floats to be consistent with others. * Update CHANGELOG.md * Update test * changed sky, emission scale, and updated references (#203) * Fix ProcessOperatorSign test Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/190 & this change 1d6e19db547ca6a79f75c839825e15943fde6288 * Allow remaking an existing link. (#146) * Allow remaking an existing link. * Update CHANGELOG.md Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> * ShaderGraph loosing reference while updating (sync with 7.x.x) (#185) * Use explicit GetOrRefreshShaderGraphObject & always lazy init the shadeGraph access. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/VFXGraph/Outputs/VFXAbstractParticleHDRPLitOutput.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/Implementations/VFXMeshOutput.cs # com.unity.visualeffectgraph/Editor/Models/VFXGraph.cs # com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs # com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphPostProcessor.cs * Fix shaderGraph not listed in VFXModel This is actually an issue in VFXModel.GetSettings, we don't have any cases like this where the parent value is private. * Update changelog.md Same entry than https://github.com/Unity-Technologies/Graphics/pull/2873/ * Removing changelog entry The actual fix was already there, this code is only a synchronisation with 7.x.x & prior version. * *Minimal test to check actual content of modified property after an override (#171) * Add test to cover behavior from https://fogbugz.unity3d.com/f/cases/1122404/ (#196) * *Updating reference image for D3D12 Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/182 * Force re-apply formatting * Fix ordering for "+" button in blackboard (#197) * Add test to cover behavior of https://fogbugz.unity3d.com/f/cases/1300115/ (#192) * Fix changelog.md (new entries should be in 12.0.) * *Update changelog.md (unexpected diff in 11.x.x) * [Fix Case 1221557] Checkbox Age Particles consistency (#202) * Provides consistent behavior with Add Age and Set Age * Update Changelog * update changelog * Add _CameraViewMatrix shader variable (#208) Add _CameraViewMatrix shader variable in HDRP, instead of using legacy unity_CameraToWorld. Remove functions using unity_CameraToWorld from VFXCommonOutput.hlsl and move to SRP specific VFXCommon.hlsl files * Fix compute culling compilation in URP (case 1309174) (#210) * Add GeometricTools.hlsl include Missing include containing DistanceFromPlane function used by IsSphereOutsideFrustum * Update changelog * [pCache] Fix minor UX issues (#207) * Disable mesh statistic field * Fix cancel while save texture * Fix create pCache from unreadable texture * *Update changelog.md * Fix missing disable for Texture Statistics * Disable motion vector per vertex optimization (#214) Temporarily disable motion vector per vertex optimization. Small refactor for vertex count calculation * Fallback for camera buffers from Main camera (#200) * Add setting for main camera buffer fallback * Move enum to C++ * Update changelog * Rename setting to Main Camera fallback and the option "None" to "No fallback" * Added an entry for Main Camera feedback in the preferences doc. * Updated tooltip * Reworded tooltip and doc entry * Added doc entry for User Systems. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * [VCS] Handle correctly locked asset (#193) * Prelimary refactor : gather IsAssetEditable in common test to ease testing * Move always m_LockedElement in front * Fix inspector of slot container when asset is locked * Fix inspector for VFXManager when asset is locked * *Update changelog.md * Fix incorrect cast in VFXSlotContainerEditor * Use m_LockedElement in blackboard & redirect it when needed Simplify integration from m_ComponentBoard * Fix case 1243947 : Debug View artefact Correctly clear the VFXDebugView while reassigning * *Update changelog.md * Let selection passing through locked label : it allows inspection * Fix locked label in blackboard when empty * Fix "Shader Value is not saved when switching between VFX Manager and Version Control" * Prevent Drag&Drop when asset is locked * Prevent tricky way to instantiate BuildContextualMenu There was an issue while clicking on left & right at the same time * Fix two issue with target - Attach a stopped visualEffect component - Stop & Reset behavior * Fix UpdateDebugMode which could be called too soon In the case of an not yet loaded VisualEffect component (because the VFXGraph has been just recompiled) * Fix ordering We want the "asset locked" just after contentViewContainer and not just before m_ComponentBoard * Update maxAlive state checking the actual IsAssetEditable during update * Fix locked issue with the VFXParameterEditor Should disable everything if IsAssetEditable returns false * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/193#discussion_r109552 blackboard => componentBoard * Mesh Index & Skinned (#30) * Squashed commit of the following: commit f51b7d616b77487339b2ec3db1e2e8bee35b3ae1 Merge: 2589034c08 229945b992 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Apr 6 17:32:10 2020 +0200 Merge branch 'vfx/feature/mesh-sampling-support-texcoord-dimension' into vfx/feature/mesh-sampling-index-buffer commit 229945b99247402006916c9c73a640d2b5662486 Merge: d26b342644 4cd4cb244d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Apr 6 17:31:23 2020 +0200 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 2589034c088795ba63bf61f22e8ba84a7ffe7607 Merge: 47e04162e6 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:24:43 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling-index-buffer commit 47e04162e60683e331c930a02e77f6d5eeae568e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:18:43 2020 +0200 Minor : add a TODO commit a7bd11748549e25789e7515c50b1c3d96499301b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:17:32 2020 +0200 Actually, keep minimal scope for VFX_GENERIC_BUFFER, it's useful for platform testing purpose. commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 0f9fc14afb9e6e8666b39860bd84922eba4a64e5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 16:49:52 2020 +0200 Remove temporary code commit bc8121349789de632d1115a7804a17b882559e1b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 16:02:23 2020 +0200 Choose StructuredBuffer<float> over ByteAddressBuffer commit 21b9d002b29b9887da8661f32505973e75d0420f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 30 17:16:37 2020 +0200 Change Buffer<uint> to Buffer<float> to avoid dx warning issue. commit be691cd625a18194c5662de17c952613b4f591e3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Mar 29 19:06:25 2020 +0200 Fix alignement for ByteAddressBuffer commit 3ec05dfadefc483507d3de12caf4a2e216af6e66 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Mar 29 17:58:05 2020 +0200 WIP : Trying to move to ByteAddressBuffer commit 2cf1db8679851ff55afcd5f17afa8a52b4d9e179 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 18:06:49 2020 +0100 add note for later commit e6fd7c1931919c657b7c65f8197be03e387e56dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 17:44:24 2020 +0100 *Draft test data (will be removed) commit c84f0e927ebe00f655d3fb92bbe98d6c03fdcf34 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 17:16:12 2020 +0100 Fix expressionMesh format commit 6f48ffbdb55f38da5750f63fc1a38d79a5d19800 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 15:01:01 2020 +0100 Update draft test commit edec8e1e997188e0dbc82ad9bb38e0ac178476d2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 15:00:41 2020 +0100 Sample Index *WIP* commit 2853d8b25eabd0dcf3f5af4718d71f17685d5a7b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 15:54:29 2020 +0100 *Remove End expression for mesh evaluation (invalid because we can't guess context for this case) commit d4f09e0cc4c058d07a2c40366e4e0bd45476d7fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 12:00:30 2020 +0100 Add minimal integration for newly added VFXExpressionVertexBufferFromMesh commit baf39dcdf6fc340269fb5442c763e4932ead57f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:59:25 2020 +0100 Add test data (to revert) commit 7a2fd0337ecc965dcea105dfd34973499f736bb8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:58:53 2020 +0100 Revert "Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh" This reverts commit 6d507a684f14dc09641877d6d691fd96adb63be4. commit 6d507a684f14dc09641877d6d691fd96adb63be4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:56:51 2020 +0100 Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh commit d26b342644bc08c2ab4118a71899bb78a2c303a7 Merge: b1512335cb 40749ce2ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 09:27:26 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit b1512335cb09b7b3e1ee783f991347704c4952be Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 18:24:05 2020 +0100 Fix after merge commit 43e25995ca9a15aa0ee5c88297616ccbd3fc5c2d Merge: e357f4871b 7abaf9bbf2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 17:47:34 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionMesh.cs commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit e357f4871b8c39257c62daf1fe63f85241325712 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 25 08:56:53 2020 +0100 Fix build in 2020.1 to resolve comment https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/258#pullrequestreview-52608 commit bfc0d9f7aeaa8b34407bfa8279d30bf59cf55099 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 18:44:28 2020 +0100 *Fix compilation commit 6cfd2d90292796c5b21e63d01c4b4bf8563c0184 Merge: 41a1a8e212 128101bc63 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 14:56:22 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 41a1a8e212c82b48832ab88f68348c145c0960c6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 15:19:24 2020 +0100 *Update expression name commit 27794064fd01207a35e7d967ff322e9d552a2054 Merge: ad597a0388 28f0ca20a0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 10:21:38 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit ad597a03881e11743e68555f985c304ee2d7557d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:18:40 2020 +0100 Support float or uint read in sample mesh color commit 8ca98dd9a375431ddc04c7a0cb625c35a2c99f57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 10:05:40 2020 +0100 Add compatibility code & use new available expression from https://ono.unity3d.com/unity/unity/changeset/6afd1f99b768984023366f3aba746390c763432f commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images com…

* More changelog fixes * Add missing warning for other block operator using depth (#140) Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#discussion_r79026 * *Adding missing meta file in TestProject * Missing doc & Deprecate VFXViewModicationProcessor (#143) * Fix missing doc & Deprecate VFXViewModicationProcessor Unexpected public API * *Revert unexpected change * Fix several issue from @lewisjordan - fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79397 - fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79398 * Fix Several issue in Property Binder (#106) * Fix case 1274790 : Use DestroyImmediate when editor isn't playing * Fix case 1247230 : Avoid null exposed property Property entry is modified by UX always not null, however, it requires a default value * Fix case 1274788 : Missing null check in Hierarchy to Attribute Map * Fix case 1248711 : Property window view wasn't working Missing Update, it also fixes Undo/Redo * *Update changelog * Fix compilation when ENABLE_LEGACY_INPUT_MANAGER isn't enabled Should be fix for 10.2 * Fix case 1279471 : Avoid OnMouseDown/Up/... declaration Game scripts or other custom code contains OnMouse_ event handlers. Presence of such handlers might impact performance on handheld devices." when building for Android/IOS * Fix positionDepthOperator ref images * Add one pixel to height in non wide mode so that margin is equal to wide mode. (#145) * Update CHANGELOG.md * Fix API validation * Harmonize Composition in Position / Velocity Blocks (#44) * Base refactor + Attempt to get position from AABox (not working for thickness ATM) * Fixed cone syntax issues + correct computation of AABox direction * Added Variant providers + Composition in Sequential * Updated Variants for Shape Sequential Blocks * Harmonized Namings + added composition to Position Depth * Updated Changelog * Fixes for PR * Fixed Blend Composition in Sequential * Added Direction to PositionSequential * Fixes in Position Circle / Set Blend factor in shapes to 1.0 by default * Used Absolute Box size as expression * Propal for https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files/e029bb9ec37555e70af21a97399774667030c031#r61533 Use case by case approach for direction of AABox * *Temp add test data for graphicTest * Fix ApplyAddressingMode : clamp & mirror was overflowing, mirror has also a wrong pattern * Edit graphicTest * Move 014 to common package * Add 014_PositionBlock in editor test listing * Precompute line_direction in PositionLine Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files#r67908 * *Add reference images * Fix editor test (wrong reference data) * Fix issue introduced at 9c54056a68e9ef90354e969e9baba18aa552f8f4 : Looping correctly the circle See also : https://unity.slack.com/archives/G1BTWN88Z/p1598508170069200?thread_ts=1598429838.039200&cid=G1BTWN88Z * Probably uploaded the wrong image reference for standalone * *Update reference images (I think I mess up twice, I should double check the change in motionVector) * Fix build (VFXExpressionCondition now supports uint) * *Temp* Delete motion vector reference image, should regenerate them from yamato. * Readd reference image using yamato result at b9a04b7424323e0c3801e34c13213c4050f020f1 * *Update changelog Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#discussion_r70582 * Fix PositionTorus when used in vertex shader * Fix multiple definition of UNITY_PI * Fix changelog bad automatic merge * Fix incorrect volume Base radius while computing volume factor on sphere & circle : use fix approach from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/89 using name instead of index See : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#issuecomment-28990 & https://docs.google.com/document/d/1RAVkfmMQA9D_hKkJyt6PKOgRs8JHkjlYRhcfBtIU1Ag/edit?disco=AAAAJ7Z4S18 Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix 1285603 View and Object mode of Shadergraph position node don't return proper values (#141) * Update VFXShaderGraphParticleOutput.cs * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix collapse exception and added automated test (#149) * Misc fixes for vfx shadergraph integrations (#130) * Diffusion profile has PropertyType.Float but isn't castable in Vector1ShaderProperty : safeprof code * Unity serialization produced a beast with object.ReferenceEquals(null) != 0 and instanceID == 0 foolProof code for this * Update CHANGELOG.md * Small fix for collapse test * Some extra security around error feedback (#153) * Prevent exceptions from making notification stay. Prevent exception in errors to potential break the ui * Prevent list from being badly deserialized. * Fix Event connected directly to Output Event (#152) * Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment * Misc fixes in strips (#136) * Vfx/feature/strips improvements (#265) * Add spanwIndexInStrip attribute * Fix particleCountInStrip in Init * Add OrientStrip block * Remove some useless code * Add From Target Position mode in Orient Strip * Update changelog * Fix SpawnOverDistance * Fix reference images * Fix changelog * Merge Orient and OrientStrip blocks * Remove FaceCameraPlane from strips * Sanitize quad strip orientation * Update VFX * Update changelog * Add error feedback * Use IsPerspectiveProjection * Fix GetStripTangent for lines * Add subpixel AA to head and trails template system * Add strip variant for intialize in menu * Fix for errors not appearing after convert output * Update graph version * Fix ribbon VFX * Fix spawnIndexInStrip (tooltip + init) * Fix issue with inspector not triggering OnSettingChanged * Check that a converted output could keep the same flow links. Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Revert adaeba7f20802aa19fe089463e1abfaf2a0488e6 * update vfx * Update URP assets * Update URP ref * Vfx/fix/additional subgraphs 2 (#155) * Updated Changelog * Updated Blocks with Fixes and Missing Workflows * update VFX additions Co-authored-by: Thomas Iché <peeweek@gmail.com> * Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139) * Reindex the TEXCOORD[n] * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix serveral minor issues (#103) Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458987790 Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988272 Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988870 * Update rebuild all script to take subgraph into account * Update VFX assets * Fix URP vfx assets * Allow Set Spawn Count & Set Spawn Time TODO : List Spawn count in available variant # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs * Add comment * Add explicit attribute SpawnCount Remove also some dead code, remove hack since we have now a reachable spawnCount attribute * Fix potential issue : spawnCount supposed to be first in all eventAttribute * Fix incorrect spawner ordering *WIP* * Missing *important* change * Add spawner test to cover behavior of CollectSpawnersHierarchy * *Commit temp data, I wil remove them before starting the PR I would like to test/check the sanitize manually * Move Get Spawn Count to deprecated * *Move old attribute to "deprecated" folder * Sanitize GetSpawnCount using VFXAttributeParameter & VFXInlineOperator * Remove test data * Add set spawn test * Fix unexpected exception since globalAttribute can be empty if there isn't any spawner linked * Minor : update comment * *Update changelog * Minor update in changelog.md * Remove unexpected expcept with leads to incorrect depth count * *Update expected reference image changes * Remove TODOPAUL * Fix Event connected directly to Output Event (revival) (#154) * Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment * Fix regression with subgraph * Add Subgraph_Event_Link_To_Spawn editor test * spawnCount & spawnTime can be stored per attribute Use specific exception for set spawn event attribute. * Fix changelog Add entry in the right place from 0009e5373ddd6927977fc8054e2ab16c14b5e81b * Restore disabled 26_NonUnifomScale due to a wrong merge (need backport to 10.x.x) * [HDRP] Fix debug view material (albedo/normal/...) (#163) * Fix debug view material TODO : Add GraphicTest * Fix tab/space mix * Add HDRP debug scene * *Add reference image for HDRD_Debug(Property) * *Update changelog.md * Force ui update when shader might be reimported in StaticMeshOutput (#158) * Don't create VFXGraph during import callbacks (#148) * do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation * Add the necessary openasset callback for the system to know if we open the asset inside the editor. (#118) * Added OnOpenAssetAttributeMode.Validate * added UNITY_2021_1 * remove the shaders has they are not edited in the editor. * Fix macro * Select node on create (#166) * Select node on create * Fix for right click in block and add doesn't deselect clicked block * fix for subgraph not being selected on drag and drop * Select converted node/block after convert subgraph * Fix for selection undo separate in some cases. Fixed flow anchor drag context selection. * Fix for undo of add subgraph operator * “Refactor” * "Refactor" bis (some file has been missed) * Dont flag dirty in vfxgraph is the model modified is a copy (#165) * *Apply formatting on branch * Workflow improvement : Change VisualEffect inspector "Edit" button to "New" when no asset is set. (#173) * Base Commit * Documentation * Updated Changelog * Fixed Typo Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Added excludeFromTAA setting to VFX outputs (#170) * Added excludeFromTAA setting to VFX outputs Added excludeFromTAA setting to VFX outputs. Currently it is only supported in HDRP suboutputs. Required adding ${VFXStencilForward} variable to forward pass templates * Update VFXHDRPSubOutput.cs suport exclude from TAA in transparent only * Added documentation to exclude from TAA property * Graphic test Added graphic test: 32_ExcludeFromTAA * Update graphic test background for better contrast * Update CHANGELOG.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * Missing Reference image for test 32_ExcludeFromTAA * Add test to cover case exposed by 1258022 (#54) * Fix Custom Spawn serialization (#132) * Allow Set Spawn Count & Set Spawn Time TODO : List Spawn count in available variant * Fix reference lost in m_SerializableType No idea of implication of this :-/ * Squashed commit of the following: (retrieve fix from @tristan) commit c24981d7dad15100eb40a92a6a9370e9ba800acd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 17:27:57 2020 +0200 Update message from @vlad suggestion Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757 commit a87ba182b30da7683e31a29048c9f2f3a0312927 Merge: 13b501e15863 296ffd333bcf Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:25:02 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/error-at-creation # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 13b501e158634dfc98b96058723d248cd5d1f34d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:24:27 2020 +0200 *Add warning for CollisionDepthBuffer Update & Fix Changelog.md commit 4bfb1e7c9874d8a9403ca5267d1e10735e52a87b Author: Tristan Genevet <tristan@unity3d.com> Date: Thu Oct 8 18:10:42 2020 +0200 Fix for displaying error from the creation of a node. * Add error feedback on failing custom spawner reference * Revert "Allow Set Spawn Count & Set Spawn Time" This reverts commit 0a6c75cc54072b831dcc56bffc3bbe04734d3324. # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs * Remove unexpected change * *Revert change in changelog * *WIP* add ResolveCustomCallbackInstance Some refactor mark as "TODOPAUL" * Clean implementation : customBehavior & comment * *Add test to cover sanitize before modify references * Change namespace for builtin custom spawner & sanitize * Extend test to verify connexion * *Update changelog.md * Add specific error if customBehavior returns null * Fix corner case when ScriptableObject reference has been lost * Work but not idea with copy/past + potential leak * Better implementation : use directly "MonoScript" * Fix spawnerTest * Rename "Can't found" => "Can't find" * Fix case 1294180 : Error feedback throwing an error while changing capacity (#174) Issue introduced with https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136 And more precisely https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136/commits/27c041da92ec89407ae775fe4c4f24681f156cb8 * [Test] Add test to cover "Thread Group Size" error (#104) * Add test * Add test to cover behavior from case 1271839 * Fix Preset (with exclusion) (#177) * Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog * Fix 1276602 incorrect uchar pcache import (#129) * Base Commit * Updated Documentation with explicit limitations. * Fixed incorrect Merge * Add regression Test * Removed Test as It can't handle Exceptions thrown in Custom Importers * Fixed value divider Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Update gradient test (#151) * Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Sample Point Cache Operator (#92) * Initial commit * Overflow handling options for the user * Addressing mode for overflow to the choice of the user * Foldable to Constant value * Update 09_PointCache.vfx * Added reference images * Remove float-to-integer conversion * Put the choice of the output type in the Inspector only * Simplify output type handling * Sample Point cache != Attribute map => two operators * Update Branch (error .yamato/docs/editor_pinning.png) * Update SamplePointCache.cs * Update 09_PointCache.vfx * Output type set in a cogwheel * Update 09_PointCache.vfx * Revert "Update Branch (error .yamato/docs/editor_pinning.png)" This reverts commit 02f6b6c993c2382bb10669edd16f7d06876a0cbc. * Restore vfx asset * Revert back to using generics for type handling * Update SampleAttributeMap.cs * Reformating + changelog * Update 09_PointCache.vfx * Update SamplePointCache.cs * Refactor of AttributeFromMap using VFXExpressionSampleAttributeMap * Merge branch 'vfx/staging' into vfx/feature/sample-point-cache * Revert "Merge branch 'vfx/staging' into vfx/feature/sample-point-cache" This reverts commit b4a03e182a3e106c2fabc262777615f9c3b94a7e. * Fix point cache vfx + update HDRP vfx * Update URP assets * Fix changelog * Fix Case 1223747 - NaN caused by normal bending (#181) * Update Pass.template * Update CHANGELOG.md * 1293608 - Fix LPPV not working in deferred (#180) * Enable LPPV in HDRP test project * Fix LPPV for gbuffer pass * Add graphics test * Update changelog * Fix 1290493 - Spaceship specific warnings (#176) * Avoid implicit trucation in template + safe normalize setting * Update CHANGELOG.md * Added variants * Delete conditioning on GPU evaluation + conservative safe normalize Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix incorrect compilation condition for linux build (#184) * Fix formatting * Update 26_NonUniformScale kind of sky : gradient instead of procedural * Fix regression from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/176 Issue introduced at 44f497b438b46a54072721d335910bfab3e392ef : Incorrect VFXExpressionCondition See also : https://unity.slack.com/archives/G1BTWN88Z/p1607963794139900?thread_ts=1607955907.136600&cid=G1BTWN88Z * Disable Gradient Sky in 26_NonUniformScale & 33_LightProbe * *Update VFX (newly introduced safeNormalize, default 0) * Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA * Revert "Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA" This reverts commit ddee2e356dc7e529cad2904836fef8a688e546a8. * 32_ExcludeFromTAA : Disable XR * 33_LightProbe : Slighlty increase treshold from 0.0005 to 0.0006 * *Update Image Reference for D312 (mainly missing file) * *Disable 32_ExcludeFromTAA Instability detected. * *Add missing D3D12 image references * Fix GPUEvent & SubGraph (#178) * Fix SelectionHasCompleteSystems Detect correctly if there are dependencies due to GPUEvent (or stripAttribute) * Add allDependenciesIncludingNotCompilable in VFXData This helper is usefull for UI + use it in SelectionHasCompleteSystems * Add note without change the beahvior * Remove debug ToArray() * [Subgraph] Prevent Pasting Context invalid subgraph (#191) * Prevent pasting context within operator/block subgraph * Fix case https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/191#discussion_r102007 Fix Approximate english log warning * Update VFXPaste log message Missing "the" * Fix Mouse Event Binder in player (#175) * Fix missing call to CreateVFXEventAttribute OnValidate is only called in editor, in runtime, we should init cache data with OnEnable * *Update changelog.md * Remove the direct link to initialize constraint * Add initSystems collection from event link * Add editor test to cover Safe Normalize behavior (#189) * Draft of specific code to handle dynamic source spawn event * - Change default SpawnCount value to 1.0f (it will be more consistent & ease debug) * Fix incorrect systemIndex computation * Vfx/docs/bugfixes (#188) * Resolved 1272101 * Resolved 1264943 * Removed uncertainty around 'should' * Resolved 1298031 * Added snippets file * Resolved 1292127 * Fixed typos * Resolved 1295296 Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix incorrect indexOfData (sill *wip*) * *Commit test data (to remove) * Texture2D Array Layout for Flipbooks (#97) * Initial commit, working for planar primitives only * Increased support to Cube, Decals, Meshes, Lit Planar Primitives, Lit Meshes * Correct handling of depth pass * Added Reference images for test * Added graphic test / restore defaut HD Material This reverts commit 1d8c36af255f41e515cbe3c87ea691125cd43077. * Update Test References * Added Tooltips, simplify input type selection * Fix handling of Lit Mesh output * Automatic Flipbook size for Array Layout * Delete the flipBookSize slot when Texture2DArray is set * More explicative Tooltip + end of flipbook blend fixed * Update CHANGELOG.md * Distortion Quad and Mesh output support * Update VFXAbstractParticleHDRPLitOutput.cs * Retrieve changelog from staging * Added entry * Motion Vector generation improvements (#194) * Added VFX_FEATURE_MOTION_VECTORS_VERTS mode to store motion vector info per vertex Optimized default motion vectors mode to store 4x3 matrix instead of 4x4. Added mode to store each previous vertex position for quads, triangles, lines and points. Refactor of motion vector defines. * Motion vectors support in lines and points * Resize buffer according to the element size * fix points and lines when not using the optimization * Fix motion vectors for lines * Changes suggested in review - Removed misplaced comment in VFXLineStripOutput - Access VFXLineOutput useTargetOffset through GetSettingValue in VFXOutputUpdate - Moved previous frame position calculation to the end of OutputUpdate compute - Added 4 bytes per particle for last frame index in elementToVFXBufferMotionVector buffer - Added noperspective when using VFX_FEATURE_MOTION_VECTORS_VERTS, through VFX_FEATURE_MOTION_VECTORS_INTERPOLATION define. - Fixed order of verts in lineSW particles. * Missing define rename in ParticleMeshes/PassForward.template * Improved condition for discarding due to not enough indirect buffers * Missing renaming of WRITE_MOTION_VECTOR_IN_FORWARD for particle lit meshes * Spawn State documentation (#195) * Added Spawn State doc * Fixed formatting Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Added what's new page and moved blocks out one level in the table of contents (#199) * Added what's new documentation for version 10 * Updated image and minor rewording * Added link from what's new to node library * Updated changelog link Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * HDRP - Fix Debug View Material (#182) * Fix fallback (?) depth state in debug view material Not sure about this : should double check with HDRP team * *Update changelog * *Updare reference image It corresponds to the result in 7.x.x & 8.x.x * *Apply reformat * *Apply reformat (bis) * Fix CameraFade for shadows (#179) * Fix CameraFade for shadows +CameraFade was taking the distance to the light when rendering the shadow map. +Added setting to optionally affect shadow, with warning for multiple cameras +Implemented functions to get camera position and direction * Update CHANGELOG.md * Update CameraFade.cs -Change fade default value to false. -Fix behaviour when affect shadows is false * Update documentation Added Affect shadows setting * Update documentation Modified AffectShadows setting description following @lewisjordan suggestions * Move camera functions to VFXCommonOutput * Remove ${VFXFragmentCommonFunctions} ${VFXFragmentCommonFunctions} was used only for the VFXCommonOutput.hlsl include, which is now generated by VFXCodeGenerator as part of ${VFXPerPassInclude} * Correct Sign operator node output for float when input is 0.0f (#190) * Changed specialization for floats to be consistent with others. * Update CHANGELOG.md * Update test * changed sky, emission scale, and updated references (#203) * Fix ProcessOperatorSign test Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/190 & this change 1d6e19db547ca6a79f75c839825e15943fde6288 * Allow remaking an existing link. (#146) * Allow remaking an existing link. * Update CHANGELOG.md Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> * ShaderGraph loosing reference while updating (sync with 7.x.x) (#185) * Use explicit GetOrRefreshShaderGraphObject & always lazy init the shadeGraph access. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/VFXGraph/Outputs/VFXAbstractParticleHDRPLitOutput.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/Implementations/VFXMeshOutput.cs # com.unity.visualeffectgraph/Editor/Models/VFXGraph.cs # com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs # com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphPostProcessor.cs * Fix shaderGraph not listed in VFXModel This is actually an issue in VFXModel.GetSettings, we don't have any cases like this where the parent value is private. * Update changelog.md Same entry than https://github.com/Unity-Technologies/Graphics/pull/2873/ * Removing changelog entry The actual fix was already there, this code is only a synchronisation with 7.x.x & prior version. * *Minimal test to check actual content of modified property after an override (#171) * Add test to cover behavior from https://fogbugz.unity3d.com/f/cases/1122404/ (#196) * *Updating reference image for D3D12 Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/182 * *Extend test * More consistent behavior : always list spawnCount first (before any other attributes) * More consistent behavior : always list spawnCount first (before any other attributes) * Fix source of attribute : event should also be considered * Force re-apply formatting * Fix ordering for "+" button in blackboard (#197) * Add test to cover behavior of https://fogbugz.unity3d.com/f/cases/1300115/ (#192) * Fix changelog.md (new entries should be in 12.0.) * *Update changelog.md (unexpected diff in 11.x.x) * [Fix Case 1221557] Checkbox Age Particles consistency (#202) * Provides consistent behavior with Add Age and Set Age * Update Changelog * update changelog * Add _CameraViewMatrix shader variable (#208) Add _CameraViewMatrix shader variable in HDRP, instead of using legacy unity_CameraToWorld. Remove functions using unity_CameraToWorld from VFXCommonOutput.hlsl and move to SRP specific VFXCommon.hlsl files * Fix compute culling compilation in URP (case 1309174) (#210) * Add GeometricTools.hlsl include Missing include containing DistanceFromPlane function used by IsSphereOutsideFrustum * Update changelog * *Proper test (ready to be shared with HDRP project) * *Reduce m_SourceCount to minimal value * HotFix for source code generator * Remove the 0 size buffer constraint for sourceAttributeBuffer of initialize * [pCache] Fix minor UX issues (#207) * Disable mesh statistic field * Fix cancel while save texture * Fix create pCache from unreadable texture * *Update changelog.md * Fix missing disable for Texture Statistics * Disable motion vector per vertex optimization (#214) Temporarily disable motion vector per vertex optimization. Small refactor for vertex count calculation * Fallback for camera buffers from Main camera (#200) * Add setting for main camera buffer fallback * Move enum to C++ * Update changelog * Rename setting to Main Camera fallback and the option "None" to "No fallback" * Added an entry for Main Camera feedback in the preferences doc. * Updated tooltip * Reworded tooltip and doc entry * Added doc entry for User Systems. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * [VCS] Handle correctly locked asset (#193) * Prelimary refactor : gather IsAssetEditable in common test to ease testing * Move always m_LockedElement in front * Fix inspector of slot container when asset is locked * Fix inspector for VFXManager when asset is locked * *Update changelog.md * Fix incorrect cast in VFXSlotContainerEditor * Use m_LockedElement in blackboard & redirect it when needed Simplify integration from m_ComponentBoard * Fix case 1243947 : Debug View artefact Correctly clear the VFXDebugView while reassigning * *Update changelog.md * Let selection passing through locked label : it allows inspection * Fix locked label in blackboard when empty * Fix "Shader Value is not saved when switching between VFX Manager and Version Control" * Prevent Drag&Drop when asset is locked * Prevent tricky way to instantiate BuildContextualMenu There was an issue while clicking on left & right at the same time * Fix two issue with target - Attach a stopped visualEffect component - Stop & Reset behavior * Fix UpdateDebugMode which could be called too soon In the case of an not yet loaded VisualEffect component (because the VFXGraph has been just recompiled) * Fix ordering We want the "asset locked" just after contentViewContainer and not just before m_ComponentBoard * Update maxAlive state checking the actual IsAssetEditable during update * Fix locked issue with the VFXParameterEditor Should disable everything if IsAssetEditable returns false * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/193#discussion_r109552 blackboard => componentBoard * Mesh Index & Skinned (#30) * Squashed commit of the following: commit f51b7d616b77487339b2ec3db1e2e8bee35b3ae1 Merge: 2589034c08 229945b992 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Apr 6 17:32:10 2020 +0200 Merge branch 'vfx/feature/mesh-sampling-support-texcoord-dimension' into vfx/feature/mesh-sampling-index-buffer commit 229945b99247402006916c9c73a640d2b5662486 Merge: d26b342644 4cd4cb244d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Apr 6 17:31:23 2020 +0200 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 2589034c088795ba63bf61f22e8ba84a7ffe7607 Merge: 47e04162e6 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:24:43 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling-index-buffer commit 47e04162e60683e331c930a02e77f6d5eeae568e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:18:43 2020 +0200 Minor : add a TODO commit a7bd11748549e25789e7515c50b1c3d96499301b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:17:32 2020 +0200 Actually, keep minimal scope for VFX_GENERIC_BUFFER, it's useful for platform testing purpose. commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 0f9fc14afb9e6e8666b39860bd84922eba4a64e5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 16:49:52 2020 +0200 Remove temporary code commit bc8121349789de632d1115a7804a17b882559e1b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 16:02:23 2020 +0200 Choose StructuredBuffer<float> over ByteAddressBuffer commit 21b9d002b29b9887da8661f32505973e75d0420f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 30 17:16:37 2020 +0200 Change Buffer<uint> to Buffer<float> to avoid dx warning issue. commit be691cd625a18194c5662de17c952613b4f591e3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Mar 29 19:06:25 2020 +0200 Fix alignement for ByteAddressBuffer commit 3ec05dfadefc483507d3de12caf4a2e216af6e66 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Mar 29 17:58:05 2020 +0200 WIP : Trying to move to ByteAddressBuffer commit 2cf1db8679851ff55afcd5f17afa8a52b4d9e179 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 18:06:49 2020 +0100 add note for later commit e6fd7c1931919c657b7c65f8197be03e387e56dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 17:44:24 2020 +0100 *Draft test data (will be removed) commit c84f0e927ebe00f655d3fb92bbe98d6c03fdcf34 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 17:16:12 2020 +0100 Fix expressionMesh format commit 6f48ffbdb55f38da5750f63fc1a38d79a5d19800 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 15:01:01 2020 +0100 Update draft test commit edec8e1e997188e0dbc82ad9bb38e0ac178476d2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 15:00:41 2020 +0100 Sample Index *WIP* commit 2853d8b25eabd0dcf3f5af4718d71f17685d5a7b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 15:54:29 2020 +0100 *Remove End expression for mesh evaluation (invalid because we can't guess context for this case) commit d4f09e0cc4c058d07a2c40366e4e0bd45476d7fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 12:00:30 2020 +0100 Add minimal integration for newly added VFXExpressionVertexBufferFromMesh commit baf39dcdf6fc340269fb5442c763e4932ead57f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:59:25 2020 +0100 Add test data (to revert) commit 7a2fd0337ecc965dcea105dfd34973499f736bb8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:58:53 2020 +0100 Revert "Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh" This reverts commit 6d507a684f14dc09641877d6d691fd96adb63be4. commit 6d507a684f14dc09641877d6d691fd96adb63be4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:56:51 2020 +0100 Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh commit d26b342644bc08c2ab4118a71899bb78a2c303a7 Merge: b1512335cb 40749ce2ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 09:27:26 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit b1512335cb09b7b3e1ee783f991347704c4952be Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 18:24:05 2020 +0100 Fix after merge commit 43e25995ca9a15aa0ee5c88297616ccbd3fc5c2d Merge: e357f4871b 7abaf9bbf2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 17:47:34 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionMesh.cs commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit e357f4871b8c39257c62daf1fe63f85241325712 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 25 08:56:53 2020 +0100 Fix build in 2020.1 to resolve comment https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/258#pullrequestreview-52608 commit bfc0d9f7aeaa8b34407bfa8279d30bf59cf55099 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 18:44:28 2020 +0100 *Fix compilation commit 6cfd2d90292796c5b21e63d01c4b4bf8563c0184 Merge: 41a1a8e212 128101bc63 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 14:56:22 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 41a1a8e212c82b48832ab88f68348c145c0960c6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 15:19:24 2020 +0100 *Update expression name commit 27794064fd01207a35e7d967ff322e9d552a2054 Merge: ad597a0388 28f0ca20a0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 10:21:38 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit ad597a03881e11743e68555f985c304ee2d7557d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:18:40 2020 +0100 Support float or uint read in sample mesh color commit 8ca98dd9a375431ddc04c7a0cb625c35a2c99f57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 10:05:40 2020 +0100 Add compatibility code & use new available expression from https://ono.unity3d.com/unity/unity/changeset/6afd1f99b768984023366f3aba746390c763432f commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Sample mesh, add placement mode : Surface & Edge *WIP* * Some experiment with low distorsion mapping * *WIP* debug data (will be removed anyway) * Clean BarycentricCoordinatesBis * Fix to graft : support for flag enum in inspector * Add animation test data from @vlad * Test scene *WIP* * Use GetVertexStride depending of channelIndex & VFXExpressionVertexBufferFromMesh depending of channelFormatAndDimensionAndStream * *WIP* pushing test data * *Push Some test data (will be removed) * Fix test adding a *WIP* note * Minor fixes after merge * Add SkinnedMeshRenderer exposable * Add SkinnedMeshRenderer in IsTypeConstantFoldable * Add VFXExpressionSampleSkinnedMeshRendererFloat & co support (it should be factorizable) * Move hexahredron to common data, it will be convinient for graphicTest * Fix PositionMesh (bad merge) * Implement Graphic Test for skinned mesh (not yet tested in standalone yet) * *Add reference images * Clean some code, remove intermediate compatibility code * Add variant provider for sample mesh * Factorize sampling function to share them with PositionMesh * Start factorization of SamplePositionMesh * Add simple TODOPAUL * Add another TODOPAUL * Change VertexAttributeFlag to VertexAttribute, use proper mesh type in MeshPosition * Implement surface coordinate & sample vertex for position mesh * Remove test data & Update actual graphicTest * Use nameof instead of verbatim (this code will not be backported) * Fix sample edge * Add skinned & mesh index/vertex count * Fix editor test (todo : graft this change to master to anticipate the C++ change) * *Update reference image for mesh sampling * *Add sampleMesh index for skinned & mesh * Fix after merge (wasn't so obvious but now works \o/ Can be factorized) * Simpler update to use now available ByteAddressBuffer # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionAbstract.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.hlsl * Revert "Simpler update to use now available ByteAddressBuffer" (onluy VFXCommon.hlsl) This reverts commit 65b5ce1c588b969b95726a83d06a34a386a8c16d. * Fix compilation * Fix wrong return type of FetchBuffer * *Restore lost test for triangle sampling * Proper sample OOB fix * Use explicit branch in SampleMeshReadFloat : we aren't supposed fetch in invalid buffer * Enable GPUSkinng, default mode * Remove float cast for condition since we are able to compare uint * Factorize insertGPUTransformation using the common switch * Clean multiple place where "ByteAddressBuffer" is declared * Simply generated code verifying at http://shader-playground.timjones.io/d7df4e7dbec05529d6943aacca2812b9 * Remove unexpected restored file (as been renamed) * *Update changelog * *Fix build * *Update image reference * Remove useless case in GetFunctionParameterType (ByteAddressBuffer is in TypeToCode anyway) * Fix after merge * First draft of documentation for sample mesh * *Update documentation * *up doc * *documentation * Add documentation for Mesh Index Count & Vertex Count * *documentation * *Remove unexpected change & deprecated code * *documentation * Remove unexpected change in changelog.mp * *Apply formatting * *Update documentation * Minor documentation update * Documentation : add "inspector" flag when relevant * Rename confusing "x" in "edge" See https://docs.google.com/document/d/1VbIc5pMkgFX2Ui4-LWrZ7uQ4EKlXlFxWWW4ufcex70I/edit * *Remove deprecated MeshSampling & Update TOC * Reviewed the Set Position(Mesh) doc * Reviewed mesh index count doc * reviewed the rest of the sample mesh operators. * Fix ToC & rename some "Skinned Mesh Renderer" in "Skinned Mesh" * Missing minor change * *Reupdate VFX after merge * Fix several tooltip issues - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89530 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89531 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89532 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89533 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89534 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89535 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89536 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89538 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89539 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89540 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89541 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89542 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89544 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89545 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89546 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89547 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89548 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89549 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89550 * Forgot to stage files from previous commit d8c1bef513605c8c7b40ec855cfe2be4de2e7d5e * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109724 Remove not needed UNITY_2020_2_OR_NEWER condition * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109727 Isolate helper function to VFXMeshSampling.hlsl * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109725 - Rename sourceExpression to targetExpression - Add InvalidOperationException if we are detecting an unexpected graph * Add missing compile of channelFormatAndDimensionAndStream - Check branch behavior - Trying to find infinite recursion due to dependent sampling - TODO : Add an editor test to inspect the actual generated graph (already checked in debug) Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * *Update all VisualEffectAsset "flipbookLayout: 0" everywhere + Some missing meta in test project (minor) * *Apply formatting * *Update missing reference images * Other missing update screenshot & missing meta * Fix formatting : this change can be grafted directly on master * Three minor fixes from https://github.com/Unity-Technologies/Graphics/pull/3414 - Wrong Image reference : Fix D3D11 standalone - Unconsistent debug assert (the recreate can be called on subslot) : Fix Space_Slot_Sanitize_Still_Possible_ArcSphere - CreateComponentWithAllBasicTypeExposed : remove VFXValueType.CameraBuffer from list of tested exposed type (it can'td irectly be exposed) These change can independantly land in `master` * Fix incorrect changelog.md in com.unity.visualeffectgraph * Remove unexpected duplicated entry in changelog.md * Fix changelog : unexpected removed entries in 11.x * *Update changelog.md * Fix build * Rename vfx file * [BRP] Fix Shader Compilation (#216) * Fix incorrect direct access to GetWorldToObjectMatrix * *Update changelog.md * Proper virtual in VFXData to handle hasDynamicSourceCount in VFXCodeGenerator without cast * Refactor GenerateComputeSourceIndex * Store system index in VFXContextCompiledData Avoid this "Anticipate what will be index of this particle system, not ideal and arbitrary." * Minor : rename define * Simplify FillEvent implementation using directly EventStructure * *Add mixing test * Update VFXSettings for 016 * Move 016 to common test package * *Update using HDRP * *Add 016_DirectLink to EditorBuildSettings * Sphere and cube outputs as experimental * *Update test to have a clearer and more stable behavior & Add editor reference images * Minor : fix compilation warning Check locally : 016_DirectLink (1.714s) --- The referenced script (Unknown) on this Behaviour is missing! The referenced script on this Behaviour (Game Object 'Main Camera') is missing! * *Missing editor build settings update * Add castShadows as additionalMappings in VFXStaticMeshOutput (#217) * [Orient] 'Look At Position' particle disappearance (#101) * Expensive fix Computes two cross products to avoid the case when one of them is zero. Is it faster than branching to check ? Is this edge case worth the additional cost ? * More explicit approach/similar instruction cost + LookAtLine * Update Orient.cs * Handles edge case when cross(axis1, axis2) = (0,0,0) for all Orient variants * Small mistake in the exception message * Factorize SafeNormalizedCross * Update changelog * Added information about compute shaders and ssbos (#222) * Added information about compute shaders and ssbos * Added recommendation to use Vulkan over OpenGL ES * Removed 'two' * Added entry about vfx graph not being out of preview for mobile platforms Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * [Fix] PropertyBinder : Reset & Undo (#212) * Fix missing record object for proper undo/redo & reset * *Update changelog.md * Fix issue https://favro.com/organization/c564ede4ed3337f7b17986b6/1973edb4634ba00a90689144?card=Uni-160638 * Avoid VFXPropertyBinder to be added twice * Fix incorrect reference after copy past * Fix RemoveComponent clearing property binder first * Handle Copy/Past \o/ * Let the LateUpdate without any editor code & use Update (avoid the one frame of latency for inspector) * Remove useless recompute of GetComponents every frame, and use Reload (safer) * Remove dead code * *Add new entry in changelog (side improvement/fix) * *Update comment * [Fix] Null Ref Exception due to IsAssetEditable (#221) * Resource can be null on a block inspector while we are removing it Use safe check of resource before IsAssetEditable * *Update changelog * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/221#discussion_r113060 * [Fix] Component Board UX issue (#220) * Fix missing call to OnSelectionChanged on first display (before selection changed called) * Fix change from component notifying the VFXView * Fix toggle component board state * Minor fixes * *Update changelog.md * Add custom namespace for test script * Minor code update * Remove reflection about compileInitialVariants : it's available since 19.3 * Remove unexpected entry in changelog.md * *Update (some) reference images * Restore the constraint on OutputEvent & Event It can't work because we aren't generating any data in that case * *Update reference image URP * *Update reference images * *Update changelog.md * Fix build of VFXSpawnerTest.cs * [Fix] System name 'Model is not registered' (#224) * *Add editor test to catch corner case issue with system name * Move Create_Simple_Graph_Then_Remove_Edget_Between_Init_And_Update_TestCaseto VFXGUITest * Actual fix of 1315593 The flow edge change is only triggering kConnectionChanged so, if you are trying to access m_SystemNames before compilation * Remove unexpected change * [Test] Revert after change (#213) * Local test (I'm using git diff to check actual file change) * test adding a lit mesh output * *Testing with shaderGraph * *test bis * *Add unit test to cover unexpected increasing size * Properly implement the test * Remove test data * *Temp lot of log & save it to independant file * HotFix : UpdateSubAsset in OnPreprocessAsset Shouldn't be necessary, the actual problem is maybe in C++ implementation * Clean test & add comment * *WIP* Serialization test which seems (tm) to reproduce the same issue * To revert : experiment adding log while loading VFXSerializableObject *Without Import Asset after write* Saving : 100 Loading : 100 Loading : 100 OnBeforeSerialize : 100 Saving : 101 Loading : 101 Loading : 101 OnAfterDeserialize : 100 Loading : 100 => Test fail ! *With Import Asset after write* Saving : 100 Loading : 100 Loading : 100 OnBeforeSerialize : 100 OnAfterDeserialize : 100 Saving : 101 Loading : 101 Loading : 101 Loading : 101 OnBeforeSerialize : 101 OnAfterDeserialize : 101 Saving : 102 Loading : 102 Loading : 102 Loading : 102 OnBeforeSerialize : 102 OnAfterDeserialize : 102 Saving : 103 Loading : 103 Loading : 103 * *Revert unwanted change * Clean & Unify test behavior * Safety check in newly integrated test (if asset is empty, it isn't expected neither) * Remove OnCompile : Avoid recompile twice, the WriteAsset is already trigerring an import * [Test] Add test to cover CopyValuesFrom (#225) * *Add test to cover CopyValuesFrom issue * *Extend the newly added test Check every value in copied values * Just added a perf marker * Changed `mobile` to `Android`…

* Misc fixes for vfx shadergraph integrations (#130) * Diffusion profile has PropertyType.Float but isn't castable in Vector1ShaderProperty : safeprof code * Unity serialization produced a beast with object.ReferenceEquals(null) != 0 and instanceID == 0 foolProof code for this * Update CHANGELOG.md * Small fix for collapse test * Some extra security around error feedback (#153) * Prevent exceptions from making notification stay. Prevent exception in errors to potential break the ui * Prevent list from being badly deserialized. * Fix Event connected directly to Output Event (#152) * Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment * Misc fixes in strips (#136) * Vfx/feature/strips improvements (#265) * Add spanwIndexInStrip attribute * Fix particleCountInStrip in Init * Add OrientStrip block * Remove some useless code * Add From Target Position mode in Orient Strip * Update changelog * Fix SpawnOverDistance * Fix reference images * Fix changelog * Merge Orient and OrientStrip blocks * Remove FaceCameraPlane from strips * Sanitize quad strip orientation * Update VFX * Update changelog * Add error feedback * Use IsPerspectiveProjection * Fix GetStripTangent for lines * Add subpixel AA to head and trails template system * Add strip variant for intialize in menu * Fix for errors not appearing after convert output * Update graph version * Fix ribbon VFX * Fix spawnIndexInStrip (tooltip + init) * Fix issue with inspector not triggering OnSettingChanged * Check that a converted output could keep the same flow links. Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Revert adaeba7f20802aa19fe089463e1abfaf2a0488e6 * update vfx * Update URP assets * Update URP ref * Vfx/fix/additional subgraphs 2 (#155) * Updated Changelog * Updated Blocks with Fixes and Missing Workflows * update VFX additions Co-authored-by: Thomas Iché <peeweek@gmail.com> * Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139) * Reindex the TEXCOORD[n] * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix serveral minor issues (#103) Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458987790 Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988272 Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988870 * Update rebuild all script to take subgraph into account * Update VFX assets * Fix URP vfx assets * Fix Event connected directly to Output Event (revival) (#154) * Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment * Fix regression with subgraph * Add Subgraph_Event_Link_To_Spawn editor test * Fix changelog Add entry in the right place from 0009e5373ddd6927977fc8054e2ab16c14b5e81b * Restore disabled 26_NonUnifomScale due to a wrong merge (need backport to 10.x.x) * [HDRP] Fix debug view material (albedo/normal/...) (#163) * Fix debug view material TODO : Add GraphicTest * Fix tab/space mix * Add HDRP debug scene * *Add reference image for HDRD_Debug(Property) * *Update changelog.md * Force ui update when shader might be reimported in StaticMeshOutput (#158) * Don't create VFXGraph during import callbacks (#148) * do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation * Add the necessary openasset callback for the system to know if we open the asset inside the editor. (#118) * Added OnOpenAssetAttributeMode.Validate * added UNITY_2021_1 * remove the shaders has they are not edited in the editor. * Fix macro * Select node on create (#166) * Select node on create * Fix for right click in block and add doesn't deselect clicked block * fix for subgraph not being selected on drag and drop * Select converted node/block after convert subgraph * Fix for selection undo separate in some cases. Fixed flow anchor drag context selection. * Fix for undo of add subgraph operator * “Refactor” * "Refactor" bis (some file has been missed) * Dont flag dirty in vfxgraph is the model modified is a copy (#165) * Workflow improvement : Change VisualEffect inspector "Edit" button to "New" when no asset is set. (#173) * Base Commit * Documentation * Updated Changelog * Fixed Typo Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Added excludeFromTAA setting to VFX outputs (#170) * Added excludeFromTAA setting to VFX outputs Added excludeFromTAA setting to VFX outputs. Currently it is only supported in HDRP suboutputs. Required adding ${VFXStencilForward} variable to forward pass templates * Update VFXHDRPSubOutput.cs suport exclude from TAA in transparent only * Added documentation to exclude from TAA property * Graphic test Added graphic test: 32_ExcludeFromTAA * Update graphic test background for better contrast * Update CHANGELOG.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * Missing Reference image for test 32_ExcludeFromTAA * Add test to cover case exposed by 1258022 (#54) * Fix Custom Spawn serialization (#132) * Allow Set Spawn Count & Set Spawn Time TODO : List Spawn count in available variant * Fix reference lost in m_SerializableType No idea of implication of this :-/ * Squashed commit of the following: (retrieve fix from @tristan) commit c24981d7dad15100eb40a92a6a9370e9ba800acd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 17:27:57 2020 +0200 Update message from @vlad suggestion Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757 commit a87ba182b30da7683e31a29048c9f2f3a0312927 Merge: 13b501e15863 296ffd333bcf Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:25:02 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/error-at-creation # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 13b501e158634dfc98b96058723d248cd5d1f34d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:24:27 2020 +0200 *Add warning for CollisionDepthBuffer Update & Fix Changelog.md commit 4bfb1e7c9874d8a9403ca5267d1e10735e52a87b Author: Tristan Genevet <tristan@unity3d.com> Date: Thu Oct 8 18:10:42 2020 +0200 Fix for displaying error from the creation of a node. * Add error feedback on failing custom spawner reference * Revert "Allow Set Spawn Count & Set Spawn Time" This reverts commit 0a6c75cc54072b831dcc56bffc3bbe04734d3324. # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs * Remove unexpected change * *Revert change in changelog * *WIP* add ResolveCustomCallbackInstance Some refactor mark as "TODOPAUL" * Clean implementation : customBehavior & comment * *Add test to cover sanitize before modify references * Change namespace for builtin custom spawner & sanitize * Extend test to verify connexion * *Update changelog.md * Add specific error if customBehavior returns null * Fix corner case when ScriptableObject reference has been lost * Work but not idea with copy/past + potential leak * Better implementation : use directly "MonoScript" * Fix spawnerTest * Rename "Can't found" => "Can't find" * Fix case 1294180 : Error feedback throwing an error while changing capacity (#174) Issue introduced with https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136 And more precisely https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136/commits/27c041da92ec89407ae775fe4c4f24681f156cb8 * [Test] Add test to cover "Thread Group Size" error (#104) * Add test * Add test to cover behavior from case 1271839 * Fix Preset (with exclusion) (#177) * Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog * Fix 1276602 incorrect uchar pcache import (#129) * Base Commit * Updated Documentation with explicit limitations. * Fixed incorrect Merge * Add regression Test * Removed Test as It can't handle Exceptions thrown in Custom Importers * Fixed value divider Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Update gradient test (#151) * Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Sample Point Cache Operator (#92) * Initial commit * Overflow handling options for the user * Addressing mode for overflow to the choice of the user * Foldable to Constant value * Update 09_PointCache.vfx * Added reference images * Remove float-to-integer conversion * Put the choice of the output type in the Inspector only * Simplify output type handling * Sample Point cache != Attribute map => two operators * Update Branch (error .yamato/docs/editor_pinning.png) * Update SamplePointCache.cs * Update 09_PointCache.vfx * Output type set in a cogwheel * Update 09_PointCache.vfx * Revert "Update Branch (error .yamato/docs/editor_pinning.png)" This reverts commit 02f6b6c993c2382bb10669edd16f7d06876a0cbc. * Restore vfx asset * Revert back to using generics for type handling * Update SampleAttributeMap.cs * Reformating + changelog * Update 09_PointCache.vfx * Update SamplePointCache.cs * Refactor of AttributeFromMap using VFXExpressionSampleAttributeMap * Merge branch 'vfx/staging' into vfx/feature/sample-point-cache * Revert "Merge branch 'vfx/staging' into vfx/feature/sample-point-cache" This reverts commit b4a03e182a3e106c2fabc262777615f9c3b94a7e. * Fix point cache vfx + update HDRP vfx * Update URP assets * Fix changelog * Fix Case 1223747 - NaN caused by normal bending (#181) * Update Pass.template * Update CHANGELOG.md * 1293608 - Fix LPPV not working in deferred (#180) * Enable LPPV in HDRP test project * Fix LPPV for gbuffer pass * Add graphics test * Update changelog * Fix 1290493 - Spaceship specific warnings (#176) * Avoid implicit trucation in template + safe normalize setting * Update CHANGELOG.md * Added variants * Delete conditioning on GPU evaluation + conservative safe normalize Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix incorrect compilation condition for linux build (#184) * Fix formatting * Update 26_NonUniformScale kind of sky : gradient instead of procedural * Fix regression from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/176 Issue introduced at 44f497b438b46a54072721d335910bfab3e392ef : Incorrect VFXExpressionCondition See also : https://unity.slack.com/archives/G1BTWN88Z/p1607963794139900?thread_ts=1607955907.136600&cid=G1BTWN88Z * Disable Gradient Sky in 26_NonUniformScale & 33_LightProbe * *Update VFX (newly introduced safeNormalize, default 0) * Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA * Revert "Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA" This reverts commit ddee2e356dc7e529cad2904836fef8a688e546a8. * 32_ExcludeFromTAA : Disable XR * 33_LightProbe : Slighlty increase treshold from 0.0005 to 0.0006 * *Update Image Reference for D312 (mainly missing file) * *Disable 32_ExcludeFromTAA Instability detected. * *Add missing D3D12 image references * Fix GPUEvent & SubGraph (#178) * Fix SelectionHasCompleteSystems Detect correctly if there are dependencies due to GPUEvent (or stripAttribute) * Add allDependenciesIncludingNotCompilable in VFXData This helper is usefull for UI + use it in SelectionHasCompleteSystems * Add note without change the beahvior * Remove debug ToArray() * [Subgraph] Prevent Pasting Context invalid subgraph (#191) * Prevent pasting context within operator/block subgraph * Fix case https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/191#discussion_r102007 Fix Approximate english log warning * Update VFXPaste log message Missing "the" * Fix Mouse Event Binder in player (#175) * Fix missing call to CreateVFXEventAttribute OnValidate is only called in editor, in runtime, we should init cache data with OnEnable * *Update changelog.md * Add editor test to cover Safe Normalize behavior (#189) * Vfx/docs/bugfixes (#188) * Resolved 1272101 * Resolved 1264943 * Removed uncertainty around 'should' * Resolved 1298031 * Added snippets file * Resolved 1292127 * Fixed typos * Resolved 1295296 Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Texture2D Array Layout for Flipbooks (#97) * Initial commit, working for planar primitives only * Increased support to Cube, Decals, Meshes, Lit Planar Primitives, Lit Meshes * Correct handling of depth pass * Added Reference images for test * Added graphic test / restore defaut HD Material This reverts commit 1d8c36af255f41e515cbe3c87ea691125cd43077. * Update Test References * Added Tooltips, simplify input type selection * Fix handling of Lit Mesh output * Automatic Flipbook size for Array Layout * Delete the flipBookSize slot when Texture2DArray is set * More explicative Tooltip + end of flipbook blend fixed * Update CHANGELOG.md * Distortion Quad and Mesh output support * Update VFXAbstractParticleHDRPLitOutput.cs * Retrieve changelog from staging * Added entry * Motion Vector generation improvements (#194) * Added VFX_FEATURE_MOTION_VECTORS_VERTS mode to store motion vector info per vertex Optimized default motion vectors mode to store 4x3 matrix instead of 4x4. Added mode to store each previous vertex position for quads, triangles, lines and points. Refactor of motion vector defines. * Motion vectors support in lines and points * Resize buffer according to the element size * fix points and lines when not using the optimization * Fix motion vectors for lines * Changes suggested in review - Removed misplaced comment in VFXLineStripOutput - Access VFXLineOutput useTargetOffset through GetSettingValue in VFXOutputUpdate - Moved previous frame position calculation to the end of OutputUpdate compute - Added 4 bytes per particle for last frame index in elementToVFXBufferMotionVector buffer - Added noperspective when using VFX_FEATURE_MOTION_VECTORS_VERTS, through VFX_FEATURE_MOTION_VECTORS_INTERPOLATION define. - Fixed order of verts in lineSW particles. * Missing define rename in ParticleMeshes/PassForward.template * Improved condition for discarding due to not enough indirect buffers * Missing renaming of WRITE_MOTION_VECTOR_IN_FORWARD for particle lit meshes * Spawn State documentation (#195) * Added Spawn State doc * Fixed formatting Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Added what's new page and moved blocks out one level in the table of contents (#199) * Added what's new documentation for version 10 * Updated image and minor rewording * Added link from what's new to node library * Updated changelog link Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * HDRP - Fix Debug View Material (#182) * Fix fallback (?) depth state in debug view material Not sure about this : should double check with HDRP team * *Update changelog * *Updare reference image It corresponds to the result in 7.x.x & 8.x.x * *Apply reformat * *Apply reformat (bis) * Fix CameraFade for shadows (#179) * Fix CameraFade for shadows +CameraFade was taking the distance to the light when rendering the shadow map. +Added setting to optionally affect shadow, with warning for multiple cameras +Implemented functions to get camera position and direction * Update CHANGELOG.md * Update CameraFade.cs -Change fade default value to false. -Fix behaviour when affect shadows is false * Update documentation Added Affect shadows setting * Update documentation Modified AffectShadows setting description following @lewisjordan suggestions * Move camera functions to VFXCommonOutput * Remove ${VFXFragmentCommonFunctions} ${VFXFragmentCommonFunctions} was used only for the VFXCommonOutput.hlsl include, which is now generated by VFXCodeGenerator as part of ${VFXPerPassInclude} * Correct Sign operator node output for float when input is 0.0f (#190) * Changed specialization for floats to be consistent with others. * Update CHANGELOG.md * Update test * changed sky, emission scale, and updated references (#203) * Fix ProcessOperatorSign test Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/190 & this change 1d6e19db547ca6a79f75c839825e15943fde6288 * Allow remaking an existing link. (#146) * Allow remaking an existing link. * Update CHANGELOG.md Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> * ShaderGraph loosing reference while updating (sync with 7.x.x) (#185) * Use explicit GetOrRefreshShaderGraphObject & always lazy init the shadeGraph access. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/VFXGraph/Outputs/VFXAbstractParticleHDRPLitOutput.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/Implementations/VFXMeshOutput.cs # com.unity.visualeffectgraph/Editor/Models/VFXGraph.cs # com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs # com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphPostProcessor.cs * Fix shaderGraph not listed in VFXModel This is actually an issue in VFXModel.GetSettings, we don't have any cases like this where the parent value is private. * Update changelog.md Same entry than https://github.com/Unity-Technologies/Graphics/pull/2873/ * Removing changelog entry The actual fix was already there, this code is only a synchronisation with 7.x.x & prior version. * *Minimal test to check actual content of modified property after an override (#171) * Add test to cover behavior from https://fogbugz.unity3d.com/f/cases/1122404/ (#196) * *Updating reference image for D3D12 Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/182 * Force re-apply formatting * Fix ordering for "+" button in blackboard (#197) * Add test to cover behavior of https://fogbugz.unity3d.com/f/cases/1300115/ (#192) * Fix changelog.md (new entries should be in 12.0.) * *Update changelog.md (unexpected diff in 11.x.x) * [Fix Case 1221557] Checkbox Age Particles consistency (#202) * Provides consistent behavior with Add Age and Set Age * Update Changelog * update changelog * Add _CameraViewMatrix shader variable (#208) Add _CameraViewMatrix shader variable in HDRP, instead of using legacy unity_CameraToWorld. Remove functions using unity_CameraToWorld from VFXCommonOutput.hlsl and move to SRP specific VFXCommon.hlsl files * Fix compute culling compilation in URP (case 1309174) (#210) * Add GeometricTools.hlsl include Missing include containing DistanceFromPlane function used by IsSphereOutsideFrustum * Update changelog * [pCache] Fix minor UX issues (#207) * Disable mesh statistic field * Fix cancel while save texture * Fix create pCache from unreadable texture * *Update changelog.md * Fix missing disable for Texture Statistics * Disable motion vector per vertex optimization (#214) Temporarily disable motion vector per vertex optimization. Small refactor for vertex count calculation * Fallback for camera buffers from Main camera (#200) * Add setting for main camera buffer fallback * Move enum to C++ * Update changelog * Rename setting to Main Camera fallback and the option "None" to "No fallback" * Added an entry for Main Camera feedback in the preferences doc. * Updated tooltip * Reworded tooltip and doc entry * Added doc entry for User Systems. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * [VCS] Handle correctly locked asset (#193) * Prelimary refactor : gather IsAssetEditable in common test to ease testing * Move always m_LockedElement in front * Fix inspector of slot container when asset is locked * Fix inspector for VFXManager when asset is locked * *Update changelog.md * Fix incorrect cast in VFXSlotContainerEditor * Use m_LockedElement in blackboard & redirect it when needed Simplify integration from m_ComponentBoard * Fix case 1243947 : Debug View artefact Correctly clear the VFXDebugView while reassigning * *Update changelog.md * Let selection passing through locked label : it allows inspection * Fix locked label in blackboard when empty * Fix "Shader Value is not saved when switching between VFX Manager and Version Control" * Prevent Drag&Drop when asset is locked * Prevent tricky way to instantiate BuildContextualMenu There was an issue while clicking on left & right at the same time * Fix two issue with target - Attach a stopped visualEffect component - Stop & Reset behavior * Fix UpdateDebugMode which could be called too soon In the case of an not yet loaded VisualEffect component (because the VFXGraph has been just recompiled) * Fix ordering We want the "asset locked" just after contentViewContainer and not just before m_ComponentBoard * Update maxAlive state checking the actual IsAssetEditable during update * Fix locked issue with the VFXParameterEditor Should disable everything if IsAssetEditable returns false * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/193#discussion_r109552 blackboard => componentBoard * Mesh Index & Skinned (#30) * Squashed commit of the following: commit f51b7d616b77487339b2ec3db1e2e8bee35b3ae1 Merge: 2589034c08 229945b992 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Apr 6 17:32:10 2020 +0200 Merge branch 'vfx/feature/mesh-sampling-support-texcoord-dimension' into vfx/feature/mesh-sampling-index-buffer commit 229945b99247402006916c9c73a640d2b5662486 Merge: d26b342644 4cd4cb244d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Apr 6 17:31:23 2020 +0200 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 2589034c088795ba63bf61f22e8ba84a7ffe7607 Merge: 47e04162e6 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:24:43 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling-index-buffer commit 47e04162e60683e331c930a02e77f6d5eeae568e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:18:43 2020 +0200 Minor : add a TODO commit a7bd11748549e25789e7515c50b1c3d96499301b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:17:32 2020 +0200 Actually, keep minimal scope for VFX_GENERIC_BUFFER, it's useful for platform testing purpose. commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 0f9fc14afb9e6e8666b39860bd84922eba4a64e5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 16:49:52 2020 +0200 Remove temporary code commit bc8121349789de632d1115a7804a17b882559e1b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 16:02:23 2020 +0200 Choose StructuredBuffer<float> over ByteAddressBuffer commit 21b9d002b29b9887da8661f32505973e75d0420f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 30 17:16:37 2020 +0200 Change Buffer<uint> to Buffer<float> to avoid dx warning issue. commit be691cd625a18194c5662de17c952613b4f591e3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Mar 29 19:06:25 2020 +0200 Fix alignement for ByteAddressBuffer commit 3ec05dfadefc483507d3de12caf4a2e216af6e66 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Mar 29 17:58:05 2020 +0200 WIP : Trying to move to ByteAddressBuffer commit 2cf1db8679851ff55afcd5f17afa8a52b4d9e179 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 18:06:49 2020 +0100 add note for later commit e6fd7c1931919c657b7c65f8197be03e387e56dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 17:44:24 2020 +0100 *Draft test data (will be removed) commit c84f0e927ebe00f655d3fb92bbe98d6c03fdcf34 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 17:16:12 2020 +0100 Fix expressionMesh format commit 6f48ffbdb55f38da5750f63fc1a38d79a5d19800 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 15:01:01 2020 +0100 Update draft test commit edec8e1e997188e0dbc82ad9bb38e0ac178476d2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 15:00:41 2020 +0100 Sample Index *WIP* commit 2853d8b25eabd0dcf3f5af4718d71f17685d5a7b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 15:54:29 2020 +0100 *Remove End expression for mesh evaluation (invalid because we can't guess context for this case) commit d4f09e0cc4c058d07a2c40366e4e0bd45476d7fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 12:00:30 2020 +0100 Add minimal integration for newly added VFXExpressionVertexBufferFromMesh commit baf39dcdf6fc340269fb5442c763e4932ead57f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:59:25 2020 +0100 Add test data (to revert) commit 7a2fd0337ecc965dcea105dfd34973499f736bb8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:58:53 2020 +0100 Revert "Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh" This reverts commit 6d507a684f14dc09641877d6d691fd96adb63be4. commit 6d507a684f14dc09641877d6d691fd96adb63be4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:56:51 2020 +0100 Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh commit d26b342644bc08c2ab4118a71899bb78a2c303a7 Merge: b1512335cb 40749ce2ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 09:27:26 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit b1512335cb09b7b3e1ee783f991347704c4952be Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 18:24:05 2020 +0100 Fix after merge commit 43e25995ca9a15aa0ee5c88297616ccbd3fc5c2d Merge: e357f4871b 7abaf9bbf2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 17:47:34 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionMesh.cs commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit e357f4871b8c39257c62daf1fe63f85241325712 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 25 08:56:53 2020 +0100 Fix build in 2020.1 to resolve comment https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/258#pullrequestreview-52608 commit bfc0d9f7aeaa8b34407bfa8279d30bf59cf55099 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 18:44:28 2020 +0100 *Fix compilation commit 6cfd2d90292796c5b21e63d01c4b4bf8563c0184 Merge: 41a1a8e212 128101bc63 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 14:56:22 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 41a1a8e212c82b48832ab88f68348c145c0960c6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 15:19:24 2020 +0100 *Update expression name commit 27794064fd01207a35e7d967ff322e9d552a2054 Merge: ad597a0388 28f0ca20a0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 10:21:38 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit ad597a03881e11743e68555f985c304ee2d7557d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:18:40 2020 +0100 Support float or uint read in sample mesh color commit 8ca98dd9a375431ddc04c7a0cb625c35a2c99f57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 10:05:40 2020 +0100 Add compatibility code & use new available expression from https://ono.unity3d.com/unity/unity/changeset/6afd1f99b768984023366f3aba746390c763432f commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Sample mesh, add placement mode : Surface & Edge *WIP* * Some experiment with low distorsion mapping * *WIP* debug data (will be removed anyway) * Clean BarycentricCoordinatesBis * Fix to graft : support for flag enum in inspector * Add animation test data from @vlad * Test scene *WIP* * Use GetVertexStride depending of channelIndex & VFXExpressionVertexBufferFromMesh depending of channelFormatAndDimensionAndStream * *WIP* pushing test data * *Push Some test data (will be removed) * Fix test adding a *WIP* note * Minor fixes after merge * Add SkinnedMeshRenderer exposable * Add SkinnedMeshRenderer in IsTypeConstantFoldable * Add VFXExpressionSampleSkinnedMeshRendererFloat & co support (it should be factorizable) * Move hexahredron to common data, it will be convinient for graphicTest * Fix PositionMesh (bad merge) * Implement Graphic Test for skinned mesh (not yet tested in standalone yet) * *Add reference images * Clean some code, remove intermediate compatibility code * Add variant provider for sample mesh * Factorize sampling function to share them with PositionMesh * Start factorization of SamplePositionMesh * Add simple TODOPAUL * Add another TODOPAUL * Change VertexAttributeFlag to VertexAttribute, use proper mesh type in MeshPosition * Implement surface coordinate & sample vertex for position mesh * Remove test data & Update actual graphicTest * Use nameof instead of verbatim (this code will not be backported) * Fix sample edge * Add skinned & mesh index/vertex count * Fix editor test (todo : graft this change to master to anticipate the C++ change) * *Update reference image for mesh sampling * *Add sampleMesh index for skinned & mesh * Fix after merge (wasn't so obvious but now works \o/ Can be factorized) * Simpler update to use now available ByteAddressBuffer # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionAbstract.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.hlsl * Revert "Simpler update to use now available ByteAddressBuffer" (onluy VFXCommon.hlsl) This reverts commit 65b5ce1c588b969b95726a83d06a34a386a8c16d. * Fix compilation * Fix wrong return type of FetchBuffer * *Restore lost test for triangle sampling * Proper sample OOB fix * Use explicit branch in SampleMeshReadFloat : we aren't supposed fetch in invalid buffer * Enable GPUSkinng, default mode * Remove float cast for condition since we are able to compare uint * Factorize insertGPUTransformation using the common switch * Clean multiple place where "ByteAddressBuffer" is declared * Simply generated code verifying at http://shader-playground.timjones.io/d7df4e7dbec05529d6943aacca2812b9 * Remove unexpected restored file (as been renamed) * *Update changelog * *Fix build * *Update image reference * Remove useless case in GetFunctionParameterType (ByteAddressBuffer is in TypeToCode anyway) * Fix after merge * First draft of documentation for sample mesh * *Update documentation * *up doc * *documentation * Add documentation for Mesh Index Count & Vertex Count * *documentation * *Remove unexpected change & deprecated code * *documentation * Remove unexpected change in changelog.mp * *Apply formatting * *Update documentation * Minor documentation update * Documentation : add "inspector" flag when relevant * Rename confusing "x" in "edge" See https://docs.google.com/document/d/1VbIc5pMkgFX2Ui4-LWrZ7uQ4EKlXlFxWWW4ufcex70I/edit * *Remove deprecated MeshSampling & Update TOC * Reviewed the Set Position(Mesh) doc * Reviewed mesh index count doc * reviewed the rest of the sample mesh operators. * Fix ToC & rename some "Skinned Mesh Renderer" in "Skinned Mesh" * Missing minor change * *Reupdate VFX after merge * Fix several tooltip issues - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89530 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89531 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89532 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89533 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89534 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89535 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89536 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89538 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89539 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89540 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89541 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89542 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89544 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89545 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89546 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89547 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89548 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89549 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89550 * Forgot to stage files from previous commit d8c1bef513605c8c7b40ec855cfe2be4de2e7d5e * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109724 Remove not needed UNITY_2020_2_OR_NEWER condition * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109727 Isolate helper function to VFXMeshSampling.hlsl * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109725 - Rename sourceExpression to targetExpression - Add InvalidOperationException if we are detecting an unexpected graph * Add missing compile of channelFormatAndDimensionAndStream - Check branch behavior - Trying to find infinite recursion due to dependent sampling - TODO : Add an editor test to inspect the actual generated graph (already checked in debug) Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * *Update all VisualEffectAsset "flipbookLayout: 0" everywhere + Some missing meta in test project (minor) * *Apply formatting * *Update missing reference images * Other missing update screenshot & missing meta * Fix formatting : this change can be grafted directly on master * Three minor fixes from https://github.com/Unity-Technologies/Graphics/pull/3414 - Wrong Image reference : Fix D3D11 standalone - Unconsistent debug assert (the recreate can be called on subslot) : Fix Space_Slot_Sanitize_Still_Possible_ArcSphere - CreateComponentWithAllBasicTypeExposed : remove VFXValueType.CameraBuffer from list of tested exposed type (it can'td irectly be exposed) These change can independantly land in `master` * Fix incorrect changelog.md in com.unity.visualeffectgraph * Remove unexpected duplicated entry in changelog.md * Fix changelog : unexpected removed entries in 11.x * *Update changelog.md * [BRP] Fix Shader Compilation (#216) * Fix incorrect direct access to GetWorldToObjectMatrix * *Update changelog.md * Sphere and cube outputs as experimental * Add castShadows as additionalMappings in VFXStaticMeshOutput (#217) * [Orient] 'Look At Position' particle disappearance (#101) * Expensive fix Computes two cross products to avoid the case when one of them is zero. Is it faster than branching to check ? Is this edge case worth the additional cost ? * More explicit approach/similar instruction cost + LookAtLine * Update Orient.cs * Handles edge case when cross(axis1, axis2) = (0,0,0) for all Orient variants * Small mistake in the exception message * Factorize SafeNormalizedCross * Update changelog * Added information about compute shaders and ssbos (#222) * Added information about compute shaders and ssbos * Added recommendation to use Vulkan over OpenGL ES * Removed 'two' * Added entry about vfx graph not being out of preview for mobile platforms Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * [Fix] PropertyBinder : Reset & Undo (#212) * Fix missing record object for proper undo/redo & reset * *Update changelog.md * Fix issue https://favro.com/organization/c564ede4ed3337f7b17986b6/1973edb4634ba00a90689144?card=Uni-160638 * Avoid VFXPropertyBinder to be added twice * Fix incorrect reference after copy past * Fix RemoveComponent clearing property binder first * Handle Copy/Past \o/ * Let the LateUpdate without any editor code & use Update (avoid the one frame of latency for inspector) * Remove useless recompute of GetComponents every frame, and use Reload (safer) * Remove dead code * *Add new entry in changelog (side improvement/fix) * *Update comment * [Fix] Null Ref Exception due to IsAssetEditable (#221) * Resource can be null on a block inspector while we are removing it Use safe check of resource before IsAssetEditable * *Update changelog * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/221#discussion_r113060 * [Fix] Component Board UX issue (#220) * Fix missing call to OnSelectionChanged on first display (before selection changed called) * Fix change from component notifying the VFXView * Fix toggle component board state * Minor fixes * *Update changelog.md * [Fix] System name 'Model is not registered' (#224) * *Add editor test to catch corner case issue with system name * Move Create_Simple_Graph_Then_Remove_Edget_Between_Init_And_Update_TestCaseto VFXGUITest * Actual fix of 1315593 The flow edge change is only triggering kConnectionChanged so, if you are trying to access m_SystemNames before compilation * Remove unexpected change * [Test] Revert after change (#213) * Local test (I'm using git diff to check actual file change) * test adding a lit mesh output * *Testing with shaderGraph * *test bis * *Add unit test to cover unexpected increasing size * Properly implement the test * Remove test data * *Temp lot of log & save it to independant file * HotFix : UpdateSubAsset in OnPreprocessAsset Shouldn't be necessary, the actual problem is maybe in C++ implementation * Clean test & add comment * *WIP* Serialization test which seems (tm) to reproduce the same issue * To revert : experiment adding log while loading VFXSerializableObject *Without Import Asset after write* Saving : 100 Loading : 100 Loading : 100 OnBeforeSerialize : 100 Saving : 101 Loading : 101 Loading : 101 OnAfterDeserialize : 100 Loading : 100 => Test fail ! *With Import Asset after write* Saving : 100 Loading : 100 Loading : 100 OnBeforeSerialize : 100 OnAfterDeserialize : 100 Saving : 101 Loading : 101 Loading : 101 Loading : 101 OnBeforeSerialize : 101 OnAfterDeserialize : 101 Saving : 102 Loading : 102 Loading : 102 Loading : 102 OnBeforeSerialize : 102 OnAfterDeserialize : 102 Saving : 103 Loading : 103 Loading : 103 * *Revert unwanted change * Clean & Unify test behavior * Safety check in newly integrated test (if asset is empty, it isn't expected neither) * Remove OnCompile : Avoid recompile twice, the WriteAsset is already trigerring an import * [Test] Add test to cover CopyValuesFrom (#225) * *Add test to cover CopyValuesFrom issue * *Extend the newly added test Check every value in copied values * Just added a perf marker * Changed `mobile` to `Android` (#227) * Fix "`syntax error: unexpected token 'if' at kernel CSMain`" (#228) int ia, int ib, ... is actually not needed since "i" remains an local scope value * [Fix] Deleted properties still visible in inspector (#231) * Fix missing BuildParameterInfo when we are removing a VFXParameter * Minor : fix typo in comment * Fix cases where some settings change didnt trigger a recompilation (#233) * Prevent focus on empty element if search list is empty (#229) See this rero : https://fogbugz.unity3d.com/f/cases/1235269/#BugEvent.1073014330 * handle constant folding correctly with SG interpolators * Added note about gamma color space in URP (#237) Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Check if parameter is null in AdvancedVisualEffectEditor::EmptyLineControl (#238) * Vfx/docs/point cache update (#234) * Added sample content documentation * Added point cache rewrite * Fixed toc formatting Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fixed various docs issues (#243) * Fixed incorrect indentation in the toc * Fixed capitalization surrounding Operator * Fixed capitalization surrounding Block * Fixed capitalization surrounding Context * Fixed table format * Added flipbook layout property * Removed outdated information * Fixed table format * Moved image to next line * Added information about when the flipbook layout property appears Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Added new documentation for sampling point caches and attribute maps (#241) * Added new documentation for sampling point caches and attribute maps * Added link to attribute map definition Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Add suffix to loop variable to avoid shader warnings (#240) * Fix issue with output mesh always triggering reimport + Fix modified state (#242) * Fix VFX with output mesh being always recompiled * Fix modified state (* being correct now) * Update save state * Use macros for texture sampling (#244) * Use macros for texture sampling + remove ambiguity between sample and sampleLOD * Forgot to do it for gradient and curve * [Fix] Unexpected expression in spawn context (#235) * Fix missing filter in per spawn expression computation * Cache the indexOfLastCommonExpression in graph * *Update changelog.md * Update HDRP VFX * Update URP Assets * [Feature] Bounds Computation helper (#201) * [Feature] Signed Distance Field Baker (#186) * Proper bounds transform (#247) * Proper bounds transform * Remove bounds padding in manual * Fix editor tests * More stable Graphics test (cherry picked from commit ef9b090fd6a8f322ea8bca0719a9b291423d15ac) * Fix sanitize for bounds mode (cherry picked from commit 4a09093f8b72c41e516f0c78a2b7e453569167cb) * Update HDRP assets (cherry picked from commit a74d2c405548307fc9e5785c12eccd11e5cbc403) * Fix compil in URP (cherry picked from commit fd8aa0847ed550a651969ed158b73214f1829802) * Update URP assets (cherry picked from commit 0b81e0f087981bbae9727003fc4ce778c753c7b5) * Formatting (cherry picked from commit d643152f0e3eef9fd3688102c2a21369a71575d2) * Update assets * Remove Input layout (cherry picked from commit d24654ac7ce462e84a4db87d36cf8a912fd51660) * Animator Culling mode : Always Animate (cherry picked from commit c1d3ab6d404b75ee12e7a5ab8ee6923258c3853f) * Fix filename to solve formatter issue (cherry picked from commit 48ca232718ffa6a6490fe7b44b0f58db5d9c3e16) * Remove old files (cherry picked from commit 4ebe6284d6d8aeeff450ad9f4595415eb9ef19b5) * Changes images of windows standalone (cherry picked from commit a1678a1b242c2625b6840ecfe96fb1448cd9af9b) * SDF Baker API Docs (#249) * Remove input layout * Animator Always Update * Revert "Animator Always Update" This reverts commit feea94bc6d9a77a671a8ae969cdd8a0b49bae78e. * Revert "Revert "Animator Always Update"" This reverts commit 16f86567f949f0eff6e5d8bd011e3e82a9aad9c5. * First commit on changing docs * More changes to modifiers * Documentation for API + IDisposable MeshToSDFBaker IDisposable is removed for the sdfPreview because it forced the Dispose function to be public, and had no real use * Fix build VFX_HDRP * Fix 'MeshToSDFBaker.m_DefaultPath' is assigned but its value is never used Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> * *Force Apply formatting * Update HDRP project assets * Fix 1336155: incorrect buffer type for strips * Forgot to update change log * What's new in version 11 (#245) * [Fix] Bounds Helper Polish (#250) * Null-check the bounds recorder when saving * Clean * Record system + warnings only if valid * Tooltip for Bounds Setting mode * formatting * Use CanBeCompiled instead of manual checks * Update HDRP assets * Remove currently useless URPSubOutput serialization * Update URP assets * Fix VFX using new SG integration being always dirty * [VFX] Enable motion vectors optimization in XR (#246) * Store projected position for vertices on each XR view when using VFX_FEATURE_MOTION_VECTORS_VERTS * Update changelog * Moving VFXCameraXRSettings out of VFXManager * Group camera XR settings in a single property * Remove useless reimport/save issues (#253) * Fix issues with subgraphs * Check isDirty before saving dependencies * Misc stuff * Formatting * formatting * Remove unused meta * [Fix] Prevent exception when inverting a degenerate TRS matrix (#252) * Prevent degenerate TRS matrices * Changelog + epsilon only for small values * Consistently output a zero-matrix when evaluated in C#, C++ or GPU * [Fix] normalWS compilation in depth unlit (#256) * Fix normalWS compilation error Only occurs if shaderGraph is using normal in opacity * Fix missing varying for normal & tangent Only if shadergraph needs those * [VFX] Add frontface semantic to vfx using shader graph materials (#257) * Add frontface semantic to vfx using shader graph materials * Update changelog * [VFX] Motion vectors for particle strips (#251) * Motion vectors for quad particle strips * Motion vectors for line particle strips * StripsMotionVector Graphic test Result image for windows used in all platforms * Store 2 verts per particle for quad strips and 1 per particle for line strips * Modify reference images .meta files * Update changelog * Get particle index from thread id * [Fix][SDFBaker] Unity Crash when switching SDF Baker saved settings containing prefabs (#264) * Use mesh instead of selectedMesh when loading params and to display FitToBox/Cube * update changelog * [Fix] Overlay Gizmo (#260) * Fix case 1340818 Separate Gizmo rendering from Overlay rendering See also https://unity.slack.com/archives/C014H2BPXMY/p1623158419065000?thread_ts=1622793094.052000&cid=C014H2BPXMY * *Update changelog.md * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/260#issuecomment-56740 Since gizmo & overaly rendering are now separated, we have to "Prepare" the gizmo Solution : use the common helper to properly cache needed gizmo data while clicking on "frame button" Simpler & Safer solution * Fix corner case issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/260#issuecomment-57521 Thanks @vita-skruibyte We have a process which invalid the gizmo cache : https://github.cds.internal.unity3d.com/unity/vfx-graphics/blob/vfx/staging/com.unity.visualeffectgraph/Editor/Inspector/AdvancedVisualEffectEditor.cs#L312 (see PropertyOverrideChanged) However, If we are trying to rebuild the gizmo property before the next inspector invalidation, the m_VFXPropertySheet won't be up to date. Use m_SerializedObject.Update(); when rebuilding the gizmo cache (this m_SerializedObject.Update(); will be called every frame anyway : https://github.cds.internal.unity3d.com/unity/vfx-graphics/blob/vfx/staging/com.unity.visualeffectgraph/Editor/Inspector/AdvancedVisualEffectEditor.cs#L373) * [Fix][1309958] Collide with Depth Buffer in Orthographi…

* Vfx/fix/additional subgraphs 2 (#155) * Updated Changelog * Updated Blocks with Fixes and Missing Workflows * update VFX additions Co-authored-by: Thomas Iché <peeweek@gmail.com> * Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139) * Reindex the TEXCOORD[n] * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix serveral minor issues (#103) Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458987790 Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988272 Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988870 * Update rebuild all script to take subgraph into account * Update VFX assets * Fix URP vfx assets * Fix Event connected directly to Output Event (revival) (#154) * Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment * Fix regression with subgraph * Add Subgraph_Event_Link_To_Spawn editor test * Fix changelog Add entry in the right place from 0009e5373ddd6927977fc8054e2ab16c14b5e81b * Restore disabled 26_NonUnifomScale due to a wrong merge (need backport to 10.x.x) * [HDRP] Fix debug view material (albedo/normal/...) (#163) * Fix debug view material TODO : Add GraphicTest * Fix tab/space mix * Add HDRP debug scene * *Add reference image for HDRD_Debug(Property) * *Update changelog.md * Force ui update when shader might be reimported in StaticMeshOutput (#158) * Don't create VFXGraph during import callbacks (#148) * do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation * Add the necessary openasset callback for the system to know if we open the asset inside the editor. (#118) * Added OnOpenAssetAttributeMode.Validate * added UNITY_2021_1 * remove the shaders has they are not edited in the editor. * Fix macro * Select node on create (#166) * Select node on create * Fix for right click in block and add doesn't deselect clicked block * fix for subgraph not being selected on drag and drop * Select converted node/block after convert subgraph * Fix for selection undo separate in some cases. Fixed flow anchor drag context selection. * Fix for undo of add subgraph operator * “Refactor” * "Refactor" bis (some file has been missed) * Dont flag dirty in vfxgraph is the model modified is a copy (#165) * Workflow improvement : Change VisualEffect inspector "Edit" button to "New" when no asset is set. (#173) * Base Commit * Documentation * Updated Changelog * Fixed Typo Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Added excludeFromTAA setting to VFX outputs (#170) * Added excludeFromTAA setting to VFX outputs Added excludeFromTAA setting to VFX outputs. Currently it is only supported in HDRP suboutputs. Required adding ${VFXStencilForward} variable to forward pass templates * Update VFXHDRPSubOutput.cs suport exclude from TAA in transparent only * Added documentation to exclude from TAA property * Graphic test Added graphic test: 32_ExcludeFromTAA * Update graphic test background for better contrast * Update CHANGELOG.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * Missing Reference image for test 32_ExcludeFromTAA * Add test to cover case exposed by 1258022 (#54) * Fix Custom Spawn serialization (#132) * Allow Set Spawn Count & Set Spawn Time TODO : List Spawn count in available variant * Fix reference lost in m_SerializableType No idea of implication of this :-/ * Squashed commit of the following: (retrieve fix from @tristan) commit c24981d7dad15100eb40a92a6a9370e9ba800acd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 17:27:57 2020 +0200 Update message from @vlad suggestion Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757 commit a87ba182b30da7683e31a29048c9f2f3a0312927 Merge: 13b501e15863 296ffd333bcf Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:25:02 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/error-at-creation # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 13b501e158634dfc98b96058723d248cd5d1f34d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:24:27 2020 +0200 *Add warning for CollisionDepthBuffer Update & Fix Changelog.md commit 4bfb1e7c9874d8a9403ca5267d1e10735e52a87b Author: Tristan Genevet <tristan@unity3d.com> Date: Thu Oct 8 18:10:42 2020 +0200 Fix for displaying error from the creation of a node. * Add error feedback on failing custom spawner reference * Revert "Allow Set Spawn Count & Set Spawn Time" This reverts commit 0a6c75cc54072b831dcc56bffc3bbe04734d3324. # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs * Remove unexpected change * *Revert change in changelog * *WIP* add ResolveCustomCallbackInstance Some refactor mark as "TODOPAUL" * Clean implementation : customBehavior & comment * *Add test to cover sanitize before modify references * Change namespace for builtin custom spawner & sanitize * Extend test to verify connexion * *Update changelog.md * Add specific error if customBehavior returns null * Fix corner case when ScriptableObject reference has been lost * Work but not idea with copy/past + potential leak * Better implementation : use directly "MonoScript" * Fix spawnerTest * Rename "Can't found" => "Can't find" * Fix case 1294180 : Error feedback throwing an error while changing capacity (#174) Issue introduced with https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136 And more precisely https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136/commits/27c041da92ec89407ae775fe4c4f24681f156cb8 * [Test] Add test to cover "Thread Group Size" error (#104) * Add test * Add test to cover behavior from case 1271839 * Fix Preset (with exclusion) (#177) * Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog * Fix 1276602 incorrect uchar pcache import (#129) * Base Commit * Updated Documentation with explicit limitations. * Fixed incorrect Merge * Add regression Test * Removed Test as It can't handle Exceptions thrown in Custom Importers * Fixed value divider Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Update gradient test (#151) * Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Sample Point Cache Operator (#92) * Initial commit * Overflow handling options for the user * Addressing mode for overflow to the choice of the user * Foldable to Constant value * Update 09_PointCache.vfx * Added reference images * Remove float-to-integer conversion * Put the choice of the output type in the Inspector only * Simplify output type handling * Sample Point cache != Attribute map => two operators * Update Branch (error .yamato/docs/editor_pinning.png) * Update SamplePointCache.cs * Update 09_PointCache.vfx * Output type set in a cogwheel * Update 09_PointCache.vfx * Revert "Update Branch (error .yamato/docs/editor_pinning.png)" This reverts commit 02f6b6c993c2382bb10669edd16f7d06876a0cbc. * Restore vfx asset * Revert back to using generics for type handling * Update SampleAttributeMap.cs * Reformating + changelog * Update 09_PointCache.vfx * Update SamplePointCache.cs * Refactor of AttributeFromMap using VFXExpressionSampleAttributeMap * Merge branch 'vfx/staging' into vfx/feature/sample-point-cache * Revert "Merge branch 'vfx/staging' into vfx/feature/sample-point-cache" This reverts commit b4a03e182a3e106c2fabc262777615f9c3b94a7e. * Fix point cache vfx + update HDRP vfx * Update URP assets * Fix changelog * Fix Case 1223747 - NaN caused by normal bending (#181) * Update Pass.template * Update CHANGELOG.md * 1293608 - Fix LPPV not working in deferred (#180) * Enable LPPV in HDRP test project * Fix LPPV for gbuffer pass * Add graphics test * Update changelog * Fix 1290493 - Spaceship specific warnings (#176) * Avoid implicit trucation in template + safe normalize setting * Update CHANGELOG.md * Added variants * Delete conditioning on GPU evaluation + conservative safe normalize Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix incorrect compilation condition for linux build (#184) * Fix formatting * Update 26_NonUniformScale kind of sky : gradient instead of procedural * Fix regression from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/176 Issue introduced at 44f497b438b46a54072721d335910bfab3e392ef : Incorrect VFXExpressionCondition See also : https://unity.slack.com/archives/G1BTWN88Z/p1607963794139900?thread_ts=1607955907.136600&cid=G1BTWN88Z * Disable Gradient Sky in 26_NonUniformScale & 33_LightProbe * *Update VFX (newly introduced safeNormalize, default 0) * Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA * Revert "Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA" This reverts commit ddee2e356dc7e529cad2904836fef8a688e546a8. * 32_ExcludeFromTAA : Disable XR * 33_LightProbe : Slighlty increase treshold from 0.0005 to 0.0006 * *Update Image Reference for D312 (mainly missing file) * *Disable 32_ExcludeFromTAA Instability detected. * *Add missing D3D12 image references * Fix GPUEvent & SubGraph (#178) * Fix SelectionHasCompleteSystems Detect correctly if there are dependencies due to GPUEvent (or stripAttribute) * Add allDependenciesIncludingNotCompilable in VFXData This helper is usefull for UI + use it in SelectionHasCompleteSystems * Add note without change the beahvior * Remove debug ToArray() * [Subgraph] Prevent Pasting Context invalid subgraph (#191) * Prevent pasting context within operator/block subgraph * Fix case https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/191#discussion_r102007 Fix Approximate english log warning * Update VFXPaste log message Missing "the" * Fix Mouse Event Binder in player (#175) * Fix missing call to CreateVFXEventAttribute OnValidate is only called in editor, in runtime, we should init cache data with OnEnable * *Update changelog.md * Add editor test to cover Safe Normalize behavior (#189) * Vfx/docs/bugfixes (#188) * Resolved 1272101 * Resolved 1264943 * Removed uncertainty around 'should' * Resolved 1298031 * Added snippets file * Resolved 1292127 * Fixed typos * Resolved 1295296 Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Texture2D Array Layout for Flipbooks (#97) * Initial commit, working for planar primitives only * Increased support to Cube, Decals, Meshes, Lit Planar Primitives, Lit Meshes * Correct handling of depth pass * Added Reference images for test * Added graphic test / restore defaut HD Material This reverts commit 1d8c36af255f41e515cbe3c87ea691125cd43077. * Update Test References * Added Tooltips, simplify input type selection * Fix handling of Lit Mesh output * Automatic Flipbook size for Array Layout * Delete the flipBookSize slot when Texture2DArray is set * More explicative Tooltip + end of flipbook blend fixed * Update CHANGELOG.md * Distortion Quad and Mesh output support * Update VFXAbstractParticleHDRPLitOutput.cs * Retrieve changelog from staging * Added entry * Motion Vector generation improvements (#194) * Added VFX_FEATURE_MOTION_VECTORS_VERTS mode to store motion vector info per vertex Optimized default motion vectors mode to store 4x3 matrix instead of 4x4. Added mode to store each previous vertex position for quads, triangles, lines and points. Refactor of motion vector defines. * Motion vectors support in lines and points * Resize buffer according to the element size * fix points and lines when not using the optimization * Fix motion vectors for lines * Changes suggested in review - Removed misplaced comment in VFXLineStripOutput - Access VFXLineOutput useTargetOffset through GetSettingValue in VFXOutputUpdate - Moved previous frame position calculation to the end of OutputUpdate compute - Added 4 bytes per particle for last frame index in elementToVFXBufferMotionVector buffer - Added noperspective when using VFX_FEATURE_MOTION_VECTORS_VERTS, through VFX_FEATURE_MOTION_VECTORS_INTERPOLATION define. - Fixed order of verts in lineSW particles. * Missing define rename in ParticleMeshes/PassForward.template * Improved condition for discarding due to not enough indirect buffers * Missing renaming of WRITE_MOTION_VECTOR_IN_FORWARD for particle lit meshes * Spawn State documentation (#195) * Added Spawn State doc * Fixed formatting Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Added what's new page and moved blocks out one level in the table of contents (#199) * Added what's new documentation for version 10 * Updated image and minor rewording * Added link from what's new to node library * Updated changelog link Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * HDRP - Fix Debug View Material (#182) * Fix fallback (?) depth state in debug view material Not sure about this : should double check with HDRP team * *Update changelog * *Updare reference image It corresponds to the result in 7.x.x & 8.x.x * *Apply reformat * *Apply reformat (bis) * Fix CameraFade for shadows (#179) * Fix CameraFade for shadows +CameraFade was taking the distance to the light when rendering the shadow map. +Added setting to optionally affect shadow, with warning for multiple cameras +Implemented functions to get camera position and direction * Update CHANGELOG.md * Update CameraFade.cs -Change fade default value to false. -Fix behaviour when affect shadows is false * Update documentation Added Affect shadows setting * Update documentation Modified AffectShadows setting description following @lewisjordan suggestions * Move camera functions to VFXCommonOutput * Remove ${VFXFragmentCommonFunctions} ${VFXFragmentCommonFunctions} was used only for the VFXCommonOutput.hlsl include, which is now generated by VFXCodeGenerator as part of ${VFXPerPassInclude} * Correct Sign operator node output for float when input is 0.0f (#190) * Changed specialization for floats to be consistent with others. * Update CHANGELOG.md * Update test * changed sky, emission scale, and updated references (#203) * Fix ProcessOperatorSign test Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/190 & this change 1d6e19db547ca6a79f75c839825e15943fde6288 * Allow remaking an existing link. (#146) * Allow remaking an existing link. * Update CHANGELOG.md Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> * ShaderGraph loosing reference while updating (sync with 7.x.x) (#185) * Use explicit GetOrRefreshShaderGraphObject & always lazy init the shadeGraph access. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/VFXGraph/Outputs/VFXAbstractParticleHDRPLitOutput.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/Implementations/VFXMeshOutput.cs # com.unity.visualeffectgraph/Editor/Models/VFXGraph.cs # com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs # com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphPostProcessor.cs * Fix shaderGraph not listed in VFXModel This is actually an issue in VFXModel.GetSettings, we don't have any cases like this where the parent value is private. * Update changelog.md Same entry than https://github.com/Unity-Technologies/Graphics/pull/2873/ * Removing changelog entry The actual fix was already there, this code is only a synchronisation with 7.x.x & prior version. * *Minimal test to check actual content of modified property after an override (#171) * Add test to cover behavior from https://fogbugz.unity3d.com/f/cases/1122404/ (#196) * *Updating reference image for D3D12 Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/182 * Force re-apply formatting * Fix ordering for "+" button in blackboard (#197) * Add test to cover behavior of https://fogbugz.unity3d.com/f/cases/1300115/ (#192) * Fix changelog.md (new entries should be in 12.0.) * *Update changelog.md (unexpected diff in 11.x.x) * [Fix Case 1221557] Checkbox Age Particles consistency (#202) * Provides consistent behavior with Add Age and Set Age * Update Changelog * update changelog * Add _CameraViewMatrix shader variable (#208) Add _CameraViewMatrix shader variable in HDRP, instead of using legacy unity_CameraToWorld. Remove functions using unity_CameraToWorld from VFXCommonOutput.hlsl and move to SRP specific VFXCommon.hlsl files * Fix compute culling compilation in URP (case 1309174) (#210) * Add GeometricTools.hlsl include Missing include containing DistanceFromPlane function used by IsSphereOutsideFrustum * Update changelog * [pCache] Fix minor UX issues (#207) * Disable mesh statistic field * Fix cancel while save texture * Fix create pCache from unreadable texture * *Update changelog.md * Fix missing disable for Texture Statistics * Disable motion vector per vertex optimization (#214) Temporarily disable motion vector per vertex optimization. Small refactor for vertex count calculation * Fallback for camera buffers from Main camera (#200) * Add setting for main camera buffer fallback * Move enum to C++ * Update changelog * Rename setting to Main Camera fallback and the option "None" to "No fallback" * Added an entry for Main Camera feedback in the preferences doc. * Updated tooltip * Reworded tooltip and doc entry * Added doc entry for User Systems. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * [VCS] Handle correctly locked asset (#193) * Prelimary refactor : gather IsAssetEditable in common test to ease testing * Move always m_LockedElement in front * Fix inspector of slot container when asset is locked * Fix inspector for VFXManager when asset is locked * *Update changelog.md * Fix incorrect cast in VFXSlotContainerEditor * Use m_LockedElement in blackboard & redirect it when needed Simplify integration from m_ComponentBoard * Fix case 1243947 : Debug View artefact Correctly clear the VFXDebugView while reassigning * *Update changelog.md * Let selection passing through locked label : it allows inspection * Fix locked label in blackboard when empty * Fix "Shader Value is not saved when switching between VFX Manager and Version Control" * Prevent Drag&Drop when asset is locked * Prevent tricky way to instantiate BuildContextualMenu There was an issue while clicking on left & right at the same time * Fix two issue with target - Attach a stopped visualEffect component - Stop & Reset behavior * Fix UpdateDebugMode which could be called too soon In the case of an not yet loaded VisualEffect component (because the VFXGraph has been just recompiled) * Fix ordering We want the "asset locked" just after contentViewContainer and not just before m_ComponentBoard * Update maxAlive state checking the actual IsAssetEditable during update * Fix locked issue with the VFXParameterEditor Should disable everything if IsAssetEditable returns false * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/193#discussion_r109552 blackboard => componentBoard * Mesh Index & Skinned (#30) * Squashed commit of the following: commit f51b7d616b77487339b2ec3db1e2e8bee35b3ae1 Merge: 2589034c08 229945b992 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Apr 6 17:32:10 2020 +0200 Merge branch 'vfx/feature/mesh-sampling-support-texcoord-dimension' into vfx/feature/mesh-sampling-index-buffer commit 229945b99247402006916c9c73a640d2b5662486 Merge: d26b342644 4cd4cb244d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Apr 6 17:31:23 2020 +0200 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 2589034c088795ba63bf61f22e8ba84a7ffe7607 Merge: 47e04162e6 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:24:43 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling-index-buffer commit 47e04162e60683e331c930a02e77f6d5eeae568e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:18:43 2020 +0200 Minor : add a TODO commit a7bd11748549e25789e7515c50b1c3d96499301b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:17:32 2020 +0200 Actually, keep minimal scope for VFX_GENERIC_BUFFER, it's useful for platform testing purpose. commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 0f9fc14afb9e6e8666b39860bd84922eba4a64e5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 16:49:52 2020 +0200 Remove temporary code commit bc8121349789de632d1115a7804a17b882559e1b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 16:02:23 2020 +0200 Choose StructuredBuffer<float> over ByteAddressBuffer commit 21b9d002b29b9887da8661f32505973e75d0420f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 30 17:16:37 2020 +0200 Change Buffer<uint> to Buffer<float> to avoid dx warning issue. commit be691cd625a18194c5662de17c952613b4f591e3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Mar 29 19:06:25 2020 +0200 Fix alignement for ByteAddressBuffer commit 3ec05dfadefc483507d3de12caf4a2e216af6e66 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Mar 29 17:58:05 2020 +0200 WIP : Trying to move to ByteAddressBuffer commit 2cf1db8679851ff55afcd5f17afa8a52b4d9e179 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 18:06:49 2020 +0100 add note for later commit e6fd7c1931919c657b7c65f8197be03e387e56dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 17:44:24 2020 +0100 *Draft test data (will be removed) commit c84f0e927ebe00f655d3fb92bbe98d6c03fdcf34 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 17:16:12 2020 +0100 Fix expressionMesh format commit 6f48ffbdb55f38da5750f63fc1a38d79a5d19800 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 15:01:01 2020 +0100 Update draft test commit edec8e1e997188e0dbc82ad9bb38e0ac178476d2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sat Mar 28 15:00:41 2020 +0100 Sample Index *WIP* commit 2853d8b25eabd0dcf3f5af4718d71f17685d5a7b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 15:54:29 2020 +0100 *Remove End expression for mesh evaluation (invalid because we can't guess context for this case) commit d4f09e0cc4c058d07a2c40366e4e0bd45476d7fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 12:00:30 2020 +0100 Add minimal integration for newly added VFXExpressionVertexBufferFromMesh commit baf39dcdf6fc340269fb5442c763e4932ead57f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:59:25 2020 +0100 Add test data (to revert) commit 7a2fd0337ecc965dcea105dfd34973499f736bb8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:58:53 2020 +0100 Revert "Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh" This reverts commit 6d507a684f14dc09641877d6d691fd96adb63be4. commit 6d507a684f14dc09641877d6d691fd96adb63be4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 11:56:51 2020 +0100 Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh commit d26b342644bc08c2ab4118a71899bb78a2c303a7 Merge: b1512335cb 40749ce2ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 27 09:27:26 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit b1512335cb09b7b3e1ee783f991347704c4952be Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 18:24:05 2020 +0100 Fix after merge commit 43e25995ca9a15aa0ee5c88297616ccbd3fc5c2d Merge: e357f4871b 7abaf9bbf2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 17:47:34 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionMesh.cs commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit e357f4871b8c39257c62daf1fe63f85241325712 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 25 08:56:53 2020 +0100 Fix build in 2020.1 to resolve comment https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/258#pullrequestreview-52608 commit bfc0d9f7aeaa8b34407bfa8279d30bf59cf55099 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 18:44:28 2020 +0100 *Fix compilation commit 6cfd2d90292796c5b21e63d01c4b4bf8563c0184 Merge: 41a1a8e212 128101bc63 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 14:56:22 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 41a1a8e212c82b48832ab88f68348c145c0960c6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 15:19:24 2020 +0100 *Update expression name commit 27794064fd01207a35e7d967ff322e9d552a2054 Merge: ad597a0388 28f0ca20a0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 10:21:38 2020 +0100 Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit ad597a03881e11743e68555f985c304ee2d7557d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:18:40 2020 +0100 Support float or uint read in sample mesh color commit 8ca98dd9a375431ddc04c7a0cb625c35a2c99f57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 10:05:40 2020 +0100 Add compatibility code & use new available expression from https://ono.unity3d.com/unity/unity/changeset/6afd1f99b768984023366f3aba746390c763432f commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Sample mesh, add placement mode : Surface & Edge *WIP* * Some experiment with low distorsion mapping * *WIP* debug data (will be removed anyway) * Clean BarycentricCoordinatesBis * Fix to graft : support for flag enum in inspector * Add animation test data from @vlad * Test scene *WIP* * Use GetVertexStride depending of channelIndex & VFXExpressionVertexBufferFromMesh depending of channelFormatAndDimensionAndStream * *WIP* pushing test data * *Push Some test data (will be removed) * Fix test adding a *WIP* note * Minor fixes after merge * Add SkinnedMeshRenderer exposable * Add SkinnedMeshRenderer in IsTypeConstantFoldable * Add VFXExpressionSampleSkinnedMeshRendererFloat & co support (it should be factorizable) * Move hexahredron to common data, it will be convinient for graphicTest * Fix PositionMesh (bad merge) * Implement Graphic Test for skinned mesh (not yet tested in standalone yet) * *Add reference images * Clean some code, remove intermediate compatibility code * Add variant provider for sample mesh * Factorize sampling function to share them with PositionMesh * Start factorization of SamplePositionMesh * Add simple TODOPAUL * Add another TODOPAUL * Change VertexAttributeFlag to VertexAttribute, use proper mesh type in MeshPosition * Implement surface coordinate & sample vertex for position mesh * Remove test data & Update actual graphicTest * Use nameof instead of verbatim (this code will not be backported) * Fix sample edge * Add skinned & mesh index/vertex count * Fix editor test (todo : graft this change to master to anticipate the C++ change) * *Update reference image for mesh sampling * *Add sampleMesh index for skinned & mesh * Fix after merge (wasn't so obvious but now works \o/ Can be factorized) * Simpler update to use now available ByteAddressBuffer # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionAbstract.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.hlsl * Revert "Simpler update to use now available ByteAddressBuffer" (onluy VFXCommon.hlsl) This reverts commit 65b5ce1c588b969b95726a83d06a34a386a8c16d. * Fix compilation * Fix wrong return type of FetchBuffer * *Restore lost test for triangle sampling * Proper sample OOB fix * Use explicit branch in SampleMeshReadFloat : we aren't supposed fetch in invalid buffer * Enable GPUSkinng, default mode * Remove float cast for condition since we are able to compare uint * Factorize insertGPUTransformation using the common switch * Clean multiple place where "ByteAddressBuffer" is declared * Simply generated code verifying at http://shader-playground.timjones.io/d7df4e7dbec05529d6943aacca2812b9 * Remove unexpected restored file (as been renamed) * *Update changelog * *Fix build * *Update image reference * Remove useless case in GetFunctionParameterType (ByteAddressBuffer is in TypeToCode anyway) * Fix after merge * First draft of documentation for sample mesh * *Update documentation * *up doc * *documentation * Add documentation for Mesh Index Count & Vertex Count * *documentation * *Remove unexpected change & deprecated code * *documentation * Remove unexpected change in changelog.mp * *Apply formatting * *Update documentation * Minor documentation update * Documentation : add "inspector" flag when relevant * Rename confusing "x" in "edge" See https://docs.google.com/document/d/1VbIc5pMkgFX2Ui4-LWrZ7uQ4EKlXlFxWWW4ufcex70I/edit * *Remove deprecated MeshSampling & Update TOC * Reviewed the Set Position(Mesh) doc * Reviewed mesh index count doc * reviewed the rest of the sample mesh operators. * Fix ToC & rename some "Skinned Mesh Renderer" in "Skinned Mesh" * Missing minor change * *Reupdate VFX after merge * Fix several tooltip issues - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89530 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89531 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89532 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89533 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89534 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89535 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89536 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89538 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89539 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89540 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89541 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89542 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89544 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89545 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89546 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89547 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89548 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89549 - https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r89550 * Forgot to stage files from previous commit d8c1bef513605c8c7b40ec855cfe2be4de2e7d5e * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109724 Remove not needed UNITY_2020_2_OR_NEWER condition * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109727 Isolate helper function to VFXMeshSampling.hlsl * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/30#discussion_r109725 - Rename sourceExpression to targetExpression - Add InvalidOperationException if we are detecting an unexpected graph * Add missing compile of channelFormatAndDimensionAndStream - Check branch behavior - Trying to find infinite recursion due to dependent sampling - TODO : Add an editor test to inspect the actual generated graph (already checked in debug) Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * *Update all VisualEffectAsset "flipbookLayout: 0" everywhere + Some missing meta in test project (minor) * *Apply formatting * *Update missing reference images * Other missing update screenshot & missing meta * Fix formatting : this change can be grafted directly on master * Three minor fixes from https://github.com/Unity-Technologies/Graphics/pull/3414 - Wrong Image reference : Fix D3D11 standalone - Unconsistent debug assert (the recreate can be called on subslot) : Fix Space_Slot_Sanitize_Still_Possible_ArcSphere - CreateComponentWithAllBasicTypeExposed : remove VFXValueType.CameraBuffer from list of tested exposed type (it can'td irectly be exposed) These change can independantly land in `master` * Fix incorrect changelog.md in com.unity.visualeffectgraph * Remove unexpected duplicated entry in changelog.md * Fix changelog : unexpected removed entries in 11.x * *Update changelog.md * [BRP] Fix Shader Compilation (#216) * Fix incorrect direct access to GetWorldToObjectMatrix * *Update changelog.md * Sphere and cube outputs as experimental * Add castShadows as additionalMappings in VFXStaticMeshOutput (#217) * [Orient] 'Look At Position' particle disappearance (#101) * Expensive fix Computes two cross products to avoid the case when one of them is zero. Is it faster than branching to check ? Is this edge case worth the additional cost ? * More explicit approach/similar instruction cost + LookAtLine * Update Orient.cs * Handles edge case when cross(axis1, axis2) = (0,0,0) for all Orient variants * Small mistake in the exception message * Factorize SafeNormalizedCross * Update changelog * Added information about compute shaders and ssbos (#222) * Added information about compute shaders and ssbos * Added recommendation to use Vulkan over OpenGL ES * Removed 'two' * Added entry about vfx graph not being out of preview for mobile platforms Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * [Fix] PropertyBinder : Reset & Undo (#212) * Fix missing record object for proper undo/redo & reset * *Update changelog.md * Fix issue https://favro.com/organization/c564ede4ed3337f7b17986b6/1973edb4634ba00a90689144?card=Uni-160638 * Avoid VFXPropertyBinder to be added twice * Fix incorrect reference after copy past * Fix RemoveComponent clearing property binder first * Handle Copy/Past \o/ * Let the LateUpdate without any editor code & use Update (avoid the one frame of latency for inspector) * Remove useless recompute of GetComponents every frame, and use Reload (safer) * Remove dead code * *Add new entry in changelog (side improvement/fix) * *Update comment * [Fix] Null Ref Exception due to IsAssetEditable (#221) * Resource can be null on a block inspector while we are removing it Use safe check of resource before IsAssetEditable * *Update changelog * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/221#discussion_r113060 * [Fix] Component Board UX issue (#220) * Fix missing call to OnSelectionChanged on first display (before selection changed called) * Fix change from component notifying the VFXView * Fix toggle component board state * Minor fixes * *Update changelog.md * [Fix] System name 'Model is not registered' (#224) * *Add editor test to catch corner case issue with system name * Move Create_Simple_Graph_Then_Remove_Edget_Between_Init_And_Update_TestCaseto VFXGUITest * Actual fix of 1315593 The flow edge change is only triggering kConnectionChanged so, if you are trying to access m_SystemNames before compilation * Remove unexpected change * [Test] Revert after change (#213) * Local test (I'm using git diff to check actual file change) * test adding a lit mesh output * *Testing with shaderGraph * *test bis * *Add unit test to cover unexpected increasing size * Properly implement the test * Remove test data * *Temp lot of log & save it to independant file * HotFix : UpdateSubAsset in OnPreprocessAsset Shouldn't be necessary, the actual problem is maybe in C++ implementation * Clean test & add comment * *WIP* Serialization test which seems (tm) to reproduce the same issue * To revert : experiment adding log while loading VFXSerializableObject *Without Import Asset after write* Saving : 100 Loading : 100 Loading : 100 OnBeforeSerialize : 100 Saving : 101 Loading : 101 Loading : 101 OnAfterDeserialize : 100 Loading : 100 => Test fail ! *With Import Asset after write* Saving : 100 Loading : 100 Loading : 100 OnBeforeSerialize : 100 OnAfterDeserialize : 100 Saving : 101 Loading : 101 Loading : 101 Loading : 101 OnBeforeSerialize : 101 OnAfterDeserialize : 101 Saving : 102 Loading : 102 Loading : 102 Loading : 102 OnBeforeSerialize : 102 OnAfterDeserialize : 102 Saving : 103 Loading : 103 Loading : 103 * *Revert unwanted change * Clean & Unify test behavior * Safety check in newly integrated test (if asset is empty, it isn't expected neither) * Remove OnCompile : Avoid recompile twice, the WriteAsset is already trigerring an import * [Test] Add test to cover CopyValuesFrom (#225) * *Add test to cover CopyValuesFrom issue * *Extend the newly added test Check every value in copied values * Just added a perf marker * Changed `mobile` to `Android` (#227) * Fix "`syntax error: unexpected token 'if' at kernel CSMain`" (#228) int ia, int ib, ... is actually not needed since "i" remains an local scope value * [Fix] Deleted properties still visible in inspector (#231) * Fix missing BuildParameterInfo when we are removing a VFXParameter * Minor : fix typo in comment * Fix cases where some settings change didnt trigger a recompilation (#233) * Prevent focus on empty element if search list is empty (#229) See this rero : https://fogbugz.unity3d.com/f/cases/1235269/#BugEvent.1073014330 * handle constant folding correctly with SG interpolators * Added note about gamma color space in URP (#237) Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Check if parameter is null in AdvancedVisualEffectEditor::EmptyLineControl (#238) * Vfx/docs/point cache update (#234) * Added sample content documentation * Added point cache rewrite * Fixed toc formatting Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fixed various docs issues (#243) * Fixed incorrect indentation in the toc * Fixed capitalization surrounding Operator * Fixed capitalization surrounding Block * Fixed capitalization surrounding Context * Fixed table format * Added flipbook layout property * Removed outdated information * Fixed table format * Moved image to next line * Added information about when the flipbook layout property appears Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Added new documentation for sampling point caches and attribute maps (#241) * Added new documentation for sampling point caches and attribute maps * Added link to attribute map definition Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Add suffix to loop variable to avoid shader warnings (#240) * Fix issue with output mesh always triggering reimport + Fix modified state (#242) * Fix VFX with output mesh being always recompiled * Fix modified state (* being correct now) * Update save state * Use macros for texture sampling (#244) * Use macros for texture sampling + remove ambiguity between sample and sampleLOD * Forgot to do it for gradient and curve * [Fix] Unexpected expression in spawn context (#235) * Fix missing filter in per spawn expression computation * Cache the indexOfLastCommonExpression in graph * *Update changelog.md * Update HDRP VFX * Update URP Assets * [Feature] Bounds Computation helper (#201) * [Feature] Signed Distance Field Baker (#186) * Proper bounds transform (#247) * Proper bounds transform * Remove bounds padding in manual * Fix editor tests * More stable Graphics test (cherry picked from commit ef9b090fd6a8f322ea8bca0719a9b291423d15ac) * Fix sanitize for bounds mode (cherry picked from commit 4a09093f8b72c41e516f0c78a2b7e453569167cb) * Update HDRP assets (cherry picked from commit a74d2c405548307fc9e5785c12eccd11e5cbc403) * Fix compil in URP (cherry picked from commit fd8aa0847ed550a651969ed158b73214f1829802) * Update URP assets (cherry picked from commit 0b81e0f087981bbae9727003fc4ce778c753c7b5) * Formatting (cherry picked from commit d643152f0e3eef9fd3688102c2a21369a71575d2) * Update assets * Remove Input layout (cherry picked from commit d24654ac7ce462e84a4db87d36cf8a912fd51660) * Animator Culling mode : Always Animate (cherry picked from commit c1d3ab6d404b75ee12e7a5ab8ee6923258c3853f) * Fix filename to solve formatter issue (cherry picked from commit 48ca232718ffa6a6490fe7b44b0f58db5d9c3e16) * Remove old files (cherry picked from commit 4ebe6284d6d8aeeff450ad9f4595415eb9ef19b5) * Changes images of windows standalone (cherry picked from commit a1678a1b242c2625b6840ecfe96fb1448cd9af9b) * SDF Baker API Docs (#249) * Remove input layout * Animator Always Update * Revert "Animator Always Update" This reverts commit feea94bc6d9a77a671a8ae969cdd8a0b49bae78e. * Revert "Revert "Animator Always Update"" This reverts commit 16f86567f949f0eff6e5d8bd011e3e82a9aad9c5. * First commit on changing docs * More changes to modifiers * Documentation for API + IDisposable MeshToSDFBaker IDisposable is removed for the sdfPreview because it forced the Dispose function to be public, and had no real use * Fix build VFX_HDRP * Fix 'MeshToSDFBaker.m_DefaultPath' is assigned but its value is never used Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> * *Force Apply formatting * Update HDRP project assets * Fix 1336155: incorrect buffer type for strips * Forgot to update change log * What's new in version 11 (#245) * [Fix] Bounds Helper Polish (#250) * Null-check the bounds recorder when saving * Clean * Record system + warnings only if valid * Tooltip for Bounds Setting mode * formatting * Use CanBeCompiled instead of manual checks * Update HDRP assets * Remove currently useless URPSubOutput serialization * Update URP assets * Fix VFX using new SG integration being always dirty * [VFX] Enable motion vectors optimization in XR (#246) * Store projected position for vertices on each XR view when using VFX_FEATURE_MOTION_VECTORS_VERTS * Update changelog * Moving VFXCameraXRSettings out of VFXManager * Group camera XR settings in a single property * Remove useless reimport/save issues (#253) * Fix issues with subgraphs * Check isDirty before saving dependencies * Misc stuff * Formatting * formatting * Remove unused meta * [Fix] Prevent exception when inverting a degenerate TRS matrix (#252) * Prevent degenerate TRS matrices * Changelog + epsilon only for small values * Consistently output a zero-matrix when evaluated in C#, C++ or GPU * [Fix] normalWS compilation in depth unlit (#256) * Fix normalWS compilation error Only occurs if shaderGraph is using normal in opacity * Fix missing varying for normal & tangent Only if shadergraph needs those * [VFX] Add frontface semantic to vfx using shader graph materials (#257) * Add frontface semantic to vfx using shader graph materials * Update changelog * [VFX] Motion vectors for particle strips (#251) * Motion vectors for quad particle strips * Motion vectors for line particle strips * StripsMotionVector Graphic test Result image for windows used in all platforms * Store 2 verts per particle for quad strips and 1 per particle for line strips * Modify reference images .meta files * Update changelog * Get particle index from thread id * [Fix][SDFBaker] Unity Crash when switching SDF Baker saved settings containing prefabs (#264) * Use mesh instead of selectedMesh when loading params and to display FitToBox/Cube * update changelog * [Fix] Overlay Gizmo (#260) * Fix case 1340818 Separate Gizmo rendering from Overlay rendering See also https://unity.slack.com/archives/C014H2BPXMY/p1623158419065000?thread_ts=1622793094.052000&cid=C014H2BPXMY * *Update changelog.md * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/260#issuecomment-56740 Since gizmo & overaly rendering are now separated, we have to "Prepare" the gizmo Solution : use the common helper to properly cache needed gizmo data while clicking on "frame button" Simpler & Safer solution * Fix corner case issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/260#issuecomment-57521 Thanks @vita-skruibyte We have a process which invalid the gizmo cache : https://github.cds.internal.unity3d.com/unity/vfx-graphics/blob/vfx/staging/com.unity.visualeffectgraph/Editor/Inspector/AdvancedVisualEffectEditor.cs#L312 (see PropertyOverrideChanged) However, If we are trying to rebuild the gizmo property before the next inspector invalidation, the m_VFXPropertySheet won't be up to date. Use m_SerializedObject.Update(); when rebuilding the gizmo cache (this m_SerializedObject.Update(); will be called every frame anyway : https://github.cds.internal.unity3d.com/unity/vfx-graphics/blob/vfx/staging/com.unity.visualeffectgraph/Editor/Inspector/AdvancedVisualEffectEditor.cs#L373) * [Fix][1309958] Collide with Depth Buffer in Orthographic mode (#239) * first step into handling orthographic cameras * New Expressions to retrieve orthographic settings + matrix construction * Update changelog * Works with Custom camera * Properly handle orthographic depth collision. Exactly for planar surfaces, approximately for curved surfaces/at the edges of a solid * Larger offset for orthographic camera * Fix naming consistency * Update the main camera operator * Fix 1225764 : Selection outline Point Output (#135) * Fix the culling output Replace empty return ( pos = (0,0,0,0) ) with pos outside of clip space * Update CHANGELOG.md * point to issue tracker instead of fogbugz * remove unnessecary culling check * Revert "remove unnessecary culling check" This reverts commit 4771ba98217a0d01fc39b6a083f478d121e02488. * Use NaN to cull * [Switch] Fix OOB in Initialize compute (#261) * Fix OOB See original experiment https://github.com/Unity-Technologies/Graphics/commit/dfe52eedf211f2350e98377b5a6fd839638f0648 * *Update changelog.md * Minor refactor of dichotomy code - Address this issue : Fix https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/261#discussion_r159944 - I checked the generated code from ilassembly : http://shader-playground.timjones.io/52be834b8d455f3240051c5f7eebee5d - Run locally URP graphicTest in playmode :green: (TODO : verify on switch) * Remove Optimized Link on PS4 for test project (#266) * Exclude skinnedsdf test from PS4 (#267) * *Apply Formatting * Minor Changelog reordering Putting new entries at the end * [Doc] Confusing note about frame delay (#265) * Fix really strange documentation entry * Apply doc suggestion From : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/265#discussion_r162754 * [VFX] Add shader formatting for Infinity and NaN in floats (#259) …

Update SceneViewDrawMode.cs

383cc40

sebastienlagarde requested a review from JulienIgnace-Unity April 14, 2020 15:58

github-actions bot added the HDRP label Apr 14, 2020

sebastienlagarde merged commit 2c7eced into HDRP/staging Apr 14, 2020

sebastienlagarde deleted the HDRP/re-enable-light-overlap branch April 14, 2020 15:59

sebastienlagarde added needs-backport-8.x needs-backport-7.x backported-8.x and removed needs-backport-8.x labels Apr 14, 2020

sebastienlagarde added a commit that referenced this pull request Apr 16, 2020

Update SceneViewDrawMode.cs (#118)

bed4007

sebastienlagarde mentioned this pull request Apr 16, 2020

Merge 8.x.x/hd/staging [Skip CI] #141

Merged

6 tasks

sebastienlagarde added a commit that referenced this pull request Apr 16, 2020

Update SceneViewDrawMode.cs (#118)

417b5d1

sebastienlagarde added backported-7.x and removed needs-backport-7.x labels Apr 16, 2020

sebastienlagarde mentioned this pull request Apr 16, 2020

Merge 7.x.x/hd/staging [Skip CI] #158

Merged

6 tasks

sebastienlagarde mentioned this pull request Apr 28, 2020

Merge Hdrp/staging [Skip CI] #202

Merged

6 tasks

sebastienlagarde mentioned this pull request Jun 2, 2020

[9.x.x] Merge Hdrp/staging [Skip CI] (#697) #708

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-enable light overlap debug mode #118

Re-enable light overlap debug mode #118

sebastienlagarde commented Apr 14, 2020

Re-enable light overlap debug mode #118

Re-enable light overlap debug mode #118

Conversation

sebastienlagarde commented Apr 14, 2020