Skip to content

[cnd] small 3.2.2 - Merging master into cnd#3711

Merged
vieiro merged 58 commits intoapache:cndfrom
vieiro:feature/cnd-3.2.2
Mar 7, 2022
Merged

[cnd] small 3.2.2 - Merging master into cnd#3711
vieiro merged 58 commits intoapache:cndfrom
vieiro:feature/cnd-3.2.2

Conversation

@vieiro
Copy link
Copy Markdown
Contributor

@vieiro vieiro commented Mar 5, 2022

Bringing MultiMimeLanguageServer (and the rest of goodies) from master into cnd.

Aldo Brucale and others added 30 commits February 3, 2022 13:21
- number literals can contain _ as separator
- BigInt type was added
- private Identifier
- optional access (?.)
- nullish coalesce (??)
- logical and assignment (&&=)
- logical or assignment (||=)
- nullish assignment (??=)
JSF: Declaration of the xmlns namespace is reported as missing library
The semicolon is optional reading the examples. This change implements:
semicolons are required after property declarations, but not after
margin declarations.
Cleanup a bunch of warnings that look like this..

   [repeat] /home/bwalker/src/netbeans/ide/xml.core/src/org/netbeans/modules/xml/api/model/GrammarQueryManager.java:153: warning: [rawtypes] found raw type: Enumeration
   [repeat]                 Enumeration en = ctx.getDocumentChildren();
   [repeat]                 ^
   [repeat]   missing type arguments for generic class Enumeration<E>
   [repeat]   where E is a type-variable:
   [repeat]     E extends Object declared in interface Enumeration
diamonds, multicatch, overrides, lamdas, collections, deprecation fixes and
other minor refactorings.
)

I initially started cleaning up VariableMirrorTranslator.java as part of
some mass deprecation cleanup work I am doing.

The changes for handling the autobox/unbox of the floating-point class turned
into a general cleanup of the VariableMirrorTranslator class.

- updated autobox/unbox
- using multi-catch now
- using strings in switch
- update a couple of places should be using diamond operator
Cleaned up the deprecated use of old constructors. The compiler/VM will now autobox this into a proper
class. So this change removes warnings like this:

[repeat] /home/bwalker/src/netbeans/profiler/lib.profiler/src/org/netbeans/lib/profiler/heap/HprofInstanceValue.java:93: warning: [deprecation] Byte(byte) in Byte has been deprecated
[repeat]                 return new Byte(bt);
[repeat]                        ^

Also, added a couple of override annotations since I was here..
Cleaning some old code to make it more current..

- removed use of old deprecated constructor use
- use autobox/unbox for encapsulation
- change chain-of-if statement to switch w/ string
- some code cleanup
…he#3525)

[NETBEANS-6425] Code completion for class fields doesn't work.
I was too agressive with merging my updates. This merge provides fixes that were received by
a Netbeans engineer.
Larger icon sizes missing in platform branding UI apache#3544
ppisl and others added 26 commits February 22, 2022 12:14
[NETBEANS-6463] Code completion doesn't offer methods from the same class
This change cleans up the use of old deprecated numeric constructors..

Warnings like this will no longer happen:

[repeat] /home/bwalker/src/netbeans/java/testng/src/org/netbeans/modules/testng/AbstractTestGenerator.java:1700: warning: [deprecation] Float(float) in Float has been deprecated
[repeat]                     defValue = maker.Literal(new Float(0.0F));
[repeat]                                              ^

The newer implements favor factory methods like valueOf() or parseFloat() since they are likely to
yield significantly better space and time performance by caching frequently requested values.

Most of the changes are in the ide/profiler/enterprise/ide modules.
[NETBEANS-5599] PHP 8.1 Support: New in initializers (Part 4)
…rnings.

- add override annotations
- using multi-catch now
- using diamond operator
- use JDK 5 for-loop
- convert to lambda or member reference
- handle deprecations where possible
[jackpot] more robust condition handling + code renovations
Update JS support to ECMAScript 13 / 2022
…rnings.

- add override annotations
- using multi-catch
- using try-with-resources
- using diamond operator
- use JDK 5 for-loop
- convert to lambda or member reference
- handle deprecations where possible
Fix Windows profiler.lib workflow by using Windows10SDK.20348
NETBEANS-5846: Ignore unresolved dependencies for BOMs.
 - layout tweaks
 - some code cleanup / language level upgrade
 - see README for details
 - base.flags for base module flags
 - desktop.flags for UI related module flags
 - compiler.flags for java compiler integration
 - tools.flags for jdk.* module flags
 - use map.entrySet() if map.get(key) is called in the loop body
 - use map.values() if only the values are needed

refactorings were done with help of jackpot rules.
project wide oprimization: improved map traversal
added java module system flag list.
* ide/lsp.client + MultiMimeLanguageServerProvider
* Copy MultiMimeLanguageServerProvider.getMimeTypes
* Contemplate already restarted servers
gh issue template update post NB 13 release.
Copy link
Copy Markdown
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straight merge to me. I only saw a single change for the ignored-overlaps and that made sense to me. I restartet the failing Travis checks, but they looked like the "normally failing" bunch.

@vieiro
Copy link
Copy Markdown
Contributor Author

vieiro commented Mar 7, 2022

@matthiasblaesing , thanks for the review.

We may want to do another merge later on, I think we're using ssh somewhere in the remote stuff for cnd, we may want to do some tests with the new ssh library versions.

@vieiro vieiro merged commit b108f57 into apache:cnd Mar 7, 2022
@matthiasblaesing
Copy link
Copy Markdown
Contributor

@vieiro I think you mean the jsch integration found in dlight.nativeexecution. My first thought is, that it looks safe. The corner case (agent integration) is not used by that and I did not see subclassing of the jsch Identity class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.