Fix FIRRTL spec emission and bump to spec 1.2.0#3094
Merged
jackkoenig merged 2 commits intomainfrom Mar 16, 2023
Merged
Conversation
seldridge
approved these changes
Mar 16, 2023
Member
seldridge
left a comment
seldridge
left a comment
There was a problem hiding this comment.
LGTM
Not sure what is going on with the failure.
jackkoenig
force-pushed
the
firrtl-spec-bump
branch
from
c2c5782 to
10f94c7
Compare
mergify bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Emit FIRRTL spec version in Emitter * Bump FIRRTL spec version to 1.2.0 (cherry picked from commit 1ef1fc4) # Conflicts: # firrtl/src/main/scala/firrtl/ir/Serializer.scala # firrtl/src/test/scala/firrtlTests/ExtModuleTests.scala
mergify bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Emit FIRRTL spec version in Emitter * Bump FIRRTL spec version to 1.2.0 (cherry picked from commit 1ef1fc4) # Conflicts: # firrtl/src/main/scala/firrtl/ir/Serializer.scala # firrtl/src/test/scala/firrtlTests/ExtModuleTests.scala # src/test/scala/circtTests/stage/ChiselStageSpec.scala
This was referenced Mar 16, 2023
mergify bot
added a commit
that referenced
this pull request
Mar 16, 2023
* Fix FIRRTL spec emission and bump to spec 1.2.0 (#3094) * Emit FIRRTL spec version in Emitter * Bump FIRRTL spec version to 1.2.0 (cherry picked from commit 1ef1fc4) # Conflicts: # firrtl/src/main/scala/firrtl/ir/Serializer.scala # firrtl/src/test/scala/firrtlTests/ExtModuleTests.scala # src/test/scala/circtTests/stage/ChiselStageSpec.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot
added a commit
that referenced
this pull request
Mar 16, 2023
* Fix FIRRTL spec emission and bump to spec 1.2.0 (#3094) * Emit FIRRTL spec version in Emitter * Bump FIRRTL spec version to 1.2.0 (cherry picked from commit 1ef1fc4) # Conflicts: # firrtl/src/main/scala/firrtl/ir/Serializer.scala # firrtl/src/test/scala/firrtlTests/ExtModuleTests.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <koenig@sifive.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now emitting FIRRTL version 1.2.0.
This fixes
.firserialization to include the FIRRTL spec version. It was previously working just forchisel3.stage.ChiselStage.emitChirrtl(which no longer exists but does on 3.6.x and 3.5.x branches), but it didn't work for anything using theCircuitSerializationAnnotation(which uses theEmitter).The backport does not include the spec version bump (since the spec version is specified in SFC on older branches), just the fix.
Contributor Checklist
docs/src?Type of Improvement
API Impact
Now emitting FIRRTL 1.2.0 and in more cases. This will be rejected by versions of SFC older than v1.5.5 and firtool older than 1.12.0.
Backend Code Generation Impact
This bumps the version in the emitted
.firand ensures we always emit a version in the.fir.Desired Merge Strategy
Release Notes
Fix emission of FIRRTL spec in emitted
.fir. Now emitting FIRRTL version 1.2.0.Reviewer Checklist (only modified by reviewer)
3.5.xor3.6.xdepending on impact, API modification or big change:5.0.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.