Skip to content

Conversation

@chrisvanheuveln
Copy link
Contributor

No description provided.

sai chintalapudi and others added 30 commits December 23, 2015 10:42
remove extra arg in self.globals
api & test cleanups for platform differences
Add event_history properties (4) to cisco_bgp
When the command_reference config_get_token and config_set methods use
keyword-based parameter substitution, array elements that contain a
parameter not supplied by the caller will be omitted from the result
array.  This behavior is desired to support, e.g., CLI interaction
involving VRFs, where both the presence or absence of a VRF are
permissible and should result in CLI interaction either containing or
not containing a vrf statement.  However, this behavior makes it easy
for developer oversight or typo to result in an empty command line
(which is bad).

This commit updates command_reference so that if the result of
keyword-based parameter substitution is an empty array then an
ArgumentError will be raised.  It also adds new assertions to test this
behavior to the existing test_config_get_token_hash_substitution test
case, and updates the documentation and changelog.
mikewiebe and others added 27 commits February 9, 2016 13:35
Fix create method to handle error
Update Platform and Copyright Information
- dup_host_mac_detection doesn't require 'nv overlay evpn'
- dup_host_ip_addr_detection requires 'nv overlay evpn'
  - getter returns nil if feature not enabled (instead of an error)
  - setter enables the feature if needed
- anycast_gateway_mac requires 'nv overlay evpn'
  - getter returns nil if feature not enabled (instead of an error)
  - setter enables the feature if needed
* This allows the non-globals to instantiate even if bgp global is not used in the manifest.
* This change likely has little value for normal manifest usage but it simplifies the test scripts.
vxlan_global --> overlay_global + fixes
Adding destroy method for pim, needed for resource=absent
Adding property - fabric forwarding mode anycast-gateway, to Cisco_Interface
* the vlan minitest has issues because it needs a specific linecard for the mt_full tests
  * dynamic interface selection fails because 'limit-resource' changes the available linecards after they've been selected
  * my solution was to pull the mt_full tests out into their own minitest file
* I removed the extended vlan 'suspend' tests since the vlan team informed us that extended vlans should not be allowed to be shutdown or suspended (n3/7/9 plats incorrectly allow it)
* The mode test was failing on N7 because of a show command bug. I changed the regex to allow for both but in the long term I would like to see us move away from using 'show vlan' for checking state and transition to 'show run' instead.
* The vlan cli_check method is failing in my test environment although it does not happen in Mike's environment. We couldn't determine the RC but I suspect it could happen for others so I added an extra check to cli_check as a workaround.
Fix zero_pad issue in overlay_global
chrisvanheuveln added a commit that referenced this pull request Feb 11, 2016
@chrisvanheuveln chrisvanheuveln merged commit 2b1a9f6 into master Feb 11, 2016
@chrisvanheuveln chrisvanheuveln deleted the release_1.2.0 branch July 29, 2016 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.