fix(orchestrator): avoid serializing upload headers twice

[ValentaTomas]

Summary

• Return the stored header byte count from StoreHeader.
• Reuse that count for upload header metrics instead of serializing again.

Test plan

• go test ./packages/shared/pkg/storage/header ./packages/orchestrator/pkg/sandbox

[cursor]

PR Summary

Low Risk
Low risk: changes are limited to StoreHeader’s return signature and using its returned size for metrics; main risk is any missed call sites expecting the old error-only signature.

Overview
Updates headers.StoreHeader to return the serialized header byte count (and to error on nil headers), and switches the orchestrator upload metrics path to use that returned size instead of serializing the header a second time.

^{Reviewed by Cursor Bugbot for commit d501464. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
2655	2	2653	7

View the full list of 4 ❄️ flaky test(s)

github.com/e2b-dev/infra/tests/integration/internal/tests/api/sandboxes::TestSnapshotTemplateCreate

Flake rate in main: 54.71% (Passed 375 times, Failed 453 times)

Stack Traces | 0s run time

=== RUN   TestSnapshotTemplateCreate
=== PAUSE TestSnapshotTemplateCreate
=== CONT  TestSnapshotTemplateCreate
--- FAIL: TestSnapshotTemplateCreate (0.00s)
Executing command curl in sandbox ircvahgylgtp1zqdjlvqr

github.com/e2b-dev/infra/tests/integration/internal/tests/api/sandboxes::TestSnapshotTemplateCreate/create_snapshot_with_name

Flake rate in main: 54.43% (Passed 375 times, Failed 448 times)

Stack Traces | 15.7s run time

=== RUN   TestSnapshotTemplateCreate/create_snapshot_with_name
=== PAUSE TestSnapshotTemplateCreate/create_snapshot_with_name
=== CONT  TestSnapshotTemplateCreate/create_snapshot_with_name
    snapshot_template_test.go:68: 
        	Error Trace:	.../api/sandboxes/snapshot_template_test.go:37
        	            				.../api/sandboxes/snapshot_template_test.go:68
        	Error:      	Not equal: 
        	            	expected: 201
        	            	actual  : 500
        	Test:       	TestSnapshotTemplateCreate/create_snapshot_with_name
--- FAIL: TestSnapshotTemplateCreate/create_snapshot_with_name (15.70s)

github.com/e2b-dev/infra/tests/integration/internal/tests/orchestrator::TestSandboxMemoryIntegrity

Flake rate in main: 66.07% (Passed 380 times, Failed 740 times)

Stack Traces | 83.5s run time

=== RUN   TestSandboxMemoryIntegrity
=== PAUSE TestSandboxMemoryIntegrity
=== CONT  TestSandboxMemoryIntegrity
    sandbox_memory_integrity_test.go:27: Build completed successfully
--- FAIL: TestSandboxMemoryIntegrity (83.54s)

github.com/e2b-dev/infra/tests/integration/internal/tests/orchestrator::TestSandboxMemoryIntegrity/tmpfs_hash

Flake rate in main: 66.42% (Passed 370 times, Failed 732 times)

Stack Traces | 106s run time

=== RUN   TestSandboxMemoryIntegrity/tmpfs_hash
=== PAUSE TestSandboxMemoryIntegrity/tmpfs_hash
=== CONT  TestSandboxMemoryIntegrity/tmpfs_hash
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{start:{pid:1265}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stdout:"Total memory: 985 MB\nUsed memory before tmpfs mount: 185 MB\nFree memory before tmpfs mount: 799 MB\nMemory to use in integrity test (80% of free, min 64MB): 639 MB\n"}}
Executing command bash in sandbox il4d8qi4p61j8yggw6osw (user: root)
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"639+0 records in\n639+0 records out\n670040064 bytes (670 MB, 639 MiB) copied, 3.65742 s, 183 MB/s\n"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"\tCommand being timed: \"dd if=/dev/urandom of=/mnt/testfile bs=1M count=639\"\n\tUser time (seconds): "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"0.00\n\tS"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"ystem"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" time (seco"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"nds): 3.60\n\tPercent of CPU t"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"his job "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"got:"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" 98%\n\t"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"Elaps"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"ed (w"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"all c"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"l"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"o"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"c"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"k"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:")"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"t"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"i"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"m"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"e"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"("}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"h"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:":"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"m"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"m"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:":"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"s"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"s"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"o"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"r"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"m"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:":"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"s"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"s"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:")"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:":"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"0:03.66"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"\n"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"\t"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"A"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"v"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"e"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"r"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"a"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"g"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"e"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"s"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"h"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"a"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"r"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"e"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"d"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"t"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"e"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"x"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"t"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:" "}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"s"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"i"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"ze (kbytes): 0\n\tAver"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stdout:"Used memory after tmpfs mount and file fill: 830 MB\n"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{data:{stderr:"age unshared data size (kbytes): 0\n\tAverage stack size (kbytes): 0\n\tAverage total size (kbytes): 0\n\tMaximum resident set size (kbytes): 2724\n\tAverage resident set size (kbytes): 0\n\tMajor (requiring I/O) page faults: 2\n\tMinor (reclaiming a frame) page faults: 346\n\tVoluntary context switches: 3\n\tInvoluntary context switches: 43\n\tSwaps: 0\n\tFile system inputs: 176\n\tFile system outputs: 0\n\tSocket messages sent: 0\n\tSocket messages received: 0\n\tSignals delivered: 0\n\tPage size (bytes): 4096\n\tExit status: 0\n"}}
    sandbox_memory_integrity_test.go:70: Command [bash] output: event:{end:{exited:true  status:"exit status 0"}}
    sandbox_memory_integrity_test.go:70: Command [bash] completed successfully in sandbox i2nmq9ry8lxkmeel81ze0
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
    sandbox_memory_integrity_test.go:80: Command [bash] output: event:{start:{pid:1282}}
    sandbox_memory_integrity_test.go:80: Command [bash] output: event:{data:{stdout:"c54719b2798a2df28d6d0a32c48c41a11ba46e42e97ee8938df262a4eaa2845a\n"}}
    sandbox_memory_integrity_test.go:80: Command [bash] output: event:{end:{exited:true  status:"exit status 0"}}
    sandbox_memory_integrity_test.go:80: Command [bash] completed successfully in sandbox i2nmq9ry8lxkmeel81ze0
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
    sandbox_memory_integrity_test.go:80: Command [bash] output: event:{start:{pid:1286}}
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
Executing command bash in sandbox i2nmq9ry8lxkmeel81ze0 (user: root)
    sandbox_memory_integrity_test.go:110: 
        	Error Trace:	.../tests/orchestrator/sandbox_memory_integrity_test.go:81
        	            				.../hostedtoolcache/go/1.26.3.../src/runtime/asm_amd64.s:1771
        	Error:      	Received unexpected error:
        	            	failed to execute command bash in sandbox i2nmq9ry8lxkmeel81ze0: unavailable: HTTP status 502 Bad Gateway
    sandbox_memory_integrity_test.go:110: 
        	Error Trace:	.../tests/orchestrator/sandbox_memory_integrity_test.go:78
        	            				.../tests/orchestrator/sandbox_memory_integrity_test.go:110
        	Error:      	Condition never satisfied
        	Test:       	TestSandboxMemoryIntegrity/tmpfs_hash
--- FAIL: TestSandboxMemoryIntegrity/tmpfs_hash (105.70s)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[gemini-code-assist]

Code Review

This pull request refactors the StoreHeader function to return the size of the stored data, optimizing metric recording by removing redundant serialization. The review identified a potential nil-pointer dereference in the serialization logic and suggested wrapping storage errors with context to improve observability.