fix!: replace makeKeyFn with delimiter to strengthen guarantee of proper escaping

[wschurman]

Why

Since cache key construction function is application-supplyable, there's potential that it doesn't escape properly, causing potential cache collisions.

How

Change the API to only allow specifying the delimiter, and hoist code into the package to handle delimiter escape.

Test Plan

Run new test to ensure no collisions on something that would've previously collided.

[wschurman]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix: correctness of TSMockitoExtensions isEqualWithEntityAware for SerializableKeyMaps of different length #614
• fix: fix possible composite key collision in StubDatabaseAdapter test utility #613
• chore: update comment for IEntityMetricsAdapter for implementors #612
• fix: pick method crash when object has hasOwnProperty key #611
• fix: fix behavior of AuthorizationResultBasedEntityAssociationLoader when field value is empty string #610
• feat: support numeric enums in StrictEnumField #609
• feat: validate GenericRedisCacheContext #608
• fix: skip when AllowIfAllSubRulesAllowPrivacyPolicyRule is empty #607
• fix: correct cycle guard behavior for deletion #606
• fix: handle potential infinite recursion for canViewerDeleteAsync #605
• feat: clean up transactional dataloader at transaction end #604
• fix: correct negative caching behavior in GenericSecondaryEntityCache #603
• fix: update cache key generation for secondary caches #602
• fix!: replace makeKeyFn with delimiter to strengthen guarantee of proper escaping #601 👈 (View in Graphite)
• fix: prevent collision in companion when entities share same name or same table name #600
• chore: remove unnecessary ViewerScopedEntityMutatorFactory #599
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (55cb75e) to head (8fb1efe).

Additional details and impacted files

@@                                                     Coverage Diff                                                     @@
##           05-13-fix_prevent_collision_in_companion_when_entities_share_same_name_or_same_table_name      #601   +/-   ##
===========================================================================================================================
  Coverage                                                                                     100.00%   100.00%           
===========================================================================================================================
  Files                                                                                            109       109           
  Lines                                                                                          17614     17623    +9     
  Branches                                                                                        1514      1518    +4     
===========================================================================================================================
+ Hits                                                                                           17614     17623    +9     

Flag	Coverage Δ
integration	28.69% <100.00%> (+0.03%)	⬆️
unittest	94.56% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.