feat: clean up transactional dataloader at transaction end#604
Open
Conversation
This was referenced May 14, 2026
Member
Author
This was referenced May 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 05-14-fix_correct_negative_caching_behavior_in_genericsecondaryentitycache #604 +/- ##
=============================================================================================================
Coverage 100.00% 100.00%
=============================================================================================================
Files 109 109
Lines 17640 17682 +42
Branches 1518 901 -617
=============================================================================================================
+ Hits 17640 17682 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
force-pushed
the
05-14-fix_correct_negative_caching_behavior_in_genericsecondaryentitycache
branch
from
b97a9bd to
9092f7e
Compare
wschurman
force-pushed
the
05-14-feat_clean_up_transactional_dataloader_at_transaction_end
branch
from
737d0b4 to
365e471
Compare
This was referenced May 14, 2026
This was referenced May 14, 2026
ide
approved these changes
May 15, 2026
Comment on lines
+205
to
+207
| * Schedule a callback to run when the transaction ends, regardless of whether | ||
| * it commits or rolls back. Use for resource cleanup tied to the transaction's lifetime | ||
| * (e.g. dropping per-transaction in-memory state). |
Member
There was a problem hiding this comment.
Document that when a transaction is successful these run after the post-commit callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
One way memory can grow unbounded within a single request is via transactional dataloaders. If a single request executes N transactions, each one accumulates it's own dataloader state.
Though this has the same semantics as regular dataloaders (which belong to companion provider which is scoped to request by application and discarded after response is sent), they can accumulate more.
How
The fix is to clear the transactional dataloader at the end of the transaction (or nested transaction), no matter whether the transaction succeeded or rolled-back.
Test Plan
Add test for condition.