Skip to content

fix: handle potential infinite recursion for canViewerDeleteAsync#605

Open
wschurman wants to merge 1 commit into
05-14-feat_clean_up_transactional_dataloader_at_transaction_endfrom
05-14-fix_handle_potential_infinite_recursion_for_canviewerdeleteasync
Open

fix: handle potential infinite recursion for canViewerDeleteAsync#605
wschurman wants to merge 1 commit into
05-14-feat_clean_up_transactional_dataloader_at_transaction_endfrom
05-14-fix_handle_potential_infinite_recursion_for_canviewerdeleteasync

Conversation

@wschurman
Copy link
Copy Markdown
Member

@wschurman wschurman commented May 14, 2026

Why

In the same way that processEntityDeletionForInboundEdgesAsync has detection for reference cycles, this preemptive check utility method needs the same detection mechanism.

How

Add the same detection mechanism as processedEntityIdentifiers

Test Plan

Add test case for this that fails before change, succeeds after.

Copy link
Copy Markdown
Member Author

wschurman commented May 14, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (365e471) to head (21c2fb8).

Additional details and impacted files
@@                                        Coverage Diff                                        @@
##           05-14-feat_clean_up_transactional_dataloader_at_transaction_end      #605   +/-   ##
=================================================================================================
  Coverage                                                           100.00%   100.00%           
=================================================================================================
  Files                                                                  109       109           
  Lines                                                                17682     17693   +11     
  Branches                                                               901       918   +17     
=================================================================================================
+ Hits                                                                 17682     17693   +11     
Flag Coverage Δ
integration 28.65% <0.00%> (-0.02%) ⬇️
unittest 94.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman force-pushed the 05-14-fix_handle_potential_infinite_recursion_for_canviewerdeleteasync branch from 9c7b80f to 5cd7a69 Compare May 14, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants