Skip to content

fix: fix behavior of AuthorizationResultBasedEntityAssociationLoader when field value is empty string#610

Open
wschurman wants to merge 1 commit into
05-14-feat_support_numeric_enums_in_strictenumfieldfrom
05-14-fix_fix_behavior_of_authorizationresultbasedentityassociationloader_when_field_value_is_empty_string
Open

fix: fix behavior of AuthorizationResultBasedEntityAssociationLoader when field value is empty string#610
wschurman wants to merge 1 commit into
05-14-feat_support_numeric_enums_in_strictenumfieldfrom
05-14-fix_fix_behavior_of_authorizationresultbasedentityassociationloader_when_field_value_is_empty_string

Conversation

@wschurman
Copy link
Copy Markdown
Member

@wschurman wschurman commented May 14, 2026

Why

The bug is that if the column in the current entity that contains the referenced entity's id is an empty string, the load method would erroneously return null. This correct the behavior to correctly try to load the entity by ID, which correctly fails since the field is invalid.

How

Fix check.

Test Plan

Add new test.

Copy link
Copy Markdown
Member Author

wschurman commented May 14, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6e3a24e) to head (99daddc).

Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           05-14-feat_support_numeric_enums_in_strictenumfield      #610   +/-   ##
=====================================================================================
  Coverage                                               100.00%   100.00%           
=====================================================================================
  Files                                                      109       109           
  Lines                                                    17738     17738           
  Branches                                                  1539      1539           
=====================================================================================
  Hits                                                     17738     17738           
Flag Coverage Δ
integration 28.62% <0.00%> (ø)
unittest 94.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants