Skip to content

fix: pick method crash when object has hasOwnProperty key#611

Open
wschurman wants to merge 1 commit into
05-14-fix_fix_behavior_of_authorizationresultbasedentityassociationloader_when_field_value_is_empty_stringfrom
05-14-fix_pick_method_crash_when_object_has_hasownproperty_key
Open

fix: pick method crash when object has hasOwnProperty key#611
wschurman wants to merge 1 commit into
05-14-fix_fix_behavior_of_authorizationresultbasedentityassociationloader_when_field_value_is_empty_stringfrom
05-14-fix_pick_method_crash_when_object_has_hasownproperty_key

Conversation

@wschurman
Copy link
Copy Markdown
Member

@wschurman wschurman commented May 14, 2026

Why

pick was calling object.hasOwnProperty(prop), but if the object had a property hasOwnProperty, it'd be used.

How

Fix is to use the Object prototype's method.

Test Plan

Run added test.

Copy link
Copy Markdown
Member Author

wschurman commented May 14, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (99daddc) to head (34de712).

Additional details and impacted files
@@                                                             Coverage Diff                                                              @@
##           05-14-fix_fix_behavior_of_authorizationresultbasedentityassociationloader_when_field_value_is_empty_string      #611   +/-   ##
============================================================================================================================================
  Coverage                                                                                                      100.00%   100.00%           
============================================================================================================================================
  Files                                                                                                             109       109           
  Lines                                                                                                           17738     17738           
  Branches                                                                                                         1539      1539           
============================================================================================================================================
  Hits                                                                                                            17738     17738           
Flag Coverage Δ
integration 28.62% <0.00%> (ø)
unittest 94.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants