Skip to content

fix: correct negative caching behavior in GenericSecondaryEntityCache#603

Open
wschurman wants to merge 1 commit into
05-14-fix_update_cache_key_generation_for_secondary_cachesfrom
05-14-fix_correct_negative_caching_behavior_in_genericsecondaryentitycache
Open

fix: correct negative caching behavior in GenericSecondaryEntityCache#603
wschurman wants to merge 1 commit into
05-14-fix_update_cache_key_generation_for_secondary_cachesfrom
05-14-fix_correct_negative_caching_behavior_in_genericsecondaryentitycache

Conversation

@wschurman
Copy link
Copy Markdown
Member

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.

How

How did you build this feature or fix this bug?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests!

Copy link
Copy Markdown
Member Author

wschurman commented May 14, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b8c572c) to head (9092f7e).

Additional details and impacted files
@@                                      Coverage Diff                                      @@
##           05-14-fix_update_cache_key_generation_for_secondary_caches      #603    +/-   ##
=============================================================================================
  Coverage                                                      100.00%   100.00%            
=============================================================================================
  Files                                                             109       109            
  Lines                                                           17636     17640     +4     
  Branches                                                          913      1518   +605     
=============================================================================================
+ Hits                                                            17636     17640     +4     
Flag Coverage Δ
integration 28.74% <0.00%> (-0.01%) ⬇️
unittest 94.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but please update PR description before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants