-
-
Notifications
You must be signed in to change notification settings - Fork 24k
TextureRD: Ignore invalid free error and keep rid unchanged when replacing rd texture #103126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
beicause
wants to merge
1
commit into
godotengine:master
Choose a base branch
from
beicause:texturerd-do-not-change-rid
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texture_rd_ridtexture_rd_rid
bcf64cc to
192c338
Compare
beicause
commented
Feb 22, 2025
192c338 to
b939a95
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b939a95 to
3efdcad
Compare
8c6501d to
a809932
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a809932 to
2aa17fc
Compare
Contributor
Author
|
Looking back, I realized the way I used to check if the rd texture is valid is wrong. godot/servers/rendering/renderer_rd/storage_rd/texture_storage.cpp Lines 60 to 67 in 2d113cc
|
texture_rd_rid2aa17fc to
04a8994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95273. Fixes #85989.
texture_rd_rid, Instead, repalce its texture by a placeholder texture.texture_rd_ridof TextureRD and replace the rd texture.