Improve docs for EditorResourcePicker::_set_create_options#104481
Open
kleonc wants to merge 1 commit intogodotengine:masterfrom
Open
Improve docs for EditorResourcePicker::_set_create_options#104481kleonc wants to merge 1 commit intogodotengine:masterfrom
EditorResourcePicker::_set_create_options#104481kleonc wants to merge 1 commit intogodotengine:masterfrom
Conversation
kleonc
added
enhancement
topic:editor
documentation
cherrypick:4.4
Repiteo
added
the
cherrypick:4.5
akien-mga
removed
cherrypick:4.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding custom options with
EditorResourcePicker::_set_create_optionswith IDs starting from 0 results in conflicts with the built-in options ("Load", "Copy", "Paste", etc.), and hence the custom options not working correctly.This PR adds a note explaining how to avoid such ID collisions.