GDScript: Fix for loop inline body highlighted as type#104507
Open
jamesminardi wants to merge 1 commit intogodotengine:masterfrom
Open
GDScript: Fix for loop inline body highlighted as type#104507jamesminardi wants to merge 1 commit intogodotengine:masterfrom
jamesminardi wants to merge 1 commit intogodotengine:masterfrom
Conversation
dalexeev
reviewed
Mar 23, 2025
| } | ||
|
|
||
| // Don't highlight for loop inline bodies as types. | ||
| if (expect_type && in_for_loop && !class_names.has(word)) { |
Member
There was a problem hiding this comment.
This is incorrect, types may not only be registered classes. The highlighter should recognize patterns like:
"for" WS+ Identifier WS* ":" WS* Type
where:
WS ::= " " | "\t"
Identifier ::= ( ID_Start | "_" ) ID_Continue*
Type ::= IdentifierChain ( "[" Type ( "," Type )* "]" )?
IdentifierChain ::= Identifier ( "." Identifier )*
jamesminardi
force-pushed
the
for_loop_highlighting
branch
7 times, most recently
from
5e6e906 to
9bd7896
Compare
jamesminardi
force-pushed
the
for_loop_highlighting
branch
2 times, most recently
from
5dc99b5 to
20115df
Compare
jamesminardi
force-pushed
the
for_loop_highlighting
branch
from
20115df to
463365a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forloops #102913Before
After
Now correctly highlights inline for loop bodies instead of only being highlighted as a typed variable for loop.