Fix the extra arguments of type NodePath in the connection dialog do not work
#107013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rindbee
force-pushed
the
fix-wrong-node-path-in-connection-dialog
branch
from
24ef137 to
fda08f1
Compare
KoBeWi
approved these changes
Jun 16, 2025
Contributor
|
Needs rebase |
…o not work Make the node path relative to the target node instead of the source node. Currently, a proxy object is used in the connection dialog to edit bound arguments. In this case, the `EditorPropertyNodePath` will get the node path relative to the source object in the connection (i.e. the object the InspectorDock is editing). This path is not available in scripts (i.e. the target object in the connection).
Rindbee
force-pushed
the
fix-wrong-node-path-in-connection-dialog
branch
from
fda08f1 to
fc0cbb3
Compare
Contributor
Author
|
Done. |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the node path relative to the target node instead of the source node.
Currently, a proxy object is used in the connection dialog to edit bound arguments.
In this case, the
EditorPropertyNodePathwill get the node path relative to the source object in the connection (i.e. the object the InspectorDock is editing).This path is not available in scripts (i.e. the target object in the connection).
Fix #106983, fix #83700.
000.mp4