Make GDVIRTUAL Binding of _instantiate_playback non-const#112591
Open
vivi512 wants to merge 1 commit intogodotengine:masterfrom
Open
Make GDVIRTUAL Binding of _instantiate_playback non-const#112591vivi512 wants to merge 1 commit intogodotengine:masterfrom
vivi512 wants to merge 1 commit intogodotengine:masterfrom
Conversation
Member
|
It may not seem like it but this requires proper handling because it technically breaks compatibility. See https://docs.godotengine.org/en/stable/engine_details/development/handling_compatibility_breakages.html . Although, one could genuinely argue that because the function was never really... functioning as intended, the breakage is completely fine. |
Contributor
|
It shouldn't be too hard to add a compatibility method and not cause any breakage. Are we really sure that no one is currently using this? It would be awkward, but folks could be using the current virtual function and casting const away from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112588 :
The GDVIRTUAL binding of the _instantiate_playback function of AudioStream marked it as const, when the actual function is non-const, making it impossible to override properly when using cpp bindings.
Binding (Incorrectly marked as const) :
godot/servers/audio/audio_stream.h
Line 173 in 6fd949a
Function(Non-const) :
godot/servers/audio/audio_stream.h
Line 185 in 6fd949a
This PR fixes it (and the associated docs)