Fix incorrect bottom panel theming

[lodetrick]

Closes #112611

Previously, if the editor theme was changed, the bottom panel's background would not be updated. This is because when the bottom panel retrieved the necessary stylebox it retrieved the overridden previous theme rather than the new theme. Removing the override is a simple method to force the retrieved stylebox to be correct.

I'm not too sure why it retrieved the override in the first place because overrides are specific to nodes but this method worked well.

[ryevdokimov]

Not sure how this should be addressed, but possibly related issue and a comment I made there: #112549 (comment)

godot/editor/editor_node.cpp

Line 680 in 6fd949a

bottom_panel->_theme_changed();

Convention says this should be a private method, and shouldn't the bottom panel handle theme changes itself via the notification system?

godot/editor/gui/editor_bottom_panel.cpp

Line 89 in 6fd949a

_theme_changed();

Having that method called on repaint (tab changed) as well seems strange. Hard to tell what is going on with a quick glance.

[KoBeWi]

Alternate fix is getting the theme stylebox either directly from theme (EditorNode::get_editor_theme()->get_stylebox()) or from another control (EditorNode::get_gui_base()->get_theme_stylebox()).

I'm not too sure why it retrieved the override in the first place because overrides are specific to nodes

The override came from BottomPanel theme variation.

possibly related issue and a comment I made there

It's not.

[lodetrick]

I ended up using the alternate solution you mentioned, it solved the issue nicely.

[Repiteo]

Thanks!