Fix float value NAN still shown as 0 in the debugger and inspector.#115013
Merged
Conversation
AThousandShips
added
bug
topic:editor
cherrypick:4.5
Kaleb-Reid
approved these changes
Jan 17, 2026
Contributor
Kaleb-Reid
left a comment
Kaleb-Reid
left a comment
There was a problem hiding this comment.
I actually wasted an hour a few days ago due to this bug. Tested the changes and they appear to work. Code looks good to me.
|
Any chance of getting this approved? |
KoBeWi
approved these changes
May 11, 2026
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Repiteo
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Despite issue #88006 being closed,
0.0still being displayed instead ofNAN.This happens because while PR #105911 allowed non-finite values, it missed handling them properly. As a result, the
_snapped_r128function called inRange::set_value()returns 0 anyway when encountering them.After adding a proper
NaNcheck, everything displays correctly.Issue
Fixes #114996
Fixes #115525