Add node path validation & tweak warning in SkeletonModifier3D#115358
Merged
Conversation
TokageItLab
added
usability
topic:animation
topic:3d
cherrypick:4.6
TokageItLab
force-pushed
the
warn-smod3
branch
from
0fed4f3 to
82b59ba
Compare
Contributor
|
Needs rebase |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For NodePath properties, if a path is assigned and the Modifier is in the scene tree, it will perform a check once via the setter and print a warning. But this can impact performance when paths are intentionally assigned to non-existent elements in the scene, so an option to disable this behavior will be added in Project Settings as same way with the AnimationMixer.
Also, index is now included and printed in bone index validation.