Fix clipboard history not updating on subsequent copies in Wayland#116648
Merged
Conversation
YeldhamDev
approved these changes
Mar 23, 2026
Member
YeldhamDev
left a comment
YeldhamDev
left a comment
There was a problem hiding this comment.
Fixes the issue, but someone needs to review the Wayland code itself.
Really hope this get merged though, such an annoying issue.
YeldhamDev
added
the
cherrypick:4.6
deralmas
approved these changes
Mar 24, 2026
Member
deralmas
left a comment
deralmas
left a comment
There was a problem hiding this comment.
Code looks good!
Could not see any obvious regressions on my usual test harness (KDE 6.5.4, GNOME 49.2.2, COSMIC 1.0.1), and my laptop (sway 1.11).
Rindbee
reviewed
Mar 26, 2026
Contributor
|
Cherry-picked for 4.6.3. |
Repiteo
removed
the
cherrypick:4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116522
When setting the clipboard, the data source was reused after the first copy and only the in-memory buffer was updated, so the compositor was never notified of subsequent clipboard changes.
The change makes it destroy and recreate the
wl_data_sourcewhen setting the clipboard selection, so thatwl_data_device_set_selectionis called each time. Clipboard managers (e.g. KDE Klipper) detect new entries by receiving a new selection event from the compositor, which only fires when set_selection is called with a new data source.This PR also applies the same fix to the primary clipboard.