Fix EditorScenePostImportPlugin::_get_internal_option_visibility() having no effect#118656
Merged
Repiteo merged 1 commit intoApr 20, 2026
Conversation
fire
changed the title
Contributor
Author
|
There is also this comment at https://github.com/godotengine/godot/blob/master/editor/import/3d/resource_importer_scene.cpp#L2547 which may be referring to this bug but I'm not sure.
|
aaronfranke
approved these changes
Apr 17, 2026
Member
There was a problem hiding this comment.
This fix is correct, I checked the code. If all calls return non-booleans it will still return true overall.
Should be squashed though. @ArokhSlade please do so, and see here for instructions: https://contributing.godotengine.org/en/latest/pull_requests/creating_pull_requests.html#the-interactive-rebase
…ving no effect post_import_plugin_skeleton_rest_fixer::_get_internal_option_visibility() gets called before user plugins. as it used to return true by default, it would always override/intercept any user implementation. now it returns null for those cases it is not explicitly coded to handle, indicating "ignore". see also: godotengine#118652
ArokhSlade
force-pushed
the
fix_import_plugin-_get_internal_option_visibility
branch
from
6b58c3d to
4fe2e80
Compare
Contributor
Author
|
squash complete |
aaronfranke
approved these changes
Apr 17, 2026
akien-mga
changed the title
EditorScenePostImportPlugin::_get_internal_option_visibility() having no effect
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
ArokhSlade
deleted the
fix_import_plugin-_get_internal_option_visibility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post_import_plugin_skeleton_rest_fixer::_get_internal_option_visibility() gets called before user plugins. as it used to return true by default, it would always override/intercept any user implementation.
now it returns null for those cases it is not explicitly coded to handle, indicating "ignore". see also: #118652
EditorScenePostImportPlugin's _get_internal_option_visibility had no effect
Bugsquad edit: