[4.x] Add ACTION_MODE_HYBRID to BaseButton and make it the default#57014
Open
wareya wants to merge 1 commit intogodotengine:masterfrom
Open
[4.x] Add ACTION_MODE_HYBRID to BaseButton and make it the default#57014wareya wants to merge 1 commit intogodotengine:masterfrom
wareya wants to merge 1 commit intogodotengine:masterfrom
Conversation
Contributor
Author
|
There was something weird in the button activation code about accelerators/shortcuts. I wasn't 100% sure how to move it around without changing how it behaves. Please double check it. |
wareya
force-pushed
the
basebutton_hybrid_4
branch
from
7628967 to
5b68489
Compare
|
I believe this would also fix issue #45033 |
Contributor
|
when is this pr gonna merge? Please some admin review this. |
Member
We haven't reached a full consensus on the feature itself yet: godotengine/godot-proposals#3234 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.x version of #56419. Implements godotengine/godot-proposals#3234 .
Unlike #56419, this PR makes the new ACTION_MODE_HYBRID mode the default.
Bugsquad edit: This closes godotengine/godot-proposals#3234.