Open the directory where the project was exported to in the default file manager#65201
Open
doot24 wants to merge 1 commit intogodotengine:masterfrom
Open
Open the directory where the project was exported to in the default file manager#65201doot24 wants to merge 1 commit intogodotengine:masterfrom
doot24 wants to merge 1 commit intogodotengine:masterfrom
Conversation
Contributor
|
@doot24 The static checks failed, can you force push the PR again so we can see how to fix the issue. This is a great change so I want to help push for it to happen. |
m4gr3d
requested changes
Feb 1, 2023
Contributor
m4gr3d
left a comment
m4gr3d
left a comment
There was a problem hiding this comment.
Added some feedback on the Android section
Comment on lines
+2545
to
+2547
| if (open_export_dir && err == OK) { | ||
| OS::get_singleton()->shell_open(p_path.get_base_dir()); | ||
| } |
Contributor
There was a problem hiding this comment.
From this comment, opening directory on Android will silently fail due to the lack of standardization around Android file manager's support for folder mimetype.
The added logic could stay, though in that scenario the documentation should be updated to reflect that this functionality doesn't work on Android.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redid pr #58511
Feature now works for Android&Web, ios&uwp should be working too
also
--headlessarg is now respected and file manager wont be opened when exporting from the terminalThis closes godotengine/godot-proposals#4114.