Use blender executable instead of blender directory#74409
Open
CharlieQLe wants to merge 3 commits intogodotengine:masterfrom
Open
Use blender executable instead of blender directory#74409CharlieQLe wants to merge 3 commits intogodotengine:masterfrom
CharlieQLe wants to merge 3 commits intogodotengine:masterfrom
Conversation
RedMser
reviewed
Mar 5, 2023
Contributor
RedMser
left a comment
RedMser
left a comment
There was a problem hiding this comment.
On Windows, there is also a second .exe file in the Blender folder blender-launcher.exe. Need to make sure picking either of those works fine (passing along launch parameters, possibly keep stdin/stdout for the future).
Better solution: You can add a filter to the file picker. If you can filter by filename in there, doing a filter for blender / blender.exe would negate my concerns.
Member
|
Are you able to push the changes to fix the whitespace error? |
Author
|
Haven't had time to continue working on this, especially since I found a workaround to the PR for the Godot Flatpak. I would still like to get this to select the Blender executable however, for consistency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of my proposal here.
In my very limited testing, it works, but there may be errors that occur on other systems since I'm running Godot in a Fedora 37 container. There may also be files that need to be corrected too, but this should be a good place to start.