Pass default values to rcedit to distinguish exported projects from the engine#75705
Pass default values to rcedit to distinguish exported projects from the engine#75705vaporvee wants to merge 1 commit intogodotengine:masterfrom
Conversation
|
Also i'm not sure about the other values that are not name and description. And should versions be empty or 1.0.0.0 ? |
YuriSizov
changed the title
|
Please amend your commit message. It should follow our guidelines. You can use the new title of this PR, for example. I would also recommend you don't use your master branch in the future. Create feature branches and work in them. That should help you avoid issues rebasing and squashing. |
|
Yeah i noticed that but thats for the future yeah i try to rename it when i have time |
|
problem is when i rebase how do i update it on origin when i finished my changes locally force pushing doesn't help :/ |
|
You push to the feature branch on your fork, force-push if you want to override. That's pretty much it, there is nothing more to it. |
|
Weitd the rebase says it worked and there is "everything up to date" |
|
I don't think there is anything to rebase for you right now, but make sure you are rebasing against the upstream master. (Don't forget to |
|
How do i rename the commit then when its not rebasing |
|
Use |
|
The title was too long for the commit message do you also need a commit description? |
|
Feel free to adjust it until it fits, like "Pass default values to rcedit to distinguish exported projects". |
|
is this commit message good yet? |
vaporvee
force-pushed
the
master
branch
2 times, most recently
from
658bcb1 to
f61c5de
Compare
|
We prefer that commit messages start with a verb describing what it does. Which is why I suggested "Pass default values to rcedit to distinguish exported projects". The "from the engine" part is not that important. |
Hard coded default values for rcedit when resource editing is enabled for Windows. Now it doesn't appear as "Godot Enigne" in the file details or Task Manager. For continuity the other file details are empty or standard values. The "file_verion" variable name typo also got fixed. This is relevant to godotengine#29569
|
Okay i just copied your message is it good now? |
|
Yes, looks good :) |
5 participants
I gave RCEdit standard values for Windows exports so it doesn't show up as "Godot Engine" in Task Manager when there are no overwrites in export. For continuity i also gave the other file details empty or standard values and i fixed the "file_verion" variable name typo.
This PR was remade because i destroyed the old one really hard with github (sorry btw)
This PR is relevant to #29569