Skip to content

Allow tooltips to show true value#98205

Open
EAinsley wants to merge 1 commit intogodotengine:masterfrom
EAinsley:fix#86371
Open

Allow tooltips to show true value#98205
EAinsley wants to merge 1 commit intogodotengine:masterfrom
EAinsley:fix#86371

Conversation

@EAinsley
Copy link
Copy Markdown
Contributor

Fix #86371

simplescreenrecorder-2024-10-15_16.15.06.mp4

Add a new variable to store the true value. When the range is in the editor, the value_changed signal will emit if the true value changed. When the range is in game, the behavior remains the same.

editorspinslidertooltip.zip

@EAinsley EAinsley requested review from a team as code owners October 15, 2024 14:27
@AThousandShips AThousandShips added bug topic:editor cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 15, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 15, 2024
@EAinsley EAinsley marked this pull request as draft October 15, 2024 15:15
@EAinsley
Copy link
Copy Markdown
Contributor Author

Just found it seems I have made some serious performance degradation. I'm not sure what caused this. Convert to draft first.

@EAinsley
Copy link
Copy Markdown
Contributor Author

My commit didn't introduce the problem.

I was testing on archlinux with Nvidia GPU, and the editor freezes from time to time. After tracing, I find vkWaitForFences blocks forever.
The issue exists on v4.4.dev.custom_build [af77100], and it's not related to this commit. I will create an issue after I did more tests.

@EAinsley EAinsley marked this pull request as ready for review October 16, 2024 00:50
@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Oct 26, 2024

This is editor-only fix, so the changes should be exclusive to EditorSpinSlider. You can add "true value" to EditorSpinSlider only; the downside is that shared->val == p_val condition will not take it into account, but I think it won't cause any serious problems.

@Repiteo Repiteo added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Feb 24, 2025
@Repiteo Repiteo modified the milestones: 4.4, 4.5 Feb 24, 2025
@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Mar 17, 2025

So there is a problem actually.
The inputted value ignores step. If you export a property with @export_range(0, 100, 0.1), you can still put a higher precision value than the step. It will be displayed in the tooltip and get stored in the scene file. Though maybe the fix is simply removing the get_value() override.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
@Repiteo Repiteo added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Sep 5, 2025
@Repiteo Repiteo modified the milestones: 4.5, 4.6 Sep 5, 2025
@Repiteo Repiteo modified the milestones: 4.6, 4.x Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release topic:editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EditorSpinSlider tooltips don't reflect "ground truth" value

5 participants